Sync 2Geom to commit 5ee51c1c4f2066faa3e2c82021fc92671ad44ba4

static code analysis

forgot a line; had weird consequences on filters

fixes a few of jenkins warnings

fix crash due to logic error in Selection::_removeObjectDescendants

unsigned int -> size_t

uint -> unsigned int

removed a few useless SP_OBJECT() casts

Just reread the entire diff against trunk. Given the diff size, i must have forgotten things, but hopefully, there are only very few changes of semantics: ->childList is now in the intuitive order (childList()[0] is now firstChild) -> sp_selection_paste_impl is now in the opposite order (change is local to selection-chemistry.cpp, and simplify a few things) -> selection.setReprList now takes the list in the opposite order. It was always the case (the list was always reversed before handing to it) -> a few comparison functions now work "the c++ way": the C way was to return -1 if a<b, 0 if a==b and 1 if a>b, now they return (bool)(a<b)

more cast cleanup

corrected the casts (hopefully)

added a set to the Selection

Put a few std::vector<SPitem*>

I can't really understand why, but i can now launch inkscape without it segfaulting. That's an improvement. Next thing: code cleaning, replacing containers with vectors

At first, I was thinking "I just have to go to the selection file, and change that GSList* with a std::list, then resolve the few problems" So, i tried that. And I will continue tomorrow, and the days after, on and on.

5. Refactoring of Application class: make copy/assignment operators private, disallow pointers to Application

3. remove dead code, refactor existing code. Connect overlooked signals.

1. make it compile

Change my mind on the solution to the bug, protect all selection additions.

Remove warning on bbox and allow empty bound selection to clear existing selection.

Make sure selection->setList checks for dupes by routing to selection->addList.

reduce variable scope

Use Jon Cruz info about OptRect to correctly get area height and width

Change small to sml to fix windows compile problem

Remove align point, not required any more

Step 2 refactoring the align functions, added some functionality to selection.

Code readability improvements and licence changes for action-context.* based on merge request code review and feedback

Factored layer model out into new Inkscape::LayerModel class. This allows Inkscape::Selection to use a LayerModel that is not associated with a UI. Changed the interface of verbs (SPAction) to use a new ActionContext rather than UI::View::View, again so that verbs may be used in a console mode. Modified boolean operation verbs to work in console-only mode. Fixed up DESKTOP_IS_ACTIVE macro to work in the case of no desktops. Modified main.cpp to process selections and verbs in no-GUI mode. Other changes are all consequences of the SPDesktop, Selection and LayerModel interface changes.

Fixing regression

Working with widjets

cppcheck

Selector tool: improve responsiveness for snapping a path's internal intersections (was unbearable already for paths having 20+ segments)

remove superfluous RectHull

move helper/recthull.h to 2geom/rect-hull.h

cppcheck

implement some switches between visual bbox and geometric bbox, depending on prefs (Bug 906952)

Fixing more broken and split doc comments.

1) Fix absolute scaling in transform dialog 2) Transform dialog now follows the user prefs for geometric vs. visual bounding box

Refactor SPItem bounding box methods: remove NRRect usage and make code using them more obvious. Fix filter region computation.

Refactoring of the snapping preferences; mainly about storing all toggles in a single array, instead of each having its own member variable

Remove more of libnr

Update 2Geom to pull in integer rectangle class

Finished cleanup of outdated SP_OBJECT_PARENT C macro.

update to latest 2geom !

Super duper mega (fun!) commit: replaced encoding=utf-8 with fileencoding=utf-8 in all 1074 Vim modelines. The reason for this is that (a) setting the encoding isn't nice, and (b) Vim 7.3 (with modeline enabled) disallows it and pops up an error whenever you open any file with it ("invalid modeline"). Also corrected five deviant modestrings: * src/ui/widget/dock.cpp and src/ui/widget/dock.h: missing colon at the end * src/ui/dialog/tile.cpp: removed gratuitous second colon at the end * src/helper/units-test.h: removed gratuitous space before a colon * share/extensions/export_gimp_palette.py: missing textwidth=99 That's my geekiest commit yet.

Avoid self-snapping when dragging a rotation center, and draw the rotation center at the snapped position

This is the first c++ification commit from me. It handles sp-line, sp-polyline, sp-item and marks the onset of document c++ification as well. Users can check performace increase with [/usr/bin/time -v inkscape_binary_with_commandline_options].

- "Snap nodes or handles" button now also includes smooth nodes - Improved snap tooltips

Refactoring the snapping API (making it easier to maintain and understand for the devs)

Small snap bug has been eliminated, flowed text snapping now uses baseline, replacing tabs by spaces, removing some commented lines

Major simplification of 3D box code.

Refactoring of 3D box tool, mainly to avoid unnecessary creation of perspectives.

The snap indicator's tooltip now displays "A to B", whereas before it only displayed "B".

Merge from fe-moved

From trunk

Merging from trunk

More NR ==> Geom conversion (points and some matrices/transforms)

Remove debugging messages

Many debugging messages

remove many unnecessary to_2geom and from_2geom calls

NR::Maybe => boost::optional

Remove now obsolete functions

First step towards making helper paths for LPE items work better

change NR::Matrix to Geom:: for many sp_item_xxx_affine functions

Make grouped 3D boxes work correctly when transformed (fixes: LP 188991)

Bug fix: prevent perspectives from being transformed more than once (by keeping track of selected boxes and their transformations).

Also consider path nodes for snapping

Warning cleanup

avoid code duplication, i.e. use sp_item_snappoints in the object-snapper.cpp

Make snapping to the item's transformation center optional, but not yet available in the snapping preferences dialog

Snapping the transformation origin should also work for paths, not only for shapes

Changes to the selector tool, e.g. option to choose either APPROXIMATE_BBOX or GEOMETRIC_BBOX

Selector tool shouldn't snap to path nodes, see Bulia's comment in bug #1589436

Eliminate remaining sources of empty NR::Rects

Switch selection bounds and center to use NR::Maybe, addressing most of the recent bbox regressions.

Merge further bbox work

specialize MaybeStorage for Rect, and start using reference maybes to avoid some copies

Separate NRRect and NR::Rect a bit further; the goal is to get to the point where there is no way to create an empty NR::Rect

adapt code to new Maybe/bbox regime

peeled back the gboolean code as it hit on some complexity theory principles... need to rethink and incrementally change gbooleans to bools

Ok, committed msgloan's patch to convert gbooleans to bools thus completing one major janitorial task we identified....

switch to sigc++ signals for "modified" and "release"

Applied patch #1503864

Get rid of the SP_DT_* macros which do nothing more than provide additional, confusing, names for other functions. If shorter names are desired, the actual functions should be renamed -- or better, made into member functions.

Fixing bug 1462517

patch #1450307 - option for select all to work in layer with it's sub-layers: * Replaced check-box in preferences with 3 radio buttons (in all document in current layer only, in current layer with sub-layers) * Altered "Select all" functionality to include objects in sub-layers (if preference is on) * Altered TAB functionality to include sub-layers (had to introduce "context layer" concept in Selection class - without it TAB'ing would end in deepest child, but it needs to return to parent on subsequent TAB key press)

use rotation center in keyboard rotation and transform dialog

optimization: prevent taking bbox twice of the first object in selection

more information on objects selected in groups

Replace GC::Managed<>::clearOnceInaccessible with GC::soft_ptr<>

bulk trailing spaces removal. consistency through MD5 of binary

Fix a typo in a previous commit. Closes #1401357.

moving trunk for module inkscape