static code analysis

static code analysis

fix for ungrouping dynamic offset displacement bug

fixed selection after ungroup fixed some regression with displacement of clones of clones when ungrouping (test case: icons.svg)

Point parameter refactor, Fixes a bug in Lattice2 whith lines.

more cast cleanup

corrected the casts (hopefully)

create SPObject factory

Fix for the performance loss in ungrouping observed by Tavmjong in rev 13933 Added std::list<SPObject*> hrefList member to SPObject class.

added a set to the Selection

scale groups when changing document units. (Bug 1369197)

Put a few std::vector<SPitem*>

At first, I was thinking "I just have to go to the selection file, and change that GSList* with a std::list, then resolve the few problems" So, i tried that. And I will continue tomorrow, and the days after, on and on.

Clones. Fix for bug #1245339 (When changing a clone's parent's layer, the clones shift position) and bug #653574 (Ungrouping moves clones inside nested groups).

during copy and paste, scale stock symbols from units of 'px' to 'document-units'. (Bug 1365451)

Remove sp_style_merge_from_parent() and sp_style_merge_from_dying_parent().

Use gray for 'context-fill' and 'context-stroke' in marker selector. Fix rendering bug when elements with 'context-fill' and 'context-stroke' are inside groups.

Remove sp_desktop_document and finish cleanup of desktop-handles.h

Implement rendering for 'context-fill' and 'context-stroke' (text not handled yet).

ignore this commit

scale symbols when changing document units (Bug 1365451)

Initial removal of box3d outdated GTKish macros.

modify scaling procedure for uniform scaling of flowed text (Bug 1278561)

Update to experimental r13565

improved version of rev 13561, to allow transforming both clip and mask on the same group

scale clip or mask upon unit change (Bug 1287288)

partial rollback of r13544, allow old recursive behavior for some locations, but not EMF import

resolves bug 1348417 and implements addition features for bug 1302857

Fix some transformation center regressions, related to the viewbox/units changes

noop: remove commented-out code that is dangerous and should not come back

Fix moving of item center: 1) at paste and 2) at changing document units

Remove the incorrect fix for the bug 1241902

Remove the incorrect fix for the bug 1241902

Fix for bug #1241902

Fix for Bug #1241902 -

Experimental merge of Ponyscape features into trunk (will not compile)

Added some consts.

C++

C++

Comprehensive fix for the issues with disappearing filtered objects. Fixes #304407 and possibly a few other bugs. Revert incorrect _item_bbox changes from r12528.

Fix computed shapes disappearing when grouping within filtered groups. Fixes blocker LP bug #850992.

C++ify calling a few SPLPEItem functions, much more work than expected... slowly slowly...

Refactored SPUse.

change names for displayName and detailedDescription, improve char code and remove const.

Refactor status-bar text for multiple items, was very broken

Fix 3d box document unit change undo bug.

Fix document unit change for disconnected connectors.

Fix document unit change for transformed flow text and transformed text on path.

Finish fixing document unit change undo bug.

Fix document unit change for 3d boxes and (mostly) for text on path.

Added viewBox implement document unit support.

Removed placement news / explicit destructor calls.

Allow svg elements to be ungrouped

Fixed logic error confusing bitwise and with logical and. Whitespace cleanup to make the issue easier to spot.

Merge Object and subclasses. Merging of SP- and C-classes complete.

Merged Item.

Merged more classes.

Merged Group and subclasses.

Registered classes with new factory. Hkern, Vkern and FeFuncX have to be rewritten, as they aren't real classes.

Added constructors to SP classes.

Replaced calls to g_object_(un)ref with sp_object_(un)ref.

Prepared exchange of casting macros.

Renamed virtual function names.

Removed function pointers from SPObject and subclasses. Added some missing virtual pads for classes that were hidden by preprocessor macros.

Various changes.

More GObject boilerplate cleanup

Fix for 1071328 : Inkscape encounters internal error when opening a valid SVG file

Added virtual pad to SPFlowtext; removed old calls to virtual SPItem methods.

Removed old calls to set_shape and update_patheffect.

Added "virtual pad" to SPGroup and SPSwitch. There was some weird try by someone else. SPGroup should work as expected, SPSwitch may still be buggy.

hack for 898797

cpp-style casting

Header cleaning

turn SPPath into a class, and add some methods...

Correct typo in bounding box calculation for groups. Fixes LP #836536

Refactor SPItem bounding box methods: remove NRRect usage and make code using them more obvious. Fix filter region computation.

Rewrite NRArena -> Inkscape::Drawing. Call render and update methods on the Drawing rather than on the root DrawingItem.

Rewrite NRArenaItem hierarchy into C++

Cleanup of oudated/redundant SP_ITEM() macro use.

Removed outdated/unsafe SP_DOCUMENT_DEFS macro and reduced usage of SP_ROOT() gtk type function/macro.

Finished cleanup of outated SP_OBJECT_DOCUMENT C macro.

update to latest 2geom !

Wholesale cruft removal part 3

Wholesale cruft removal part 2

SPShape c++ified to the extent it was possible and more changes done for XML privatisation. Major changes yet to come.

SPObject c++ification finalized along with the beginning of XML Privatisation tweaks

another c++ification for sp-object.h/cpp and still in progress...

New Class SPDocumentUndo created which takes care of c++fying some non SPDocument based methods

C++fied SPDocument added

This is the first c++ification commit from me. It handles sp-line, sp-polyline, sp-item and marks the onset of document c++ification as well. Users can check performace increase with [/usr/bin/time -v inkscape_binary_with_commandline_options].

Patch by Martin Sucha to add preferences to for grouping on Clip/Mask

Refactoring the snapping API (making it easier to maintain and understand for the devs)

Major simplification of 3D box code.

work on the lpe group undo bug. it's not solved, but i think LPE code does everything correct now. I think now it's the interplay between undo-system and LPE that bugs.

Patch by Johan to fix 391368

Revert recent refactoring changes by johnce because they break the build, which cannot be fixed easily.

SPDocument->Document

When ungrouping, apply the correct transformation to a linked offset (fixes bug #239430)

The snap indicator's tooltip now displays "A to B", whereas before it only displayed "B".

coding style

More NR ==> Geom changes

Merge from fe-moved

From trunk

Merging from trunk

Next roud of NR ==> Geom conversion

More NR ==> Geom conversion (points and some matrices/transforms)

fix bug 269390, whitespace

remove extra unref; now ref/unref is done by show/hide; this used to stop this arenaitem from leaking, but this is now fixed properly in SPItem

removed unnecessary pointer, changed to by reference. (the pointer was not allowed to be NULL, so reference is better)

Support for title and desc elements when serializing as Plain SVG.

NR::Maybe => boost::optional

fix 252547: skip explicitly hidden objects when calculating bbox of group

Prevent 'title', 'desc' and 'metadata' elements being moved to 'defs' when ungrouping (fixes bug 243720).

plumb XML::Documents in everywhere

ellipses and groups now use 2geompath for svg_write: sp_svg_write_path(np->curve->get_pathvector() );

merge gsoc2008_johan_path2geom into trunk

LPE STACKING! (many thanks to the french students who made this.)

warning cleanup and fixed string free issue

Fix passing wrong pointer type when using the tweak tool on 3D boxes

- Created a SPLPEItem class that handles applying a LPE to an Item - LPEs can now be applied to groups - Updated the bend path to work properly with groups

The deprecated version of sp_item_invoke_bbox_full (which still uses NRRects) returns empty rectangles when calculating geometric bboxes of vertical or horizontal lines. A group of those lines will therefore also have an empty geometric bbox, which is wrong. We must use the new version of sp_item_invoke_bbox_full, which uses NR::Maybe<NR::Rects> instead.

Make grouped 3D boxes work correctly when transformed (fixes: LP 188991)

fix converting 3d boxes to path and ungrouping - do not lose selection, preserve style, id and clip/mask

Applying fixes for gcc 4.3 build issues (closes LP: #169115)

Convert 3D boxes to ordinary groups before tweaking, ungrouping or applying 'convert to path' (closes LP #179693 and #176646).

noop: remove old, commented out debugging code

Fundamentally reworked version of the 3D box tool (among many other things, this fixes bugs #168900 and #168868). See mailing list for details. Sorry for this single large commit but it was unfeasible to keep the history.

Also consider path nodes for snapping

avoid code duplication, i.e. use sp_item_snappoints in the object-snapper.cpp

Selector tool shouldn't snap to path nodes, see Bulia's comment in bug #1589436

plumb XML::Document parameter into duplication, courtesy of bryce

Warning cleanup of unused variables

refactor sp_svg_transform_write to return a dynamically-allocated string -- dynamic allocation won't hurt you, but buffer overruns will!

continue switching sp_repr_new* over to XML::Document::create*

Fixed ungrouping bug where the changed transformation of items was not written to XML.

whitespace

fix 1520018: sync up the embed/not embed transform logic when ungrouping with that used in sp_item_write_transform, so as to not embed e.g. for clipped/masked objects

undo annotations

marker refactoring work

patch from Gustav Broberg: undo annotations and history dialog

svg-filters branch merged back to head

Applied patch #1501709

fix translation for fit page the translation is now preserved across save by translating all child elements of the root instead of just translating the root itself.

fixing incorrect group children order (bug introduced with <switch> support)

SVG 1.1 Conditional Processing Module rendering support (<switch> element, requiredReatures/requiredExtensions/systemLanguage attributes). Two more W3C SVG Test Suite testes pass after this change.