static code analysis

create SPObject factory

prevent possible usage of -1 array index

Remove sp_desktop_document and finish cleanup of desktop-handles.h

Replace INKSCAPE.active_desktop() by SP_ACTIVE_DESKTOP for easier grepability

Initial removal of box3d outdated GTKish macros.

Removed dangerous GTK-mimicking macros.

Fixed some unused variables warnings.

5. Refactoring of Application class: make copy/assignment operators private, disallow pointers to Application

1. make it compile

Moved and renamed some tool-related files.

Added some consts.

Add 3d Box displayName and description

Refactor status-bar text for multiple items, was very broken

Merge Object and subclasses. Merging of SP- and C-classes complete.

Merged Item.

Merged more classes.

Merged Group and subclasses.

Registered classes with new factory. Hkern, Vkern and FeFuncX have to be rewritten, as they aren't real classes.

Added constructors to SP classes.

Prepared exchange of casting macros.

Renamed virtual function names.

Removed function pointers from SPObject and subclasses. Added some missing virtual pads for classes that were hidden by preprocessor macros.

Various changes.

Clean up more GObject type definitions

cppcheck: use gobject casts in box3d and hide dead code

Added virtual pad to SPFlowtext; removed old calls to virtual SPItem methods.

code cleanup: add own includes to cpp files or make the functions static if they are not used elsewhere.

Added "virtual pad" to SPBox3D.

remove some unnecessary inkscape_active_desktop() calls

- rename SPItem::i2d_affine to i2dt_affine, to clarify that it is item-to-desktop, not item-to-document. This should make it easier to spot bugs. - tag some instances where the document-to-desktop transform has been hardcoded

Cleanup of oudated/redundant SP_ITEM() macro use.

Applying patch from Campbell Barton to help building on other than gcc.

Pass removing some outdated C-macro use.

update to latest 2geom !

Wholesale cruft removal part 4; fix crash when rendering guides

More in XML privatisation with new create3DBox function and other supplements to efficiently hide information.

SPObject c++ification finalized along with the beginning of XML Privatisation tweaks

another c++ification for sp-object.h/cpp and still in progress...

This is the first c++ification commit from me. It handles sp-line, sp-polyline, sp-item and marks the onset of document c++ification as well. Users can check performace increase with [/usr/bin/time -v inkscape_binary_with_commandline_options].

Major simplification of 3D box code.

Refactoring of 3D box tool, mainly to avoid unnecessary creation of perspectives.

fix crash when moving a box after copying it to clipboard; this code is still badly broken, we must not use any UI classes such as selection in set_transform, but at least it does not crash now

Revert recent refactoring changes by johnce because they break the build, which cannot be fixed easily.

Inkscape::XML::Document -> Inkscape::XML::DocumentTree (more refactoring ...)

SPDocument->Document

Use the line intersection routines in 2geom/line.h instead of the deprecated ones in 2geom/geom.h. (I know we're in a refactoring freeze, but this one I was already working on before this freeze was announced and it's quite safe IMHO. It's only a small change in 2geom's API and can hardly do any real harm. I will not refactor anything else until after the v0.47 release, promised!)

get rid of a lot of no longer needed "libnr/nr-..." includes.

fix compile. re-enable decrepated 2geom functions.

From trunk

Merging from trunk

Next roud of NR ==> Geom conversion

More NR::Point ==> Geom::Point

remove many unnecessary to_2geom and from_2geom calls

convert all SPCurve's points and matrices arguments and return types to 2Geom

try to use consistent document for creating guides

Check that objects are of the right type before casting them. Fixes crash that occurs when transforming a 3D box with a title or description (bug 237331).

change NR::Matrix to Geom:: for many sp_item_xxx_affine functions

plumb XML::Documents in everywhere

use object's document

Fix passing wrong pointer type when using the tweak tool on 3D boxes

Make grouped 3D boxes work correctly when transformed (fixes: LP 188991)

fix converting 3d boxes to path and ungrouping - do not lose selection, preserve style, id and clip/mask

warning cleanup

Clean up comments and remove (already commented) debugging messages

Fix another small z-order issue for 3D boxes

Add option in Preferences to keep objects after conversion to guides

Slightly more 'object-oriented' way to invoke item-specific conversion-to-guides methods

Fix wrong offset when Ctrl+dragging 3D boxes by their center

Use visual/geometric bbox (as specified in Selector tool preferences) when converting to guidelines. Also, provide options to convert rectangles and 3D boxes using their bbox, too (i.e., disregarding their true shapes).

Add possibility to convert objects (only rectangles and 3D boxes currently) to guidelines. Also see corresponding post on the mailing list; in particular, feel free to revert it if this is inappropriate during Frost phase.

Fix small z-order error for 3D boxes

Convert 3D boxes to ordinary groups before tweaking, ungrouping or applying 'convert to path' (closes LP #179693 and #176646).

Also transform stroke, patterns, and gradients of 3D box sides

+ Fix bug #179840, forking of LPEs + Groundwork for fixing transforming LPE bugs. TODO: implement the actual transformation of LPE parameters.

Recompute box corners relative to new perspective when merging persps (to prevent boxes from jumping randomly)

Don't show boxes as everted (i.e., always show the same sides) during initial drag, regardless of the mouse pointer position.

Don't store special attributes/types when saving 3D boxes to plain SVG (so that they show up correctly when reopening files).

Bug fix: prevent perspectives from being transformed more than once (by keeping track of selected boxes and their transformations).

Warning cleanup

If necessary, split up perspectives when applying transformations to boxes; moreover, fix crash caused by listening to already destroyed perspectives

Fundamentally reworked version of the 3D box tool (among many other things, this fixes bugs #168900 and #168868). See mailing list for details. Sorry for this single large commit but it was unfeasible to keep the history.

Fix crash when 3D boxes are rotated in selector context

Decent support for setting the direction of infinite VPs via the toolbar and partial fix for wrong undo behaviour (?)

Infrastructure to set direction of infinite VPs (now adjustable by some shortcuts; this may be removed later on)

Constrained center-dragging for 3D boxes (with Ctrl)

Remove some warnings and fix crash in 3D box tool

Various small cleanups

Rewrite of z-order code for 3D boxes, first stage (hopefully this is finally the right approach)

Enable center-dragging of boxes in Z direction by using Shift

Eliminate a number of compile warnings

Enable center-dragging of boxes ('in perspective') within the XY-plane

Remember last used style for single 3D box faces (also fixes bug with wrongly assigned faces for duplicated boxes, e.g.)

Hold perspectives on document level rather than globally; this corrects the changes made in commit #15681

Fix behaviour of toggle buttons (for VP states) in 3D box toolbar; reshape boxes when state of a VP changes

Compute the correct visible front corner (also for 'upended' boxes) and set the z-orders accordingly so that they are correct for any relative position of the handles

Set z-orders of 3D box faces during dragging/resizing according to the perspective

Fix wrong states of VPs when writing to SVG

Draw perspective lines; provide shortcuts to toggle their visibility and the corners where they are attached

Workaround for some segfaults: Store perspectives globally instead of in each desktop (this should probably be reverted later on)

Convenience for debugging

Write/read perspectives to/from SVG; store ratios of the distances from corners to VPs (preparation for dragging)

Store a global list of existing perspectives; for each perspective hold a list of associated boxes; explicitly pass perspectives as arguments when creating PLs

Use Inkscape's own code to write coordinates to svg (much nicer fix than commit #15449)

Make string conversion of box coordinates locale-independent (fixes bug with languages that use comma instead of decimal point)

Move check for unlinked paths of 3D box faces to the correct location

Write distinguished corners of 3D boxes to the svg representation from which the box can be recomputed. This is used to fix several bugs related to the editing of boxes resulting from cloning, undo operations or newly opened documents (we had stray pointers to SPPaths before that made Inkscape crash).

Create all 3D box faces in the beginning (fixes resizing bug; first step towards correct handling of degenerate boxes)

More 3D auxiliary/convenience functions

Status message & cleanups

small cleanups

New/updated 3D box auxiliary/convenience functions (e.g., allow (un)constrained movement of corners, too; determine midpoints of edges)

Refactoring of 3D box internals. Handle the corners in the box itself and only link to them from the separate faces. This way we can make the code *much* cleaner and more generic. Provide generic auxiliary functions for the movement of corners in XY-plane and Z-direction.

Only create the faces of a 3D box when needed (use pointers to refer to them).

Swap axis directions Y and Z (for consistency)

Use arrays to manage corners and faces of 3D boxes

First (very limited) version of the 3D box tool; allows for drawing of new boxes in a fixed perspective without any live interaction.