static code analysis

static code analysis

cppification: GSList replaced by vectors (vanishing points)

3D box tool: the shift key must not prevent snapping of the vanishing point. It must only serve to separate the vanishing points, in case of multiple boxes sharing the same vanishing points

corrected the casts (hopefully)

Put a few std::vector<SPitem*>

At first, I was thinking "I just have to go to the selection file, and change that GSList* with a std::list, then resolve the few problems" So, i tried that. And I will continue tomorrow, and the days after, on and on.

Remove sp_desktop_document and finish cleanup of desktop-handles.h

Purge sp_desktop_controls

Deprecate and remove sp_desktop_selection in favor of SPDesktop::getSelection

Replace INKSCAPE.active_desktop() by SP_ACTIVE_DESKTOP for easier grepability

Initial removal of box3d outdated GTKish macros.

Move more UI code into ui/

5. Refactoring of Application class: make copy/assignment operators private, disallow pointers to Application

1. make it compile

Further refactored SPKnot.

First step of refactoring SPKnot.

Moved and renamed some tool-related files.

First step of moving tools into appropriate namespaces.

code cleanup: add own includes to cpp files or make the functions static if they are not used elsewhere.

Stop deriving SPCanvasItem from GtkObject

Header cleaning for GTK+3 migration

Centralized line creation and enhanced visibility.

C++ification of SPCtrlLine in preparation of visibility improvements.

Header cleaning

Super duper mega (fun!) commit: replaced encoding=utf-8 with fileencoding=utf-8 in all 1074 Vim modelines. The reason for this is that (a) setting the encoding isn't nice, and (b) Vim 7.3 (with modeline enabled) disallows it and pops up an error whenever you open any file with it ("invalid modeline"). Also corrected five deviant modestrings: * src/ui/widget/dock.cpp and src/ui/widget/dock.h: missing colon at the end * src/ui/dialog/tile.cpp: removed gratuitous second colon at the end * src/helper/units-test.h: removed gratuitous space before a colon * share/extensions/export_gimp_palette.py: missing textwidth=99 That's my geekiest commit yet.

Implement snapping of vanishing points (LP #629333)

New Class SPDocumentUndo created which takes care of c++fying some non SPDocument based methods

Refactoring of 3D box tool, mainly to avoid unnecessary creation of perspectives.

Revert recent refactoring changes by johnce because they break the build, which cannot be fixed easily.

SPDocument->Document

remove unused

switch to using shape_editor, instead of separate knotholders and listeners; fixes a lot of crashes, simplifies code

From trunk

More NR::Point ==> Geom::Point

NR::Maybe => boost::optional

change knot.h to Geom::Point only instead of NR::Point.

C++ify knotholders

Clean up comments and remove (already commented) debugging messages

Bug fix: prevent perspectives from being transformed more than once (by keeping track of selected boxes and their transformations).

Warning cleanup

If necessary, split up perspectives when applying transformations to boxes; moreover, fix crash caused by listening to already destroyed perspectives

Fundamentally reworked version of the 3D box tool (among many other things, this fixes bugs #168900 and #168868). See mailing list for details. Sorry for this single large commit but it was unfeasible to keep the history.

Warning cleanup

Warning cleanup

Decent support for setting the direction of infinite VPs via the toolbar and partial fix for wrong undo behaviour (?)

Draw perspective lines for infinite VPs, too (they are updated during scrolling or zooming); don't create knots for infinite VPs on the canvas

Hold perspectives on document level rather than globally; this corrects the changes made in commit #15681

Status bar tips for VP draggers

Fix behaviour of toggle buttons (for VP states) in 3D box toolbar; reshape boxes when state of a VP changes

Set z-orders of 3D box faces during dragging/resizing according to the perspective

Draw perspective lines; provide shortcuts to toggle their visibility and the corners where they are attached

(Un-)Snapping of VPs by Shift-dragging; this makes it possible to separate perspectives and thus create new ones interactively

First stage of draggable vanishing points (no snapping/unsnapping yet)

Write/read perspectives to/from SVG; store ratios of the distances from corners to VPs (preparation for dragging)

Preparatory stuff to combine VPs in draggers

Move 3D axis manipulation functions to separate file

More 3D auxiliary/convenience functions

New/updated 3D box auxiliary/convenience functions (e.g., allow (un)constrained movement of corners, too; determine midpoints of edges)

More meaningful name for 3D axis directions

First (very limited) version of the 3D box tool; allows for drawing of new boxes in a fixed perspective without any live interaction.