10f17aefbf9d58f75efeda82a7e1744f576b42dc 21810 |
|
27-Jul-2009 |
vboxsync |
IPRT: r=bird: RTZip - dunno if anything works after my changes because there isn't any testcase. Please add one.
- Fixed numerous allocation related issues (missing checks for success and leaks).
- RTTarList wouldn't set *pcFiles and *ppapszFiles if no files were found.
- Don't pass pcbRead and pcbWritten to RTFileRead/Write if it is
unacceptable to do partial reads and writes.
- for (;;) instead of do while (0).
- Always specify all three flag categories for RTFileOpen calls!
- Adding > 4GB files to a tar file on 32-bit would fill up the disk.
- Missing rc check in rtTarCheckheader when converting the checksum.
- Don't override errors with VERR_FILE_IO_ERROR, VERR_FILE_NOT_FOUND or in one case VINF_SUCCESS.
- Use RT_ZERO instead of memset.
- Use Assert*Return for input validation. The if (bad) {AssertMsgFailed();
return failure; } style checking found around IPRT is from before the
Assert*Return macro was added.
- Added todos for inefficient 512 bytes at a time copying.
- Added todos for interface renaming to conform with IPRT conventions. |