OPENDJ-1802 Make ByteString methods more intentional ByteString.java: Renamed: - valueOf(byte[]) to valueOfBytes(byte[]) - valueOf(byte[], int, int) to valueOfBytes(byte[], int, int) - valueOf(char[]) to valueOfUtf8(char[]) - valueOf(CharSequence) to valueOfUtf8(CharSequence) - valueOf(Object) to valueOfObject(Object) - valueOf(int) to valueOfInt(int) - valueOf(long) to valueOfLong(long)
JmxPrivilegeTestCase.java: Extracted methods assertSuccess() Code cleanup
Removed more duplicated code
Extracted methods to remove duplicated code
Code cleanup DirectoryServer.java: Changed getAttributeType(String lowerName, boolean returnDefault) to getAttributeTypeOrDefault(String lowerName). Renamed getAttributeType(String lowerName, String upperName) to getAttributeTypeOrDefault(String lowerName, String upperName). DirectoryConfig.java: Removed getAttributeType(String lowerName, boolean returnDefault), used DirectoryServer methods instead. *.java: Changed all code that was calling DirectoryServer.getAttributeType(lowerName, false) to directly call the more explicit DirectoryServer.getAttributeType(lowerName). SubjectAttributeToUserAttributeCertificateMapper.java: In initializeCertificateMapper(), isConfigurationChangeAcceptable() and applyConfigurationChange(), extracted methods buildAttributeMap() and getUserBaseDNs() to remove code duplication
Code cleanup *.java: Used CollectionUtils.newArrayList() as much as possible. Made use of LDAPAttribute constructors which accepts Strings. This avoids String to ByteString conversion in client code since the constructors handle it. AttributeBuilder.java: Added toAttributeList() to avoid the need for client code to create a List itself. Attributes.java: Added several createAsList() to avoid the need for client code to create a List itself.
AutoRefactor'ed Use Diamond Operator
AutoRefactor: annotations cleanup
OPENDJ-1777 Move test source directory to src/test/java Move all test code from tests/unit-tests-testng/src/server directory to maven standard test source directory src/test/java Update pom.xml accordingly