Fixes issues #4552 #4557, making sure plugins and internal services are properly handling subtree move or delete. The changes particularly resolve problems raised by the community with the referential integrity and the isMemberOf plug-ins. Unit-tests have been updated to cover those cases

Fix issue 4043 - intermittent failures in ACI unit tests Introduce API for registering internal plugins which are not exposed in the user configuration. Update ACI cache to use a post-op plugin instead of a change listener.

Fix for issue 4239 setup on Windows 2008 set LDAP ds-cfg-listen-port to 389

Fix for #4098 Initializing a fractional domain through import-ldif when server is down does not work Fractional LDIF import plugin is now able to read fractional configuration from config backend if server is offline. => Initializing a fractional replica is possible even if server is offline.

With this refactoring: - Removed the ability for plugins to directly change the result of an operation - The plugin result API is simplified and more structured. - Pre and Post operation are guaranteed to run in pairs. - Better handling of cancel requests to minimize incorrect result codes. - Operations can indicate too late to cancel from anywhere in the work flow. - Added a non blocking abort method to cancel operations without waiting for a result. - Cancel requests from client disconnect now includes the disconnect reason. Fix for issue 2858

Updated the copyright statement to reflect that Sun owns the full copyright on the project files.

Update the server to provide a basic framework for controlling when plugins will be invoked. There are two basic changes: - Add a new ds-cfg-invoke-for-internal-operations configuration attribute for all plugins, which indicates whether the plugin should be invoked for internal operations. If this is false, then the plugin will only be invoked for externally-requested operations. - Add four new plugin types: postSynchronizationAdd, postSynchronizationDelete, postSynchronizationModify, and postSynchronizationModifyDN. These allow a plugin to perform a limited set of processing for changes that are successfully applied through synchronization. The unique attribute plugin has also been updated to support the post-synchronization plugin types so that if a conflict is introduced concurrently on two different servers within the propagation delay, an administrative alert will be generated to indicate that manual intervention is required to address the problem. Finally, ensure that audit logging is enabled during the unit tests, and update the audit logger to include the connection ID and operation ID for the operation being logged. OpenDS Issue Number: 2057

Update package-info.java files to include the @PublicAPI annotation to indicate whether any or all of the classes in that package are intended to be part of the public API. Further, mark all classes that we intend to be part of the public API with the @PublicAPI annotation to indicate the ways in which they may be used. Note that the use of these annotations and the ultimate determination as to what is in our public API and the ways in which those elements may be used still needs to be carefully reviewed before the 1.0 release. Also, perform minor cleanup in various places througout the code. This includes: - Eliminate the use of protected fields in classes that are in the org.opends.server.api package (and the classes that extend them). The use of protected fields can be troublesome, and there are generally better ways to accomplish the same thing. - Eliminate the use of the {@inheritDoc} Javadoc tag in classes that are intended to be part of the public API. Some IDEs don't resolve {@inheritDoc} to show the actual documentation. Further, there were problems in the way that some instances of {@inheritDoc} were used, namely having a method sourced from multiple parents, and in some cases {@inheritDoc} was used to refer to code defined outside of the OpenDS codebase, which will not be properly handled by the javadoc utility. - Update a number of public API classes to mark them as final if we do not intend for them to be overridden. Further, for some classes that cannot be marked final, mark some methods final if we do not intend for those methods to be overridden.

This commit is a step toward getting OpenDS internationalized. There are still issues to be resolved before we can declare that we are internationalized but this commit covers the bulk of changes needed at this time. In general this commit converts any string values that might potentially be shown to an end user (client or administrator) to a new class called Message. This includes exception messages, error log messages, alert and email text, labels, and CLI output. Message's main interface includes methods for rendering itself as a string in the default locale using toString() or a specified locale toString(Locale). In addition to addressing localization, this would allow us to potentially support controls allowing clients to set a preferred locale for server communication or output log messages in different languages. Message extends CharSequence so it can be used in some places where strings are currently used with not code change (e.g. writing to a buffer) as well as allowing messages to be composed of one another. In order to create localized messages, instead of adding them to the *Messages.java class, you define them in the corresponding properties files. In general the property file keys are used to derive the new messages severity, category, and ordinal. There are directives that can be used in the properties file in order to avoid doing this however. For instance all the properties files used internally include the 'global.category' directive at the top of the file that instructs the generator to make all the following message belong to a single category. So for internal messages the property value key will be as follows: [SEVERITY]_[DESCRIPTION]_[ORDINAL] See the properties files themselves for more information. Once your messages are in the properties file you can use the ant target 'generatemessages' to create create MessageDescriptor objects that are referred to in the Java code. In the code you might think of these objects as replacing the int-valued message IDs. To create messages you call MessageDescriptor.get() which replaces MessageHandler.getMessage(). It might be helpful then to try to define your messages before referring to them in your code since until you run 'generatemessages' you won't have any Java-code with with to create your message objects. In order to support non-localizable text in messages (host names, DN's, etc.) Message's can be created from String values by calling Message.raw(String). In this way it is also possible to circumvent the intention of changing the APIs to use Message objects instead of Strings which is to support writing of localizable messages. This method is currently used in the code as a crutch for areas of the code that need internationalization (tagged with a 'TODO: i18n' comment). It might also be used by 3rd party developers that don't intend to localize their products. However for internal use we should not be using this method to create Messages for text that is locale sensitive. Additionally this code includes a MessageBuilder that can be used in much the same way that a StringBuilder can be used. It has a method toMessage() that can be used to generate a message object when needed. At this time this method just converts the buffer contents to a raw, unlocalizable message so this will need to addressed in the future. Some other issues: - While all of the unit tests pass after this commit, there may be issues in the code where we have no or minimal test coverage. This includes much of the setup and GUI tools packages for which I have not done any testing but will begin after this commit. - The new message related Java sources are contained in package org.opends.messages and organized in a new module src/module modeled somewhat after the admin module: src/messages/src (non-generated Java source files) src/messages/generated (generated source files) src/messages/messages (properties files for messages) If you run the code from within your IDE you will have to mark all messages/src, messages/generated and messages as source directories. - To generated the MessageDescriptor files you invoke the 'generatemessages' target. - If you run the code from within your IDE you will probably ne - This commit would change the plugin API. Here are the changes caught by DirectoryServerPluginTestCase: doShutdown(String)->doShutdown(Message) doPostDisconnect(PostDisconnectPluginResult,ClientConnection,DisconnectReason,int,String) -> doPostDisconnect(PostDisconnectPluginResult,ClientConnection,DisconnectReason,Message); - This commit aligns the entire code-base behind the new Formatter class (printf style formattings like %s) as opposed to the older MessageFormat style (using curly braces for message arguments). This allows us to provide more type safety for message arguments. So for instance you can include a %c argument specifier in your format string and the MessageDescriptor will enforce specification of a Character as message creation time. - Not all of the config framework has not been converted to use Messages. Perhaps as some point we might have a 'message' syntax for locale-sensitive textural data. I'm sure Matt will have ideas about this. - In addition to Message, MessageDescriptor and MessageBuilder, the org.opends.server.message package includes enums for Category and Severity that replace the definitions formerly found in MessageHandler. - The interface for the ErrorLogger has been simplified to allow logging of messages using a single Message parameter. The severity and category of the message will be derived from the Message itself instead of specified as arguments when a message is logged. - I will provide more documentation about this plumbing on the Wiki shortly. - I will expand on the included tests soon.

Add support for a new type of plugin which can be used to detect changes and take some action whenever a subordinate entry is modified as a result of a modify DN operation that targets an entry that has one or more children (i.e., a subtree move or subtree rename operation). At present, subordinate modify DN plugins are not allowed to change the contents of the entry as it is being moved/renamed, but an appropriate API is in place if we decide to add this functionality in the future. This commit also includes a significant amount of cleanup for plugin result code, including corrections to copy-and-paste errors in the javadoc documentation. OpenDS Issue Number: 752

Fix a set of problems with the configuration interface in which there were a number of cases in which insufficient validation was performed. In particular, if a new configuration object was added over protocol or an existing configuration object was changed from disabled to enabled, then the server would only perform generic validation for that component and would not have any way to perform more detailed validation that could detect larger numbers of problems. This change introduces a new "isConfigurationAcceptable" method for lots of different types of configuration objects. There are default implementations in the superclasses for those objects, so components aren't required to implement this method, but they can if appropriate and these changes also include updating all components that implement the ConfigurationChangeListener interface in a non-trivial manner so that they provide this method to perform the same kinds of validation. This fix was initially targeted at issue #1861, but it should also correct problems like those reported in issues 1932, 1936, and 1937.

Merge admin framework from config-prototype-branch onto trunk.

Remove blank lines at the beginning of methods left after eliminating the debugEnter and debugConstructor calls.

Update all CDDL headers in source files to remove a typo.

This removes old debug logging framework method calls that are going to be automatically instrumented by AspectJ. Non instrumented debug method calls are updated to use the new debug framework methods. However, the new debug logging framework is not yet active as the Aspects are not weaved in. After this revision, debug logging will be disabled in the server until the new AOP framework is complete. - Removed debugEnter and debugConstructor from all source files. - Removed CLASS_NAME static string for debug purposes. - Removed old debug logging framework. - Added new debug logging frameworking using AOP. - Added AspectJ binary and libraries. - Change all modified files copyrights to include 2007.

Update the plugin API to make the shutdown reason available to shutdown plugins. OpenDS Issue Number: 995

Add a new org.opends.server.types.DirectoryConfig class that can be used to expose a number of the methods from the DirectoryServer class as part of the public interface while reducing the need for extensions to reference code in the org.opends.server.core package. OpenDS Issue Number: 746

Perform significant refactoring in the core and plugin code in order to help make it easier for external developers to extend OpenDS. In particular, this is a big step towards eliminating the need for developers to reference anything in the core package, and it's also a signficant simplification to the plugin API because it helps expose which operation methods are safe to call at various points in the plugin processing. The most significant changes in this commit include: - I've created a new org.opends.server.types.operation package and added a lot of interfaces into it. These interfaces define the set of methods that may be called on operations at various points in plugin processing (e.g., there's a PreParseAddOperation interface that exposes the methods of the AddOperation class that are safe to call from a pre-parse plugin). All of the core operation types now implement the appropriate set of interfaces, and the plugin API methods now take these interfaces as arguments rather than the Operation subclass itself. - I've moved a number of classes from the core package to the types package. All references to these classes anywhere in the code were updated to reflect the change. The classes that were moved include: * CancelledOperationException * CancelRequest * CancelResult * CryptoManager * DirectoryException * InitializationException * LockManager * OperationType * Schema - I've also moved the test cases for the DirectoryException and InitializationException classes from the core to the types package. - Some general cleanup in the core operation classes. Virtually all methods should now be marked final. All methods inherited from the abstract Operation class now use "{@inheritDoc}" for the javadoc documentation and have the "@override" annotation. - The DirectoryServerPlugin class has been updated so that the default implementations for all plugin methods now throw a runtime exception to indicate that the requested functionality has not been implemented.

- pre-operation plugins are not called anymore when processing synchronization operations for ADD,DELELTE and MODIFYDN as it was already the case for MODIFY operation This is necessary to make sure that entries use the same unique ID everywhere. - Synchronization now its own serialization mechanism for synchronization messages (before it was using java object serialization) This allows to use the same serialization for data transfer between LDAP servers and changelog servers and for saving the changes into the changelog database. It will also allow to make some evolution the protocol without breaking the compatibility with previous releases. This also brings some performance improvements as this new serialization mechanism only needs to be done once on the master that originally processed the operation while before it was done for each transfer over the wire and for writing the changelog database.

Initial public commit of OpenDS Directory Server source code.