s/comment/self-documenting/

Use %pm available since apr 1.3 instead of an extra call to apr_strerror

* modules/filters/mod_ext_filter.c (ef_unified_filter): Set hit_eos flag on hitting EOS. (ef_input_filter): Give back EOS if filter is invoked after hitting EOS, rather than attempting (and failing) to read from the closed pipe to the child.

Replace use of apr_file_write() with apr_file_write_full() to prevent incomplete writes. Add comments in some places where error handling/logging is missing. PR: 53131. Submitted by: Nicolas Viennot <apache viennot biz>, Stefan Fritsch

Fix various filter functions to return apr_status_t instead of int

Further clarify the naming of the entity that originates the request by calling that entity a useragent instead of a client.

Add lots of unique tags to error log messages

Introduce a per connection "peer_ip" and a per request "client_ip" to distinguish between the raw IP address of the connection and the effective IP address of the request.

Introduce a per request version of the remote IP address, which can be optionally modified by a module when the effective IP of the client is not the same as the real IP of the client (such as a load balancer).

Introduce ap_(get|set)_core_module_config() functions/macros and use them everywhere. We know that the core module has module_index 0. Therefore we can save some pointer operations in ap_get_module_config(cv, &core_module) and ap_set_module_config(cv, &core_module, val). As these are called rather often, this may actually have some (small) measurable effect.

mod_ext_filter: Remove DebugLevel option in favor of per-module loglevel

Use the new APLOG_USE_MODULE/AP_DECLARE_MODULE macros everywhere to take advantage of per-module loglevels

mod_ext_filter: fix test for onfail behaviour (accidentally omitted from r731388)

Improved fix to PR#41120: send a clean error response when aborting

Fix mod_ext_filter to detect failure to start the external program, and add configuration option to abort or continue. PR 41120

Remove all references to CORE_PRIVATE.

revert r581660 , fixed instead in APR trunk/r583421 1.2.x/r583860

mod_ext_filter: Prevent a hang on Windows when the filter input data is pipelined PR 29901

Handle filter names which include capital letters. PR: 40323

update license header text

Update the copyright year in all .c, .h and .xml files

No functional Change: Removing trailing whitespace. This also means that "blank" lines consisting of just spaces or tabs are now really blank lines

Update copyright year to 2005 and standardize on current copyright owner line.

fix name of The Apache Software Foundation

fix copyright dates according to the first checkin

apply Apache License, Version 2.0

update license to 2004.

switch to new pollset api

get rid of _FOREACH

mod_ext_filter: Set additional environment variables for use by the external filter. PR: 20944 The missing code was identified by Andrew Ho, coded/tested by Jeff Trawick, and verified yet again by Neil Fraser.

mod_ext_filter: Add the ability to filter request bodies. Submitted by: Philipp Reisner <philipp.reisner@linbit.com> Reviewed by: Jeff Trawick

Fix the inability to log errors like exec failure in mod_ext_filter/mod_cgi script children (e.g., exec failure). This was broken after such children stopped inheriting the error log handle. (For this to work with mod_ext_filter, that module's LogStderr option has to be on.)

mod_cgi, mod_cgid, mod_ext_filter: Log errors when scripts cannot be started on Unix because of such problems as bad permissions, bad shebang line, etc. Some minor points: If mod_ext_filter debug is enabled, we go ahead and burn cycles in the parent to try to discover when we won't be able to exec the script. The mod_cgid handler wasn't communicating the right log level to the daemon; that was required to get the child errfn to spit out the right message, and it may fix an existing problem.

finished that boring job: update license to 2003. Happy New Year! ;-))

mod_ext_filter: Fix a problem building argument lists which occasionally caused exec to fail. The argument array passed to apr_proc_create() needs to have a NULL entry at the end. PR: 15491

Move mod_ext_filter out of experimental and into filters. See Attic in experimental directory for previous change history.