Main/Medium: Preserve any errors when deleting the medium locks list

Main/Medium: Clarify progress description when decrypting a medium

Main,FE/VBoxManage: Support exporting machines as appliances which have encrypted disks. Because the OVF standard doesn't support encrypted disks so far we always decrypt exported images which requires the password before starting the export proess

Fix unused variables warnings

Main/Medium+Snapshot: make all code recursing over trees (objects containing lists of child objects) use as little stack as possible, and establish safe depth limits to avoid crashes, plus related cleanups in related code areas

Main/Medium: release media locks by destroying tasks before sending task completion notifications (see #7763)

Main: Add a method to check for the correct encryption password

Fix for the fix

Main/Medium: Fix regression introduced with yesterdays changes

Main/Medium: Logic change for IMedium::ChangeEncryption, an empty password and password ID will result in the current password being used for encryption if the cipher is not empty. Useful for changing the encryption cipher of an image while still using the same password

Main: Rearrange and rename parameters of IMedium::ChangeEncryption

Main: Fix another place where VBOX_E_PASSWORD_INCORRECT should be returned

Medium: Return VBOX_E_PASSWORD_INCORRECT when changing the encryption setting for an image with encryption configured

Encryption: Add a way to retrieve the encryption settings without providing the password. Returns only the used cipher and the password ID

Fix lock order violation

Encryption/Main: Allow encryption of differencing media as long as there are no branches in the image chain and no image is used by multiple virtual machines

Main: Fixes for disk encryption support and make use of the optimized filter preparation when encrypting images for the first time

Add support to supply passwords for disk encryption while the VM is running

Main/Medium: Add basic support to encrypt/decrypt media, work in progress

Main/VirtualBox: eliminate redundant parameter to i_registerMedium, avoiding bugs with registering e.g. floppy images as hard disks. Main/Medium: switch over to CreateMedium, final API touch-ups, variable name cleanup, typo checking for backend support of fixed image creation, check for backends not supporting a particular device type Frontends/VBoxManage: cleanup, adapt to new API, generalize all operations which worked on hard disks only to all device types Frontends/VirtualBox: adapt to new API

Main: Fix race condition between Medium::Close and Medium::i_queryInfo which can result in corrupted parent UUIDs of images or errors when closing an image

Missing file

R7524 - needs testing in VBoxManage.

MediumImpl: safearray cleanup.

MediumImpl: Medium::getVariant cleanup

Main/Medium: fix deadlock between Medium::RefreshState and Medium::Close, lock order violation involving the event sem used in AutoCaller.

Main/VirtualBox+Medium+Snapshot: fix lock inconsistency which crept into the previous fixes

Main/Medium+AutoCaller+others: fix medium uninit deadlock caused by lock order violations, sometimes taking the caller before the media tree lock, sometimes after, plus a few other small fixes

Main/Medium: Fix VBoxSVC crashes when quering iSCSI targets with authentication configured

Main: AutoCaller/VirtualBoxBase refactoring, cleanly splitting out the object state handling, and moving all caller synchronization to one file. Also eliminated a not so vital template (AutoCallerBase) by much simpler inheritance. Theoretically has no visible effects, the behavior should be identical. Done as a preparation for reimplementing the caller synchronization.

Main: Add possibility to add medium properties for filters in a way wihtout changing any interfaces (for 4.3) for now

Main/Medium: fix some copy/paste issues, resulted in not so perfect error messages for OVF export and import, talking about cloning instead. Backport candidate, no regression risk.

6813 src-client/MachineDebuggerImpl.cpp + various formatting changes

6813 src-all/ProgressImp.cpp + some formatting/line length sorting

6813 - formatting changes as needed - HostImpl.cpp USBDeviceFilterImpl.cpp MediumImpl.cpp

6813 stage 7 VirtualBoxImpl.cpp etc

6813 - stage 5 - Make use of server side API wrapper code in all interfaces

6813 - User server side API wrapper code in all interfaces.. stage 4 rev 1

Main/Medium: fix regression in the wrapper conversion which caused hangs on every IMedium.close call

6813 - stage 3 rev 1

Main/MediumImpl: be more silent if Special medium properties are not there

Main/NetworkAdapter+Machine+Appliance+SystemProperties+Medium+Console+Settings+IDL: make NAT networking a separate network attachment type which improves the user experience, store the necessary settings, plus changing the design of the methods which will move images and entire VMs, they lacked a progress object Frontends/VirtualBox: adapted fully, can configure NAT networks with proper drop down list support Frontends/VBoxManage: also supports NAT networks completely, and adds the long missing code to list intnets

Main/Medium: redesign API level medium locking, needed conversions from MediaList to MediumLockLists in several places, forced cleanups elsewhere, too Main/Token: introduced token objects for controlling the unlocking, will be used as a general concept in the future Main/Snapshot: snapshot deletion needed significant cleanups as it was still using many shortcuts, directly calling the API to lock media instead of using lock lists. Now much better, and the online snapshot deletion is also a lot cleaner as it no longer passes unnecessary parameters around which are already known in the machine/snapshot code Main/MediumLock: small improvements, now has a mode which skips locking already locked media, needed by the Snapshot code where we have overlapping lock lists and have to update the original one instead Main/Console+Session+Machine: follow-up changes for the online snapshot merging parameter passing simplification, plus an unrelated lock order violation fix in Machine which happens only for inaccessible machines Main/testcase: update correspondingly doc: update SDK reference

Main/Medium: allow free form properties in the Special/ namespace, previously only properties defined by the VD backend were possible

Main/xml/Settings.cpp: limit snapshot depth to 250, avoiding crashes Main/Snapshot: limit snapshot depth to 250 Main/Medium: eliminate some spurious error messages when saving a VM config

Main/Medium: Use VD_OPEN_FLAGS_INFO when creating the diff image because the medium chain is not complete

Main: Code generator for (xp)com API implementations, including logging and parameter conversion, so far only used by MediumFormat. Next try, needed significant tweaks to work with xpcom (safearray handling fixes in the parameter conversion helpers), different STL implementation (which doesn't support declaring template type parameters as const), missing build dependencies (which didn't show on the dual core system used for writing the code), and finally the duplicate XPCOM classinfo and AddRef/Release/QueryInterface method definitions needed to be removed.

back out API wrapper generator, too broken with XPCOM

Main: Code generator for (xp)com implementations, including logging and parameter conversion, so far only used by MediumFormat.

Main/Medium: Remove leftover calls to UnlockWrite in ResetHandler causing hangs during startup

Main/Medium: improve the error handling for medium UUID change failures, e.g. when the medium is readonly.

Main/Medium: resizing needs to update the image size information, and finally rip out the useless and weird logic which always returned the capacity for the base medium for all diff images,

Main/SnapshotImpl: Select merge direction based on the image size

Main: operator precedence

Main: The change ulong to ULONG inside the loops where enumeration MediumVariant is converted.

The changes inside loops where enumeration MediumVariant is converted. For correct work under both systems Windows and Linux because enumeration is defined differently on these systems.

Main: change API. Interface IMedium was touched. Handling enumeration MediumVariant was changed. PR5434.

Main: adjust r83244. Don't loop endlessly in case the PRNG is broken and avoid the empty location hack by introducing a sperate API to check for used UUIDs

Main: Check for already used UUIDs when registering a new non file based Medium and recreate if there are conflicts

Main: Fix assertion, pMedium can be Null if there is an error

Main: make the code more readable. Places where the comparisons were of the form 'isValid() == true\false' or 'isZero() == true\false' were carved \ simplified.

Main: renavation com::Guid class. PR5744

Main/Medium: fix logic for updating image UUID and parent UUID so that arbitrary medium hierarchies (potentially with overlaps with known media) can be opened/fixed up to use their own UUIDs

Main/Machine+Snapshot+Medium: fix cancelling snapshots, used to trigger both backref inconsistency and incorrect lock list/map updates which could cause runtime misbehavior, the config file was already made consistent with the previous changes

Main/MediumImpl: Fix deadlock when two threads attempt to close the same medium object. Triggers lock order violation which is not detectable by the lock validator as only one lock is a RW semaphore, the other one is the AutoCaller event semaphore used for synchronizing callers and init/uninit.

Main/Medium: fix race (involving several locks and the object state/caller) between VirtualBox::OpenMedium and Medium::saveSettings. Very tiny window, can only happen after queryInfo has sorted it correctly into the media tree and before the medium was marked as initialized. Also eliminate a race between placing the image in the media tree and updating its UUID to the correct value.

Main/Medium: fix copy/paste bugs in error messages for resizing a medium

Main: big API naming cleanup, use all caps acronyms everywhere, including SDK docs Frontends/VBoxManage: implement guestcontrol execute for new API, disabled by default

added 3 extra methods for 6124

Main: properly initialize fSettingsCipherKeySet; don't ignore errors during encryption

optional encrypted store of the iSCSI initiator secret

Main/Medium: fix excessive settings saving as part of Medium::deleteStorage, and adjusted all necessary callers (only one change needed, as all other places save the media registries already in one way or another)

Main/Medium: small optimization, as it is only necessary to look at the original location if it isn't the same as the (potentially modified) one.

Main/VirtualBox: very tricky fix for renaming linked clones (media registry needs saving) which avoids locking problems by using a separate thread

Main/MediumImpl: correct error code if a medium file is not accessible

Main/Medium: Update medium registries when closing/deleting a medium. Regression.

Main/Medium: Hopefully final go at holding the Medium object lock as briefly as possible. Previously the code was simpler, but held the lock over long operations such as opening images, and this caused e.g. slow GUI startup time.

Main/VirtualBox+Machine+Snapshot+Medium: fix lock order issues introduced by new style of medium registry updates

Main/Medium: fix outdated method names in comments

Main/Medium: another go at the medium locking related to queryInfo, since there was a remaining deadlock with the LockWrite method.

Main/VirtualBox+Machine+Medium: redesign the medium registry save logic, as the local lists in the threads caused inconsistencies with concurrent operations and the return of spurious errors

Main/Medium: Report errors detected when closing the medium in Medium::queryInfo. Otherwise failure to change the medium UUID goes unnoticed.

Main/Medium: rework locking scheme to solve lock order violations and long GUI start up time caused by too much locking Main/all: Remove the enter and leave methods from write locks, they cause hard to find locking problems. Better solve them explicitly.

Main/Medium: Add field for default open flags and add VD_OPEN_FLAGS_IGNORE_FLUSH for now

Main/Medium+Snapshot+VirtualBox: extend the API in a compatible way to support skipping the automatic directory creation when creating new images.

Main: only add parent to the lock list if it isn't null

Main: only add parent to the lock list if it isn't null

Main/Medium+Machine: final lock order fixes

Main/Medium: lock typo

Main/Medium: all remaining changes to get the media tree lock order issues sorted in this file (I hope).

Main/Medium+Machine: fix lock order issues when creating diff images, and eliminate a bit of redundant code.

Main/Medium+Machine+AutoLock: Integrate the queryInfo semaphore into the AutoLock infrastructure with the appropriate lock class. Adjust the locking rules for queryInfo and start propagating them up to the callers. Needs more work, but this is comparably simple: just get the mediaTree lock in the caller if the assert triggers.

Main/Medium: replace the event semaphore used to wait for queryInfo by a RW semaphore

build fix

warnings

Main: fix possible dead-lock between IMedium::RefreshState and IMedium::Reset

Main/Machine+Medium: fix medium registry association when attaching a device or mounting a medium, when there is a chain of parent images which are not associated with any media registry, including the necessary locking adjustments

Main/Medium: fix error message handling in the error cleanup code

VD: Interface cleanup. Merge the two involved structures (generic interface descriptor and callback table) into one, remove the duplicated interface wrappers in the backends and move the interface definitions into separate headers separating public and private interfaces.

Main/Medium: make CreateDiffMedium more convenient to use by associating the medium with a registry, and fix error handling in CloneTo by not attempting to save the config since this often causes spurious extra error messages

Main-Clone: use new Medium::cloneToEx method

Main/Medium: fix object locks and medium lock state in createDiffStorage()

Main/Medium: public cloneToEx API for internal use which makes it possible to control certain optimizations during VM cloning

Main/Machine: fix the medium registry logic for linked clones. Previously creating a linked clone of a snapshot of a linked clone didn't result in the right medium registry update.

Main/Medium: comment typo

Main-CloneVM;FE/CLI;Doc: update differencing disk names with there new uuid; rename all other disks to the new name + disk#; optional allow keeping old disk names

Main/Medium: added new attribute for getting the possible medium types, not implemented right now

Main: add implicit parents which are not attached to other machines to the deletion list on unregister (code still disabled)

Main/Medium: fix regression in previous change, VBoxSVC crashed for newly added media, when format autodetection is used

Main/Medium: Fix incorrect forcing of absolute paths for non-file based media. Triggered with iSCSI, causing strange full location values. Also clean up code a bit which checks backend capabilities.

Main/VirtualBox+Medium: resurrect the feature of changing the medium UUID when opening the image, which allows to resolve duplicate UUIDs without using external tools. Also fixes Medium::setIDs, which wasn't correctly working. Frontends/*: corresponding changes.

Main/Medium: provide error message for duplicate attachment of one medium to the current state of a VM, so that users have a hint what needs fixing

Main/MediumImpl: Fix memory leaks in some medium operation error cases. Clean up error handling, in particular with saving registries. Return all relevant error messages, i.e. both the failing operation and the reason for the failure to save the registry if applicable. Update the comments to match the current method names.

Main: don't override existing error codes

Main/Medium: only create the target path if the destination is file based

Main/Medium: VMDK variant streamOptimized cannot be used to directly attach, so force indirect attachment

Main/medium: Create target images for export in sequential mode.

Main: fix warning

Main: further fix broken snapshots when disk images are shared between several machines: recurse into diff images as well

Main: fix broken snapshots when disk images are shared between several machines

Main: before unregistering a machine, move media shared with another machine to that machine's media registry to prevent that machine from becoming inaccessible

Main: do not return first item from list of registry IDs unconditionally since that list may be empty; this fixes the problem that media registry do not get saved properly if a new immutable image gets attached to a machine

Main: document the reasoning behind the host drive UUIDs

Main. QT/FE: fix long standing COM issue

Main/Medium: Query the capabilites of the target format used for the diff image and not the capabilities of the image we create the diff for. Fixes creating snapshots of images which don't support diff images (Raw for example)

Main: source re-org.