tree-wide: remove Emacs lines from all files This should be handled fine now by .dir-locals.el, so need to carry that stuff in every file.

tmpfiles: don't skip path_set_perms on error fixes #2196

tree-wide: check if errno is greater than zero (2) Compare errno with zero in a way that tells gcc that (if the condition is true) errno is positive.

tmpfiles: create subvolumes for "v", "q", and "Q" only if / is a subvolume It's not a good idea to create subvolumes for parts of the OS tree (such as /home, or /var) if the root directory is not a subvolume too. We shouldn't assume control of "heavier" objects such as subvolumes, if the originating object (the root directory) is a "light-weight" object, i.e. a plain directory. Effectively this means that chroot() environments that are run on a plain directory do not have to deal with problems around systemd creating subvolumes that cannot be removed with a simple "rm" anymore. However, if the chroot manager creates a proper subvolume for such an environment it will also get further subvolumes placed in there, under the assumption that the manager understands the concept of subvolumes in that case.

tmpfiles: don't consider it a problem if quota is not enabled on btrfs If quota is not enabled on a btrfs file system, accept that, and only log a debug message, but do not consider this a reason for failure. Fixes: #1809

defs: rework CONF_DIRS_NULSTR() macro The macro is generically useful for putting together search paths, hence let's make it truly generic, by dropping the implicit ".d" appending it does, and leave that to the caller. Also rename it from CONF_DIRS_NULSTR() to CONF_PATHS_NULSTR(), since it's not strictly about dirs that way, but any kind of file system path. Also, mark CONF_DIR_SPLIT_USR() as internal macro by renaming it to _CONF_PATHS_SPLIT_USR() so that the leading underscore indicates that it's internal.

util-lib: move CONF_DIRS_NULSTR definition to def.h After all, this is not some compiler or C magic, but something very specific to how systemd works, hence let's move it into def.h, and out of macro.h

mount-util: move fstype_is_network() and name_to_handle_at() definitions over

util-lib: split out allocation calls into alloc-util.[ch]

util-lib: split out globbing related calls into glob-util.[ch]

util-lib: split out printf() helpers to stdio-util.h

src/basic: rename audit.[ch] → audit-util.[ch] and capability.[ch] → capability-util.[ch] The files are named too generically, so that they might conflict with the upstream project headers. Hence, let's add a "-util" suffix, to clarify that this are just our utility headers and not any official upstream headers.

util-lib: split out umask-related code to umask-util.h

util-lib: move string table stuff into its own string-table.[ch]

util-lib: split stat()/statfs()/stavfs() related calls into stat-util.[ch]

util-lib: move a number of fs operations into fs-util.[ch]

util-lib: split out file attribute calls to chattr-util.[ch]

util-lib: move more file I/O related calls into fileio.[ch]

util-lib: split string parsing related calls from util.[ch] into parse-util.[ch]

util-lib: split out user/group/uid/gid calls into user-util.[ch]

util-lib: split out IO related calls to io-util.[ch]

util-lib: split out fd-related operations into fd-util.[ch] There are more than enough to deserve their own .c file, hence move them over.

util-lib: split our string related calls from util.[ch] into its own file string-util.[ch] There are more than enough calls doing string manipulations to deserve its own files, hence do something about it. This patch also sorts the #include blocks of all files that needed to be updated, according to the sorting suggestions from CODING_STYLE. Since pretty much every file needs our string manipulation functions this effectively means that most files have sorted #include blocks now. Also touches a few unrelated include files.

util: split out escaping code into escape.[ch] This really deserves its own file, given how much code this is now.

path-util: unify how we process paths specified on the command line Let's introduce a common function that makes relative paths absolute and warns about any errors while doing so.

util-lib: get_current_dir_name() can return errors other than ENOMEM get_current_dir_name() can return a variety of errors, not just ENOMEM, hence don't blindly turn its errors to ENOMEM, but return correct errors in path_make_absolute_cwd(). This trickles down into a couple of other functions, some of which receive unrelated minor fixes too with this commit.

tmpfiles: simplify mountpoint detection No functional change. Just a simplification. A || (!A && B) is the same as A || B Introduced in 78a92a5a2306709e4587e332728a76901323ade9

tmpfiles: introduce "q" and "Q" for creating quota-enabled btrfs subvolumes This allows us to set up the quota group hierarchy in a reasonable way on btrfs file systems.

util: introduce common version() implementation and use it everywhere This also allows us to drop build.h from a ton of files, hence do so. Since we touched the #includes of those files, let's order them properly according to CODING_STYLE.

util: Don't interpret quotes by default in extract_first_word This adds an EXTRACT_QUOTES option to allow the previous behaviour, of not interpreting any character inside ' or " quotes as separators.

util: change unquote_*_word to extract_*_word It now takes a separators argument, which defaults to WHITESPACE if NULL is passed.

tree-wide: fix indentation

tmpfiles: downgrade errors when a file system does not support file attributes This downgrades errors from setting file attributes via tmpfiles to warnings and makes them non-fatal. Also, as a special case, if a file system does not support file attributes at all, then the message is downgraded to debug, so that it is not seen at all. With this change reiserfs should not see any messages at all anymore (since it apparently does not implement file attributes at all), but XFS will still get a warning but no failure. The warning is something the XFS kernel folks should fix though, by adjusting their file attributes behaviour to be identical to ext234's. Fixes #560.

tmpfiles: only root-owned aquota.* files are special Fixes #188.

tmpfiles: make sure "R" lines also remove subvolumes

tmpfiles: use lstat() instead of stat() when checking whether a file system object already exists

tmpfiles: don't fail if we cannot create a subvolume because a file system is read-only but a dir already exists anyway https://bugs.freedesktop.org/show_bug.cgi?id=90281

util: add generic calls for prefixing a root directory to a path So far a number of utilities implemented their own calls for this, unify them in prefix_root() and prefix_roota(). The former uses heap memory, the latter allocates from the stack via alloca(). Port over most users of a --root= logic.

tmpfiles: try to handle read-only file systems gracefully On read-only filesystems trying to create the target will not fail with EEXIST but with EROFS. Handle EROFS by checking if the target already exists, and if empty when truncating. This avoids reporting errors if tmpfiles doesn't actually needs to do anything. [zj: revert condition to whitelist rather then blacklisting, and add goto to avoid stat'ting twice.]

tmpfiles: use an ordered hashmap for the tmpfiles items We should try to execute them in the same order they appear in the configuration files, as it is documented. Hence move to an ordered hashmap. (Note though, that this still doesn't execute them completely in order: we will still apply non-glob lines before glob-lines, and reorder lines prefixing each other and that apply to the same paths). http://lists.freedesktop.org/archives/systemd-devel/2015-March/029055.html

tmpfiles: consider an argument of "-" as non-specified

tmpfiles: don't follow symlinks when adjusting ACLs, fille attributes, access modes or ownership

tmpfiles: use qsort_safe

shared: add formats-util.h

tmpfiles: fix build with clang Clang is not happy about using the cleanup attribute in switches

tmpfiles: add specifier expansion for L and C lines, too

tmpfiles: enforce ordering when executing lines Always create files first, and then adjust their ACLs, xattrs, file attributes, never the opposite. Previously the order was not deterministic, thus possibly first adjusting ACLs/xattrs/file attributes before actually creating the items.

tmpfiles: eat up empty columns

tmpfiles: substitute % specifiers in arguments for writing files and xattrs

tmpfiles: warn if we get an argument on lines that don't take any

tmpfiles: mostly revert 71044f609b829d802e0eb81270e13b4f55d76476 Add a comment why returning a positive error is OK and intended in this case. (It's still a nasty hack to do this though!)

util: unify how we parse mode_t strings

tmpfiles: properly return error code from path_set_acl()

tmpfiles: add file attribute calls to list of glob needing commands

tmpfiles: rework file attribute code - Stick to one type for the flags field: unsigned. This appears to be what the kernel uses, and there's no point in using something else. - compress the flags array by avoiding sparse entries - extend some error messages to not use abbreviated words - avoid TTOCTTOU issues by invoking fstat() after open() when applying file flags - add explanation why we need to check the file type with fstat(). - don't needlessly abbreviate "attribute" as "attrib", in particually as "chattr" abbreviates it as "attr" rather than "attrib".

util: merge change_attr_fd() and chattr_fd()

util: rework cunescape(), improve error handling Change cunescape() to return a normal error code, so that we can distuingish OOM errors from parse errors. This also adds a flags parameter to control whether "relaxed" or normal parsing shall be done. If set no parse failures are generated, and the only reason why cunescape() can fail is OOM.

util: rework rm_rf() logic - Move to its own file rm-rf.c - Change parameters into a single flags parameter - Remove "honour sticky" logic, it's unused these days

util: rework word parsing and c unescaping code When parsing words from input files, optionally automatically unescape the passed strings, controllable via a new flags parameter. Make use of this in tmpfiles, and port everything else over, too. This improves parsing quite a bit, since we no longer have to process the same string multiple times with different calls, where an earlier call might corrupt the input for a later call.

tmpfiles: minor simplification

tmpfiles: avoid out of bounds read Otherwise this will go wrong for 'v'.

Allow systemd-tmpfiles to set the file/directory attributes Allow systemd-tmpfiles to set the file/directory attributes, like chattr(1) does. Two more commands are added: 'H' and 'h' to set the attributes, recursively and not.

tmpfiles: remove redundant debug message Mar 13 19:48:30 adam.happyassassin.net systemd-tmpfiles[970]: "/var/lib/machines" has right mode 40700 Mar 13 19:48:30 adam.happyassassin.net systemd-tmpfiles[970]: /var/lib/machines created successfully.

tree-wide: there is no ENOTSUP on linux Replace ENOTSUP by EOPNOTSUPP as this is what linux actually uses.

tmpfiles: port to unquote_many_words()

tmpfiles: Fix handling of duplicate lines Commit 3f93da987 accidentally dropped the "return 0" after detection of a duplicate line. Put it back, to get back the documented and intended "first match wins" behaviour. https://launchpad.net/bugs/1428540

tmpfiles: quietly ignore ACLs on unsupported filesystems A warning is printed if ACLs cannot be retrieved for any reason other than -ENOSYS. For -ENOSYS, debug log is printed.

remove unused includes This patch removes includes that are not used. The removals were found with include-what-you-use which checks if any of the symbols from a header is in use.

tmpfiles: Fix parse_acl error message parse_acl() returns the error instead of setting errno.

tmpfiles: fix compilation without acl support

partial revert of fed6df8 This one was acutally used to free xattr

remove unused variables

tmpfiles: let's always use DEFINE_PRIVATE_STRING_TABLE_LOOKUP_TO_STRING() instead of defining our own string tables

tmpfiles: accurately report creation results

tmpfiles: remove dead branch In the test, p is a path to a directory, always absolute. dent->d_name is a single path component, so they cannot be equal. The comparison was wrong also for other reasons: D type supports globs, so direct comparisons using streq are not enough.

tmpfiles: fix help text The help text, apart from being too long, did not describe what the options really do.

tmpfiles: use casts instead of warning suppression This warning got its own name only in gcc5, so the suppression does not work in gcc4, and generates a warning of its own. Use a cast, which is ugly too, but less so.

tmpfiles: do not bump access times of directories we are cleaning up Both plain opendir() and glob() will bump access time. Privileged option O_NOATIME can be used to prevent the access time from being updated. We already used it for subdirectories of the directories which we were cleaning up. But for the directories specified directly in the config files, we wouldn't do that. This means that, paradoxically, our own temporary directories for PrivateTmp would stay around forever, as long as one let systemd-tmpfiles-clean.service run regularly, because they had their own glob patterns specified. https://bugzilla.redhat.com/show_bug.cgi?id=1183684

tmpfiles: add debug statements for all actions systemd-tmpfiles can be used by users, but it can be quite hard to figure out the logic it follows, especially since the logic is in some places rather torturous. Hopefuly this will make it easier for users to understand what is happening.

tmpfiles: minor simplification

shared/acl-util: add mask only when needed, always add base ACLs For ACLs to be valid, a set of entries for user, group, and other must be always present. Always add those entries. While at it, only add the mask ACL if it is actually required, i.e. when at least on ACL for non-owner group or user exists.

tmpfiles: implement augmenting of existing ACLs This is much more useful in practice (equivalent to setfacl -m).

tmpfiles: make t and a globby, add their recursive versions T and A For types which adapt existing files it is generally more useful to accept globs. In analogy to z and Z, add recursive versions using uppercase letters. Technically, making a accept globs is backwards incompatible, but in practice it probably isn't yet widely used and we can assume that most people don't create files with wildcards in names. Functions which are used as callbacks, but not directly on items, are renamed not to have "item_" prefix.

tmpfiles: make recursive operation generic

tmpfiles: add 'a' type to set ACLs

tmpfiles: attach an array of items to each path The data structure used by tmpfiles is changed: instead of hashmaps mapping {path → Item*} we now have hashmaps containing {path -> ItemArray}, where ItemArray contains a pointer to an array of Items. For current code it doesn't matter much, but when we add new types it is easier to simply add a new Item for a given path, then to coalesce multiple lines into one Item. In the future, this change will also make it possible to remember the file and line where each Item originates, and use that in reporting errors. Currently this is not possible, since each Item can be created from multiple lines.

tmpfiles: make sure not to concatenate non-absolute path If the path is absolute was only checked later. Also do not check if path if absolute if we just specified it starting with a slash.

tmpfiles: detect all combinations of + and ! The same algorithm as with - and @ in ExecStart= is used.

tmpfiles: simplification Certain conditions were checked more than once. Warning message is improved.

Add initialization helper for file_handle_union

tmpfiles: make gcc shut up

tmpfiles: finish with EXIT_FAILURE if anything failed Return value is successful only if everything succeeded.

tmpfiles: fix 'D' lines https://bugs.freedesktop.org/show_bug.cgi?id=87953

tmpfiles: add new line type 'v' for creating btrfs subvolumes

tmpfiles: remove spurious include of <sys/capability.h> It does not use any functions from libcap directly. The CAP_MKNOD constant in use by this file comes from <linux/capability.h> imported through "missing.h". Tested that "systemd-tmpfiles" builds cleanly and works after this change.

tmpfiles, man: Add xattr support to tmpfiles This patch makes it possible to set extended attributes on files created by tmpfiles. This can be especially used to set SMACK security labels on volatile files and directories. It is done by adding new line of type "t". Such line should contain attributes in Argument field, using following format: name=value All other fields are ignored. If value contains spaces, then it must be surrounded by quotation marks. User can also put quotation mark in value by escaping it with backslash. Example: D /var/run/cups - - - - t /var/run/cups - - - - security.SMACK64=printing

treewide: introduce UID_INVALID (and friends) as macro for (uid_t) -1

treewide: another round of simplifications Using the same scripts as in f647962d64e "treewide: yet more log_*_errno + return simplifications".

treewide: use log_*_errno whenever %m is in the format string If the format string contains %m, clearly errno must have a meaningful value, so we might as well use log_*_errno to have ERRNO= logged. Using: find . -name '*.[ch]' | xargs sed -r -i -e \ 's/log_(debug|info|notice|warning|error|emergency)\((".*%m.*")/log_\1_errno(errno, \2/' Plus some whitespace, linewrap, and indent adjustments.

treewide: a few more log_*_errno + return simplifications The one in tmpfiles.c:create_item() even looks like it fixes a bug.

treewide: yet more log_*_errno + return simplifications Using: find . -name '*.[ch]' | while read f; do perl -i.mmm -e \ 'local $/; local $_=<>; s/(if\s*\([^\n]+\))\s*{\n(\s*)(log_[a-z_]*_errno\(\s*([->a-zA-Z_]+)\s*,[^;]+);\s*return\s+\g4;\s+}/\1\n\2return \3;/msg; print;' $f done And a couple of manual whitespace fixups.

treewide: no need to negate errno for log_*_errno() It corrrectly handles both positive and negative errno values.

treewide: auto-convert the simple cases to log_*_errno() As a followup to 086891e5c1 "log: add an "error" parameter to all low-level logging calls and intrdouce log_error_errno() as log calls that take error numbers", use sed to convert the simple cases to use the new macros: find . -name '*.[ch]' | xargs sed -r -i -e \ 's/log_(debug|info|notice|warning|error|emergency)\("(.*)%s"(.*), strerror\(-([a-zA-Z_]+)\)\);/log_\1_errno(-\4, "\2%m"\3);/' Multi-line log_*() invocations are not covered. And we also should add log_unit_*_errno().

Introduce CONF_DIRS_NULSTR helper to define standard conf dirs Several different systemd tools define a nulstr containing a standard series of configuration file directories, in /etc, /run, /usr/local/lib, /usr/lib, and (#ifdef HAVE_SPLIT_USR) /lib. Factor that logic out into a new helper macro, CONF_DIRS_NULSTR.

selinux: clean up selinux label function naming

mac: rename apis with mac_{selinux/smack}_ prefix

tmpfiles: compare return against correct errno name_to_handle_at returns -EOPNOTSUPP, not -ENOTSUP.

tmpfiles: use allocated buffer for path Paths can in principle be longer then PATH_MAX, so simply allocate the buffer with malloc(). CID #1237773

systemd-tmpfiles: Fix IGNORE_DIRECTORY_PATH age handling If one has a config like: d /tmp 1777 root root - X /tmp/important_mount All files below /tmp/important_mount will be deleted as the /tmp/important_mount item will spuriously inherit a max age of 0 from /tmp. /tmp has a max age of 0 but age_set is (of course) false. This affects also the PrivateTmp feature of systemd. All tmp files of such services will be deleted unconditionally and can cause service failures and data loss. Fix this by checking ->age_set in the IGNORE_DIRECTORY_PATH logic.

hashmap: introduce hash_ops to make struct Hashmap smaller It is redundant to store 'hash' and 'compare' function pointers in struct Hashmap separately. The functions always comprise a pair. Store a single pointer to struct hash_ops instead. systemd keeps hundreds of hashmaps, so this saves a little bit of memory.

tmpfiles: only execute chmod()/chown() when needed This avoids errors like this, when the paths are already there with the correct permissions and owner: chmod(/var/spool) failed: Read-only file system

Unify parse_argv style getopt is usually good at printing out a nice error message when commandline options are invalid. It distinguishes between an unknown option and a known option with a missing arg. It is better to let it do its job and not use opterr=0 unless we actually want to suppress messages. So remove opterr=0 in the few places where it wasn't really useful. When an error in options is encountered, we should not print a lengthy help() and overwhelm the user, when we know precisely what is wrong with the commandline. In addition, since help() prints to stdout, it should not be used except when requested with -h or --help. Also, simplify things here and there.

tmpfiles: copy/link /usr/share/factory/ files when the source argument is omitted

tmpfiles: make sure "C" doesn't copy anything if the destination already exists Previously it would recursively copy the entire tree in, and descend into subdirectories even if the destination already exists. Let's do what the documentation says and not do that. If files down the tree shall be copied too, they should get their own "C" lines.

tmpfiles: do not fail when copying an empty directory

tmpfiles: create directories already with the right label, instead of creating them first, and relabeling them afterwards

tmpfiles: w lines should allow following symlinks

tmpfiles: add "+" modifier support to b, c, p lines in addition to L

tmpfiles: add new "L+" command as stronger version of "L", that removes the destination before creating a symlink Also, make use of this for mtab as long as mount insists on creating it even if we invoke it with "-n".

tmpfiles: set up selinux label proeprly when creating fifos

tmpfiles: skip mknod() on -EPERM (device cgroup)

tmpfiles: minor modernizations

tmpfiles: add ability to mask access mode by pre-existing access mode on files/directories This way it makes a lot more sense to specify an access mode for "Z" lines.

tmpfiles: remove unnecessary function

tmpfiles: when processing lines, always process prefixes before suffixes If two lines refer to paths that are suffix and prefix of each other, then always process the prefix first, the suffix second. In all other cases strictly process rules in the order they appear in the files. This makes creating /var/run as symlink to /run a lot more fun, since it is automatically created first.

tmpfiles: static variables populated immediately from the command line should be prefixed with arg_

tmpfiles: always recreate the most basic directory structure in /var Let's allow booting up with /var empty. Only create the most basic directories to get to a working directory structure and symlink set in /var.

tmpfiles: get rid of "m" lines, make them redundant by "z" "m" so far has been a non-globbing version of "z". Since this makes it quite redundant, let's get rid of it. Remove "m" from the man pages, beef up "z" docs instead, and make "m" nothing more than a compatibility alias for "z".

tmpfiles: add new "C" line for copying files or directories

tmpfiles: various modernizations

label: when clearing selinux context, don't mangle errno

implement a union to pad out file_handle Cases where name_to_handle_at is used allocated the full struct to be MAX_HANDLE_SZ, and assigned this size to handle_bytes. This is wrong since handle_bytes should describe the length of the flexible array member and not the whole struct. Define a union type which includes sufficient padding to allow assignment of MAX_HANDLE_SZ to be correct.

util: replace close_nointr_nofail() by a more useful safe_close() safe_close() automatically becomes a NOP when a negative fd is passed, and returns -1 unconditionally. This makes it easy to write lines like this: fd = safe_close(fd); Which will close an fd if it is open, and reset the fd variable correctly. By making use of this new scheme we can drop a > 200 lines of code that was required to test for non-negative fds or to reset the closed fd variable afterwards.

shared: export is_dir

tmpfiles: add --root option to operate on an alternate fs tree This makes it possible to initialize or cleanup an arbitrary filesystem hierarchy in the same way that it would be during system boot.

shared: add root argument to search_and_fopen This adds the same root argument to search_and_fopen that conf_files_list already has. Tools that use those two functions as a pair can now be easily modified to load configuration files from an alternate root filesystem tree.

tmpfiles: simplification

tmpfiles: fix memory leak of exclude_prefixes Missed in 5c795114.

tmpfiles: don't allow label_fix to print ENOENT when we want to ignore it

tmpfiles: rename --unsafe to --boot As suggested by Kay, it is better to describe what is done, not what might happen.

tmpfiles: introduce the concept of unsafe operations Various operations done by systemd-tmpfiles may only be safely done at boot (e.g. removal of X lockfiles in /tmp, creation of /run/nologin). Other operations may be done at any point in time (e.g. setting the ownership on /{run,var}/log/journal). This distinction is largely orthogonal to the type of operation. A new switch --unsafe is added, and operations which should only be executed during bootup are marked with an exclamation mark in the configuration files. systemd-tmpfiles.service is modified to use this switch, and guards are added so it is hard to re-start it by mistake. If we install a new version of systemd, we actually want to enforce some changes to tmpfiles configuration immediately. This should now be possible to do safely, so distribution packages can be modified to execute the "safe" subset at package installation time. /run/nologin creation is split out into a separate service, to make it easy to override. https://bugzilla.redhat.com/show_bug.cgi?id=1043212 https://bugzilla.redhat.com/show_bug.cgi?id=1045849

log: log_error() and friends add a newline after each line anyway, so avoid including it in the log strings

tmpfiles: replace readdir_r with readdir

clients: unify how we invoke getopt_long() Among other things this makes sure we always expose a --version command and show it in the help texts.

build-sys: use -Og instead of -O0 to catch warnings $ touch src/core/dbus.c; make CFLAGS=-O0 make --no-print-directory all-recursive Making all in . CC src/core/libsystemd_core_la-dbus.lo CCLD libsystemd-core.la $ touch src/core/dbus.c; make CFLAGS=-Og make --no-print-directory all-recursive Making all in . CC src/core/libsystemd_core_la-dbus.lo src/core/dbus.c: In function 'init_registered_system_bus': src/core/dbus.c:798:18: warning: 'id' may be used uninitialized in this function [-Wmaybe-uninitialized] dbus_free(id); ^ CCLD libsystemd-core.la -Og Optimize debugging experience. -Og enables optimizations that do not interfere with debugging. It should be the optimization level of choice for the standard edit-compile-debug cycle, offering a reasonable level of optimization while maintaining fast compilation and a good debugging experience.

tmpfiles: log unaccessible FUSE mount points only as debug message

util: allow trailing semicolons on define_trivial_cleanup_func lines Emacs C indenting really gets confused by these lines if they carry no trailing semicolon, hence let's make this nicer for good old emacs. The other macros which define functions already do this too, so let's copy the scheme here. Also, let's use an uppercase name for the macro. So far our rough rule was that macros that are totally not function-like (like this ones, which define a function) are uppercase. (Well, admittedly it is a rough rule only, for example function and variable decorators are all lower-case SINCE THE CONSTANT YELLING IN THE SOURCES WOULD SUCK, and also they at least got underscore prefixes.) Also, the macros that define functions that we already have are all uppercase, so let's do the same here...

Introduce udev object cleanup functions

tmpfiles: add a new "m" line type that adjusts user/group/mode of a file if it exists

tmpfiles: support simple specifier expansion for specified paths

tmpfiles: introduce --exclude-prefix The opposite of --prefix, allows specifying path prefixes which should be skipped when processing rules.

tmpfiles: support passing --prefix multiple times

tmpfiles: Fix memory leak in parse_line()

tmpfiles: fix error check

Add set_consume which always takes ownership Freeing in error path is the common pattern with set_put().

move _cleanup_ attribute in front of the type http://lists.freedesktop.org/archives/systemd-devel/2013-April/010510.html

Fix spelling errors using 'codespell' tool

Add _cleanup_globfree_ Fixes a memleak in error path in exec_context_load_environment.

Use initalization instead of explicit zeroing Before, we would initialize many fields twice: first by filling the structure with zeros, and then a second time with the real values. We can let the compiler do the job for us, avoiding one copy. A downside of this patch is that text gets slightly bigger. This is because all zero() calls are effectively inlined: $ size build/.libs/systemd text data bss dec hex filename before 897737 107300 2560 1007597 f5fed build/.libs/systemd after 897873 107300 2560 1007733 f6075 build/.libs/systemd … actually less than 1‰. A few asserts that the parameter is not null had to be removed. I don't think this changes much, because first, it is quite unlikely for the assert to fail, and second, an immediate SEGV is almost as good as an assert.

util: add a bit of syntactic sugar to run short code fragments with a different umask

util: rename parse_usec() to parse_sec() sinds the default unit is seconds Internally we store all time values in usec_t, however parse_usec() actually was used mostly to parse values in seconds (unless explicit units were specified to define a different unit). Hence, be clear about this and name the function about what we pass into it, not what we get out of it.

tmpfiles: fix obscure leak in error path The leak was because of the single return in midst of all 'goto finish'es. Using automatic cleanup simplifies things.

Always use errno > 0 to help gcc gcc thinks that errno might be negative, and functions could return something positive on error (-errno). Should not matter in practice, but makes an -O4 build much quieter.

tmpfiles: add missing missing.h include mbiebl> src/tmpfiles/tmpfiles.c:221:13: error: ‘MAX_HANDLE_SZ’ undeclared (first use in this function) Fixup for 427b47c4abaf4b5.

tmpfiles: --clean -- check for bind mounts of the same filesystem and skip them

tmpfiles: use cleanup func. to save a few lines

tmpfiles: move exclamation mark into right place Unary not has higher precedence than comparisons, so the condition was bogus.

binfmt,tmpfiles,modules-load,sysctl: rework the various early-boot services that work on .d/ directories This unifies much of the logic behind them: - All four will now ofllow the rule that the earlier file and earlier assignment in the .d/ directories wins. Before, sysctl was the only outlier, where the later setting always won. - All four now support getopt() and --help on the command line. - All four can now handle specification of configuration file names on the command line to apply. The tools will automatically find them, and apply them. Previously only tmpfiles could do that. This is useful for %post scripts in RPMs and suchlike. - This fixes various error path issues in conf_files_list()

shared: conf-files - add root parameter

tmpfiles: introduce type X Type X will exclude path itself from clean-up. However, if the path is a directory systemd-tmpfiles will clean-up its content. In contrast to type x, where path is ignored completely, type X needs some Age parameter. In order to determine Age parameter, we will look for config entries of type d or D and pick the best match. Best match is either exact match or longest prefix match.

tmpfiles: Fix file descriptor leak on error Detected by cppcheck

tmpfiles: allow Age to be set to 0 Mostly useful for testing purposes. Setting Age to 1s works just as well, but it is surprising that using 0s (or just 0) does not work. Also clarify this in the documentation.

udev: add hardware database support

tmpfiles: restore previous behavior for F/f d4e9eb91ea changed the behavior for the F and f actions, wrongly sending them to glob_item(). Restore the old behavior and shortcut straight to write_one_file().

util: define union dirent_storage and make use of it everywhere Make sure to allocate enough space for readdir_r(). https://bugzilla.redhat.com/show_bug.cgi?id=858754

tmpfiles: use write(2) for the 'w' action This resolves problems with filesystems which do not implement the aio_write file operation. In this case, the kernel will fall back using a loop writing technique for each pointer in a received iovec. The result is strange errors in dmesg such as: [ 31.855871] elevator: type not found [ 31.856262] elevator: switch to [ 31.856262] failed It does not make sense to implement a synchronous aio_write method for sysfs as this isn't a real filesystem where a reasonable use case for using writev exists, nor is there an expectation that tmpfiles will be used to write more data than can be reasonably written in a single write syscall. In addition, some sysfs attrs are currently buggy and will NOT reject the second write with the newline, causing the sysfs value to be zeroed out. This of course should be fixed in the kernel regardless of any wrongdoing in userspace, but this simple change makes us immune to such a bug. This change means that we do not write a trailing newline by default, as the expected use case of 'w' is for sysfs and procfs. In exchange, honor C-style backslash escapes so that if the newline is really needed, the user can add it.

tmpfiles: plug file descriptor leak. Introduced in d4e9eb91.

tmpfiles: support globbing for w option Break out the write logic into a separate function and simply use it as a callback to glob_item. This allows users to consolidate writes to sysfs with multiple similar pathnames, e.g. w /sys/class/block/sd[a-z]/queue/read_ahead_kb - - - - 1024

tmpfiles: don't attempt creation of device nodes when we run in a container

log.h: new log_oom() -> int -ENOMEM, use it also a number of minor fixups and bug fixes: spelling, oom errors that didn't print errors, not properly forwarding error codes, few more consistency issues, et cetera

use "Out of memory." consistantly (or with "\n") glibc/glib both use "out of memory" consistantly so maybe we should consider that instead of this. Eliminates one string out of a number of binaries. Also fixes extra newline in udev/scsi_id

tmpfiles: also look in /lib/tmpfiles.d on split /usr systems https://bugs.freedesktop.org/show_bug.cgi?id=38686 I don't think the usecase case in that bug makes much sense, but all the other tools do honour /lib in the search path so we probably should do that here, too.

unit: introduce %s specifier for the user shell

util: rename join() to strjoin() This is to match strappend() and the other string related functions.

util: rm_rf() refuse cleaning non-memory file systems, as extra paranoia

mount-setup: don't complain if we try to fix the label of a dir beneath a mount but can't due to EROFS

update TODO

tmpfiles: exclude the first level directories in /run/user from automatic clean up It's logind's job to maintain those user dirs, so avoid automatic clean up for them. However, we do cover everything within them.

tmpfiles: create char devices with correct SELinux context https://bugzilla.redhat.com/show_bug.cgi?id=824059

tmpfiles: fix error message

tmpfiles: print error if basename lookup fails; document it in manpage

tmpfiles: allow to specify basename only: systemd-tmpfiles <program.conf> Allow passing of basename only, instead of the absolute path; letting systemd-tmpfiles perform a path lookup for the proper fragment path in the config directories. This allows distributions to call: systemd-tmpfiles <program.conf> on upgrade of a package, with respecting the possibly overriden (or even masked) tmpfile.

mkdir: append _label to all mkdir() calls that explicitly set the selinux context

tmpfiles: if we are supposed to write a string to a file, it's OK if we can't write the trailing newline

util: split-out path-util.[ch]

util: split-out conf-file.[ch]

tmpfiles: fix error message

selinux: unify systemd and udev code

move all tools to subdirs