Choose "-D" instead of "-d" for the rotatelogs option that creates the path to the log file. I want to use "-d" for another directory related option next where (I think) the "directory" "d" makes more sense. "-d" has not yet been backported, so changing to "-D" is not a real compatibility issue.

Small changes to rotatelogs: - add "-n num" to help text - clarify in help text, that "program is invoked" is the "-p" case - prevent crash with "-v" (verbose) if no "-p prog" is used - add one space for formatting

* support/rotatelogs.c (main): Prevent creation of zombies from post-rotate programs.

more apr_file_write_full() simplification (like r1542413)

* support/rotatelogs.c: Introduce an adjusted_time_t type to store the weird "adjusted time since epoch" type returned by get_now(). Switch from int to long to fix an unnecessary Y2K38 issue. Adjust use throughout and clean up other type issues. No functional change intended apart from fixing Y2K38.

rotatelogs: Remove last constant length error buffer. * support/rotatelogs.c (ERRMSGSZ): Remove. (rotate_status): Remove errbuff member. (truncate_and_write_error): Accept the error message as an argument. (doRotate): Shift the pool destruction slightly later and use it to generate the error message to pass truncate_and_write_error(). (main): In case of write errors create a pool to generate the error message, since the other pools available may never been freed. Adjust to pass message directly to truncate_and_write_error().

rotatelogs: Remove another use of a consant length buffer for errors. * support/rotatelogs.c (doRotate): Use apr_psprintf() and %pm. Move the destruction of the pool after we're done with the error message so the error string stays allocated long enough.

rotatelogs: Use apr_psprintf() with %pm instead of a constant length buffer for errors. * support/rotatelogs.c (post_rotate, doRotate): Switch to using apr_psprintf() with %pm. Suggested by: rpluem

Add an option to autocreate directories to rotatelogs. * support/rotatelogs.c (rotate_config): Remove const from szLogRoot since we'll be passing it to apr_filepath_merge. Add create_path member. (usage, dumpConfig): Update to reflect new -d option. (doRotate): Add code that knows how to create the directories a log file is going to go into. (main): Add the -d option and canonicalize the incoming path with apr_filepath_merge() so that the code in doRotate can work properly. * docs/man/rotatelogs.8, docs/manual/programs/rotatelogs.html.en: Update for -d option. PR: 46669 Submitted by: Philippe Lantin <plantin cobaltgroup.com> (which was actually a patch written by myself when I worked there) Tweaked by: breser (ported to trunk and changed option from -p to -d)

* support/rotatelogs.c (get_now): Fix the NULL ptr dereferences added in r1532281.

* support/rotatelogs.c (get_now): Return the offset applied to the Unix time as a parameter. (doRotate): When exploding the time for strtfime formatting, iff in -l mode, subtract the offset and explode the real Unix time as a local time so %Z etc works correctly.

don't truncate the very first file opened (unless the truncate flag is there too)

rotatelogs: add -n number-of-files option to roate through a number of fixed-name logfiles.

Use apr_snprintf(... "%pm"...) instead of explicit call to apr_strerror

error[120] is already defined in this function. Just use it instead of shadowing.

* support/rotatelogs.c: Cleanups, no functional change. Drop revision history, "svn log" works; use APR_PATH_MAX; constify more.

* support/rotatelogs.c (post_rotate): Really omit the second arg when invoking a post-rotate program, rather than passing an empty arg. (Fixes to code match desired&documented behaviour.)

* support/rotatelogs.c (truncate_and_write_error): Factor out from doRotate, main; make error handling consistant and print the actual error to stderr. (doRotate, main): Use it. PR: 45084

Replace use of apr_file_write() with apr_file_write_full() to prevent incomplete writes. Add comments in some places where error handling/logging is missing. PR: 53131. Submitted by: Nicolas Viennot <apache viennot biz>, Stefan Fritsch

* support/rotatelogs.c (usage, main): Add support for -c option. Submitted by: Jan Kaluža <jkaluza redhat.com>

Cleanup effort in prep for GA push: Trim trailing whitespace... no func change

* support/rotatelogs.c (main): Exit with success on EOF.

Simplify state handling in rotatelogs, fixing -L support in the case where open() fails for a new log file. * support/rotatelogs.c (struct logfile): New structure. (struct rotate_status): Store only current logfile state here, using struct logfile. (close_logfile): Rename from closeFile; assume a valid logfile structure is passed in; simplify to use stored filename. (checkRotate, main): Adjust for new structure. (post_rotate): Adjust, move linkfile handling here. (doRotate): Simplify.

Tweak rotatelogs -p such that the program is invoked the first time a new log file is opened as well as for rotations: * support/rotatelogs.c (usage): Update. (post_rotate): Omit third arg if no prev logfile known. (doRotate): Invoke even if no previous logfile was open.

rotatelogs: Add support for running a custom program after a log rotation. * support/rotatelogs.c (post_rotate): New function. (usage, dumpConfig): Update. (doRotate): Save old filename before rotate; call post_rotate after successful rotation. (main): Add -p argument. * docs/manual/programs/rotatelogs.xml: Document -p. PR: 51285 Submitted by: <sveniu ifi.uio.no>, jorton

rotatelogs: Add -e option to write logs through to stdout for optional further processing.

With rotatelogs -v, on platforms where APR_FINFO_NAME is not implemented, the verbose printf for closing the file never occurred because apr_file_info_get() always returned APR_INCOMPLETE. Fix that so we still get a printf with the information we get back.

Renamed optarg -> opt_arg to avoid name clashes with system-own optarg; removed leftover from IDE build times.

Use portable apr_snprintf in rotatelogs.

Add -L option to create a hard link to the current log file. PR: 48761 Submitted by: <lindon orthanc.ca> With additional changes by: poirier

support/rotatelogs: Support the simplest log rotation case, log truncation. Useful when the log is being processed in real time using a command like tail.

Bring back OS/2 support. Reverses r758929 with a little bit of conflict resolution.

remove OS/2 platform support

Mostly revert r733493: signal based rotation for rotatelogs. Prefer adding reliable piped logs to the error loggers in httpd, so that one could simply kill rotatelogs and httpd automatically starts new instances of all loggers.

Adopt latest changes in usage message.

Allow size units B, K, M, G and combination of time and size based rotation for rotatelogs.

rotatelogs: Add flag for verbose (debug) output.

More rotatelogs changes: - checkRotate() notes the reason for rotation - rename a few variables - rename some macros and introduce a few more

Minor rotatelogs changes: - remove 'now' from status struct. We only need it locally. - add 'static' to function declaration, although the code is still in a single file - change signature of get_now() - make argument count check easier to understand

Use APR_WANT_STRFUNC and apr_want.h instead of APR_HAVE_* and system header inclusion.

Allow to trigger rotatelogs log file rotation from using HUP and INT signals to the rotatelogs process. This is helpful, when log activity is low, but you want rotatelogs to close the open log files. SIGHUP triggers checking the rules given during startup, SIGINT forces rotate independently form those rules. When the signal triggers a rotation, the open file is closed immediately. The new file is opened when new log data arrives, or in case "-f" was given it is opened immediately. Based on my patch in BZ 44427. Note on Windows: The new functionality is undefined when SIGHUP or SIGINT are not available. Does the use case make sense on Windows? If so, which signals should we use?

Addition to r733479 and r733479: Mainly cleanup plus correct decision in checkRotate() if status->nLogFD is NULL.

Addition to r744476: - Fix compilation error - set correct time when forcing log file open on startup

Refactor rotatelogs to allow easier implementation of signal triggered log rotation. - move code into new functions checkRotate() and doRotate() - bundle config data and runtime data in two structs to allow easier passing to functions - Simplify bypass_io logic as a first use case for doRotate and rename flag to force_open to reflect the new logic

rotatelogs: Log the current file size and error code/description when failing to write to the log file. Sometimes users have a hard time believing that their little log file was really big enough to reach quota/filesystem/other limit back at the time of the error.

Add in new option for rotatelogs: -f This forces rotatelogs to create the logfile as soon as started not as soon as it sees it's first line of input.

* Don't leak memory when reopening the logfile. PR: 40183 Submitted by: rpluem, Takashi Sato <serai lans-tv.com> Reviewed by: rpluem

- when using "-l" reduce two consecutive calls to apr_time_now() to one. This will not change the logic if no "-l" gets used, and it will spare one call to apr_time_now() in case "-l" gets used and more important it gives the code better atomicity, because in fact between the two calls there is a slight change of jumping oder the DST boundary - for historic reasons the same code block is used two times with a slightly different way of transforming apr_time_t to int (once division by APR_USEC_PER_SEC, once call to apr_time_sec()), so let's unify it. - finally move the block into a function, because it gets used already two times. PR: 44004 Submitted by: Rainer Jung <rainer.jung kippdata.de> Reviewed by: rpluem

Allow local timestamps to be used when rotating based on file size. IOW, accept and respect either -l or UTC offset when rotating based on file size.

improve command-line parsing example invocations now flagged as invalid: specifying UTC offset with size-based rotation specifying -l with size-based rotation specifying both -l and UTC offset range checking of integer parameters not attempted; basic data type issues may need to be addressed first such as the use of unsigned int for max file size

increase size of error string buffer passed to apr_strerror(); 120 is the size most frequently used in Apache; APR provides no hints

* support/rotatelogs.c (main): Produce useful error message for open() failures. PR: 39487

update license header text

Update the copyright year in all .c, .h and .xml files

No functional Change: Removing trailing whitespace. This also means that "blank" lines consisting of just spaces or tabs are now really blank lines

Update copyright year to 2005 and standardize on current copyright owner line.

make the check for GMT offset occur each time through the loop, in case a switch between standard and daylight savings time occurred. (correction to previous code courtesy of Uli Zappe.) PR: 24417 Submitted by: Uli Zappe <uli ritual.org>

oops; left over from an earlier version

add "-l" option to indicate interval is based on localtime not gmt

fix name of The Apache Software Foundation

fix copyright dates according the first cehck in

apply Apache License, Version 2.0

update license to 2004.

finished that boring job: update license to 2003. Happy New Year! ;-))

Axe some warnings in rotatelogs which came when the program was converted to use APR. The behaviors of apr_file_read() and apr_file_write() weren't taken completely into account. But note: In a couple of places the check "nRead < 0" was removed. While that is meaningless with APR and hasn't done anything useful in a long time, in Apache 1.3 days it was essentially a check for read-failed-with-EINTR. Apparently a rotation would occur if the read was interrupted by a signal. That function has been lost with the APR-ization. PR: 12617

Cleanup some type mismatch emits and consistify to our new apr time helpers

Just quiet an annoying warning.

Added log rotation based on file size to the RotateLog support utility.

Oops, found another typo

Fixing a typo

Correct const'ness of argv in all support apps, and use the new apr_app_initialize over apr_initialize for win32, and other platforms that may wish to tweak 'apr-ized' application support (e.g. Netware?)

Update callers of apr_explode_gmt to apr_time_exp_gmt. The function was renamed in apr. Submitted by: Thom May <thom@planetarytramp.net>

Update our copyright for this year.

apr-utils rename apr_ansi_time_to_apr_time and apr_exploded_time_t. PR: Obtained from: Submitted by: Thom May <thom@planetarytramp.net> Reviewed by: Ian Holsman

Too many args is a bad thing too, some days

Rewrite of rotatelogs as an apr-ized app. Mladen Turk <mturk@mappingsoft.com>, William Rowe

include string.h for the strstr() prototype

Enhance customisability of rotatelogs: strftime(3) formatting of filename and offset from UTC. Reviewed by: Greg Stein, David Reid, OtherBill

Update copyright to 2001

All the supports now build on APR (+APRUTIL), no reliance on httpd.

*) Accomodate an out-of-space condition in the piped logs and the rotatelogs.c code, and no longer churn log processes for this condition. [Victor J. Orlikowski]

Just style nits before someone goes and does something significant. Submitted by: Victor J. Orlikowski [v.j.orlikowski@gte.net] Reviewed by: William Rowe

Protect system header files with the appropriate macros.

Clean up a big chunk of ap_config.h. This basically stops ap_config.h from including any files. Because of this change, other files must include their own headers. I also cleaned up a couple of other bugs in some modules because I had to compile them all. I expect this to break multiple platforms, but this will be fixed over time. The massive configure cleanup is almost done. I will go through the files one more time after this commit.

Why should Ryan have all the fun? Cleans up compiler warning emits.

Make reliable piped logs work on 2.0.

Fix some compile breaks in the support directory. These have not been tested, but they do compile at least.

Update to Apache Software License version 1.1

Fix FreeBSD build break caused by my last commit to the file. Doh!

Add rotatelogs to the Windows port

Apache 1.3.9 baseline for the Apache 2.0 repository. Obtained from: Apache 1.3.9 (minus unused files), tag APACHE_1_3_9 Submitted by: Apache Group