632b9457425d6f867ef5ac5959f58fc8f2c5c8e7 1429582 |
|
06-Jan-2013 |
jailletc36 |
According to my testing, one special case of 'log_xlate_error', i.e. EES_INCOMPLETE_CHAR,
is 13x (!!!) faster with the use 'ap_bin2hex' instead of apr_snprintf(..., "%02X" + srlen for each character.
Output is *not* exactly the same. It was uppercase, now it is lowercase.
It is just for logging, so I don't think it is an issue.
Should it be, a call to ap_strtoupper can be added.
So sad it is just for logging in case of error... no real speedup to be expected in real life . |