minor commentary and indentation fixes for ap_log_*data()

We really need some place where we can place a whole bunch of data/info-that-should-be-logged-by-all-mpms.

fix Doxygen warnings/comments

Add ap_log_data(), ap_log_rdata(), etc. for logging buffers.

Move *_DECLARE_* macros to beginning of line in headers. Patch submitted by: normw gknw net.

The Pidfile directive and ap_log_pid()/ap_remove_pid()/ap_read_pid() now respect DefaultRuntimeDir

For a local variable in a macro, use a name that is less likely to clash with other variable names.

Add AP_HAVE_C99 to make correct check for C99 less onerous Using __STDC_VERSION__ without checking if it is defined causes warnings on C89.

Add APLOGNO() macro for unique tags for every log message. Add some scripts to make adding these tags easier.

Pass ap_errorlog_info to error_log hook.

add conn_rec to error log hook

More cleanup: Expand tabs and some more indentation fixes No functional change

Cleanup effort in prep for GA push: Trim trailing whitespace... no func change

Fix build failure without HAVE_SYSLOG, e.g. on Netware

Expand the comment about APLOG_* and C++ a bit

consolidate logic to remove the pidfile in a new API, ap_remove_pid(), related to existing ap_log_pid() and ap_read_pid() presumably this is useful to third-party MPMs as well

aplog_module_index must always be set for C++, so simplify the APLOG_MODULE_INDEX macro to avoid warnings with some C++ compilers

Correct C++ incompatibility with http_log.h.

doxygen improvements

Fix constness in log macro. Prevent compiler warning.

Add generate_log_id hook to allow to use the ID generated by mod_unique_id as error log ID for requests.

- add more comments explaining the logging macros - make the documentation more doxygen friendly, as suggested by Justin Erenkrantz

- Introduce ap_log_cserror to allow mod_ssl to associate log messages to different servers than c->base_server. - Adjust the scope of some mod_ssl trace logging from server to conn.

Use the correct loglevel checks in the wrappers for ap_log_cerror/ap_log_rerror. This fixes per-dir loglevel configuration for loglevels > notice.

Fix ap_log_perror macro in case of C99 compilation with APLOG_MAX_LOGLEVEL defined.

Fix build failure by reverting part of r953125

Fix some issues found by Ruediger Pluem

- Add loglevels to request_rec and conn_rec - Introduce per-directory loglevel configuration

- Introduce log levels trace1/.../trace8 - Add macro wrappers for ap_log_*error. On C99, this will save argument preparation and function call overhead when a message is not logged because of the configured loglevel. - Introduce per-module loglevel configuration.

Log command line on startup, so there's a record of command line arguments like -f. Suggested by Shaya Potter. [Dan Poirier] PR: 48752

Fix a lot of doxygen warnings. Thanks to Brad Hards for the patch. I added a few more fixes, and there are still more that might need a doxygen expert. PR: 48061 Submitted by: Brad Hards Reviewed by: poirier

Fix docs and bump mmn minor

Revert the default resource abuse introduced in r104019, which can mask child logger process failures, by migrating back to 2.0.49 and prior when rotated logs were reliable on Solaris, etc. Provides two new piped syntaxes for ErrorLog; "||program" or "|$shellcmd", where the existing 2.2 behavior may be preserved or the new 2.4 behavior explicitly elected. The default should discourage users from "|$" syntax except as required, in the future.

Make the piped_log structure opaque: * include/http_log.h: Remove piped_log structure definition here; (ap_piped_log_read_fd, ap_piped_log_write_fd): Turn macros into functions. * server/log.c: Move piped_log structure definition here; replace fds[2] with read_fd, write_fd. (ap_piped_log_read_fd, ap_piped_log_write_fd): New functions. (throughout...): Replace use of ap_piped_log_write_fd, ap_piped_log_read_fd, with direct reference to structure fields.

Remove CORE_PRIVATE. This define serves no modern purpose, since every module in the wild, including our own define it, for no purpose. If you have functions which you do not want in the 'public' API, put them in a private header, that is not installed, just like mod_ssl does.

update license header text

Update the copyright year in all .c, .h and .xml files

Doxygen fixup / cleanup submited by: Neale Ranns neale ranns.org reviewed by: Ian Holsman

The new function ap_logs_child_init() is intended for use only by the core server. Require CORE_PRIVATE to obtain the prototype.

Prevent hangs of child processes when writing to piped loggers at the time of graceful restart. PR: 26467 Reviewed by: Joe Orton

Update copyright year to 2005 and standardize on current copyright owner line.

fix prototypes in documentation to match actual const-ness

add ap_log_cerror(); use it in a couple of places in core output filter so that the client IP address is recorded in the log

fix name of The Apache Software Foundation

fix copyright dates according to the first check in

apply Apache License, Version 2.0

update license to 2004.

finished that boring job: update license to 2003. Happy New Year! ;-))

Modify ap_open_logs (an internal function) to follow the hook open_logs argument schema so it can be directly invoked by the hook handler. Also clean up the open_logs processing to return an error rather than simply exit()ing.

Fix the PATH exposure security problem I thought I fixed in 2.0.36.

Fix code comments Submitted by: Stas Bekman <stas@stason.org>

Update comments for Stas Bekman

add ap_log_pid() for reading an Apache pid file Submitted by: Justin Erenkrantz

ignore APLOG_NOERRNO; note that it is deprecated

Added the APLOG_TOCLIENT flag to ap_log_rerror() to explicitly tell the server that warning messages should be sent to the client in addition to being recorded in the error log. Prior to this change, ap_log_rerror() always sent warning messages to the client. In one case, a faulty CGI script caused the server to send a warning message to the client that contained the full path to the CGI script. This could be considered a minor security exposure.

Introduced -E startup_logfile_name option to httpd to allow admins to begin logging errors immediately. This provides Win32 users an alternative to sending startup errors to the event viewer, and allows other daemon tool authors an alternative to logging to stderr.

Update our copyright for this year.

Allow the user to get detailed debugging information without a full recompile [absolutely necessary on Win32 and other platforms that really don't support administrator-compilation.] -e level follows the LogLevel options. The only question, should -e override the compiled-in default for the creation of the server_rec? No strong feeling either way, here.

httpd.exp and lots of other export files are generated based on the AP[RU]_DECLARE macros. This commit gets mod_cgid working again as a DSO on AIX. However, this brings up the need to look for any functions that are available as part of the API, and AP[RU]_DECLAREing them, so things don't blow up in DSOs.

This patch removes spaces that shouldn't be there. It bit me when I tried to get the new make_exports to work. I now fixed my make_exports (will commit patch later), so that will eat this anyway, but it seems nicer to make this obey the coding style rules as well. Submitted by: Sander Striker

Add a new request phase, for allowing management modules to forward error logs to their management agents.

another nit caught by C::Scan: change request_rec param name from 's' to 'r' in ap_log_rerror()

Small docco fixes.

Tweak some declarations so they're picked up by make_export.awk

Update copyright to 2001

fix minor prototype inconsistencies noticed with C::Scan

Some missing exports

Set up stderr logging explictly early in initialization so that a pool is available for creating the APR representation of stderr.

Namespace protect the rest of the macros defined by ap_config.h

Renamed all MODULE_EXPORT symbols to AP_MODULE_DECLARE and all symbols for CORE_EXPORT to AP_CORE_DECLARE (namespace protecting the wrapper) and retitled API_EXPORT as AP_DECLARE and APR_EXPORT as APR_DECLARE. All _VAR_ flavors changes to _DATA to be absolutely clear. Thank you Greg, for the most obvious suggestion.

Remove some old APIs. These were left around for legacy modules. Since we have broken all modules anyway, this is a good time to cleanup a bit.

prefix libapr functions and types with apr_

Make http_log use ScanDoc

Add support for pool to log_error_core. Also add ap_log_perror to allow logging without either a request or server _rec.

Change ap_context_t to ap_pool_t. This compiles, runs, and serves pages on Linux, but probably breaks somewhere.

if HAVE_SYSLOG is defined but LOG_PRIMASK isn't, define LOG_PRIMASK to the standard value

Update to Apache Software License version 1.1

Fix all the License issues. Including: s/Apache Group/Apache Software Foundation/ s/1999/2000/ s/Sascha's license/ASF license

Finish the commits for the change in the header files. Basically, this hides all of the Apache macros that modules don't need access to. This should have been committed with the modules, but I wasn't paying attention to the directory I was in when I ran the commit. Submitted by: Manoj Kasichainula and Ryan Bloom

Eliminate ap_config.h's checks when using autoconf. Now, ap_ac_config.h is used instead, and autoconf's configure script will check for everything else.

Some compile fixes for the piped log code. It doesn't completely completely compile, but it looks a little better.

Add apr_thread_proc.h so it can find ap_proc_t.

First step in removing the fprintf(stderr problem from Apache. Basically, I defined APLOG_STARTUP, which refrains from printing the date string and the log level information in log_error_core. I then changed all the fprintf(stderr calls to ap_log_error, and used APLOG_STARTUP. log_error_core on Unix takes care of creating a log file and directing it to stderr if a log file isn't already active. I will continue to make these changes tomorrow. Currently, the main code and the dexter mpm have been modified.

Add a status value to ap_log_error and ap_log_rerror. This allows us to use apr_status codes in our error logs. The main advantage of this, is portable error codes. Now, Windows will finally be able to use errno!

Make Apache use the new ap_create_process call. This is the first of a group of patches. This patch, allows the core server to compile and serve pages. There is a set of patches which will follow to allow the standard modules to use ap_create_process. This change should make writing code which spawns new processes easy to read and understand. Submitted by: Paul Reder

Remove all of the calls to functions like "ap_popenf". These functions were moved down to APR, but they are being removed. They are not portable, and were only moved down for backwards compatability. With this change, they can be safely removed, which is the next commit on it's way. Submitted by: Ryan Bloom and Paul Reder

Changed pools to contexts. Tested with prefork and pthread mpm's. I'll check this out tomorrow and make sure everything was checked in correctly.

Odd comments and leftover bits from the pthreads version. The comments really should be deleted, or at least cleaned up. Submitted by: pthreads leftovers

Apache 1.3.9 baseline for the Apache 2.0 repository. Obtained from: Apache 1.3.9 (minus unused files), tag APACHE_1_3_9 Submitted by: Apache Group