lib: array_idx_modifiable changed not to allocate space.

lib: array_idx_get_space is defined as alias to array_idx_modifiable

global: Fix spelling mistakes in comments Original work by @andreasschulze and @jsoref

lib: array - new copy-making array iterator Previously macros took a pointer, and that pointer was made to pointed to each element of the array in turn. Typical use cases for things like char* or struct* arrays were to immediately/repeatedly, dereference that pointer. This new iter (only one implementation done so far, more a proof of concept) gets rid of the user-visable pointer, and performs the dereference every time, and only when, a valid element is being iterated over. Empty array => no assignment. No U.B. NOTE: This cannot be done without assuming C99. It breaks the build on compilers that old if any components that are enabled use the macro. It strongly suggests we just need to make C99 mandatory. Signed-off-by: Phil Carmody <phil@dovecot.fi>

lib: array - permit array_swap with uninitialised arrays Before initialisation, all fields are blank, so the element_size field is not the actual size, and the i_assert would fire. Signed-off-by: Phil Carmody <phil@dovecot.fi>

lib: array - two helpers to avoid wasteful array_count There's no need to dereference array->element_size and perform a division when all you care about is the boolean isempty/nonempty predicate: $ git grep 'array_count(.*) > 0' | wc -l 77 $ git grep 'array_count(.*) == 0' | wc -l 95 Changing 6 of them has the following impact on the code: $ size src/lib-imap-client/imapc-connection.o text data bss dec hex filename 20879 0 4 20883 5193 src/lib-imap-client/imapc-connection.o $ size src/lib-imap-client/imapc-connection.o text data bss dec hex filename 20796 0 4 20800 5140 src/lib-imap-client/imapc-connection.o Signed-off-by: Phil Carmody <phil@dovecot.fi>

lib: array - helper to swap array buffer ownership Currently there's no simple way to create a replacement for an array, and then atomically switch in that replacement. With this helper, you can just exchange ownership of the two lists and then free the new list (which now contains the old buffer). Signed-off-by: Phil Carmody <phil@dovecot.fi>

lib: array - explain implications of ARRAY_TYPE() in comment If you use ARRAY_TYPE() to pass an array around, then you must also use ARRAY_TYPE() to define the array itself, ARRAY() will no longer do. Reported-by: Arnt Gulbrandsen <arnt@gulbrandsen.priv.no> Signed-off-by: Phil Carmody <phil@dovecot.fi>

lib: array - new linear search helper There are large numbers of array_foreach loops which do nothing but search for the first element which matches some key. This can be abstracted out into a helper. Signed-off-by: Phil Carmody <phil@dovecot.fi>

lib: array - array_foreach_idx is just a generic ptr_to_idx helper Signed-off-by: Phil Carmody <phil@dovecot.fi>

lib: test-array - remove possibility to optimise out tests (void) on a call to a "pure" function was causing some compilers (gcc 4.8) to not reach the assert within the pure function. Technically it's not a pure function, as (in the assert fail case) it has effects other than its return value. However, simply removing the void cast (and then actually using the return value) also prevents this optimisation. An additional fatal test was added - there's a difference between an access outside the allocated range and outside the initialised range. Signed-off-by: Phil Carmody <phil@dovecot.fi>

lib: array - additional compile-time checks to array_append The new two-array helper macro works in this context too. Note: array_copy doesn't have any protection currently, it isn't obvious how to wrap that with some safety without breaking interfaces. It only seems to have one internal user, lib/aqueue. Signed-off-by: Phil Carmody <phil@dovecot.fi>

lib: array - element-wise comparison via callback 2 are provided - with and without a context pointer. Signed-off-by: Phil Carmody <phil@dovecot.fi>

lib: array/hash - enable typof checks for more compilers We have a HAVE_TYPEOF macro from autoconf, we may as well make use of it. Signed-off-by: Phil Carmody <phil@dovecot.fi>

lib: array/hash - protect macro parameters If a pointer parameter p is ``ptr + offset'', then sizeof(*p) becomes sizeof(*ptr + offset), which isn't what was wanted. sizeof(*(p)) is the safe expression to use instead. Ditto for just ``*data'' in array.h. The macros in hash.h which have been changed have been reindented for better readability and consistency. The bracketting of elem in (elem)++ in both of the array_foreach* macros isn't actually useful, as elem participates in token-pasting elsewhere. However, the two macros have been made more similar to each other for better parallelism. Signed-off-by: Phil Carmody <phil@dovecot.fi>

Removed CONTEXT_TYPE_SAFETY macro and reimplemented its functionality better. gcc/clang now gives a compiler error in many places if callback isn't exactly what was expected. It's also now much easier to add more of these checks.

Array API changed: ARRAY_DEFINE(name, type) -> ARRAY(type) name Easy way to update your existing code: perl -i -pe 's:ARRAY_DEFINE\(([^,]+), *([^)]+)\);:ARRAY($2) $1;:' **/*.[ch]

Added array_append_zero() to write a zero-filled record to an array. Replaced (void)array_append_space() calls with it.

Code cleanup: Use array_count_i() to calculate array's size internally.

Added array_foreach_idx() --HG-- branch : HEAD

array_bsearch(): Cast return value to proper type. --HG-- branch : HEAD

array_foreach_modifiable() was broken in non-C99 compilers. Patch by Apple. --HG-- branch : HEAD

array.h: Compile fix for non-C99 compilers. --HG-- branch : HEAD

Added array_foreach() and array_foreach_modifiable(). --HG-- branch : HEAD

Added type safe array_bsearch(). --HG-- branch : HEAD

Added array_sort() for type-safe array sorting. --HG-- branch : HEAD

Added array_get_pool(). Patch by Stephan Bosch. --HG-- branch : HEAD

array_copy() was broken if source array was different from destination array. --HG-- branch : HEAD

Added more consts, ATTR_CONSTs and ATTR_PUREs. --HG-- branch : HEAD

Added array_reverse(). --HG-- branch : HEAD

Uninlined some of the more complex array functions. --HG-- branch : HEAD

Added queue implementation. --HG-- branch : HEAD

Renamed _array_*() to array_*_i() --HG-- branch : HEAD

Changed buffer_free() and buffer_free_without_data() APIs to take ** pointer which is set to NULL instead of hiding it with a macro. --HG-- branch : HEAD

Changed .h ifdef/defines to use <NAME>_H format. --HG-- branch : HEAD

Use COMPILE_ERROR_IF_TYPES_NOT_COMPATIBLE() for validating the data type. --HG-- branch : HEAD

Removed disable-asserts-specific array_idx(). It didn't work if array's element_size was different than sizeof(element type). --HG-- branch : HEAD

Removed extra ';' --HG-- branch : HEAD

Don't allow giving NULL parameter to array_get() or array_get_modifiable(). --HG-- branch : HEAD

Some more array changes. v and v_modifiable are now pointer-to-pointers so that they can actually be used to access the array's contents directly. Only array_idx() uses this currently though, and only if asserts are disabled. --HG-- branch : HEAD

Replaced ARRAY_CREATE() macro with [ipt]_array_init() macros. The macro has no side effects so it might as well be lowercased. --HG-- branch : HEAD

Removed type parameter from ARRAY_CREATE since it's not needed anymore. --HG-- branch : HEAD

Added array_idx_clear(). --HG-- branch : HEAD

Array API redesigned to work using unions. It now provides type safety without having to enable DEBUG, as long as the compiler supports typeof(). Its API changed a bit. It now allows directly accessing the array contents, although that's not necessarily recommended. Changed existing array usage to be type safe in a bit more places. Removed array_t completely. Also did s/modifyable/modifiable/. --HG-- branch : HEAD

Added "bool" type and changed all ints that were used as booleans to bool. --HG-- branch : HEAD

Moved array declaration to array-decl.h and include it in lib.h. So array.h needs to be now included to use any array_*() functions. --HG-- branch : HEAD

Renamed array_modifyable_*() functions. I could never remember how they were named. --HG-- branch : HEAD

Still more changes to how typeof() is used. Now it finally seems to be working nicely. --HG-- branch : HEAD

ARRAY_CREATE() macro fix. Wasn't working in all situations. --HG-- branch : HEAD

Added ARRAY_DEFINE_EXTERN(). --HG-- branch : HEAD

Keywords are now stored in X-Keywords headers in mbox. Did several related API changes to get better performance. --HG-- branch : HEAD

Added ARRAY_DEFINE_PTR() which needs to be used instead of ARRAY_DEFINE() for pointers. --HG-- branch : HEAD

ARRAY_SET_TYPE() in non-DEBUG-mode was giving errors with older gccs if it was used at the beginning of a function (function can't start with ";"). --HG-- branch : HEAD

Added ARRAY_INIT for initializing array_t in structs. --HG-- branch : HEAD

#ifdefs were wrong, we need both __GNUC__ and DEBUG to do type checking. Added new ARRAY_TYPE_CHECKS macro which can also be defined manually to enable it. --HG-- branch : HEAD

Renamed ARRAY_ARG_SET_TYPE() to ARRAY_SET_TYPE() and updated comments. --HG-- branch : HEAD

Updated example code, it was using older API.. --HG-- branch : HEAD

Added dynamic array implementation. When compiling with gcc and DEBUG enabled, gcc checks type safety at compile time. --HG-- branch : HEAD