global: start relying on mailbox_header_lookup_unref(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - mailbox_header_lookup_unref(&E); - } + mailbox_header_lookup_unref(&E);

global: don't cast NULL to void * NULL is guaranteed to be a void * thanks to dd6043c05e32a8e8db1233ed711a2c74d1477a89.

Updated copyright notices to include the year 2018.

global: Use mail_set_critical() and mailbox_set_critical() if possible Replace calls to mail_storage_set_critical() with mail_set_critical() or mailbox_set_critical() in places where mailbox or mail are easily available.

lib-storage: Fix assert-crash when searching header and MIMEPART For now this is just a bit kludgy workaround. The proper fix requires larger changes, which aren't worth the effort right now. For example: doveadm fetch -u testuser uid MAILBOX inbox FROM foo MIMEPART FILENAME CONTAINS bar BODY baz Crashes with: Panic: file index-mail-headers.c: line 294 (index_mail_parse_header): assertion failed: (part != NULL)

lib-storage: convert index to use container_of

lib-storage: index: Made MIME FILENAME search criterion match case-insensitively.

lib-storage: Fix searching when search query has invalid keywords. For example "SEARCH KEYWORD ]" was returning all mails instead of nothing.

lib-storage: Fix mail.access_type for search prefetches

lib-storage: Add asserts to make sure lookup_abort is being used correctly.

Partially implemented IMAP SEARCH=X-MIMEPART capability. This capability is currently Dovecot-specific.

lib-storage: Add explicit MAIL_ERROR_LOOKUP_ABORT error The MAIL_ERROR_NOTPOSSIBLE was a bit too generic to assume to mean the same thing. It doesn't look like there are any external plugins that break because of this change.

lib-storage: Add mail.access_type

lib-storage: Fix error handling when searching mails Only expunge errors and failures caused by lookup_abort should be ignored. The rest of the mail errors mean that the search result might not be correct. We'll still run the search as fully as possible, but we just return an error at the end.

lib-storage: Search optimization - avoid parsing message_parts unnecessarily If they're not already cached, the mail is parsed twice: once to get the message_parts and again to perform the actual search. The searching can however do the message_parts parsing internally as well.

lib-storage: Fix error handling when sorting mails. All errors were treated the same as if message had been expunged. This caused potentially wrong results to be sent to the client without any indication that they're wrong.

Updated copyright notices to include the year 2017.

global: Replaced all instances of memset(p, 0, sizeof(*p)) with the new i_zero() macro. Used the following script: C_FILES=`git ls-files *.c` H_FILES=`git ls-files *.h` for F in "$C_FILES $H_FILES"; do echo "$F" perl -p -i -e 's/safe_memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero_safe(&$1)/g' $F perl -p -i -e 's/safe_memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero_safe($1)/g' $F perl -p -i -e 's/memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero(&$1)/g' $F perl -p -i -e 's/memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero($1)/g' $F done

global: Change string position/length from unsigned int to size_t Mainly to avoid truncating >4GB strings, which might potentially cause some security holes. Normally there are other limits, which prevent such excessive strings from being created in the first place. I'm sure this didn't find everything. Maybe everything could be found with compiler warnings. -Wconversion kind of does it, but it gives way too many unnecessary warnings. These were mainly found with: grep " = strlen" egrep "unsigned int.*(size|len)"

lib-storage: Renamed MAIL_SEARCH_ARG_FLAG_USE_TZ to _FLAG_UTC_TIMES

lib-storage: Reverse MAIL_SEARCH_ARG_FLAG_USE_TZ handling again. It wasn't really wrong, it was just confusing. And doveadm's tz-handling was wrong. Reverses 059e4ac419224598349704b74cb9f6b49278df46

lib-storage: Reverse MAIL_SEARCH_ARG_FLAG_USE_TZ handling. It was being used the wrong way. SEARCH SENTON/BEFORE/AFTER should have checked the times within the mail's timezone, not UTC.

lib-storage: remove mailbox-recent-flags.h from index-storage.h

Use mail_get_*stream_because() wherever possible.

global: Use only explicit int -> bool conversions These were checked with a patched clang.

global: unsigned int:1 -> bool:1 perl -i -pe 's/unsigned int ([^,:;]+):1;/bool $1:1;/' **/*.[ch]

lib-storage: fixup the broken search result with \seen or \delete remove side effects of match_always flag during search.

lib-storage: When cached mime.parts is detected to be inconsistent, log it as hex-encoded.

lib-mail: message_search_msg() passes through message_parser_deinit_from_parts()'s error string

Use mail_set_cache_corrupted_reason() wherever possible.

lib-storage: Avoid duplicate work when a search query has multiple header/body keys.

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

Remove now-unnecessary direct stdlib.h #includes.

lib-storage: Moved most of the \Recent flag handling code to mailbox-recent-flags.c There are also some API changes, because functions were renamed and the recent_* fields were moved to struct mailbox. I'm not aware of any plugins using these though, except for index_mailbox_set_recent_seq() which for now is kept as a backwards compatibility macro. No changes were made to the actual code logic.

lib-storage: Cleanup - separate search arg values that are set by mail_search_init()

lib-storage: Added "oldestonly" search arg to stop searching after the first non-match. This parameter works only for doveadm search queries. It's not fully exact currently, because if mailbox.search_next_update_seq() skips over non-matching messages we don't stop if the next message matches. So this parameter is mainly useful for optimization of commands like: doveadm expunge -u user@domain mailbox inbox savedsince 30d oldestonly Where the timestamps should be ascending all the time anyway and there's no point in continuing to search for more mails after the first timestamp is too high.

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

lib-storage: Mail prefetching was still not working right. I wonder if it ever actually worked (except for SEARCH TEXT).

lib-storage: Don't fetch wanted_fields for messages that don't match the search query. For example "doveadm fetch text subject foo" was opening all the mails, even though only a few matched the subject (that was hopefully already in cache file). The behavior still isn't perfect though. The wanted_fields should probably be split into search_wanted_fields and fetch_wanted_fields, but the current behavior is likely good enough for now.

Use i_stream_get_error() wherever possible instead of %m

lib-storage: Added X-REAL-UID search parameter.

lib-storage: SEARCH_MAILBOX* value is now also compared to to the (virtual) mailbox name. This fixes for example "doveadm fetch uid mailbox virtual/all"

lib-storage: Replaced mail_get_real_mail() with mail_get_backend_mail() that can fail. For now the mail_get_real_mail() can still be used for backwards compatibility.

Updated copyright notices to include year 2014.

lib-storage: If search finds a match to a cached header, don't open the body stream.

lib-storage: Header+body searches might not have searched the body in some cases. Only the header was requested for the search stream, which with imapc and pop3c could have caused the body not to be in the stream, although it usually was because of the "fetch body" hint.

lib-storage: Optimize SEARCH_MODSEQ query if it's higher than HIGHESTMODSEQ.

lib-storage: Avoid wasting data stack during searches.

Replaced all -1U and (unsigned int)-1 with UINT_MAX. It's somewhat clearer this way. Also clang's -fsanitize=integer gives runtime errors about -1U (but not about explicit casts, so no need to change (type)-1 casts).

Oops :) Update copyrights to 2013 without breaking all .c files.