doveadm: client: Set IO only after enabling SSL io_add_istream() needs to be used with the SSL istream, otherwise it can cause hangs.

Updated copyright notices to include the year 2018.

doveadm: Fix potential crash or reading garbage from doveadm-server The connection's input buffer may have been reallocated or otherwise moved while checking for log input.

doveadm: client - Cleanup: Simplify the input loop

doveadm: client - Cleanup: Remove unnecessary stream_errno check

doveadm: client - Cleanup: Remove unnecessary code indentation

doveadm: client - Cleanup: Handle input NULL first

doveadm: client - Cleanup: Set authenticate_sent in a more proper location

doveadm: client - Cleanup: Don't check authenticate_sent twice

doveadm: client - Read any pipelined replies after authentication reply This practically shouldn't happen.

doveadm: client - Cleanup: Read server input only once in the input handler

doveadm: client - Fail if server sends more than one VERSION reply in handshake

doveadm: client - Fix connecting to UNIX sockets that don't need authentication Trying to access doveadm UNIX socket that didn't require authentication failed with: Error: doveadm server sent invalid handshake: ...

doveadm: client - Cleanup: Rename handshaked to authenticate_sent This better describes what it does.

doveadm: Send hostname without ":port" as TLS SNI name for outgoing SSL connections.

doveadm: Ignore errors also on outgoing SSL connection ostreams Setting the errors as ignored on the plain ostream was done too late, so ssl ostream didn't inherit the error handling flag.

lib-mail: ostream-dot - Require o_stream_finish() to write the trailer Similar to ostream-zlib.

doveadm proxy: Don't crash if remote doesn't support log proxying

doveadm: Return after destroying connection Prevents NULL deferences, found by coverity.

doveadm: Add remote(host) prefix to all proxied logs

doveadm: Deliver remote logs over doveadm socket

doveadm: Refactor server/client code to support versioning properly This way we can distinguish between old and new server side

doveadm-server: Refactor connection handshake and authentication Simplifies next change

global: use i_close_fd{,_path}() instead of open-coding them

global: start relying on [io]_stream_destroy(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - i_stream_destroy(&E); - } + i_stream_destroy(&E); @@ expression E; @@ - if (E != NULL) { - o_stream_destroy(&E); - } + o_stream_destroy(&E);

global: start relying on timeout_remove(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - timeout_remove(&E); - } + timeout_remove(&E);

global: start relying on io_remove{,_closed}(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - io_remove(&E); - } + io_remove(&E); @@ expression E; @@ - if (E != NULL) { - io_remove_closed(&E); - } + io_remove_closed(&E);

doveadm: Send and receive exit codes correctly The old code would assume TEMPFAIL for almost everything.

global: Fix ssl_set usage Remove verify_remote_cert, as it's always TRUE now. Set allow_invalid_cert to TRUE if verification is not required.

Updated copyright notices to include the year 2017.

global: Replaced all instances of memset(p, 0, sizeof(*p)) with the new i_zero() macro. Used the following script: C_FILES=`git ls-files *.c` H_FILES=`git ls-files *.h` for F in "$C_FILES $H_FILES"; do echo "$F" perl -p -i -e 's/safe_memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero_safe(&$1)/g' $F perl -p -i -e 's/safe_memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero_safe($1)/g' $F perl -p -i -e 's/memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero(&$1)/g' $F perl -p -i -e 's/memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero($1)/g' $F done

doveadm: Fixed hanging when printing output from different server connections.

doveadm: Avoid recursively calling server input callback Probably doesn't fix anything, but it could cause confusing backtraces at least.

doveadm-server: Fixed potential hang when reading replies to multiple commands

doveadm: Revert earlier NUL-printing change 793b024bf. It changes the output in ways that are a bit difficult to fix. Also the the important part where NULs printing is useful is in a message body, which should work even without this change. So for now just revert it.

doveadm: When printing input from doveadm-server, don't truncate at NUL.

doveadm: Streamline tabunescape

global: Removed redundant corking in ostream flush callbacks.

lib-ssl-iostream: Changed require_valid_cert -> allow_invalid_cert We should default to being safe.

global: unsigned int:1 -> bool:1 perl -i -pe 's/unsigned int ([^,:;]+):1;/bool $1:1;/' **/*.[ch]

lib: remove autoclose parameter from [io]_stream_create_fd Use [io]_stream_create_fd_autoclose() for autoclose.

o_stream_send_istream() API changed again The new API enforces the caller to correctly handle all the possible situations. It also makes in unambiguous whether to wait for input or output stream.

global: Simplify code with the new o_stream_send_istream() API

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

Changed type of internet port values to in_port_t everywhere. Created special SET_IN_PORT setting type for internet port values. Created net_str2port() for parsing internet port values. Removed several atoi() invocations in the process.

doveadm: Added doveadm_username to specify the username for authentication. The default is still "doveadm" and the server side doesn't currently support anything except "doveadm".

doveadm-server: Fixed potential crash if doveadm client disconnected Found by Coverity

doveadm: Added support for mail commands to read an input stream (from stdin) This is done by calling doveadm_mail_get_input() from the command's init() function. Currently it reads the entire input into a seekable istream with hardcoded 5 minute timeout. The input stream sending works also through doveadm proxying. This could probably be used by dsync at some point to support proxying over doveadm proxies, but that would require some more work. Especially a flag for commands to specify that they allow non-blocking input streams.

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

Updated copyright notices to include year 2014.

doveadm: If server connection gets disconnected, log the reason.

doveadm: If we get disconnected from server, log the reason.

doveadm: Pass through the exit code from doveadm-server to client.

lib-ssl-iostream: Simplified certificate validation. Also give better error messages.

lib-ssl-iostream: Added support for TLS SNI, which caused some API changes.

lib-ssl-iostream: If handshake callback fails, close the iostreams immediately. This way the callback itself doesn't have to do it. Also fixes errors caused by it, since they didn't close the ostream.

lib-ssl-iostream: ssl_iostream_set_handshake_callback() API changed. The callback can now return the error message to caller instead of having to log it itself.

lib-ssl-iostream: API changes to return error strings if init() functions fail. This also fixed a couple of broken error handlings.

dsync: Added tcps (TCP+SSL) target.

dsync: Use iostreams instead of fd when receiving connection from doveadm-server.

dsync: Added tcp:host[:port] target for syncing via doveadm-server.

doveadm: If doveadm-server sends broken input, disconnect.

doveadm: When connecting to doveadm socket without :port, use doveadm_port setting.

Oops :) Update copyrights to 2013 without breaking all .c files.