i915/src/intel_hdmi.c

/*
 * Copyright (c) 2006, 2013, Oracle and/or its affiliates. All rights reserved.
 */

/*
 * Copyright 2006 Dave Airlie <airlied@linux.ie>
 * Copyright (c) 2006-2009, 2013, Intel Corporation
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
 * to deal in the Software without restriction, including without limitation
 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
 * and/or sell copies of the Software, and to permit persons to whom the
 * Software is furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice (including the next
 * paragraph) shall be included in all copies or substantial portions of the
 * Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
 * DEALINGS IN THE SOFTWARE.
 *
 * Authors:
 *  Eric Anholt <eric@anholt.net>
 *  Jesse Barnes <jesse.barnes@intel.com>
 */

#include "drmP.h"
#include "drm.h"
#include "drm_crtc.h"
#include "drm_edid.h"
#include "intel_drv.h"
#include "i915_drm.h"
#include "i915_drv.h"
#include "drm_sun_i2c.h"  /* OSOL_i915 */

static struct drm_device *intel_hdmi_to_dev(struct intel_hdmi *intel_hdmi)
{
    return hdmi_to_dig_port(intel_hdmi)->base.base.dev;
}

static void
assert_hdmi_port_disabled(struct intel_hdmi *intel_hdmi)
{
    struct drm_device *dev = intel_hdmi_to_dev(intel_hdmi);
    struct drm_i915_private *dev_priv = dev->dev_private;
    uint32_t enabled_bits;

    enabled_bits = HAS_DDI(dev) ? DDI_BUF_CTL_ENABLE : SDVO_ENABLE;

    if (I915_READ(intel_hdmi->hdmi_reg) & enabled_bits)
         DRM_ERROR("HDMI port enabled, expecting disabled\n");
}

struct intel_hdmi *enc_to_intel_hdmi(struct drm_encoder *encoder)
{
    struct intel_digital_port *intel_dig_port =
        container_of(encoder, struct intel_digital_port, base.base);
    return &intel_dig_port->hdmi;
}

static struct intel_hdmi *intel_attached_hdmi(struct drm_connector *connector)
{
    return enc_to_intel_hdmi(&intel_attached_encoder(connector)->base);
}

void intel_dip_infoframe_csum(struct dip_infoframe *frame)
{
    uint8_t *data = (uint8_t *)frame;
    uint8_t sum = 0;
    unsigned i;

    frame->checksum = 0;
    frame->ecc = 0;

    for (i = 0; i < frame->len + DIP_HEADER_SIZE; i++)
        sum += data[i];

    frame->checksum = 0x100 - sum;
}

static u32 g4x_infoframe_index(struct dip_infoframe *frame)
{
    switch (frame->type) {
    case DIP_TYPE_AVI:
        return VIDEO_DIP_SELECT_AVI;
    case DIP_TYPE_SPD:
        return VIDEO_DIP_SELECT_SPD;
    default:
        DRM_DEBUG_DRIVER("unknown info frame type %d\n", frame->type);
        return 0;
    }
}

static u32 g4x_infoframe_enable(struct dip_infoframe *frame)
{
    switch (frame->type) {
    case DIP_TYPE_AVI:
        return VIDEO_DIP_ENABLE_AVI;
    case DIP_TYPE_SPD:
        return VIDEO_DIP_ENABLE_SPD;
    default:
        DRM_DEBUG_DRIVER("unknown info frame type %d\n", frame->type);
        return 0;
    }
}

static u32 hsw_infoframe_enable(struct dip_infoframe *frame)
{
    switch (frame->type) {
    case DIP_TYPE_AVI:
        return VIDEO_DIP_ENABLE_AVI_HSW;
    case DIP_TYPE_SPD:
        return VIDEO_DIP_ENABLE_SPD_HSW;
    default:
        DRM_DEBUG_DRIVER("unknown info frame type %d\n", frame->type);
        return 0;
    }
}

static u32 hsw_infoframe_data_reg(struct dip_infoframe *frame,
                  enum transcoder cpu_transcoder)
{
    switch (frame->type) {
    case DIP_TYPE_AVI:
        return HSW_TVIDEO_DIP_AVI_DATA(cpu_transcoder);
    case DIP_TYPE_SPD:
        return HSW_TVIDEO_DIP_SPD_DATA(cpu_transcoder);
    default:
        DRM_DEBUG_DRIVER("unknown info frame type %d\n", frame->type);
        return 0;
    }
}

static void g4x_write_infoframe(struct drm_encoder *encoder,
                struct dip_infoframe *frame)
{
    /* LINTED */
    uint32_t *data = (uint32_t *)frame;
    struct drm_device *dev = encoder->dev;
    struct drm_i915_private *dev_priv = dev->dev_private;
    u32 val = I915_READ(VIDEO_DIP_CTL);
    unsigned i, len = DIP_HEADER_SIZE + frame->len;

    if (!(val & VIDEO_DIP_ENABLE))
        DRM_ERROR("Writing DIP with CTL reg disabled\n");

    val &= ~(VIDEO_DIP_SELECT_MASK | 0xf); /* clear DIP data offset */
    val |= g4x_infoframe_index(frame);

    val &= ~g4x_infoframe_enable(frame);

    I915_WRITE(VIDEO_DIP_CTL, val);

//  mmiowb();
    for (i = 0; i < len; i += 4) {
        I915_WRITE(VIDEO_DIP_DATA, *data);
        data++;
    }
    /* Write every possible data byte to force correct ECC calculation. */
    for (; i < VIDEO_DIP_DATA_SIZE; i += 4)
        I915_WRITE(VIDEO_DIP_DATA, 0);
//  mmiowb();

    val |= g4x_infoframe_enable(frame);
    val &= ~VIDEO_DIP_FREQ_MASK;
    val |= VIDEO_DIP_FREQ_VSYNC;

    I915_WRITE(VIDEO_DIP_CTL, val);
    POSTING_READ(VIDEO_DIP_CTL);
}

static void ibx_write_infoframe(struct drm_encoder *encoder,
                struct dip_infoframe *frame)
{
    /* LINTED */
    uint32_t *data = (uint32_t *)frame;
    struct drm_device *dev = encoder->dev;
    struct drm_i915_private *dev_priv = dev->dev_private;
    struct intel_crtc *intel_crtc = to_intel_crtc(encoder->crtc);
    int reg = TVIDEO_DIP_CTL(intel_crtc->pipe);
    unsigned i, len = DIP_HEADER_SIZE + frame->len;
    u32 val = I915_READ(reg);

    if (!(val & VIDEO_DIP_ENABLE))
        DRM_ERROR("Writing DIP with CTL reg disabled\n");

    val &= ~(VIDEO_DIP_SELECT_MASK | 0xf); /* clear DIP data offset */
    val |= g4x_infoframe_index(frame);

    val &= ~g4x_infoframe_enable(frame);

    I915_WRITE(reg, val);

//  mmiowb();
    for (i = 0; i < len; i += 4) {
        I915_WRITE(TVIDEO_DIP_DATA(intel_crtc->pipe), *data);
        data++;
    }
    /* Write every possible data byte to force correct ECC calculation. */
    for (; i < VIDEO_DIP_DATA_SIZE; i += 4)
        I915_WRITE(TVIDEO_DIP_DATA(intel_crtc->pipe), 0);
//  mmiowb();

    val |= g4x_infoframe_enable(frame);
    val &= ~VIDEO_DIP_FREQ_MASK;
    val |= VIDEO_DIP_FREQ_VSYNC;

    I915_WRITE(reg, val);
    POSTING_READ(reg);
}

static void cpt_write_infoframe(struct drm_encoder *encoder,
                struct dip_infoframe *frame)
{
    /* LINTED */
    uint32_t *data = (uint32_t *)frame;
    struct drm_device *dev = encoder->dev;
    struct drm_i915_private *dev_priv = dev->dev_private;
    struct intel_crtc *intel_crtc = to_intel_crtc(encoder->crtc);
    int reg = TVIDEO_DIP_CTL(intel_crtc->pipe);
    unsigned i, len = DIP_HEADER_SIZE + frame->len;
    u32 val = I915_READ(reg);

    if (!(val & VIDEO_DIP_ENABLE))
        DRM_ERROR("Writing DIP with CTL reg disabled\n");

    val &= ~(VIDEO_DIP_SELECT_MASK | 0xf); /* clear DIP data offset */
    val |= g4x_infoframe_index(frame);

    /* The DIP control register spec says that we need to update the AVI
     * infoframe without clearing its enable bit */
    if (frame->type != DIP_TYPE_AVI)
        val &= ~g4x_infoframe_enable(frame);

    I915_WRITE(reg, val);

//  mmiowb();
    for (i = 0; i < len; i += 4) {
        I915_WRITE(TVIDEO_DIP_DATA(intel_crtc->pipe), *data);
        data++;
    }
    /* Write every possible data byte to force correct ECC calculation. */
    for (; i < VIDEO_DIP_DATA_SIZE; i += 4)
        I915_WRITE(TVIDEO_DIP_DATA(intel_crtc->pipe), 0);
//  mmiowb();

    val |= g4x_infoframe_enable(frame);
    val &= ~VIDEO_DIP_FREQ_MASK;
    val |= VIDEO_DIP_FREQ_VSYNC;

    I915_WRITE(reg, val);
    POSTING_READ(reg);
}

static void vlv_write_infoframe(struct drm_encoder *encoder,
                     struct dip_infoframe *frame)
{
    /* LINTED */
    uint32_t *data = (uint32_t *)frame;
    struct drm_device *dev = encoder->dev;
    struct drm_i915_private *dev_priv = dev->dev_private;
    struct intel_crtc *intel_crtc = to_intel_crtc(encoder->crtc);
    int reg = VLV_TVIDEO_DIP_CTL(intel_crtc->pipe);
    unsigned i, len = DIP_HEADER_SIZE + frame->len;
    u32 val = I915_READ(reg);

    if (!(val & VIDEO_DIP_ENABLE))
        DRM_ERROR("Writing DIP with CTL reg disabled\n");

    val &= ~(VIDEO_DIP_SELECT_MASK | 0xf); /* clear DIP data offset */
    val |= g4x_infoframe_index(frame);

    val &= ~g4x_infoframe_enable(frame);

    I915_WRITE(reg, val);

//  mmiowb();
    for (i = 0; i < len; i += 4) {
        I915_WRITE(VLV_TVIDEO_DIP_DATA(intel_crtc->pipe), *data);
        data++;
    }
    /* Write every possible data byte to force correct ECC calculation. */
    for (; i < VIDEO_DIP_DATA_SIZE; i += 4)
        I915_WRITE(VLV_TVIDEO_DIP_DATA(intel_crtc->pipe), 0);
//  mmiowb();

    val |= g4x_infoframe_enable(frame);
    val &= ~VIDEO_DIP_FREQ_MASK;
    val |= VIDEO_DIP_FREQ_VSYNC;

    I915_WRITE(reg, val);
    POSTING_READ(reg);
}

static void hsw_write_infoframe(struct drm_encoder *encoder,
                struct dip_infoframe *frame)
{
    /* LINTED */
    uint32_t *data = (uint32_t *)frame;
    struct drm_device *dev = encoder->dev;
    struct drm_i915_private *dev_priv = dev->dev_private;
    struct intel_crtc *intel_crtc = to_intel_crtc(encoder->crtc);
    u32 ctl_reg = HSW_TVIDEO_DIP_CTL(intel_crtc->config.cpu_transcoder);
    u32 data_reg = hsw_infoframe_data_reg(frame, intel_crtc->config.cpu_transcoder);
    unsigned int i, len = DIP_HEADER_SIZE + frame->len;
    u32 val = I915_READ(ctl_reg);

    if (data_reg == 0)
        return;

    val &= ~hsw_infoframe_enable(frame);
    I915_WRITE(ctl_reg, val);

//  mmiowb();
    for (i = 0; i < len; i += 4) {
        I915_WRITE(data_reg + i, *data);
        data++;
    }
    /* Write every possible data byte to force correct ECC calculation. */
    for (; i < VIDEO_DIP_DATA_SIZE; i += 4)
        I915_WRITE(data_reg + i, 0);
//  mmiowb();

    val |= hsw_infoframe_enable(frame);
    I915_WRITE(ctl_reg, val);
    POSTING_READ(ctl_reg);
}

static void intel_set_infoframe(struct drm_encoder *encoder,
                struct dip_infoframe *frame)
{
    struct intel_hdmi *intel_hdmi = enc_to_intel_hdmi(encoder);

    intel_dip_infoframe_csum(frame);
    intel_hdmi->write_infoframe(encoder, frame);
}

static void intel_hdmi_set_avi_infoframe(struct drm_encoder *encoder,
                     struct drm_display_mode *adjusted_mode)
{
    struct intel_hdmi *intel_hdmi = enc_to_intel_hdmi(encoder);
    struct intel_crtc *intel_crtc = to_intel_crtc(encoder->crtc);
    struct dip_infoframe avi_if = {
        .type = DIP_TYPE_AVI,
        .ver = DIP_VERSION_AVI,
        .len = DIP_LEN_AVI,
    };

    if (adjusted_mode->flags & DRM_MODE_FLAG_DBLCLK)
        avi_if.body.avi.YQ_CN_PR |= DIP_AVI_PR_2;

    if (intel_hdmi->rgb_quant_range_selectable) {
        if (intel_crtc->config.limited_color_range)
            avi_if.body.avi.ITC_EC_Q_SC |= DIP_AVI_RGB_QUANT_RANGE_LIMITED;
        else
            avi_if.body.avi.ITC_EC_Q_SC |= DIP_AVI_RGB_QUANT_RANGE_FULL;
    }

    avi_if.body.avi.VIC = drm_match_cea_mode(adjusted_mode);

    intel_set_infoframe(encoder, &avi_if);
}

static void intel_hdmi_set_spd_infoframe(struct drm_encoder *encoder)
{
    struct dip_infoframe spd_if;

    memset(&spd_if, 0, sizeof(spd_if));
    spd_if.type = DIP_TYPE_SPD;
    spd_if.ver = DIP_VERSION_SPD;
    spd_if.len = DIP_LEN_SPD;
    strcpy((char *)spd_if.body.spd.vn, "Intel");
    strcpy((char *)spd_if.body.spd.pd, "Integrated gfx");
    spd_if.body.spd.sdi = DIP_SPD_PC;

    intel_set_infoframe(encoder, &spd_if);
}

static void g4x_set_infoframes(struct drm_encoder *encoder,
                   struct drm_display_mode *adjusted_mode)
{
    struct drm_i915_private *dev_priv = encoder->dev->dev_private;
    struct intel_digital_port *intel_dig_port = enc_to_dig_port(encoder);
    struct intel_hdmi *intel_hdmi = &intel_dig_port->hdmi;
    u32 reg = VIDEO_DIP_CTL;
    u32 val = I915_READ(reg);
    u32 port;

    assert_hdmi_port_disabled(intel_hdmi);

    /* If the registers were not initialized yet, they might be zeroes,
     * which means we're selecting the AVI DIP and we're setting its
     * frequency to once. This seems to really confuse the HW and make
     * things stop working (the register spec says the AVI always needs to
     * be sent every VSync). So here we avoid writing to the register more
     * than we need and also explicitly select the AVI DIP and explicitly
     * set its frequency to every VSync. Avoiding to write it twice seems to
     * be enough to solve the problem, but being defensive shouldn't hurt us
     * either. */
    val |= VIDEO_DIP_SELECT_AVI | VIDEO_DIP_FREQ_VSYNC;

    if (!intel_hdmi->has_hdmi_sink) {
        if (!(val & VIDEO_DIP_ENABLE))
            return;
        val &= ~VIDEO_DIP_ENABLE;
        I915_WRITE(reg, val);
        POSTING_READ(reg);
        return;
    }

    switch (intel_dig_port->port) {
    case PORT_B:
        port = VIDEO_DIP_PORT_B;
        break;
    case PORT_C:
        port = VIDEO_DIP_PORT_C;
        break;
    default:
        BUG();
        return;
    }

    if (port != (val & VIDEO_DIP_PORT_MASK)) {
        if (val & VIDEO_DIP_ENABLE) {
            val &= ~VIDEO_DIP_ENABLE;
            I915_WRITE(reg, val);
            POSTING_READ(reg);
        }
        val &= ~VIDEO_DIP_PORT_MASK;
        val |= port;
    }

    val |= VIDEO_DIP_ENABLE;
    val &= ~VIDEO_DIP_ENABLE_VENDOR;

    I915_WRITE(reg, val);
    POSTING_READ(reg);

    intel_hdmi_set_avi_infoframe(encoder, adjusted_mode);
    intel_hdmi_set_spd_infoframe(encoder);
}

static void ibx_set_infoframes(struct drm_encoder *encoder,
                   struct drm_display_mode *adjusted_mode)
{
    struct drm_i915_private *dev_priv = encoder->dev->dev_private;
    struct intel_crtc *intel_crtc = to_intel_crtc(encoder->crtc);
    struct intel_digital_port *intel_dig_port = enc_to_dig_port(encoder);
    struct intel_hdmi *intel_hdmi = &intel_dig_port->hdmi;
    u32 reg = TVIDEO_DIP_CTL(intel_crtc->pipe);
    u32 val = I915_READ(reg);
    u32 port;

    assert_hdmi_port_disabled(intel_hdmi);

    /* See the big comment in g4x_set_infoframes() */
    val |= VIDEO_DIP_SELECT_AVI | VIDEO_DIP_FREQ_VSYNC;

    if (!intel_hdmi->has_hdmi_sink) {
        if (!(val & VIDEO_DIP_ENABLE))
            return;
        val &= ~VIDEO_DIP_ENABLE;
        I915_WRITE(reg, val);
        POSTING_READ(reg);
        return;
    }

    switch (intel_dig_port->port) {
    case PORT_B:
        port = VIDEO_DIP_PORT_B;
        break;
    case PORT_C:
        port = VIDEO_DIP_PORT_C;
        break;
    case PORT_D:
        port = VIDEO_DIP_PORT_D;
        break;
    default:
        BUG();
        return;
    }

    if (port != (val & VIDEO_DIP_PORT_MASK)) {
        if (val & VIDEO_DIP_ENABLE) {
            val &= ~VIDEO_DIP_ENABLE;
            I915_WRITE(reg, val);
            POSTING_READ(reg);
        }
        val &= ~VIDEO_DIP_PORT_MASK;
        val |= port;
    }

    val |= VIDEO_DIP_ENABLE;
    val &= ~(VIDEO_DIP_ENABLE_VENDOR | VIDEO_DIP_ENABLE_GAMUT |
         VIDEO_DIP_ENABLE_GCP);

    I915_WRITE(reg, val);
    POSTING_READ(reg);

    intel_hdmi_set_avi_infoframe(encoder, adjusted_mode);
    intel_hdmi_set_spd_infoframe(encoder);
}

static void cpt_set_infoframes(struct drm_encoder *encoder,
                   struct drm_display_mode *adjusted_mode)
{
    struct drm_i915_private *dev_priv = encoder->dev->dev_private;
    struct intel_crtc *intel_crtc = to_intel_crtc(encoder->crtc);
    struct intel_hdmi *intel_hdmi = enc_to_intel_hdmi(encoder);
    u32 reg = TVIDEO_DIP_CTL(intel_crtc->pipe);
    u32 val = I915_READ(reg);

    assert_hdmi_port_disabled(intel_hdmi);

    /* See the big comment in g4x_set_infoframes() */
    val |= VIDEO_DIP_SELECT_AVI | VIDEO_DIP_FREQ_VSYNC;

    if (!intel_hdmi->has_hdmi_sink) {
        if (!(val & VIDEO_DIP_ENABLE))
            return;
        val &= ~(VIDEO_DIP_ENABLE | VIDEO_DIP_ENABLE_AVI);
        I915_WRITE(reg, val);
        POSTING_READ(reg);
        return;
    }

    /* Set both together, unset both together: see the spec. */
    val |= VIDEO_DIP_ENABLE | VIDEO_DIP_ENABLE_AVI;
    val &= ~(VIDEO_DIP_ENABLE_VENDOR | VIDEO_DIP_ENABLE_GAMUT |
         VIDEO_DIP_ENABLE_GCP);

    I915_WRITE(reg, val);
    POSTING_READ(reg);

    intel_hdmi_set_avi_infoframe(encoder, adjusted_mode);
    intel_hdmi_set_spd_infoframe(encoder);
}

static void vlv_set_infoframes(struct drm_encoder *encoder,
                   struct drm_display_mode *adjusted_mode)
{
    struct drm_i915_private *dev_priv = encoder->dev->dev_private;
    struct intel_crtc *intel_crtc = to_intel_crtc(encoder->crtc);
    struct intel_hdmi *intel_hdmi = enc_to_intel_hdmi(encoder);
    u32 reg = VLV_TVIDEO_DIP_CTL(intel_crtc->pipe);
    u32 val = I915_READ(reg);

    assert_hdmi_port_disabled(intel_hdmi);

    /* See the big comment in g4x_set_infoframes() */
    val |= VIDEO_DIP_SELECT_AVI | VIDEO_DIP_FREQ_VSYNC;

    if (!intel_hdmi->has_hdmi_sink) {
        if (!(val & VIDEO_DIP_ENABLE))
            return;
        val &= ~VIDEO_DIP_ENABLE;
        I915_WRITE(reg, val);
        POSTING_READ(reg);
        return;
    }

    val |= VIDEO_DIP_ENABLE;
    val &= ~(VIDEO_DIP_ENABLE_VENDOR | VIDEO_DIP_ENABLE_GAMUT |
         VIDEO_DIP_ENABLE_GCP);

    I915_WRITE(reg, val);
    POSTING_READ(reg);

    intel_hdmi_set_avi_infoframe(encoder, adjusted_mode);
    intel_hdmi_set_spd_infoframe(encoder);
}

static void hsw_set_infoframes(struct drm_encoder *encoder,
                   struct drm_display_mode *adjusted_mode)
{
    struct drm_i915_private *dev_priv = encoder->dev->dev_private;
    struct intel_crtc *intel_crtc = to_intel_crtc(encoder->crtc);
    struct intel_hdmi *intel_hdmi = enc_to_intel_hdmi(encoder);
    u32 reg = HSW_TVIDEO_DIP_CTL(intel_crtc->config.cpu_transcoder);
    u32 val = I915_READ(reg);

    assert_hdmi_port_disabled(intel_hdmi);

    if (!intel_hdmi->has_hdmi_sink) {
        I915_WRITE(reg, 0);
        POSTING_READ(reg);
        return;
    }

    val &= ~(VIDEO_DIP_ENABLE_VSC_HSW | VIDEO_DIP_ENABLE_GCP_HSW |
         VIDEO_DIP_ENABLE_VS_HSW | VIDEO_DIP_ENABLE_GMP_HSW);

    I915_WRITE(reg, val);
    POSTING_READ(reg);

    intel_hdmi_set_avi_infoframe(encoder, adjusted_mode);
    intel_hdmi_set_spd_infoframe(encoder);
}

static void intel_hdmi_mode_set(struct drm_encoder *encoder,
                /* LINTED */
                struct drm_display_mode *mode,
                struct drm_display_mode *adjusted_mode)
{
    struct drm_device *dev = encoder->dev;
    struct drm_i915_private *dev_priv = dev->dev_private;
    struct intel_crtc *intel_crtc = to_intel_crtc(encoder->crtc);
    struct intel_hdmi *intel_hdmi = enc_to_intel_hdmi(encoder);
    u32 hdmi_val;

    hdmi_val = SDVO_ENCODING_HDMI;
    if (!HAS_PCH_SPLIT(dev))
        hdmi_val |= intel_hdmi->color_range;
    if (adjusted_mode->flags & DRM_MODE_FLAG_PVSYNC)
        hdmi_val |= SDVO_VSYNC_ACTIVE_HIGH;
    if (adjusted_mode->flags & DRM_MODE_FLAG_PHSYNC)
        hdmi_val |= SDVO_HSYNC_ACTIVE_HIGH;

    if (intel_crtc->config.pipe_bpp > 24)
        hdmi_val |= HDMI_COLOR_FORMAT_12bpc;
    else
        hdmi_val |= SDVO_COLOR_FORMAT_8bpc;

    /* Required on CPT */
    if (intel_hdmi->has_hdmi_sink && HAS_PCH_CPT(dev))
        hdmi_val |= HDMI_MODE_SELECT_HDMI;

    if (intel_hdmi->has_audio) {
        DRM_DEBUG_DRIVER("Enabling HDMI audio on pipe %c\n",
                 pipe_name(intel_crtc->pipe));
        hdmi_val |= SDVO_AUDIO_ENABLE;
        hdmi_val |= HDMI_MODE_SELECT_HDMI;
        intel_write_eld(encoder, adjusted_mode);
    }

    if (HAS_PCH_CPT(dev))
        hdmi_val |= SDVO_PIPE_SEL_CPT(intel_crtc->pipe);
    else
        hdmi_val |= SDVO_PIPE_SEL(intel_crtc->pipe);

    I915_WRITE(intel_hdmi->hdmi_reg, hdmi_val);
    POSTING_READ(intel_hdmi->hdmi_reg);

    intel_hdmi->set_infoframes(encoder, adjusted_mode);
}

static bool intel_hdmi_get_hw_state(struct intel_encoder *encoder,
                    enum pipe *pipe)
{
    struct drm_device *dev = encoder->base.dev;
    struct drm_i915_private *dev_priv = dev->dev_private;
    struct intel_hdmi *intel_hdmi = enc_to_intel_hdmi(&encoder->base);
    u32 tmp;

    tmp = I915_READ(intel_hdmi->hdmi_reg);

    if (!(tmp & SDVO_ENABLE))
        return false;

    if (HAS_PCH_CPT(dev))
        *pipe = PORT_TO_PIPE_CPT(tmp);
    else
        *pipe = PORT_TO_PIPE(tmp);

    return true;
}

static void intel_hdmi_get_config(struct intel_encoder *encoder,
                  struct intel_crtc_config *pipe_config)
{
    struct intel_hdmi *intel_hdmi = enc_to_intel_hdmi(&encoder->base);
    struct drm_i915_private *dev_priv = encoder->base.dev->dev_private;
    u32 tmp, flags = 0;

    tmp = I915_READ(intel_hdmi->hdmi_reg);

    if (tmp & SDVO_HSYNC_ACTIVE_HIGH)
        flags |= DRM_MODE_FLAG_PHSYNC;
    else
        flags |= DRM_MODE_FLAG_NHSYNC;

    if (tmp & SDVO_VSYNC_ACTIVE_HIGH)
        flags |= DRM_MODE_FLAG_PVSYNC;
    else
        flags |= DRM_MODE_FLAG_NVSYNC;

    pipe_config->adjusted_mode.flags |= flags;
}

static void intel_enable_hdmi(struct intel_encoder *encoder)
{
    struct drm_device *dev = encoder->base.dev;
    struct drm_i915_private *dev_priv = dev->dev_private;
    struct intel_crtc *intel_crtc = to_intel_crtc(encoder->base.crtc);
    struct intel_hdmi *intel_hdmi = enc_to_intel_hdmi(&encoder->base);
    u32 temp;
    u32 enable_bits = SDVO_ENABLE;

    if (intel_hdmi->has_audio)
        enable_bits |= SDVO_AUDIO_ENABLE;

    temp = I915_READ(intel_hdmi->hdmi_reg);

    /* HW workaround for IBX, we need to move the port to transcoder A
     * before disabling it, so restore the transcoder select bit here. */
    if (HAS_PCH_IBX(dev))
        enable_bits |= SDVO_PIPE_SEL(intel_crtc->pipe);

    /* HW workaround, need to toggle enable bit off and on for 12bpc, but
     * we do this anyway which shows more stable in testing.
     */
    if (HAS_PCH_SPLIT(dev)) {
        I915_WRITE(intel_hdmi->hdmi_reg, temp & ~SDVO_ENABLE);
        POSTING_READ(intel_hdmi->hdmi_reg);
    }

    temp |= enable_bits;

    I915_WRITE(intel_hdmi->hdmi_reg, temp);
    POSTING_READ(intel_hdmi->hdmi_reg);

    /* HW workaround, need to write this twice for issue that may result
     * in first write getting masked.
     */
    if (HAS_PCH_SPLIT(dev)) {
        I915_WRITE(intel_hdmi->hdmi_reg, temp);
        POSTING_READ(intel_hdmi->hdmi_reg);
    }

    if (IS_VALLEYVIEW(dev)) {
        struct intel_digital_port *dport =
            enc_to_dig_port(&encoder->base);
        int channel = vlv_dport_to_channel(dport);

        vlv_wait_port_ready(dev_priv, channel);
    }
}

static void intel_disable_hdmi(struct intel_encoder *encoder)
{
    struct drm_device *dev = encoder->base.dev;
    struct drm_i915_private *dev_priv = dev->dev_private;
    struct intel_hdmi *intel_hdmi = enc_to_intel_hdmi(&encoder->base);
    u32 temp;
    u32 enable_bits = SDVO_ENABLE | SDVO_AUDIO_ENABLE;

    temp = I915_READ(intel_hdmi->hdmi_reg);

    /* HW workaround for IBX, we need to move the port to transcoder A
     * before disabling it. */
    if (HAS_PCH_IBX(dev)) {
        struct drm_crtc *crtc = encoder->base.crtc;
        int pipe = crtc ? to_intel_crtc(crtc)->pipe : -1;

        if (temp & SDVO_PIPE_B_SELECT) {
            temp &= ~SDVO_PIPE_B_SELECT;
            I915_WRITE(intel_hdmi->hdmi_reg, temp);
            POSTING_READ(intel_hdmi->hdmi_reg);

            /* Again we need to write this twice. */
            I915_WRITE(intel_hdmi->hdmi_reg, temp);
            POSTING_READ(intel_hdmi->hdmi_reg);

            /* Transcoder selection bits only update
             * effectively on vblank. */
            if (crtc)
                intel_wait_for_vblank(dev, pipe);
            else
                msleep(50);
        }
    }

    /* HW workaround, need to toggle enable bit off and on for 12bpc, but
     * we do this anyway which shows more stable in testing.
     */
    if (HAS_PCH_SPLIT(dev)) {
        I915_WRITE(intel_hdmi->hdmi_reg, temp & ~SDVO_ENABLE);
        POSTING_READ(intel_hdmi->hdmi_reg);
    }

    temp &= ~enable_bits;

    I915_WRITE(intel_hdmi->hdmi_reg, temp);
    POSTING_READ(intel_hdmi->hdmi_reg);

    /* HW workaround, need to write this twice for issue that may result
     * in first write getting masked.
     */
    if (HAS_PCH_SPLIT(dev)) {
        I915_WRITE(intel_hdmi->hdmi_reg, temp);
        POSTING_READ(intel_hdmi->hdmi_reg);
    }
}

static int hdmi_portclock_limit(struct intel_hdmi *hdmi)
{
    struct drm_device *dev = intel_hdmi_to_dev(hdmi);

    if (IS_G4X(dev))
        return 165000;
    else if (IS_HASWELL(dev))
        return 300000;
    else
        return 225000;
}

static int intel_hdmi_mode_valid(struct drm_connector *connector,
                 struct drm_display_mode *mode)
{
    if (mode->clock > hdmi_portclock_limit(intel_attached_hdmi(connector)))
        return MODE_CLOCK_HIGH;
    if (mode->clock < 20000)
        return MODE_CLOCK_LOW;

    if (mode->flags & DRM_MODE_FLAG_DBLSCAN)
        return MODE_NO_DBLESCAN;

    return MODE_OK;
}

bool intel_hdmi_compute_config(struct intel_encoder *encoder,
                   struct intel_crtc_config *pipe_config)
{
    struct intel_hdmi *intel_hdmi = enc_to_intel_hdmi(&encoder->base);
    struct drm_device *dev = encoder->base.dev;
    struct drm_display_mode *adjusted_mode = &pipe_config->adjusted_mode;
    int clock_12bpc = pipe_config->requested_mode.clock * 3 / 2;
    int portclock_limit = hdmi_portclock_limit(intel_hdmi);
    int desired_bpp;

    if (intel_hdmi->color_range_auto) {
        /* See CEA-861-E - 5.1 Default Encoding Parameters */
        if (intel_hdmi->has_hdmi_sink &&
            drm_match_cea_mode(adjusted_mode) > 1)
            intel_hdmi->color_range = HDMI_COLOR_RANGE_16_235;
        else
            intel_hdmi->color_range = 0;
    }

    if (intel_hdmi->color_range)
        pipe_config->limited_color_range = true;

    if (HAS_PCH_SPLIT(dev) && !HAS_DDI(dev))
        pipe_config->has_pch_encoder = true;

    /*
     * HDMI is either 12 or 8, so if the display lets 10bpc sneak
     * through, clamp it down. Note that g4x/vlv don't support 12bpc hdmi
     * outputs. We also need to check that the higher clock still fits
     * within limits.
     */
    if (pipe_config->pipe_bpp > 8*3 && clock_12bpc <= portclock_limit
        && HAS_PCH_SPLIT(dev)) {
        DRM_DEBUG_KMS("picking bpc to 12 for HDMI output\n");
        desired_bpp = 12*3;

        /* Need to adjust the port link by 1.5x for 12bpc. */
        pipe_config->port_clock = clock_12bpc;
    } else {
        DRM_DEBUG_KMS("picking bpc to 8 for HDMI output\n");
        desired_bpp = 8*3;
    }

    if (!pipe_config->bw_constrained) {
        DRM_DEBUG_KMS("forcing pipe bpc to %i for HDMI\n", desired_bpp);
        pipe_config->pipe_bpp = desired_bpp;
    }

    if (adjusted_mode->clock > portclock_limit) {
        DRM_DEBUG_KMS("too high HDMI clock, rejecting mode\n");
        return false;
    }

    return true;
}

static enum drm_connector_status
intel_hdmi_detect(struct drm_connector *connector, bool force)
{
    struct drm_device *dev = connector->dev;
    struct intel_hdmi *intel_hdmi = intel_attached_hdmi(connector);
    struct intel_digital_port *intel_dig_port =
        hdmi_to_dig_port(intel_hdmi);
    struct intel_encoder *intel_encoder = &intel_dig_port->base;
    struct drm_i915_private *dev_priv = dev->dev_private;
    struct edid *edid;
    enum drm_connector_status status = connector_status_disconnected;

    intel_hdmi->has_hdmi_sink = false;
    intel_hdmi->has_audio = false;
    intel_hdmi->rgb_quant_range_selectable = false;
    edid = drm_get_edid(connector,
                intel_gmbus_get_adapter(dev_priv,
                            intel_hdmi->ddc_bus));

    if (edid) {
        if (edid->input & DRM_EDID_INPUT_DIGITAL) {
            status = connector_status_connected;
            if (intel_hdmi->force_audio != HDMI_AUDIO_OFF_DVI)
                intel_hdmi->has_hdmi_sink =
                        drm_detect_hdmi_monitor(edid);
            intel_hdmi->has_audio = drm_detect_monitor_audio(edid);
            intel_hdmi->rgb_quant_range_selectable =
                drm_rgb_quant_range_selectable(edid);
        }
        kfree(edid, EDID_LENGTH * (DRM_MAX_EDID_EXT_NUM + 1));
    }

    if (status == connector_status_connected) {
        if (intel_hdmi->force_audio != HDMI_AUDIO_AUTO)
            intel_hdmi->has_audio =
                (intel_hdmi->force_audio == HDMI_AUDIO_ON);
        intel_encoder->type = INTEL_OUTPUT_HDMI;
    }

    return status;
}

static int intel_hdmi_get_modes(struct drm_connector *connector)
{
    struct intel_hdmi *intel_hdmi = intel_attached_hdmi(connector);
    struct drm_i915_private *dev_priv = connector->dev->dev_private;

    /* We should parse the EDID data and find out if it's an HDMI sink so
     * we can send audio to it.
     */

    return intel_ddc_get_modes(connector,
                   intel_gmbus_get_adapter(dev_priv,
                               intel_hdmi->ddc_bus));
}

static bool
intel_hdmi_detect_audio(struct drm_connector *connector)
{
    struct intel_hdmi *intel_hdmi = intel_attached_hdmi(connector);
    struct drm_i915_private *dev_priv = connector->dev->dev_private;
    struct edid *edid;
    bool has_audio = false;

    edid = drm_get_edid(connector,
                intel_gmbus_get_adapter(dev_priv,
                            intel_hdmi->ddc_bus));
    if (edid) {
        if (edid->input & DRM_EDID_INPUT_DIGITAL)
            has_audio = drm_detect_monitor_audio(edid);
        kfree(edid, EDID_LENGTH * (DRM_MAX_EDID_EXT_NUM + 1));
    }

    return has_audio;
}

static int
intel_hdmi_set_property(struct drm_connector *connector,
              struct drm_property *property,
              uint64_t val)
{
    struct intel_hdmi *intel_hdmi = intel_attached_hdmi(connector);
    struct intel_digital_port *intel_dig_port =
        hdmi_to_dig_port(intel_hdmi);
    struct drm_i915_private *dev_priv = connector->dev->dev_private;
    int ret;

    ret = drm_object_property_set_value(&connector->base, property, val);
    if (ret)
        return ret;

    if (property == dev_priv->force_audio_property) {
        enum hdmi_force_audio i = (enum hdmi_force_audio) val;
        bool has_audio;

        if (i == intel_hdmi->force_audio)
            return 0;

        intel_hdmi->force_audio = i;

        if (i == HDMI_AUDIO_AUTO)
            has_audio = intel_hdmi_detect_audio(connector);
        else
            has_audio = (i == HDMI_AUDIO_ON);

        if (i == HDMI_AUDIO_OFF_DVI)
            intel_hdmi->has_hdmi_sink = 0;

        intel_hdmi->has_audio = has_audio;
        goto done;
    }

    if (property == dev_priv->broadcast_rgb_property) {
        bool old_auto = intel_hdmi->color_range_auto;
        uint32_t old_range = intel_hdmi->color_range;

        switch (val) {
        case INTEL_BROADCAST_RGB_AUTO:
            intel_hdmi->color_range_auto = true;
            break;
        case INTEL_BROADCAST_RGB_FULL:
            intel_hdmi->color_range_auto = false;
            intel_hdmi->color_range = 0;
            break;
        case INTEL_BROADCAST_RGB_LIMITED:
            intel_hdmi->color_range_auto = false;
            intel_hdmi->color_range = HDMI_COLOR_RANGE_16_235;
            break;
        default:
            return -EINVAL;
        }

        if (old_auto == intel_hdmi->color_range_auto &&
            old_range == intel_hdmi->color_range)
            return 0;
        goto done;
    }

    return -EINVAL;

done:
    if (intel_dig_port->base.base.crtc)
        intel_crtc_restore_mode(intel_dig_port->base.base.crtc);

    return 0;
}

static void intel_hdmi_pre_enable(struct intel_encoder *encoder)
{
    struct intel_digital_port *dport = enc_to_dig_port(&encoder->base);
    struct drm_device *dev = encoder->base.dev;
    struct drm_i915_private *dev_priv = dev->dev_private;
    struct intel_crtc *intel_crtc =
        to_intel_crtc(encoder->base.crtc);
    int port = vlv_dport_to_channel(dport);
    int pipe = intel_crtc->pipe;
    u32 val;

    if (!IS_VALLEYVIEW(dev))
        return;

    /* Enable clock channels for this port */
    val = vlv_dpio_read(dev_priv, DPIO_DATA_LANE_A(port));
    val = 0;
    if (pipe)
        val |= (1<<21);
    else
        val &= ~(1<<21);
    val |= 0x001000c4;
    vlv_dpio_write(dev_priv, DPIO_DATA_CHANNEL(port), val);

    /* HDMI 1.0V-2dB */
    vlv_dpio_write(dev_priv, DPIO_TX_OCALINIT(port), 0);
    vlv_dpio_write(dev_priv, DPIO_TX_SWING_CTL4(port),
             0x2b245f5f);
    vlv_dpio_write(dev_priv, DPIO_TX_SWING_CTL2(port),
             0x5578b83a);
    vlv_dpio_write(dev_priv, DPIO_TX_SWING_CTL3(port),
             0x0c782040);
    vlv_dpio_write(dev_priv, DPIO_TX3_SWING_CTL4(port),
             0x2b247878);
    vlv_dpio_write(dev_priv, DPIO_PCS_STAGGER0(port), 0x00030000);
    vlv_dpio_write(dev_priv, DPIO_PCS_CTL_OVER1(port),
             0x00002000);
    vlv_dpio_write(dev_priv, DPIO_TX_OCALINIT(port),
             DPIO_TX_OCALINIT_EN);

    /* Program lane clock */
    vlv_dpio_write(dev_priv, DPIO_PCS_CLOCKBUF0(port),
             0x00760018);
    vlv_dpio_write(dev_priv, DPIO_PCS_CLOCKBUF8(port),
             0x00400888);
}

static void intel_hdmi_pre_pll_enable(struct intel_encoder *encoder)
{
    struct intel_digital_port *dport = enc_to_dig_port(&encoder->base);
    struct drm_device *dev = encoder->base.dev;
    struct drm_i915_private *dev_priv = dev->dev_private;
    int port = vlv_dport_to_channel(dport);

    if (!IS_VALLEYVIEW(dev))
        return;

    /* Program Tx lane resets to default */
    vlv_dpio_write(dev_priv, DPIO_PCS_TX(port),
             DPIO_PCS_TX_LANE2_RESET |
             DPIO_PCS_TX_LANE1_RESET);
    vlv_dpio_write(dev_priv, DPIO_PCS_CLK(port),
             DPIO_PCS_CLK_CRI_RXEB_EIOS_EN |
             DPIO_PCS_CLK_CRI_RXDIGFILTSG_EN |
             (1<<DPIO_PCS_CLK_DATAWIDTH_SHIFT) |
             DPIO_PCS_CLK_SOFT_RESET);

    /* Fix up inter-pair skew failure */
    vlv_dpio_write(dev_priv, DPIO_PCS_STAGGER1(port), 0x00750f00);
    vlv_dpio_write(dev_priv, DPIO_TX_CTL(port), 0x00001500);
    vlv_dpio_write(dev_priv, DPIO_TX_LANE(port), 0x40400000);

    vlv_dpio_write(dev_priv, DPIO_PCS_CTL_OVER1(port),
             0x00002000);
    vlv_dpio_write(dev_priv, DPIO_TX_OCALINIT(port),
             DPIO_TX_OCALINIT_EN);
}

static void intel_hdmi_post_disable(struct intel_encoder *encoder)
{
    struct intel_digital_port *dport = enc_to_dig_port(&encoder->base);
    struct drm_i915_private *dev_priv = encoder->base.dev->dev_private;
    int port = vlv_dport_to_channel(dport);

    /* Reset lanes to avoid HDMI flicker (VLV w/a) */
    mutex_lock(&dev_priv->dpio_lock);
    vlv_dpio_write(dev_priv, DPIO_PCS_TX(port), 0x00000000);
    vlv_dpio_write(dev_priv, DPIO_PCS_CLK(port), 0x00e00060);
    mutex_unlock(&dev_priv->dpio_lock);
}
static void intel_hdmi_destroy(struct drm_connector *connector)
{
    drm_connector_cleanup(connector);
    kfree(connector, sizeof(struct intel_connector));
}

static const struct drm_encoder_helper_funcs intel_hdmi_helper_funcs = {
    .mode_set = intel_hdmi_mode_set,
};

static const struct drm_connector_funcs intel_hdmi_connector_funcs = {
    .dpms = intel_connector_dpms,
    .detect = intel_hdmi_detect,
    .fill_modes = drm_helper_probe_single_connector_modes,
    .set_property = intel_hdmi_set_property,
    .destroy = intel_hdmi_destroy,
};

static const struct drm_connector_helper_funcs intel_hdmi_connector_helper_funcs = {
    .get_modes = intel_hdmi_get_modes,
    .mode_valid = intel_hdmi_mode_valid,
    .best_encoder = intel_best_encoder,
};

static const struct drm_encoder_funcs intel_hdmi_enc_funcs = {
    .destroy = intel_encoder_destroy,
};

static void
intel_hdmi_add_properties(struct intel_hdmi *intel_hdmi, struct drm_connector *connector)
{
    intel_attach_force_audio_property(connector);
    intel_attach_broadcast_rgb_property(connector);
    intel_hdmi->color_range_auto = true;
}

void intel_hdmi_init_connector(struct intel_digital_port *intel_dig_port,
                      struct intel_connector *intel_connector)
{
    struct drm_connector *connector = &intel_connector->base;
    struct intel_hdmi *intel_hdmi = &intel_dig_port->hdmi;
    struct intel_encoder *intel_encoder = &intel_dig_port->base;
    struct drm_device *dev = intel_encoder->base.dev;
    struct drm_i915_private *dev_priv = dev->dev_private;
    enum port port = intel_dig_port->port;

    (void) drm_connector_init(dev, connector, &intel_hdmi_connector_funcs,
               DRM_MODE_CONNECTOR_HDMIA);
    (void) drm_connector_helper_add(connector, &intel_hdmi_connector_helper_funcs);

    connector->interlace_allowed = 1;
    connector->doublescan_allowed = 0;

    switch (port) {
    case PORT_B:
        intel_hdmi->ddc_bus = GMBUS_PORT_DPB;
        intel_encoder->hpd_pin = HPD_PORT_B;
        break;
    case PORT_C:
        intel_hdmi->ddc_bus = GMBUS_PORT_DPC;
        intel_encoder->hpd_pin = HPD_PORT_C;
        break;
    case PORT_D:
        intel_hdmi->ddc_bus = GMBUS_PORT_DPD;
        intel_encoder->hpd_pin = HPD_PORT_D;
        break;
    case PORT_A:
        intel_encoder->hpd_pin = HPD_PORT_A;
        /* Internal port only for eDP. */
    default:
        BUG();
    }

    if (IS_VALLEYVIEW(dev)) {
        intel_hdmi->write_infoframe = vlv_write_infoframe;
        intel_hdmi->set_infoframes = vlv_set_infoframes;
    } else if (!HAS_PCH_SPLIT(dev)) {
        intel_hdmi->write_infoframe = g4x_write_infoframe;
        intel_hdmi->set_infoframes = g4x_set_infoframes;
    } else if (HAS_DDI(dev)) {
        intel_hdmi->write_infoframe = hsw_write_infoframe;
        intel_hdmi->set_infoframes = hsw_set_infoframes;
    } else if (HAS_PCH_IBX(dev)) {
        intel_hdmi->write_infoframe = ibx_write_infoframe;
        intel_hdmi->set_infoframes = ibx_set_infoframes;
    } else {
        intel_hdmi->write_infoframe = cpt_write_infoframe;
        intel_hdmi->set_infoframes = cpt_set_infoframes;
    }

    if (HAS_DDI(dev))
        intel_connector->get_hw_state = intel_ddi_connector_get_hw_state;
    else
        intel_connector->get_hw_state = intel_connector_get_hw_state;

    intel_hdmi_add_properties(intel_hdmi, connector);

    intel_connector_attach_encoder(intel_connector, intel_encoder);
//  drm_sysfs_connector_add(connector);

    /* For G4X desktop chip, PEG_BAND_GAP_DATA 3:0 must first be written
     * 0xd.  Failure to do so will result in spurious interrupts being
     * generated on the port when a cable is not attached.
     */
    if (IS_G4X(dev) && !IS_GM45(dev)) {
        u32 temp = I915_READ(PEG_BAND_GAP_DATA);
        I915_WRITE(PEG_BAND_GAP_DATA, (temp & ~0xf) | 0xd);
    }
}

void intel_hdmi_init(struct drm_device *dev, int hdmi_reg, enum port port)
{
    struct intel_digital_port *intel_dig_port;
    struct intel_encoder *intel_encoder;
    struct intel_connector *intel_connector;

    intel_dig_port = kzalloc(sizeof(struct intel_digital_port), GFP_KERNEL);
    if (!intel_dig_port)
        return;

    intel_connector = kzalloc(sizeof(struct intel_connector), GFP_KERNEL);
    if (!intel_connector) {
        kfree(intel_dig_port, sizeof(struct intel_digital_port));
        return;
    }

    intel_encoder = &intel_dig_port->base;

    drm_encoder_init(dev, &intel_encoder->base, &intel_hdmi_enc_funcs,
             DRM_MODE_ENCODER_TMDS);

    drm_encoder_helper_add(&intel_encoder->base, &intel_hdmi_helper_funcs);

    intel_encoder->compute_config = intel_hdmi_compute_config;
    intel_encoder->enable = intel_enable_hdmi;
    intel_encoder->disable = intel_disable_hdmi;
    intel_encoder->get_hw_state = intel_hdmi_get_hw_state;
    intel_encoder->get_config = intel_hdmi_get_config;
    if (IS_VALLEYVIEW(dev)) {
        intel_encoder->pre_enable = intel_hdmi_pre_enable;
        intel_encoder->pre_pll_enable = intel_hdmi_pre_pll_enable;
        intel_encoder->post_disable = intel_hdmi_post_disable;
    }

    intel_encoder->type = INTEL_OUTPUT_HDMI;
    intel_encoder->type_size = sizeof(struct intel_digital_port);
    intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
    intel_encoder->cloneable = false;

    intel_dig_port->port = port;
    intel_dig_port->hdmi.hdmi_reg = hdmi_reg;
    intel_dig_port->dp.output_reg = 0;

    intel_hdmi_init_connector(intel_dig_port, intel_connector);
}