tree-wide: remove Emacs lines from all files This should be handled fine now by .dir-locals.el, so need to carry that stuff in every file.

udev: add emacs header line Otherwise emacs wants to use 2-space indentation and other attrocities.

tree-wide: group include of libudev.h with sd-*

tree-wide: sort includes Sort the includes accoding to the new coding style.

util-lib: split out fd-related operations into fd-util.[ch] There are more than enough to deserve their own .c file, hence move them over.

util-lib: split our string related calls from util.[ch] into its own file string-util.[ch] There are more than enough calls doing string manipulations to deserve its own files, hence do something about it. This patch also sorts the #include blocks of all files that needed to be updated, according to the sorting suggestions from CODING_STYLE. Since pretty much every file needs our string manipulation functions this effectively means that most files have sorted #include blocks now. Also touches a few unrelated include files.

tree-wide: replace while(1) by for(;;) everywhere Another Coccinelle script.

tree-wide: update empty-if coccinelle script to cover empty-while and more Let's also clean up single-line while and for blocks.

udevadm,..: make --help output of udev tools more like the output of the various other tools

udev: improve help/usage for some more programs

treewide: use log_*_errno whenever %m is in the format string If the format string contains %m, clearly errno must have a meaningful value, so we might as well use log_*_errno to have ERRNO= logged. Using: find . -name '*.[ch]' | xargs sed -r -i -e \ 's/log_(debug|info|notice|warning|error|emergency)\((".*%m.*")/log_\1_errno(errno, \2/' Plus some whitespace, linewrap, and indent adjustments.

udev: switch to systemd logging functions

scsi_id: fix usage spelling s/threat/treat/g

udev: never bypass our own logging framework and call vsyslog() directly from udev tools

Remove dead lines in various places As pointed-out by clang -Wunreachable-code. No behaviour changes.

log: log_error() and friends add a newline after each line anyway, so avoid including it in the log strings

udevadm,scsi_id: add short options to help strings and to the man page Also clean things up a bit here and there.

scsi_id: cleanup Remove -i option which would case exit(1) to happen. Remove some unused code. Convert to bool where appropriate. Simplify things a bit. Always free everything. https://bugzilla.redhat.com/show_bug.cgi?id=1043304

Add more _printf_'s for format-nonliterals Clang is a bit more strict wrt format-nonliterals: http://clang.llvm.org/docs/LanguageExtensions.html#format-string-checking Adding these extra printf attributes also makes gcc able to find more problems. E.g. this patch uncovers a format issue in udev-builtin-path_id.c Some parts looked intetional about breaking the format-nonliteral check. I added some supression for warnings there.

tree-wide usage of %m specifier instead of strerror(errno) Also for log_error() except where a specific error is specified e.g. errno ? strerror(errno) : "Some user specified message"

use streq instead of strcmp

util: introduce strcaseeq/strncaseeq

use strneq instead of strncmp

udev: move string copy functions to shared/

udev: get rid of SYSCONFDIR

log.h: new log_oom() -> int -ENOMEM, use it also a number of minor fixups and bug fixes: spelling, oom errors that didn't print errors, not properly forwarding error codes, few more consistency issues, et cetera

use "Out of memory." consistantly (or with "\n") glibc/glib both use "out of memory" consistantly so maybe we should consider that instead of this. Eliminates one string out of a number of binaries. Also fixes extra newline in udev/scsi_id

udev: add some O_CLOEXEC

udev: switch to systemd logging functions

udev: fix gcc warnings

move imported udev into place