dhcp: make host/domain name validity checks stricter Also don't permit host/domain names that reference the root domain, and unify the codepaths for this.

libsystemd-network: use assert_se It cannot fail. CID #1320623.

dhcp: make DHCP_OPTION_* enum public libsystemd-network provides the public function sd_dhcp_client_set_request_option() to enable the request of a given DHCP option. However the enum defining such options is defined in the internal header dhcp-protocol.h. Move the enum definition to the public header sd-dhcp-client.h and properly namespace values.

dhcp: export routes as opaque objects At the moment sd_dhcp_lease_get_routes() returns an array of structs which are not defined in public headers. Instead, change the function to return an array of pointers to opaque sd_dhcp_route objects.

tree-wide: use xsprintf() where applicable Also add a coccinelle receipt to help with such transitions.

tree-wide: expose "p"-suffix unref calls in public APIs to make gcc cleanup easy GLIB has recently started to officially support the gcc cleanup attribute in its public API, hence let's do the same for our APIs. With this patch we'll define an xyz_unrefp() call for each public xyz_unref() call, to make it easy to use inside a __attribute__((cleanup())) expression. Then, all code is ported over to make use of this. The new calls are also documented in the man pages, with examples how to use them (well, I only added docs where the _unref() call itself already had docs, and the examples, only cover sd_bus_unrefp() and sd_event_unrefp()). This also renames sd_lldp_free() to sd_lldp_unref(), since that's how we tend to call our destructors these days. Note that this defines no public macro that wraps gcc's attribute and makes it easier to use. While I think it's our duty in the library to make our stuff easy to use, I figure it's not our duty to make gcc's own features easy to use on its own. Most likely, client code which wants to make use of this should define its own: #define _cleanup_(function) __attribute__((cleanup(function))) Or similar, to make the gcc feature easier to use. Making this logic public has the benefit that we can remove three header files whose only purpose was to define these functions internally. See #2008.

sd-dhcp: parse error message in DECLINE or NAK If a client sends a DECLINE or a server sends a NAK, they can include a string with a message to explain the error. Parse this and print it at debug level.

libsystemd-network: inet_pton does not set errno on parsing error it would set errno only for an invalid address family. Also fix a copy&paste error in one error string.

util-lib: move character class definitions to string-util.h

util-lib: split out allocation calls into alloc-util.[ch]

util-lib: split out hex/dec/oct encoding/decoding into its own file

util-lib: split string parsing related calls from util.[ch] into parse-util.[ch]

util-lib: split out fd-related operations into fd-util.[ch] There are more than enough to deserve their own .c file, hence move them over.

util-lib: split our string related calls from util.[ch] into its own file string-util.[ch] There are more than enough calls doing string manipulations to deserve its own files, hence do something about it. This patch also sorts the #include blocks of all files that needed to be updated, according to the sorting suggestions from CODING_STYLE. Since pretty much every file needs our string manipulation functions this effectively means that most files have sorted #include blocks now. Also touches a few unrelated include files.

dhcp: make sure we can deal with a single trailing NUL byte in the hostname Fixes #1337

tree-wide: do not shadow the global var timezone

dhcp: say domain name, when we mean domain name

dhcp: clean up dhcp4 lease object a) drop handling of obsolete or unused DHCP options time_offset, mtu_aging_timeout, policy filter, mdr, ttl, ip forwarding settings. Should this become useful one day we can readd support for this. b) For subnet mask and broadcast it is not always clear whether 0 or 255.255.255.255 might be valid, hence maintain a boolean indicating validity next to it. c) serialize/deserialize broadcast address, lifetime, T1 and T2 together with the rest of the fields in dhcp_lease_save() and dhcp_lease_load(). d) consistently return ENODATA from getter functions for data that is missing in the lease. e) add missing getter calls for broadcast, lifetime, T1, T2. f) when decoding DHCP options, generate debug messages on parse failures, but try to proceed if possible. g) Similar, when deserializing a lease in dhcp_lease_load(), make sure we deal nicely with unparsable fields, to provide upgrade compat. h) fix some memory allocations

dhcp: generic data should be void*, not uint8_t* If we handly arbitrary data we should use "void*" pointers, not "uint8_t*", how go intended C to be used.

dhcp: stop using refcnt.h No need to invole atomic ops in single-threaded APIs, let's simplify this.

dhcp: keep lease save/load functions private When we make sd-dhcp public one day we really should not make sd_dhcp_lease_save() and sd_dhcp_lease_load() public, since it's pretty much only useful as internal utility for networkd itself.

dhcp: normalize DHCP host and domain names from leases Previoulsy, we just checked whether the domain names specified in incoming DHCP leases are valid. Given that validation code actually internally normalizes anyway, it's a good idea to simply do the full normalization and store that in the lease structure. This allows us to remove the manual removal of a trailing dot, if there is one.

dhcp: various simplifications

dhcp,network: implement RFC 4833 (DHCP Timezone option) This one is simply to add: encode the tzdata timezone in the DHCP options and optionally make use of it.

dhcp: be more careful when parsing strings from DHCP packets Let's make sure there's no embedded 0 byte. Also, let's reset the string if the length is zero.

libsystemd-network: fix memory leak

libsystemd-network: plug memory leak Coverity #1315324

hostname-util: add relax parameter to hostname_is_valid Tests are modified to check behaviour with relax and without relax. New tests are added for hostname_cleanup(). Tests are moved a new file (test-hostname-util) because there's now a bunch of them. New parameter is not used anywhere, except in tests, so there should be no observable change.

network: make enough space for string Follow-up for PR #877.

networkd: clean up duplicate code

networkd: serialize the private options Save the private options along side the rest of the options in the lease files.

networkd: add private options to lease struct This stores private-zone DHCP options inside of their respective DHCP lease. These options aren't used by networkd (what would it do with them?), but saving them will allow other programs to query the values. To improve performance, the options are stored in ascending order by tag.

tree-wide: port everything over to fflush_and_check() Some places invoked fflush() directly with their own manual error checking, let's unify all that by using fflush_and_check(). This also unifies the general error paths of fflush()+rename() file writers.

dhcp: add support for vendor specific DHCP option This adds support for option 43 (Vendor Specific Information) to libsystemd-network DHCP code. The option carries an opaque object of n octets, interpreted by vendor-specific code on the clients and servers. [@zonque: adopted to new unhexmem() API]

basic: util - fix errorhandling in unhexmem() We were ignoring failures from unhexchar, which meant that invalid hex characters were being turned into garbage rather than the string rejected. Fix this by making unhexmem return an error code, also change the API slightly, to return the size of the returned memory, reflecting the fact that the memory is a binary blob,and not a string. For convenience, still append a trailing NULL byte to the returned memory (not included in the returned size), allowing callers to treat it as a string without doing a second copy.

sd-dhcp-lease: fix handling of multiple routers currently if a dhcp server sends more than one router, sd-dhcp-lease does not copy the ip because it assumes it will only ever be 4 bytes. a dhcp server could send more than one ip in the router list, so we should copy the first one and ignore the rest of the bytes.

libsystemd-network: use domain validation instead of hostname validation for dhcp domain option previously hostname_is_valid was used to validate domain names, which would silently drop perfectly valid dns names that were longer than a single dns label.

json: minor style fixes

util: split all hostname related calls into hostname-util.c

remove unused includes This patch removes includes that are not used. The removals were found with include-what-you-use which checks if any of the symbols from a header is in use.

sd-dhcp: chop of trailing dot of DHCP supplied host and domain nams

refcnt: refcnt is unsigned, fix comparisons This does not make a difference, but the code was confusing.

treewide: more log_*_errno + return simplifications

treewide: no need to negate errno for log_*_errno() It corrrectly handles both positive and negative errno values.

treewide: auto-convert the simple cases to log_*_errno() As a followup to 086891e5c1 "log: add an "error" parameter to all low-level logging calls and intrdouce log_error_errno() as log calls that take error numbers", use sed to convert the simple cases to use the new macros: find . -name '*.[ch]' | xargs sed -r -i -e \ 's/log_(debug|info|notice|warning|error|emergency)\("(.*)%s"(.*), strerror\(-([a-zA-Z_]+)\)\);/log_\1_errno(-\4, "\2%m"\3);/' Multi-line log_*() invocations are not covered. And we also should add log_unit_*_errno().

sd-dhcp-lease: fix copy-paste error asserting wrong function argument

sd-dhcp-lease: load/save client ID The lease is usually tied to the client ID, so users of the lease may want to know what client ID it was acquired with.

sd-dhcp-lease: expose load/save functions Based on patch by Dan Williams.

sd-dhcp-lease: use shared default prefixlen function Also change the default prefixlen function to only access the first octet of the in_addr.

sd-dhcp-lease: use unaligned read helpers

shared: in-addr-utils - add default_subnet_mask and default_prefixlen methods These use the (deprecated) IPv4 address classes to deduce the corresponding subnet masks. This is useful when addresses without subnet masks and prefix lengths are given. Make use of these new functions from sd-dhcp-lease.

dhcp: the localhost isn't valid as hostname either

sd-dhcp-lease: verify hostname and domainnames we receive

networkd: merge DNS and NTP entries when exporting In the state files, do not distinguish where the various entries came from (static or DHCP), but include them all in the same list.

sd-network: remove redundant array size parameter from functions that return arrays As long as the number of array entries is relatively small it's nicer to simply return the number of entries directly, instead of using a size_t* return parameter for it.

Add support for DHCP static route options This adds support for DHCP options 33 and 121: Static Route and Classless Static Route. To enable this feature, set UseRoutes=true in .network file. Returned routes are added to the routing table.

sd-dhcp-client/networkd: set lifetimes for IPv4 addresses Note that /proc/sys/net/ipv4/ip_dynaddr needs to be non-zero. [tomegun: hook up DHCP renew events to increase the lifetime when necessary]

dhcp-lease: add support for parsing a few more dhcp options

dhcp-lease: refactor lease parsing Use helper functions, and add some more sanity checking/asserts.

sd-dhcp-lease/sd-network: modernization and fix leak

sd-dhcp-lease: move in_addr (de)serialization to shared network code

networkd: dont configure route if lease doesn't have one

sd-dhcp-lease: fix double realloc

sd-dhcp-lease: (de)serialize DNS and NTP servers Also use inet_ntoa rather than inet_ntop.

sd-dhcp-leaes: use newdup()

sd-dhcp-lease: add NTP support Export the NTP servers so timesyncd can use them.

test-dhcp-client: unref lease objects to make valgrind happy Also unref client objects in test code, and initalize logging, to DEBUG by default.

sd-dhcp-client: add fallback subnet masks The DHCP RFC does not require the DHCP server to send a subnet mask, so if it is missing, let's try to use the default subnet masks based on address class. In case the class the address belongs to does not have a default subnet mask, we fail as before. Also improve logging when handling invalid dhcp messages, and simply ignore them rather than stop the whole dhcp client.

networkd: fix creation of runtime dirs at startup This allows us to drop the repeated attempted creations of the runtime dirs during runtime.

sd-dhcp-lease: add sd_dhcp_lease_get_next_server()

sd-dhcp-lease: add sd_dhcp_lease_get_server_identifier()

sd-dhcp-lease: add Root Path support This is necessary when mounting /dev/nfs based on a DHCP lease.

sd-network: add new library This is similar to sd-login, but exposes the state of networkd rather than logind. Include it in libsystemd-dhcp and rename it to libsystemd-network.