CODING_STYLE: make sure line break recommendation matches edit configuration In the .vimrc and .dir-locals.el we suggest a line width of 119. We should recommend the same in CODING_STYLE.

CODING_STYLE: elaborate on usage of C99 fixed size integer types

update CODING_STYLE

update CODING_STYLE

update CODING_STYLE

update CODING_STYLE with various additions

tree-wide: never use the off_t unless glibc makes us use it off_t is a really weird type as it is usually 64bit these days (at least in sane programs), but could theoretically be 32bit. We don't support off_t as 32bit builds though, but still constantly deal with safely converting from off_t to other types and back for no point. Hence, never use the type anymore. Always use uint64_t instead. This has various benefits, including that we can expose these values directly as D-Bus properties, and also that the values parse the same in all cases.

CODING_STYLE: mandate alphabetical include order systemd-internal headers must not rely on include order. That means, they either must contain forward-declarations of used types/functions, or they must include all dependencies on their own. Therefore, there is no reason to mandate an include order on the call-side. However, global includes should always be ordered first. We don't want local definitions to leak into global includes, possible changing their behavior. Apparently, namespacing is a complex problem that people are incapable of implementing properly.. Apart from "global before local", there is no reason to mandate a random include order (which we happen to do right now). Instead, mandate alphabetical ordering. The current rules do not have any benefit at all. They neither reduce include-complexity, nor allow easy auditing of include files. But with alphabetical ordering, we get duplicate-detection for free, it gets *much much* easier to figure out whether a header is already included, and it is trivial to add new headers.

CODING_STYLE: say that "for (;;)" is better than "while (1)"

Stop talking about the "XDG" version of basename() XDG refers to X Desktop Group, a former name for freedesktop.org. This group is responsible for specifications like basedirs, .desktop files and icon naming, but as far as I know, it has never tried to redefine basename(). I think these references were meant to say XPG (X/Open Portability Guide), a precursor of POSIX. POSIX is better-known and less easily confused with XDG, and is how the basename(3) man page describes the libgen.h version of basename(). The other version of basename() is glibc-specific and is described in basename(3) as "the GNU version"; specifically mention that version, to disambiguate.

CODING_STYLE: document order in which to #include headers

CODING_STYLE: document that we should avoid kernel types like u32

CODING_STYLE: document that EXIT_FAILURE and EXIT_SUCCESS should be used

CODING_STYLE: document best practices when initializing structs

CODING_STYLE: document alloca() DONTS

CODING_STYLE: document that we prefer /* comments */ over // comments

CODING_STYLE: document how destructors should work

CODING_STYLE: mention that dup() should not be used

CODING_STYLE: clarify that exit() is never OK to call

CODING_STYLE: mention casting of function invocations to (void)

update TODO

tree-wide: whenever we include libgen.h, immediately undefine basename() Also, document in adjacent comments and in CODING_STYLE why we do that.

CODING_STYLE: elaborate on O_CLOEXEC a bit

Reindent man pages to 2ch

CODING_STYLE: clarify that we really should use O_CLOEXEC everywhere

CODING_STYLE: don't clobber arguments on failure

CODING_STYLE: clarify that single-line if blocks should not be enclosed in {}

Fix a few more typos

CODING_STYLE: document that we don't break lines at 80ch

Unify parse_argv style getopt is usually good at printing out a nice error message when commandline options are invalid. It distinguishes between an unknown option and a known option with a missing arg. It is better to let it do its job and not use opterr=0 unless we actually want to suppress messages. So remove opterr=0 in the few places where it wasn't really useful. When an error in options is encountered, we should not print a lengthy help() and overwhelm the user, when we know precisely what is wrong with the commandline. In addition, since help() prints to stdout, it should not be used except when requested with -h or --help. Also, simplify things here and there.

doc: use expanded forms for written style

doc: typographical improvements and choice of words

doc: grammatical corrections

Fix several small typos

extend CODING_STYLE document a bit

trivial coding style clean ups - Add space between if/for and the opening parentheses - Place the opening brace on same line as the function (not for udev) From the CODING_STYLE Try to use this: void foo() { } instead of this: void foo() { }

analyze: various cleanups Update systemd-analyze to follow the coding style of the other tools more closely. Also, update the CODING_STYLE to document this for future additions. Changes: - Always use usec_t for time units, so that we always use the same types everywhere, and format times the same way as everywhere else. - Add "static" to global variables - Make sure we can always distuingish OOM and other errors: ensure we always return useful error codes from all functions. - Always free unit_times array

Clarify sentence

Minor typo

Be consistent about "." vs no "." at the end of lines"

Spelling Corrections Just some lame spelling corrections with no functionality.

CODING_STYLE: minor updates

CODING_STYLE: add missing -

initial commit