Remove useless assignment to function parameter Reported by: cppcheck void free_fun(struct info *info) free(info->name); free(info); info = NULL; ^^^^^^^^^^^ Assignment to function parameter has no effect outside the function. Reviewed-by: Pavel Reichl <preichl@redhat.com>

Move DEBUG macro body to debug_fn Move DEBUG macro body to the debug_fn function, adding "function" argument to the latter. Rename "debug_fn" in sssd_krb5_locator_plugin.c to "plugin_debug_fn" to remove conflict with the sssd debug_fn. Replace DEBUG_MSG macro usage with debug_fn function usage. Remove DEBUG_MSG macro along with tests. The above makes the total size of binaries drop by 20% for the standard Fedora build and by 44% for a build configured according to Debian packaging script. Reviewed-by: Jakub Hrozek <jhrozek@redhat.com> Reviewed-by: Stephen Gallagher <sgallagh@redhat.com> Reviewed-by: Simo Sorce <simo@redhat.com>

Fix formating of variables with type: long

KRB5_LOCATOR: Print the filename that couldn't be opened

krb5 locator: Do not leak addrinfo

Kerberos locator: Include the correct krb5.h header file https://fedorahosted.org/sssd/ticket/1325

Convert read and write operations to sss_atomic_read https://fedorahosted.org/sssd/ticket/1209

Multiline macro cleanup This is mostly a cosmetic patch. The purpose of wrapping a multi-line macro in a do { } while(0) is to make the macro usable as a regular statement, not a compound statement. When the while(0) is terminated with a semicolon, the do { } while(0); block becomes a compound statement again.

Set _GNU_SOURCE globally

Make sure to close varargs before returning from a function https://fedorahosted.org/sssd/ticket/528

Properly handle read() and write() throughout the SSSD We need to guarantee at all times that reads and writes complete successfully. This means that they must be checked for returning EINTR and EAGAIN, and all writes must be wrapped in a loop to ensure that they do not truncate their output.

Krb5 locator plugin returns KRB5_PLUGIN_NO_HANDLE To allow a fallback to the setting in krb5.conf the locator plugin returns KRB5_PLUGIN_NO_HANDLE in nearly all error conditions. Only if the call back fails the error code of the callback is returned.

Fix kinit after password change In an environment with slave KDCs and a central server where password changes are allowed the request for a new TGT immediately after the password change should be made against this server, because the slave server might not know the new password. To achieve this the Kerberos localtor plugin now returns the address of the kpasswd server as master_kdc.

Fix segfault in the locator plugin

Add krb5_kpasswd option

Write the IP address of the KDC to the kdcinfo file

Rename server/ directory to src/ Also update BUILD.txt