Unlikely potential memory leak. Point 12 of PR 54936

Merge branch revert-ap-ldap: Revert ap_ldap integration due to veto by Graham Leggett Mailing list threads: http://mail-archives.apache.org/mod_mbox/httpd-dev/201106.mbox/%3C4192DC1D-C0B9-42BB-B614-C3A41290F18B@sharp.fm%3E http://mail-archives.apache.org/mod_mbox/httpd-dev/201107.mbox/%3C4E15E51E.4090700@rowe-clan.net%3E

Incorporate the ap_ldap incomplete API, as there is no interest or effort at APR to make this a complete abstraction, and it was voted 'off the island' with APR 2.0. This will allow httpd 2.3 to build against either apr-2.0 or apr+util 1.x.

mod_ldap: Make LDAPSharedCacheSize 0 create a non-shared-memory cache per process as opposed to disabling caching completely. This allows to use the non-shared-memory cache as a workaround for the shared memory cache not being available during graceful restarts PR: 48958

Remove mistaken fix. Just checking if peer review was working... you passed. :)

A quick fix to avoid potential memory issues.

better apr_ctime() usage (too bad it is apr_ctime_LEN instead of apr_ctime_SIZE)

mod_ldap, mod_authnzldap: Add support for nested groups (i.e. the ability to authorize an authenticated user via a "require ldap-group X" directive where the user is not in group X, but is in a subgroup contained in X. PR 42891 [Paul J. Reder]

update license header text

revert accidental copyright year changes

Update the copyright year in all .c, .h and .xml files

No functional Change: Removing trailing whitespace. This also means that "blank" lines consisting of just spaces or tabs are now really blank lines

No functional change: simple detabbing of indented code.

* modules/ldap/util_ldap_cache.c (util_ldap_cache_init): Only remove the shm segment by name if a name is configured.

* modules/ldap/util_ldap_cache.c (util_ldap_url_node_display, util_ldap_search_node_display, util_ldap_compare_node_display, util_ldap_dn_compare_node_display): Use ap_rprintf. Terminate table rows with "</tr>" not "<tr>".

* modules/ldap/util_ldap_cache.c: Remove various casts-from-void *, fix various minor style nits. No functional changes.

* modules/ldap/util_ldap_cache.c (MODLDAP_SHMEM_CACHE): Remove unused macro.

* modules/ldap/util_ldap.c (util_ldap_post_config): Don't attempt to remove the shm segment here. * modules/ldap/util_ldap_cache.c (util_ldap_cache_init): Properly remove the shm segment here before creating a new one; don't attach to any existing shm segment if apr_shm_create() fails. (util_ldap_cache_module_kill): Don't attempt to remove the shm segment here; apr_shm_destroy() does that anyway.

* modules/ldap/util_ldap_cache.c (util_ldap_cache_module_kill): Make private function static. (util_ldap_cache_child_kill): Remove prototype for function which doesn't exist.

* modules/ldap/util_ldap_cache.c (util_ldap_cache_init): Use the actual available size of the shm segment not the requested size. Ensure the requested size is aligned. Check errors from apr_rmm_init.

Actually use the compare_cache_size value that is being set by LDAPOpCacheEntries. The actual cache_size was previously defaulting to the value of search _cache_size set by LDAPCacheEntries.

Don't attempt to remove the cache_file if one was never specified.

Keep track of the number of attributes retrieved from LDAP so that all the values can be properly cached even if the value is NULL. [PR 33901]

Update copyright year to 2005 and standardize on current copyright owner line.

Correct the order of includes to follow httpd conventions, and get Win32 compiling again.

* modules/ldap/util_ldap.c (util_ldap_post_config): Fix false positives from gcc -Wformat-security. * modules/ldap/util_ldap_cache.c (util_ldap_url_node_display): Add default to switch to avoid uninitialised variable warnings. * modules/ldap/util_ldap_cache_mgr.c (util_ald_create_caches): Fix to return NULL rather than random chunk from stack on error path.

Move util_ldap out of experimental and into ldap. See Attic in experimental directory for previous change history.

Remove all of the ldap modules. These have been moved to their own repository, httpd-ldap, and they now form their own sub-project of the httpd project.

Added some bulletproofing to memory allocation in the LDAP cache code. PR: Obtained from: Submitted by: Reviewed by:

Add specified user attributes to the environment when using mod_auth_ldap. This allows you to use mod_include to embed specified user attributes in a page like so: Hello <!--#echo var="AUTHENTICATE_CN"-->, how are you? PR: Obtained from: Submitted by: Reviewed by:

Enabled negative caching on attribute comparisons in the LDAP cache. Fixed a problem where the default cache TTL was set in milliseconds not microseconds causing the cache to time out almost immediately. PR: Obtained from: Submitted by: Reviewed by:

Fixed all the #if APR_HAS_SHARED_MEMORY checks within the LDAP module code to follow APR. PR: Obtained from: Submitted by: Reviewed by:

Clean up an unnecessary function.

Landing of mod_ldap - the LDAP cache and connection pooling module.