quota: Warn when quota check is blocked by background quota calculation This was previously double logged as "Quota transaction has failed earlier" error.

quota: Remove "Failed to set quota transaction limits" error This error adds nothing that helps the user to debug a problem.

Updated copyright notices to include the year 2018.

quota: Include mailbox name in quota_transaction_set_limits() error_r

quota: Prefix quota errors with backend name in quota_get_resource() Remove quota backend name error_r prefixing from get_resource() vfuncs.

quota: Add QUOTA_ALLOC_RESULT_BACKGROUND_CALC enum value

quota: Return quota_get_result from quota_backend_vfuncs.get_resource() Add a QUOTA_UNKNOWN_RESOURCE_ERROR_STRING for returning error_r with QUOTA_GET_RESULT_UNKNOWN_RESOURCE. Forbid backends from returning QUOTA_GET_RESULT_UNLIMITED in quota_get_resource() with an i_panic().

quota: Add error_result_r parameter to quota_transaction_set_limits()

quota: Improve error messages

quota: Add error_r to update() of quota_backend_vfuncs

quota: Add error_r to get_resource() of quota_backend_vfuncs

quota: Add error_r parameter to init_limits() of quota_backend_vfuncs

quota: Add error_r to quota_get_resource()

quota: Add error_r to quota_transaction_set_limits()

quota: Add error_r to quota_settings->test_alloc()

global: Use PRI* macros and %zu instead of casting

quota: quota_get_resource() - return enum to make the result more exact This is mainly to differentiate between "resource name unknown" and "unlimited quota". This also fixes quota_clone plugin to update quota even when quota is unlimited. It was supposed to have been skipped only when the resource names weren't known. The private quota.get_resource() API is unchanged. The backends were already returning 0 only when the resource name was unknown.

quota plugin: restructure quota_root_get_rule_limits() If the user has unlimited quota, we have no reason to find the real mailbox name.

quota: Fix negative storage-based quota_warnings to work with count backend Finishes f9362223346d10a5866b376ed227b77b26ea4292, which fixed it for "messages" but not for "storage".

quota: When setting auto_updating to transaction, skip invisible quota roots Skip the quota root also if the mailbox matches "ignore" quota_rule. This is only an optimization fix so that unnecessary work isn't done for quota roots that aren't actually used.

quota: Fix failing again if quota setting has invalid parameters This was broken by the recent quota parameter parsing changes.

quota: quota_root_iter_next() - Iterate all visible roots Don't try to skip the roots that don't have an active quota. imap_quota plugin does the skipping now itself, and quota_clone shouldn't really be even used with more than one quota root.

quota: Fix negative quota_warnings with count backend For example this never triggered: quota_warning = -messages=100%% quota-warning %u -100 The change to quota_alloc() to update the count_used doesn't seem to actually fix anything right now, but it makes the code more correct.

quota: Remove unused quota_free()

quota: Fix quota_vsizes=yes to work with all backends

quota: assertion for *args != NULL is added in order to avoid warning from static analyzer and *args[0] changed to (*args)[0]

quota: Fix infinite loop when parsing quota parameters Broken by previous quota changes.

Whitespace cleanup

quota root default init changed to use common param parse function

common quota parameter parsing function implemented

quota: Add imapc backend This allows using imapc storage with imapc quota. The quota acts as read-only, so it's used only when the current quota usage is explicitly asked. The quota can be looked up using either a mailbox name or quota root name. By default INBOX's quota is looked up. If there are multiple quota roots returned for the mailbox, only the first quota root returned by the QUOTAROOT reply is used.

quota: Fix namespace deduplication when mailboxes don't have paths. Nothing requires a mailbox path for quota backends, especially imapc. Still do namespace deduplication based on alias_for settings.

quota, acl: Use mail_user_plugin_getenv_bool() for boolean settings These were forgotten earlier.

quota: Add backend register/unregister This way, other mail plugins can register their own quota backends.

global: Log internal storage error on failure

quota: Use mail_user_plugin_getenv_bool to get quota_vsizes

quota: Add quota_max_mail_size setting

quota: Use quota_alloc_result in quota_settings.test_alloc

quota: Introduce quota_alloc_result return type

quota: Log why quota_over_flag check is skipped if mail_debug=yes

quota: If quota_over_script is unset, skip the quota_over check.

quota: If quota_over_flag_value is unset, skip the quota_over check.

quota: Remove quota_over_flag_* from quota_root. They are used only in one specific location and don't need to be stored permanently.

quota: Make sure quota_warning doesn't wrap "quota before" value. This could happen in some race conditions (and with bugs).

quota: When executing quota_warning/over_flag script, log the reason why.

Updated copyright notices to include the year 2017.

global: Replaced all instances of memset(p, 0, sizeof(*p)) with the new i_zero() macro. Used the following script: C_FILES=`git ls-files *.c` H_FILES=`git ls-files *.h` for F in "$C_FILES $H_FILES"; do echo "$F" perl -p -i -e 's/safe_memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero_safe(&$1)/g' $F perl -p -i -e 's/safe_memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero_safe($1)/g' $F perl -p -i -e 's/memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero(&$1)/g' $F perl -p -i -e 's/memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero($1)/g' $F done

quota: Use program-client for quota-warning scripts

quota: Don't execute quota_over_script if userdb lookup was over 10 secs ago

quota: If quota lookup updates vsize header, lock it earlier to avoid a deadlock.

quota: Fixed handling when mail size lookup fails due to mail already being expunged. We don't want to fail it as a quota allocation failure, but just pass through the "mail is expunged" error to the original caller.

quota: Don't get message sizes when updating mailbox that ignores quotas. Nothing is done with the size anyway.

quota: Log an error if mail's size can't be read. We were still logging "Internal quota calculation error" but not necessarily any other reason.

global: Use only explicit int -> bool conversions These were checked with a patched clang.

quota: Differentiate between forced and non-forced quota recalc The "count" backend doesn't need to recalc quota unless an explicit "doveadm quota recalc" command is called.

quota: Skip reading mail sizes when quota backend doesn't need it. If quota backend is updating the quota internally, it's just going to ignore the looked up size. The only reason for looking up the sizes is to check with quota_try_alloc() whether user is going over quota.

lib-dict: dict_transaction_commit*() returns now error string

lib-dict: Renamed dict_init_full() to dict_init()

quota: Added quota_over_flag_lazy_check flag. By default the quota_over_flag is checked immediately at startup. With this option the check is done only at a time when the quota is anyway being read.

quota: Cleanup - split quota_over_flag to init & run parts In preparation for the next change.

quota: Fixed debug logging for quota_over_flag

quota: Fixed quota_over_flag handling when quota usage==limit It couldn't really work correctly otherwise. If we've reached the quota, we want to start rejecting new mails.

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

quota: Avoid crash in quota_root_iter_init() if mailbox has no quota enabled. This allows quota_get_mail_user_quota() to be called even when quota doesn't exist. Cleaned up all the code using it to now check for the NULL result. This fixes a crash in quota_clone plugin.

Remove now-unnecessary direct stdlib.h #includes.

quota: Make sure the limit return value is initialized when quota_get_resource() returns 0 Later on a debug log message in quota_over_flag_check_root() was accessing the limit, which wasn't necessarily initialized. Also initialized value return value just as well to be safe.

quota: Added "count" backend, which simply sums up mailboxes' vsizes. In a way this is similar to the simple "dirsize" backend, but much more efficient. As long as mailbox_list_index=yes, the quota can typically be looked up only by reading the dovecot.list.index* files. This backend enforces using quota_vsizes=yes setting to keep the performance good, because physical sizes don't have a similar optimized vsize header. There's also no especially good reason why this backend should support physical sizes - they were originally mainly used to allow quickly stat()ing Maildir files.

quota: Added quota_vsizes=yes setting to count quotas using virtual sizes instead of physical sizes. This doesn't work with all the quota backends.

quota: Code cleanup - extract default init() handling to quota_root_default_init()

quota: Don't assume mail is too large if a quota root has mail count limit but not size limit. Based on patch by Alexei Gradinari

quota: Added debug information for quota_over_flag handling.

quota: When reporting quota value/limit in kilobytes, round the value upwards. Most importantly this doesn't truncate <1024 values to 0, which also in quota limit means unlimited.

quota: If overquota-flag in userdb is wrong, execute a configured script. The idea here is that a quota_warning script could set user's overquota-flag to e.g. LDAP where MTA could reject mails already at RCPT TO stage. The quota_warning scripts however have race conditions that are difficult (or impossible) to fix, so sometimes the overquota-flag could become wrong and might require manual intervention to fix it. This feature is supposed to solve the issue by comparing the overquota-flag's status to the actual current quota usage and execute a script to fix up the situation if needed. This script is of course racy as well, but there's always the next login that can fix the situation. Also it's pretty rare that user's quota is jumping just around the limit. The overquota-flag name in userdb must be "quota_over_flag". There are two settings to configure what to do: plugin { # If quota_over_flag=TRUE, the overquota-flag is enabled. Otherwise not. quota_over_flag_value = TRUE # Any non-empty value for quota_over_flag means user is over quota. # Wildcards can be used in a generic way, e.g. "*yes" or "*TRUE*" #quota_over_flag_value = * # Service script to execute if overquota-flag is wrong. Configured the # same as quota_warning scripts. The current quota_over_flag's value is # appended as the last parameter. quota_over_script = quota-warning mismatch %u }

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

quota: Added "hidden" option to hide the quota root from IMAP GETQUOTAROOT command.

quota: Quota recalculation didn't include INBOX in some configurations. If one inbox=yes and another inbox=no namespace shared the same mail location, and the inbox=no namespace was first, only it was used to list all mailboxes.

Replaced dict_init() with dict_init_full() in various places.

quota: Moved some functions to quota-util.c

Updated copyright notices to include year 2014.

quota-status: Allow mail to go over quota up to quota_grace.

quota: Fix to previous wildcard change

quota: Allow mailbox names in quota_rules to contain "*" and "?" wildcards.

quota: Added support for SETQUOTA IMAP command. The configuration is done via quota_set setting. Currently only dict backend is supported. For example: plugin { quota_set = dict:file:/var/lib/dovecot/quota/%u } The SETQUOTA command is available only for the "admin" user (userdb lookup must return admin=y).

quota: Improved init() failure error logging.

quota: Fixed quota_rule with non-uppercase INBOX.

Removed ambiguous mail_user.admin flag. dsync shouldn't sync mailboxes without +r ACL.

quota: dsync shouldn't trigger quota warnings They would probably just be duplicates that were already triggered by the other replica.

quota: Added more debug logs about quota_grace

maildir++ quota: Fixed relative quota_grace when taking limit from maildirsize file

Replaced all -1U and (unsigned int)-1 with UINT_MAX. It's somewhat clearer this way. Also clang's -fsanitize=integer gives runtime errors about -1U (but not about explicit casts, so no need to change (type)-1 casts).

Renamed quota_last_extra to quota_grace.

quota: Use quota_last_extra only for LDA/LMTP (not for IMAP).

quota: Added quota_last_extra setting, which defaults to 10% This can be used to save the last message when user is almost over quota. So by default the last message can bring the quota over 10% of the total quota limit. The setting allows also explicit values. Setting it to 0 brings it back to previous behavior.

Oops :) Update copyrights to 2013 without breaking all .c files.