quota: Warn when quota check is blocked by background quota calculation This was previously double logged as "Quota transaction has failed earlier" error.

quota: Remove "Failed to set quota transaction limits" error This error adds nothing that helps the user to debug a problem.

lib-storage: Rename .vsize.lock file to dovecot-vsize.lock .vsize.lock can break maildir++ because it looks like a maildir folder, so rename it to dovecot-vsize.lock. Introduced in 9963bef6

quota: Add and use QUOTA_USER_CONTEXT_REQUIRE Satisfies static analyzers

quota: Contexts are now required or checked Satisfied static analyzers

Updated copyright notices to include the year 2018.

global: Use mail_set_critical() and mailbox_set_critical() if possible Replace calls to mail_storage_set_critical() with mail_set_critical() or mailbox_set_critical() in places where mailbox or mail are easily available.

quota: Take mailbox as parameter in quota_set_storage_error() This is to start using mailbox_set_critical() later.

quota: Add QUOTA_GET_RESULT_BACKGROUND_CALC enum value

quota: Add QUOTA_ALLOC_RESULT_BACKGROUND_CALC enum value

quota: Add error_result_r parameter to quota_transaction_set_limits()

quota: Improve error messages

quota: Add error_r to quota_transaction_set_limits()

quota: Add error string to quota_set_storage_error()

quota: Add error_r to quota_settings->test_alloc()

lib-storage: Add reason to mailbox.transaction_begin()

lib-storage: Add reason to mailbox_transaction_begin() Remove mailbox_transaction_set_reason().

quota: Fix negative quota_warnings with count backend For example this never triggered: quota_warning = -messages=100%% quota-warning %u -100 The change to quota_alloc() to update the count_used doesn't seem to actually fix anything right now, but it makes the code more correct.

global: Add mailbox_transaction_set_reason() calls Added to the most important places.

quota: Add quota_max_mail_size setting

quota: Introduce quota_alloc_result return type

quota: Don't log "Internal quota calculation error" It's not very informative and we can't give a better error message without changing the APIs. The real error should have been logged already anyway, so this is just duplication of an error. I think originally this was added because some backend forgot to log an error.

plugins: Remove unnecessary mail_save_context.dest_mail==NULL checks It can never be NULL after the previous change: "lib-storage: Always create mail_save_context.dest_mail".

Updated copyright notices to include the year 2017.

quota: Don't skip quota checks when moving mails between different quota roots.

quota: If quota lookup updates vsize header, lock it earlier to avoid a deadlock.

global: unsigned int:1 -> bool:1 perl -i -pe 's/unsigned int ([^,:;]+):1;/bool $1:1;/' **/*.[ch]

quota: Differentiate between forced and non-forced quota recalc The "count" backend doesn't need to recalc quota unless an explicit "doveadm quota recalc" command is called.

quota: Skip reading mail sizes when quota backend doesn't need it. If quota backend is updating the quota internally, it's just going to ignore the looked up size. The only reason for looking up the sizes is to check with quota_try_alloc() whether user is going over quota.

lib-storage: Added MAILBOX_FLAG_DELETE_UNSAFE

quota: Fix to earlier commit 62f2f6baf expunge_uids may become empty with prev_idx > 0

quota: Added quota_over_flag_lazy_check flag. By default the quota_over_flag is checked immediately at startup. With this option the check is done only at a time when the quota is anyway being read.

quota: Cleanup - split quota_over_flag to init & run parts In preparation for the next change.

quota: Optimize handling a large number of expunges. This assumes that the mail_expunge() was called in the same order as sync_notify(), which practically means that they were both done in ascending uid order. This is usually true.

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

quota: Avoid crash in quota_root_iter_init() if mailbox has no quota enabled. This allows quota_get_mail_user_quota() to be called even when quota doesn't exist. Cleaned up all the code using it to now check for the NULL result. This fixes a crash in quota_clone plugin.

lib-storage: Update mailbox vsize header on save/copy/expunge. This allows always efficiently looking up maiboxes' vsizes after they're initially calculated. The expunge handling is unfortunately done currently in quota handling code, so it works only if quota is enabled. Ideally this would be solved in v2.3 with some lib-storage core changes.

quota: Added quota_vsizes=yes setting to count quotas using virtual sizes instead of physical sizes. This doesn't work with all the quota backends.

quota: Commit expunge transaction instead of rolling back. This likely won't make much of a difference, since it should have accessed only expunged mails. But it's a bit cleaner this way.

quota: If overquota-flag in userdb is wrong, execute a configured script. The idea here is that a quota_warning script could set user's overquota-flag to e.g. LDAP where MTA could reject mails already at RCPT TO stage. The quota_warning scripts however have race conditions that are difficult (or impossible) to fix, so sometimes the overquota-flag could become wrong and might require manual intervention to fix it. This feature is supposed to solve the issue by comparing the overquota-flag's status to the actual current quota usage and execute a script to fix up the situation if needed. This script is of course racy as well, but there's always the next login that can fix the situation. Also it's pretty rare that user's quota is jumping just around the limit. The overquota-flag name in userdb must be "quota_over_flag". There are two settings to configure what to do: plugin { # If quota_over_flag=TRUE, the overquota-flag is enabled. Otherwise not. quota_over_flag_value = TRUE # Any non-empty value for quota_over_flag means user is over quota. # Wildcards can be used in a generic way, e.g. "*yes" or "*TRUE*" #quota_over_flag_value = * # Service script to execute if overquota-flag is wrong. Configured the # same as quota_warning scripts. The current quota_over_flag's value is # appended as the last parameter. quota_over_script = quota-warning mismatch %u }

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

Handle "out of disk space" and "out of user quota" as separate cases. "Out of disk space" is a temporary error that should be logged as error and the failure should be sent to user as "Internal server error". Obsolete the use of MAIL_ERROR_NOSPACE and MAIL_ERRSTR_NO_SPACE. Use the clearer MAIL_ERROR_NOQUOTA and MAIL_ERRSTR_NO_QUOTA instead.

Updated copyright notices to include year 2014.

quota: Allow mailbox names in quota_rules to contain "*" and "?" wildcards.

quota: Don't log errors about missing namespaces for autocreated shared mail_users.

quota: dsync shouldn't trigger quota warnings They would probably just be duplicates that were already triggered by the other replica.

quota: Added quota_last_extra setting, which defaults to 10% This can be used to save the last message when user is almost over quota. So by default the last message can bring the quota over 10% of the total quota limit. The setting allows also explicit values. Setting it to 0 brings it back to previous behavior.

Oops :) Update copyrights to 2013 without breaking all .c files.

Updated copyright notices to include year 2013.