lib: cast {,CONST_}PTR_OFFSET's offset argument to size_t This fixes build on 32-bit systems where the addition may cause integer promotion to an integer type larger than uintptr_t. gcc 6.3.0 warning: file-cache.c: In function 'file_cache_write': macros.h:25:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ((void *) (((uintptr_t) (ptr)) + (offset)))

lib: Use uintptr_t in PTR_OFFSET and POINTER_CAST Use uintptr_t instead of pointers. Fixes clang 6.0 warning: arithmetic on a null pointer treated as a cast from integer to pointer is a GNU extension

lib: move i_fd_close*() to fd-util.[ch]

lib: introduce i_close_fd_path() It is like i_close_fd() but takes an argument with the name of the file that's being closed. The name is only used when printing the error message due to a failed close() syscall.

lib: improve i_close_fd() error message In addition to printing the file and line number, we can print the actual arg passed in as well as the function calling i_close_fd().

lib: print correct error string on i_close_fd() failure close_keep_errno() preserved the original errno, therefore the %m in i_close_fd()'s error message printed an unrelated error string.

lib: Define i_unreached() to __builtin_unreachable() with STATIC_CHECKER This helps clang's alpha.deadcode.UnreachableCode checker.

lib: i_close_fd(-1) should be a no-op

lib: introduce container_of This is a simple but type safe implementation.

lib: Fix compiler warning about mixing boolean with multiplication

lib, lib-storage: Move INOTIFY_ST_CHANGED to ST_CHANGED in lib Allows reusing this elsewhere

lib: Add a common HAVE_TYPE_CHECKS I'm not sure if it should be checking gcc >= 3.0 or 3.3, but they're all old so doesn't really matter. The __cplusplus check was added to both, since it wouldn't have done anything anyway as COMPILE_ERROR_IF_TRUE() is 0 for __cplusplus.

lib: Created i_zero() wrapper for memset(p, 0, sizeof(*p)). Also creates an i_zero_safe() version for safe_memset().

lib/macros.h - protect old compilers from use of modern features no_sanitize(integer) is not in 3.5 (debian stable's version), but is documented in 3.9. Exactly when it appeared isn't immediately obvious. Signed-off-by: Phil Carmody <phil@dovecot.fi>

lib: Add ATTR_UNSIGNED_WRAPS for disabling clang -fsanitize=integer

lib: Assert-crash in i_close_fd() if fd == 0 lib-master now guarantees that fd==0 doesn't normally happen.

use __func__ instead of __FUNCTION__ __FUNCTION__ is a non-standard extension while __func__ is C99.

lib: Fix to compiling STATIC_ARRAY in C++ code

configure: Check if C99 "static" keyword is supported for array sizes.

lib: define FALSE to be (!1) This allows the patched clang to treat FALSE as a boolean expression.

global: Require comparisons to be strict boolean expressions * No implicit integer -> boolean or pointer -> boolean conversions * !expr can be used only if expr is boolean type These were checked with a patched clang. It found various actual bugs, which were fixed by the previous commits.

[LEN] to [static LEN] on some function parameters Also add STATIC_ARRAY macro to hide it in c++ compilation.

lib: Avoid typeof() if HAVE_TYPEOF isn't set, even if gcc version is high enough. This is mainly to test that we can compile without typeof().

lib: Added fd=-1 assert to i_close_fd() macro. This way we'll see clearly where it fails, instead of just seeing assert in close_keep_errno() without an easy way to see where it crashed.

lib: Use __attribute__((returns_nonnull)) for the common memory/string functions. Also added a couple of missing ATTR_MALLOCs.

lib: Fix MEM_ALIGN to cope with huge allocations Attempting to allocate 2^32+1 bytes will look like it succeeds, as MEM_ALIGN will set alloc_size = 8. The caller will then think it's got 4 gig to play with. e.g. t_malloc0 will wipe vast areas of memory before segfaulting, which might include useful information we'd like in a corefile. Signed-off-by: Phil Carmody <phil@dovecot.fi>

i_close_fd() didn't handle errors correctly with gcc.

Fixed compiling with gcc v3.3 and older. Perhaps the check needs to be also for somewhat newer versions?..

Reverted the recent hash.h changes. Instead use -Wno-duplicate-decl-specifier with clang. The modified version required hash table users to know the structs' contents, which isn't otherwise necessary.

Fixed "duplicate const" warnings with new clang.

Use proper HAVE_TYPEOF check instead of checking with gcc versions.

Removed CONTEXT_TYPE_SAFETY macro and reimplemented its functionality better. gcc/clang now gives a compiler error in many places if callback isn't exactly what was expected. It's also now much easier to add more of these checks.

Hash table API is now (mostly) type safe.

Changed i_close_fd() API to set the fd to -1 after closing.

Replaced (void)close(fd) and close_keep_errno() with i_close_fd(). i_close_fd() preserves the errno and logs an error if the close() fails.

Added ATTR_NOWARN_UNUSED_RESULT, which expands to nowarn_unused_result attribute if supported. Requires a patched clang.

Marked functions parameters that are allowed to be NULL. Some APIs were also changed. The non-obvious APIs where NULL parameter was changed to "" are master_service_init() and auth_master_user_list_init(). These checks can currently be enabled only on a patched clang: http://llvm.org/bugs/show_bug.cgi?id=6786

Added t_strflocaltime().

Add DOVECOT_PREREQ to src/lib/macros.h - convenience macro to test the version of dovecot

Removed unused BITS_IN_UINT and CLAMP macros.

Unexpand BITS_IN_SIZE_T in the only place it's used and remove the macro.

Moved a global NVL() macro to the few places in lib-imap where it was actually used.

Added CONST_STRUCT_MEMBER_P() and removed unused (broken) STRUCT_MEMBER(). --HG-- branch : HEAD

Asserts now use __FUNCTION__ instead of __PRETTY_FUNCTION__. With gcc these had the same output, but clang's __PRETTY_FUNCTION__ returns a larger output that's not useful. --HG-- branch : HEAD

Removed unused GNUC_FUNCTION* macros. --HG-- branch : HEAD

Added CONTEXT_CALLBACK2() helper macro. --HG-- branch : HEAD

Removed MEMBER() macro. Require C99 style struct initializer. --HG-- branch : HEAD

Added ATTR_HOT and ATTR_COLD macros. Use them in a couple of places. --HG-- branch : HEAD

Added ATTR_PURE macro, which expands to pure attribute if available. --HG-- branch : HEAD

MEMBER(): Don't try to use the C99 "." feature with HP-UX. --HG-- branch : HEAD

Use malloc attribute, __builtin_expect() and __builtin_types_compatible_p() only with new enough gccs. Patch by Sven Anderson. --HG-- branch : HEAD

unlikely() and likely() were broken with non-gcc. --HG-- branch : HEAD

Added likely() and unlikely() macros. Use unlikely() with asserts. --HG-- branch : HEAD

Renamed __attr_*__ to ATTR_*. Renamed __attrs_used__ to ATTRS_DEFINED. --HG-- branch : HEAD

Changed .h ifdef/defines to use <NAME>_H format. --HG-- branch : HEAD

Added N_ELEMENTS() macro. --HG-- branch : HEAD

Added missing __attr_*__ macros for non-GCC compilers. --HG-- branch : HEAD

Added HAVE_TYPEOF, COMPILE_ERROR_IF_TRUE() and COMPILE_ERROR_IF_TYPES_NOT_COMPATIBLE() macros. --HG-- branch : HEAD

warn_unused_result attribute exists only with gcc 4.0 and later. --HG-- branch : HEAD

Type safe callbacks weren't as easy as I thought. Only callback(void *context) can be handled generically. Others can be handled specially, but only if all the parameters are pointers, otherwise eg. int parameter can be replaced with long without compiler giving any warnings. --HG-- branch : HEAD

Added context parameter type safety checks for most callback APIs. --HG-- branch : HEAD

Define __attrs_used__ if the compiler actually supports attributes. --HG-- branch : HEAD

Use malloc attribute for the most commonly used memory and string allocation functions. Use warn_unused_result attribute for reallocs. --HG-- branch : HEAD

Added sentinel GCC attribute to *_strconcat() functions. Added format printf-attribute to vprintf-type functions. --HG-- branch : HEAD

i_unreached(): show also file and line number in error message --HG-- branch : HEAD

importing new index code. mbox still broken. --HG-- branch : HEAD

Added __attr_scanf__ --HG-- branch : HEAD

Removed STRUCT_OFFSET, offsetof() is ANSI-C for the same purpose. Added MEMBER() macro to define C99-style struct labels. --HG-- branch : HEAD

No i_memmove here, just memmove. --HG-- branch : HEAD

Naming style changes, finally got tired of most of the typedefs. Also the previous enum -> macro change reverted so that we don't use the highest bit anymore, that's incompatible with old indexes so they will be rebuilt. --HG-- branch : HEAD

If PEDANTIC is defined, don't use (void)(..) with STMT_START/END. --HG-- branch : HEAD

We weren't using va_list properly, especially gcc/PowerPC didn't like it. --HG-- branch : HEAD

Several minor fixes: signess, casting away const, missing static, etc. --HG-- branch : HEAD

Added --enable-asserts (default) and fixed some warnings when building without. Added i_unreached() to indicate supposedly unreachable code block and changed a existing i_assert(0) calls to it. Removed return_if_fail() and return_val_if_fail() macros, they're not useful. --HG-- branch : HEAD

Replaced INT_TO_POINTER and POINTER_TO_INT macros with POINTER_CAST and POINTER_CAST_TO macros, the CAST_TO takes a parameter to which type we're casting to. Also POINTER_CAST should be valid ANSI-C now. --HG-- branch : HEAD

more size_t fixes. --HG-- branch : HEAD

nearest_power() uses now size_t. --HG-- branch : HEAD

Better fix for POINTER_TO_UINT --HG-- branch : HEAD

POINTER_TO_UINT() fixed to not give warnings with 64bit pointers. --HG-- branch : HEAD

Initial revision --HG-- branch : HEAD