Updated copyright notices to include the year 2018.

global: Use t_buffer_create sed -i -e 's/buffer_create_dynamic(pool_datastack_create(), */t_buffer_create(/g'

mbox: Add assert to make static analyzer happier

global: Replace o_stream_nfinish() with o_stream_flush()

global: start relying on [io]_stream_destroy(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - i_stream_destroy(&E); - } + i_stream_destroy(&E); @@ expression E; @@ - if (E != NULL) { - o_stream_destroy(&E); - } + o_stream_destroy(&E);

lib-storage: convert missed mbox casts to container_of

global: Replace random_fill_weak with random_fill They are now the same thing

lib-storage: convert mbox to use container_of

lib-storage: Move backend code to a common index_storage_save_abort_last()

lib-storage: Remove unnecessary mail_save_context.dest_mail==NULL checks It can never be NULL after the previous change: "lib-storage: Always create mail_save_context.dest_mail". The code removal in maildir_transaction_save_commit_pre() seemed potentially dangerous, but I don't think such code path is possible anymore. Also even if it is, it's probably fine since the mail_free() is called even earlier than before (although that itself might have been a problem). This also removes last traces of code that made it possible to save mails to mbox without assigning UID to the mail. The previous commit already caused this, so this is just removing dead code.

global: Add asserts to make static analyzer happier.

Updated copyright notices to include the year 2017.

global: Replaced all instances of memset(p, 0, sizeof(*p)) with the new i_zero() macro. Used the following script: C_FILES=`git ls-files *.c` H_FILES=`git ls-files *.h` for F in "$C_FILES $H_FILES"; do echo "$F" perl -p -i -e 's/safe_memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero_safe(&$1)/g' $F perl -p -i -e 's/safe_memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero_safe($1)/g' $F perl -p -i -e 's/memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero(&$1)/g' $F perl -p -i -e 's/memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero($1)/g' $F done

global: Make sure i_stream_read() calls handle 0 and -2 return values correctly.

global: Require comparisons to be strict boolean expressions * No implicit integer -> boolean or pointer -> boolean conversions * !expr can be used only if expr is boolean type These were checked with a patched clang. It found various actual bugs, which were fixed by the previous commits.

global: unsigned int:1 -> bool:1 perl -i -pe 's/unsigned int ([^,:;]+):1;/bool $1:1;/' **/*.[ch]

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

Remove now-unnecessary direct stdlib.h #includes.

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

Use i_stream_get_error() wherever possible instead of %m

mbox: istream-tee wasn't being used as expected with the new changes, causing crashes/hangs. After wondering about this for a while I decided this was the only fully reliable way of doing this. Although it would have been possible to change the istream-tee code to support this: child1 and child2 are tee-istream children: - i_stream_read(child1) - i_stream_read(child2) - i_stream_get_data(child1) Because reading from the parent istream-tee updates all of its childrens' buffer, there's no big problem (other than access_counter currently messing up). But if one of the children weren't a direct child of tee-istream, but there was a wrapper istream, the wrapper's buffer wouldn't have been updated by the istream-tee read. So rather than spending time figuring out to fix the access_counter it's probably better to have it clearly fail as the use case can't be fully safe anyway.

Added various asserts to try to silence Coverity false positives.

Updated copyright notices to include year 2014.

mbox: Previous change broke index updates to successful saves.

mbox: Fixed committing transaction after a previous save had failed.

mbox: If save's input stream fails, fail saving instead of ignoring the error.

Oops :) Update copyrights to 2013 without breaking all .c files.

Updated copyright notices to include year 2013.