Updated copyright notices to include the year 2018.

global: Use mail_set_critical() and mailbox_set_critical() if possible Replace calls to mail_storage_set_critical() with mail_set_critical() or mailbox_set_critical() in places where mailbox or mail are easily available.

global: Replace o_stream_nfinish() with o_stream_finish() whenever possible

lib-storage: convert index to use container_of

lib-storage: convert missed maildir casts to container_of

lib-storage: convert maildir to use container_of

lib-storage: Move backend code to a common index_storage_save_abort_last()

lib-storage: Remove unnecessary mail_save_context.dest_mail==NULL checks It can never be NULL after the previous change: "lib-storage: Always create mail_save_context.dest_mail". The code removal in maildir_transaction_save_commit_pre() seemed potentially dangerous, but I don't think such code path is possible anymore. Also even if it is, it's probably fine since the mail_free() is called even earlier than before (although that itself might have been a problem). This also removes last traces of code that made it possible to save mails to mbox without assigning UID to the mail. The previous commit already caused this, so this is just removing dead code.

Updated copyright notices to include the year 2017.

global: Make sure *_malloc() calculations won't cause integer overflows.

global: Change string position/length from unsigned int to size_t Mainly to avoid truncating >4GB strings, which might potentially cause some security holes. Normally there are other limits, which prevent such excessive strings from being created in the first place. I'm sure this didn't find everything. Maybe everything could be found with compiler warnings. -Wconversion kind of does it, but it gives way too many unnecessary warnings. These were mainly found with: grep " = strlen" egrep "unsigned int.*(size|len)"

lib-storage: remove mailbox-recent-flags.h from index-storage.h

global: unsigned int:1 -> bool:1 perl -i -pe 's/unsigned int ([^,:;]+):1;/bool $1:1;/' **/*.[ch]

lib: Removed ostream.last_failed_errno It's been identical to ostream.stream_errno for a while now.

global: Use [io]_stream_get_error() insted of %m

lib-storage: Moved common code to index_storage_save_continue()

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

Remove now-unnecessary direct stdlib.h #includes.

lib-storage: Replaced some unlink()s with i_unlink*()s where we could. This changes some mail_storage_set_critical() calls to i_error()s, but because these unlink() failures don't actually fail the operation it doesn't matter.

Replaced unlink() calls with i_unlink*() wherever possible.

lib-storage: Moved most of the \Recent flag handling code to mailbox-recent-flags.c There are also some API changes, because functions were renamed and the recent_* fields were moved to struct mailbox. I'm not aware of any plugins using these though, except for index_mailbox_set_recent_seq() which for now is kept as a backwards compatibility macro. No changes were made to the actual code logic.

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

Handle "out of disk space" and "out of user quota" as separate cases. "Out of disk space" is a temporary error that should be logged as error and the failure should be sent to user as "Internal server error". Obsolete the use of MAIL_ERROR_NOSPACE and MAIL_ERRSTR_NO_SPACE. Use the clearer MAIL_ERROR_NOQUOTA and MAIL_ERRSTR_NO_QUOTA instead.

treewide - use of explicit NULL in pointer comparisons rather than 0-alikes Found by sparse.

maildir: Make sure the filename contains S=size and W=size even if GUID doesn't.

maildir: Make sure we don't replace correct mail sizes with broken ones when preserving GUID.

maildir: If GUID can't be preserved in filename due to size change, set it in dovecot-uidlist This fixes problems with dsync when zlib is used and filenames/GUIDs don't contain (correct) S=sizes.

maildir: Fixed looking up physical size for a mail while it's being saved. Based on patch by Teemu Huovila.

Updated copyright notices to include year 2014.

maildir: Don't try to preserve old filename when saving if uidlist couldn't be locked.

Oops :) Update copyrights to 2013 without breaking all .c files.

Updated copyright notices to include year 2013.