Updated copyright notices to include the year 2018.

lib-index: Add mail_index.event

lib-storage: Add mailbox.event

global: Use mail_set_critical() and mailbox_set_critical() if possible Replace calls to mail_storage_set_critical() with mail_set_critical() or mailbox_set_critical() in places where mailbox or mail are easily available.

global: Use t_buffer_create sed -i -e 's/buffer_create_dynamic(pool_datastack_create(), */t_buffer_create(/g'

lib-storage: Add INDEXCACHE=<path> to mail_location This allows configuring a different directory for dovecot.index.cache files than the rest of the index files.

lib-storage: When copying mails, copy also empty cache fields This mainly means that it copies cache fields for nonexistent message headers. Those are still important, because otherwise Dovecot doesn't know whether they exist or not.

global: Fix spelling mistakes in comments Original work by @andreasschulze and @jsoref

lib-storage: Add settings to configure lib-index optimization parameters The defaults are expected to be pretty good, but these settings make it easier to test whether other values might be more optimal.

lib-storage: Add reason to mailbox_transaction_begin() Remove mailbox_transaction_set_reason().

global: start relying on [io]_stream_unref(NULL) being a no-op Cleanup performed with the following semantic patch: @@ expression E; @@ - if (E != NULL) { - i_stream_unref(&E); - } + i_stream_unref(&E); @@ expression E; @@ - if (E != NULL) { - o_stream_unref(&E); - } + o_stream_unref(&E);

lib-storage: convert index to use container_of

lib-storage: Add setting to disable \NoSelect mailboxes Enabled using mail_location = ...:NO-NOSELECT Trying to create \NoSelect "dir/" will result just creating "dir", similar to how Maildir++ layout already did it. Deleting a mailbox will delete all of its \NoSelect parents.

sdbox: Create missing mail directory on resync if index directory exists This problem should be visible only with ITERINDEX enabled.

lib-index, lib-storage: Add mail_index_header.last_temp_file_scan Also add index_mailbox_update_last_temp_file_scan() for easily updating it. This is reusing an old "sync timestamp" field. Because it was a timestamp, it doesn't matter if the old data still exists in it. This field could have been added as an extension, but that's more work and this feature is generic enough that it should be useful for many of the mail storage backends.

lib-storage: Add mail_location=..:ITERINDEX This changes mailbox list iteration to work using INDEX directory instead of the normal mail directory. This can be helpful when the indexes are stored on a faster storage.

lib-storage: Don't autocreate mailbox during deletion. Trying to delete a nonexistent autocreated mailbox first created it and then immediately deleted it.

lib-storage: When save is aborted, close dest_mail without crashing Fixes: Panic: file mail-index-transaction-update.c: line 1023 (mail_index_update_ext): assertion failed: (seq > 0 && (seq <= mail_index_view_get_messages_count(t->view) || seq <= t->last_new_seq)) Because cache was still attempted to be updated, but the mail was already expunged from index.

lib-storage: Move backend code to a common index_storage_save_abort_last()

lib-storage: Remove unnecessary mail_save_context.dest_mail==NULL checks It can never be NULL after the previous change: "lib-storage: Always create mail_save_context.dest_mail". The code removal in maildir_transaction_save_commit_pre() seemed potentially dangerous, but I don't think such code path is possible anymore. Also even if it is, it's probably fine since the mail_free() is called even earlier than before (although that itself might have been a problem). This also removes last traces of code that made it possible to save mails to mbox without assigning UID to the mail. The previous commit already caused this, so this is just removing dead code.

lib-storage: Set vsize extension when copying mails.

lib-storage: Move index_mail.vsize_ext_id to mailbox.mail_vsize_ext_id It's mailbox-specific, so it doesn't have to be looked up every time. Also this is needed for the following fix.

index-storage: Update mailbox last_rename_stamp on rename

Updated copyright notices to include the year 2017.

global: Replaced all instances of memset(p, 0, sizeof(*p)) with the new i_zero() macro. Used the following script: C_FILES=`git ls-files *.c` H_FILES=`git ls-files *.h` for F in "$C_FILES $H_FILES"; do echo "$F" perl -p -i -e 's/safe_memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero_safe(&$1)/g' $F perl -p -i -e 's/safe_memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero_safe($1)/g' $F perl -p -i -e 's/memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero(&$1)/g' $F perl -p -i -e 's/memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero($1)/g' $F done

LAYOUT=index: Update mailbox name to mailbox index's header when opening. This way if the mailbox list index gets lost, a recent mailbox name is still available.

lib-storage: Fixed potential .vsize.lock deadlock.

lib-index: If mail_debug=yes, log cache compressions.

lib-storage: mbox_min_index_size setting didn't work correctly.

lib-storage: Fixed mailbox_delete_empty() error message when mails exist

dbox: Optimize POP3 MAIL_FETCH_UIDL_BACKEND. We keep track of the highest UID known to have POP3 UIDL in index's header. If saving adds a newer message, it'll also update the header. When fetching UIDL_BACKEND, we can need to check only mails with lower UIDs. There are some race conditions here, but normally UIDLs are set only once during migration so it shouldn't matter.

o_stream_send_istream() API changed again The new API enforces the caller to correctly handle all the possible situations. It also makes in unambiguous whether to wait for input or output stream.

lib-storage: Fixed istream error handling while saving mails. We might have logged them as write errors, or we might have ignored the error if i_stream_read() failed. Now the behavior is consistent.

lib-storage: Moved common code to index_storage_save_continue()

lib-dict: Changed dict_wait() to return void. If it encounters any failures, it should just make sure to abort any pending async requests before returning.

lib-storage: Don't set internal error to storage when there's nothing to sync. This may also wrongly overwrite an existing error.

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

Remove now-unnecessary direct stdlib.h #includes.

lib-storage: Update mailbox vsize header on save/copy/expunge. This allows always efficiently looking up maiboxes' vsizes after they're initially calculated. The expunge handling is unfortunately done currently in quota handling code, so it works only if quota is enabled. Ideally this would be solved in v2.3 with some lib-storage core changes.

lib-storage: Mailbox deletion shouldn't fail when trying to delete read-only attributes.

lib-storage: Another fix to using index_storage_mailbox_close() without an opened view. Calling mail_index_close() without mail_index_open() caused it to assert-crash.

lib-storage: Allow index_storage_mailbox_close() to be called without an opened view. Some failing mailbox_open() call may leave it in such a state.

lib-storage: Moved index/index-mailbox-check.c code to mailbox-watch.c This changes the API, but adds backwards compatibility macros.

lib-storage: Moved most of the \Recent flag handling code to mailbox-recent-flags.c There are also some API changes, because functions were renamed and the recent_* fields were moved to struct mailbox. I'm not aware of any plugins using these though, except for index_mailbox_set_recent_seq() which for now is kept as a backwards compatibility macro. No changes were made to the actual code logic.

lib-storage: Moved vsize_hdr_ext_id to struct mailbox for more global access.

lib-storage: Renamed struct index_vsize_header to struct mailbox_index_vsize Also moved the struct to mail-storage-private.h for more global access.

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

lib-storage: Fully unreference indexes when deleting mailboxes.

lib-storage: When deleting mailbox, finish the expunges before marking mailbox deleted. This decreases the amount of time the mailbox is visible but not accessible.

lib-storage: Added index_storage_mailbox_delete_pre/post(). This avoids reimplementing the whole index_storage_mailbox_delete() for storage backends that need to do more work in the middle.

lib-storage: mail_never_cache_fields=* means now to disable all caching.

Updated copyright notices to include year 2014.

lib-storage: Don't crash in mailbox_is_inconsistent() if mailbox hasn't been opened.

lib-storage: Added a separate prefix for server metadata that aren't deleted with INBOX.

imapc: Fixed mailbox deletion.

lib-storage: Allow mail_*cache_fields settings to specify any hdr.* fields. Also the fields were previously set only once globally, so if the process served multiple users, it wouldn't have been possible to use per-user values for these fields.

lib-storage: Added mail_always_cache_fields setting.

lib-storage: Set virtual/physical size in dest_mail when copying, if possible. Ideally lib-index would be fixed so this wouldn't be necessary. The lib-index way of fixing it would also be useful for more than just quota plugin.

lib-storage: mailbox_copy() didn't always copy all the cached fields to destination. If the destination mailbox's cache file wasn't already opened, the default cache decisions were used.

lib-storage: Don't reset mail_save_context.copying|moving|copying_via_save too early.

lib-storage: Changed mailbox_attribute_get/set() APIs to have a transaction and update index. The _get() doesn't currently actually use the transaction. It was mainly put there for future use where it could be useful. It's also possible that _iter() will need a transaction also. For now these decisions seem good enough.

lib-storage: Write dovecot.mailbox.log entries using virtual names, not storage names. This file is used only by dsync, and the new dsync design uses only virtual names everywhere. This of course means that now it's not easily possible to use different virtual names for the same user, but nobody really did that before anyway. The only other fully working solution would be to send both the virtual and the storage names in dsync, but that's a bit of a waste.

Replaced all -1U and (unsigned int)-1 with UINT_MAX. It's somewhat clearer this way. Also clang's -fsanitize=integer gives runtime errors about -1U (but not about explicit casts, so no need to change (type)-1 casts).

lib-storage: Reset saving/moving/copying_via_save flag between mail_save_context uses.

lib-storage: Assert-crash if mailbox_save_context isn't properly freed before reusing.

Oops :) Update copyrights to 2013 without breaking all .c files.