Updated copyright notices to include the year 2018.

lib-index: Add mail_index_base_optimization_settings

lib-index: Fix wrong mail_index_modseq_header automatically It happens only on the next sync, although that isn't actually guaranteed to happen. Still, it happens almost always so this should be good enough.

lib-index: Track .log.2 rotation time in index header This avoids unnecessarily stat()ing the file. Also it's a bit better since it's tracking the actual rotation time, not the mtime of what the .log file happened to have at the time of rotation. The initial rotation timestamp is written only to the dovecot.index header without going through dovecot.index.log. This works, because the dovecot.index is written practically always after a log rotation. For the rare cases when it doesn't happen, the dovecot.index.log.2 just gets deleted later after the next log rotation.

lib-index: Add MAIL_INDEX_OPEN_FLAG_NO_DIRTY This way mailbox format backends that don't need dirty flags can use them for other purposes.

Updated copyright notices to include the year 2017.

global: Replaced all instances of memset(p, 0, sizeof(*p)) with the new i_zero() macro. Used the following script: C_FILES=`git ls-files *.c` H_FILES=`git ls-files *.h` for F in "$C_FILES $H_FILES"; do echo "$F" perl -p -i -e 's/safe_memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero_safe(&$1)/g' $F perl -p -i -e 's/safe_memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero_safe($1)/g' $F perl -p -i -e 's/memset\(&\(?([^,]*)\)?,\s*0,\s*sizeof\(\g1\)\)/i_zero(&$1)/g' $F perl -p -i -e 's/memset\(([^,]*),\s*0,\s*sizeof\(\*\g1\)\)/i_zero($1)/g' $F done

lib-index: Fix detecting whether caller synced everything in mailbox. When mailbox_index_sync_begin() was followed by _commit(), without _next()s in the middle actually syncing the mailbox, the tail_offset was updated to indicate that the mailbox was fully synced. Existing code didn't rely on this, so it probably didn't break anything. This code hasn't worked for a long time, because log_view is always read fully to the end in _sync_begin().

global: Require comparisons to be strict boolean expressions * No implicit integer -> boolean or pointer -> boolean conversions * !expr can be used only if expr is boolean type These were checked with a patched clang. It found various actual bugs, which were fixed by the previous commits.

global: unsigned int:1 -> bool:1 perl -i -pe 's/unsigned int ([^,:;]+):1;/bool $1:1;/' **/*.[ch]

lib-index: Added mail_index_sync_set_reason() to improve lock wait log warnings

lib-index: Small improvements to logging the reason for long transaction log lock waits

lib-index: mail_index_sync_next() didn't always return expunges sorted Maildir and mbox formats were using index_sync_changes_read(), which assumed that they were sorted. So some of the intended expunges weren't actually always being done. This mainly affected when expunges were being done simultaneously by multiple processes or by pipelined commands. For example: printf "a select inbox\nb uid move 2 Trash\nc uid move 1 Trash\nd logout\n" | ./imap

global: freshen copyright git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-5]/$1-2016/g;s/ (201[0-5]) Dovecot/ $1-2016 Dovecot/'

lib-index: tail_offset wasn't updated as often as it should have been. ctx->last_tail_offset was being increased for every non-external transaction and at the end we checked if head was larger than it. This logic didn't really make any sense, since non-external transactions specifically were supposed to update the tail_offset.

lib-index: Fixed checking when we want to update dovecot.index This has been broken since 76f576fc28dc. After that dovecot.index was usually updated only when dovecot.index.log was being rotated.

Remove now-unnecessary direct stdlib.h #includes.

lib-index: Added mail_index_sync_have_any_expunges() This can be used to quickly check before mail_index_sync_begin() if there are likely to be any expunges that will be synced.

lib-index: Avoid writing tail offset update to transaction log if it's not necessary. This should avoid extra writes that do nothing but update the tail offset. mdbox's map requires this behavior, so disable it for it. For others it might cause the next sync to read more data unnecessarily, but it should be worth the extra cost of write most of the times.

lib-index: Added reason_r parameter to mail_transaction_log_view_set() This is used to improve some of the error messages about index corruption.

global: freshen copyright Robomatically: git ls-files | xargs perl -p -i -e 's/(\d+)-201[0-4]/$1-2015/g;s/ (201[0-4]) Dovecot/ $1-2015 Dovecot/' Happy 2015 everyone! Signed-off-by: Phil Carmody <phil@dovecot.fi>

lib-index: Added mail_index_sync_no_warning() to prevent "long transaction lock" warnings. Use it with Maildir to prevent double-warning.

lib-index: Include reason string in warnings about keeping transaction log locked for too long.

lib-index: Delay unlocking cache compression until changes to transaction log are committed. This should fix race condition with two processes compressing the file at the same time with same file_seq and becoming confused.

lib-index, lib-storage: Fixed race conditions with deleting mailbox. Now only one process can successfully finish mailbox_mark_index_deleted().

lib-index: Don't update log_file_tail_offset unnecessarily. Update it only if we're already writing to transaction log anyway or if we're required to update the offset because mail_index_sync_commit() has increased it past non-external transactions (this is especially important with mdbox map index).

Updated copyright notices to include year 2014.

lib-index: If error is found from transaction log, update dovecot.index so it won't be read again.

lib-index: Don't unnecessarily update dovecot.index again after log rotation.

Replaced all -1U and (unsigned int)-1 with UINT_MAX. It's somewhat clearer this way. Also clang's -fsanitize=integer gives runtime errors about -1U (but not about explicit casts, so no need to change (type)-1 casts).

lib-index: Added assert.

Oops :) Update copyrights to 2013 without breaking all .c files.

Updated copyright notices to include year 2013.