lib-auth: Remove request after abort Otherwise the request will still stay in hash table and get dereferenced when all requests are aborted causing an attempt to access free'd memory. Found by Apollon Oikonomopoulos <apoikos@debian.org> Broken in 1a29ed2f96da1be22fa5a4d96c7583aa81b8b060

lib-auth: Require being connected before adding requests

lib-auth: Prevent double-disconnect When disconnecting, it's possible that disconnect gets called twice by some callback, so protect it with a boolean. Fixes Panic: file hash.c: line 152 (hash_table_clear): assertion failed: (table->frozen == 0)

global: unsigned int:1 -> bool:1 perl -i -pe 's/unsigned int ([^,:;]+):1;/bool $1:1;/' **/*.[ch]

Reverted "support for non-pointers" part of the hash table API changes. Originally I wrote it using clang, which didn't give as many warnings as gcc did. I guess this way is safer anyway..

Array API changed: ARRAY_DEFINE(name, type) -> ARRAY(type) name Easy way to update your existing code: perl -i -pe 's:ARRAY_DEFINE\(([^,]+), *([^)]+)\);:ARRAY($2) $1;:' **/*.[ch]

Hash table API is now (mostly) type safe.

lib-auth: Improved warning message about aborting auth requests.

lib-auth: Added auth_client_disconnect(). --HG-- branch : HEAD

auth: Identify clients using a 128bit random cookie on top of the existing PID. When master is finishing the login, it must give this cookie to REQUEST command and it must match what auth process knows. This change makes it safe to do client/master login without a dedicated master process. --HG-- branch : HEAD

lib-auth: Changed API to connect to only a single specified auth socket. Login processes now always connect to socket called "auth". --HG-- branch : HEAD

If auth server hasn't responded to handshake in 30 seconds, log an error and reconnect. --HG-- branch : HEAD

Changed .h ifdef/defines to use <NAME>_H format. --HG-- branch : HEAD

If no auth sockets are found in 10 seconds, kill ourself. --HG-- branch : HEAD

Removed support for external I/O loop. The point was originally that this library could be used by external software to talk to dovecot-auth, but nowadays it's much easier to just implement the authentication protocol. --HG-- branch : HEAD

deinit, unref, destroy, close, free, etc. functions now take a pointer to their data pointer, and set it to NULL. This makes double-frees less likely to cause security holes. --HG-- branch : HEAD

Added "bool" type and changed all ints that were used as booleans to bool. --HG-- branch : HEAD

Connect to available auth sockets by round robin. --HG-- branch : HEAD

Added VERSION command and checking to authentication protocol. --HG-- branch : HEAD

Changed dovecot-auth protocol to ASCII based. Should be easier now to write replacement server if needed by someone. Also cleaned up/made more consistent auth code. The new code could still use some cleaning though.. --HG-- branch : HEAD

Added APOP authentication for POP3. Patch by Andrey Panin. This required some changes in auth APIs. --HG-- branch : HEAD

Allow using more easily outside dovecot. --HG-- branch : HEAD

Removed hardcoded mechanism lists. It's now possible to add them dynamically. Added support for SASL initial response. --HG-- branch : HEAD

fixes --HG-- branch : HEAD

Moved client side code for auth process handling to lib-auth. Some other login process cleanups. --HG-- branch : HEAD