TODO revision 9cacf564513b5fd6078cd418b104083aab8b9bd8
b3ae710c251d0ce5cf2cef63208e325497b5e323Zbigniew Jędrzejewski-Szmek* swap units that are activated by one name but shown in the kernel under another are semi-broken
f957632b960a0a42999b38ded7089fa602b41745Kay Sievers* NM should pull in network.target (PENDING)
f957632b960a0a42999b38ded7089fa602b41745Kay Sievers https://bugzilla.redhat.com/show_bug.cgi?id=692008
f957632b960a0a42999b38ded7089fa602b41745Kay Sievers* make anaconda write timeout=0 for encrypted devices
d19e85f0d474ed1882561b458d528cbae49f640eZbigniew Jędrzejewski-Szmek* service: pid file reading after reload doesn't work, since we don't reset the pid variable
d19e85f0d474ed1882561b458d528cbae49f640eZbigniew Jędrzejewski-Szmek* make sure timeouts are applied to Type=oneshot services.
d19e85f0d474ed1882561b458d528cbae49f640eZbigniew Jędrzejewski-Szmek* Dangling symlinks of .automount unit files in .wants/ directories, set up
3e495a6651609d0a45b62aab5c3ed5a3b40e11abZbigniew Jędrzejewski-Szmek automount points even when the original .automount file did not exist
3e495a6651609d0a45b62aab5c3ed5a3b40e11abZbigniew Jędrzejewski-Szmek anymore. Only the .mount unit was still around.
f38afcd0c7f558ca5bf0854b42f8c6954f8ad7f3Lennart Poettering* make polkit checks async
f38afcd0c7f558ca5bf0854b42f8c6954f8ad7f3Lennart Poettering* properly handle .mount unit state tracking when two mount points are stacked one on top of another on the exact same mount point.
58f55364fa00a6a4706df2c4a01c6967f432e531Lennart Poettering* prefer /etc over /run?
83a1ff25e5228b0a5b2cc942fd4f964d10bb73b0Zbigniew Jędrzejewski-Szmek* when dumping cgroup contents, include main/control PID of a service, explicitly
83a1ff25e5228b0a5b2cc942fd4f964d10bb73b0Zbigniew Jędrzejewski-Szmek* keep an eye on https://bugzilla.gnome.org/show_bug.cgi?id=670100
83a1ff25e5228b0a5b2cc942fd4f964d10bb73b0Zbigniew Jędrzejewski-Szmek* D-Bus: always pass cred data along each message
124f2f9b6f66db00942b5882d68aa8fa8857865eLennart Poettering* journal: work on https://fedoraproject.org/wiki/Features/systemd-journal
d4b47aa30b45aa933bdf76e8dc9da01caa11e046David Herrmann* journal: allow turning off logging entirely
124f2f9b6f66db00942b5882d68aa8fa8857865eLennart Poettering* journal: sanely deal with entries which are larger than the individual file size, but where the componets would fit
124f2f9b6f66db00942b5882d68aa8fa8857865eLennart Poettering* add command to systemctl to plot dependency graph as tree (see rhbz 795365)
124f2f9b6f66db00942b5882d68aa8fa8857865eLennart Poettering* make logind reserve tty10 or so for text logins, so that gdm never picks it up
e06fe15b1f27d9d2317b25232d6df1e0a60dfce2Lennart Poettering* add option to sockets to avoid activation. Instead just drop packets/connections, see http://cyberelk.net/tim/2012/02/15/portreserve-systemd-solution/
61192f1d6954196d5066942241a024de4712243cLennart Poettering* isolate for getty is still broken, due to logind
61192f1d6954196d5066942241a024de4712243cLennart Poettering* default unix qlen is too small (10). bump sysctl? add sockopt?
6ce02c2a3a2aa888c3e074ae235d94808a165f9aLennart Poettering* support units generated by a generator and placed in /run/systemd/system/; the directory is
aea040c87280c41cb99b64b55f7368661a2d9912Lennart Poettering currently ignored because it is empty before the generatores are executed
17978b17d9f5d3591f1c644938efc9c27aa60485Lennart Poettering* let 'systemctl reboot' called as non-root talk to logind instead of systemd, to get polkit
17978b17d9f5d3591f1c644938efc9c27aa60485Lennart Poettering system policy in the loop of privilege checking, so normal users can possibly use /sbin/reboot
17978b17d9f5d3591f1c644938efc9c27aa60485Lennart Poettering* Possibly, detect whether SysV init scripts can do reloading by looking for "echo Usage:" lines
17978b17d9f5d3591f1c644938efc9c27aa60485Lennart Poettering* figure out whether we should leave dbus around during shutdown
17978b17d9f5d3591f1c644938efc9c27aa60485Lennart Poettering* support closing all fds via RLIMIT_NOFILE instead of /proc, in order to make chroot stuff work.
48e6d6a6e911af0cf4e3ef12b0a3eeb2c8031d8aLennart Poettering* add interface to allow immediate rotation of the journal, and even flushing.
48e6d6a6e911af0cf4e3ef12b0a3eeb2c8031d8aLennart Poettering* don't log coredumps of PID 1 into the journal
b1b5922e2f4ee12e852fcc8d288a6afa90c10c5fLennart Poettering* if a journal file is corrupt, rotate it and create a new one
8aa203819fc7f2a840191f8d9d0e65566c0ce98eLennart Poettering* dbus: in fedora, make the machine a symlink to /etc/machine-id
b18d23d7ac6a53d52b99dbf0b2048d5a946a2e28Lennart Poettering* journald: reuse XZ context
449a22a58f0fa55d9d0fd2eb597272446e032acdLennart Poettering* logind: add equivalent to sd_pid_get_owner_uid() to the D-Bus API
449a22a58f0fa55d9d0fd2eb597272446e032acdLennart Poettering* write RPM spec macros for presets
3d1137ac2b196cee345ac70fcdac675af142c8dcLennart Poettering* write man pages for systemd-cat
3d1137ac2b196cee345ac70fcdac675af142c8dcLennart Poettering* journal: write man pages for API
60d17b74d714fa15d68639062dc2932d7b096229Lennart Poettering* journal: OR matches are borked
60d17b74d714fa15d68639062dc2932d7b096229Lennart Poettering* journal: extend hash tables as we go
60d17b74d714fa15d68639062dc2932d7b096229Lennart Poettering* journal: API for looking for retrieving "all values of this field"
2f653bded321fc2271edcda43d54fcc3e6c20dc9Lennart Poettering* journal: deal nicely with byte-by-byte copied files, especially regards header
2f653bded321fc2271edcda43d54fcc3e6c20dc9Lennart Poettering* journal: local deserializer of export mode, http server
2f653bded321fc2271edcda43d54fcc3e6c20dc9Lennart Poettering* journal: message catalog
ac749874bbb66c0e7eff15ca35d1616d29b6f3c1Lennart Poettering* journal: forward-secure signatures
ac749874bbb66c0e7eff15ca35d1616d29b6f3c1Lennart Poettering* document the exit codes when services fail before they are exec()ed
7d417f0f357c59cc1846aa832161e69a2328f699Lennart Poettering* rework namespace support, don't use pivot_root, and mount things after creating the namespace, not before
7d417f0f357c59cc1846aa832161e69a2328f699Lennart Poettering* systemctl journal command
7d417f0f357c59cc1846aa832161e69a2328f699Lennart Poettering* journalctl: --cursor support, priority filtering
e342b74468870f2e4f3e15f7277a0adea42183caZbigniew Jędrzejewski-Szmek* systemctl status: show coredumps
036a4773ffa1152e4cabd27473450b8cc01e019bLennart Poettering* systemctl status: show whether journal was rotated since service started
036a4773ffa1152e4cabd27473450b8cc01e019bLennart Poettering* save coredump in Windows/Mozilla minidump format
a88abde72169ddc2df77df3fa5bed30725022253Lennart Poettering* support crash reporting operation modes (https://live.gnome.org/GnomeOS/Design/Whiteboards/ProblemReporting)
a88abde72169ddc2df77df3fa5bed30725022253Lennart Poettering* allow per-entry control on /var vs. /run (think incognito browser mode)
f93b36affa5ac5710cd84bfb8ff0dafabe99fbf1Lennart Poettering* clean up session cgroups that remain after logout (think sshd), but eventually run empty
20760dcf5df7e253c21a51886cdb02dee612730bLennart Poettering* support "systemctl stop foobar@.service" to stop all units matching a certain template
20760dcf5df7e253c21a51886cdb02dee612730bLennart Poettering* move to LGPL2+
20760dcf5df7e253c21a51886cdb02dee612730bLennart Poettering* logind: allow showing logout dialog from system
df22b0bbfde403b3fa71f3c2f1e2ca38af946388Lennart Poettering* document that %% can be used to write % in a string that is specifier extended
df22b0bbfde403b3fa71f3c2f1e2ca38af946388Lennart Poettering* check utf8 everywhere
b9be39bfb4ed8e43a7c445831131e44be998eb32Lennart Poettering* when an instanced service exits, remove its parent cgroup too if possible.
b9be39bfb4ed8e43a7c445831131e44be998eb32Lennart Poettering* Make libselinux, libattr, libcap, libdl dependencies only of the tools which actually need them.
c05482281c32bd408808b14c5fb03e706e65602dLennart Poettering* as Tom Gundersen pointed out there's a always a dep loop if people use crypto file systems with random keys
e0ec8950935ce587935e299c22232fbf4a2664c9Lennart Poettering* unset container= in PID1?
73cb77549536deab85d8d1261b5381e87d80ab23Lennart Poettering* automatically escape unit names passed on the service (i.e. think "systemctl start serial-getty.service@serial/by-path/jshdfjsdfhkjh" being automatically escaped as necessary.
73cb77549536deab85d8d1261b5381e87d80ab23Lennart Poettering* if we can not get user quota for tmpfs, mount a separate tmpfs instance
84bef24dd3ad050bab8ecdcd130d0d9794005fa0Lennart Poettering for every user in /run/user/$USER with a configured maximum size
84bef24dd3ad050bab8ecdcd130d0d9794005fa0Lennart Poettering* default to actual 32bit PIDs, via /proc/sys/kernel/pid_max
477e75ef9ea6bb2e7e8cc76278c442942110f227Lennart Poettering* add an option to make mounts private/shareable and so on, enable this for root by default
477e75ef9ea6bb2e7e8cc76278c442942110f227Lennart Poettering* internal restart counter for units (focus on auto-respawn)
477e75ef9ea6bb2e7e8cc76278c442942110f227Lennart Poettering* finer-grained auto-respawn settings (rate-limit)
7dfb0404b3b6882d582a571f61a52b2f56961675Lennart Poettering* be able to specify a forced restart of service A where service B depends on, in case B
7dfb0404b3b6882d582a571f61a52b2f56961675Lennart Poettering needs to be auto-respawned?
7dfb0404b3b6882d582a571f61a52b2f56961675Lennart Poettering* Something is wrong with symlink handling of "autovt@.service" in "systemctl list-unit-files"
2bc39683c0cada86c9dc39e5f3d0ea475cf12e57Lennart Poettering* when a bus name of a service disappears from the bus make sure to queue further activation requests
687f6a0ba77872299b9fb1f2f04d31c977088a63Lennart Poettering* something like ConditionExec= or ExecStartPre= without failure state
687f6a0ba77872299b9fb1f2f04d31c977088a63Lennart Poettering* service restart retry configuration
687f6a0ba77872299b9fb1f2f04d31c977088a63Lennart Poettering* tmpfiles: apply "x" on "D" too (see patch from William Douglas)
2bc39683c0cada86c9dc39e5f3d0ea475cf12e57Lennart Poettering* don't set $HOME in services unless requested
687f6a0ba77872299b9fb1f2f04d31c977088a63Lennart Poettering* hide PAM/TCPWrap options in fragment parser when compile time disabled
31a11e8f30449a81867e8fd081e3e76cf6664bb4Lennart Poettering* when we automatically restart a service, ensure we retsart its rdeps, too.
dbdee28bfadd6d8bd93cb34c85ce1fc325dd8120Lennart Poettering* allow Type=simple with PIDFile=
17fe56148c44dfa5583a8643c1918fd6eccf2aeeLennart Poettering https://bugzilla.redhat.com/show_bug.cgi?id=723942
17fe56148c44dfa5583a8643c1918fd6eccf2aeeLennart Poettering* move PAM code into its own binary
7687f85ea6bab434324bb985e2898bf6373891bfLennart Poettering* warn if the user stops a service but not its associated socket
7687f85ea6bab434324bb985e2898bf6373891bfLennart Poettering* logind: spawn user@..service on login
c14db9b32ab90738973071d31f259d1a457d7b4aLennart Poettering* logind: non-local X11 server handling
fa607802f332e06f4044c3eb38dbea41076c803dLennart Poettering* implement Register= switch in .socket units to enable registration
fa607802f332e06f4044c3eb38dbea41076c803dLennart Poettering in Avahi, RPC and other socket registration services.
a47e6701bfc45519a4e038daa52e9236e932f59aLennart Poettering* make sure systemd-ask-password-wall does not shutdown systemd-ask-password-console too early
b80c66ba9836456de5260e4a1b696ba25561f613Lennart Poettering* readahead: use BTRFS_IOC_DEFRAG_RANGE instead of BTRFS_IOC_DEFRAG ioctl, with START_IO
bd69054b0987b40a0df87d40772893f6f8a078daLennart Poettering* readahead: check whether a btrfs volume includes ssd by checking mount flag "ssd"
c3a0d00d6dd6f5997d673e133ef6f9f856550b0aLennart Poettering* support sd_notify() style notification when reload begins (RELOADING=1), reload is finished (READY=1), and add ReloadSignal= then to use in combination
c3a0d00d6dd6f5997d673e133ef6f9f856550b0aLennart Poettering* support sd_notify() style notification when shutting down, to make auto-exit bus services work (STOPPING=1)
c3a0d00d6dd6f5997d673e133ef6f9f856550b0aLennart Poettering* verify that the AF_UNIX sockets of a service in the fs still exist
de146bb2aac13361ade3050d37696499ac4ca9aeLennart Poettering when we start a service in order to avoid confusion when a user
de146bb2aac13361ade3050d37696499ac4ca9aeLennart Poettering assumes starting a service is enough to make it accessible
de146bb2aac13361ade3050d37696499ac4ca9aeLennart Poettering* Make it possible to set the keymap independently from the font on
c3a0d00d6dd6f5997d673e133ef6f9f856550b0aLennart Poettering the kernel cmdline. Right now setting one resets also the other.
82e6c50c473f4be8df77c7a510577f1975eedddbLennart Poettering* move nss-myhostname into systemd
d2f81fb00cc3c49e21b31000ba7d37b81a260257Lennart Poettering* and a dbus call to generate target from current state
98cd2651988619bf606f0b27825440c4638a7e0bLennart Poettering* drop /.readahead on bigger upgrades with yum
b7307642391c8ebb9724c99e6b33239e2c0ff944Lennart Poettering* add inode nr check to readahead to suppress preloading changed files
2a441c8afe7c81f74cc2ceccdf9a71301cd39d4dLennart Poettering* add support for /bin/mount -s
2a441c8afe7c81f74cc2ceccdf9a71301cd39d4dLennart Poettering* GC unreferenced jobs (such as .device jobs)
40ff4a4abd76d71408e598ed02d7860b8465fa9aLennart Poettering* when failing to start a service due to ratelimiting, try again later, if restart=always is set
40ff4a4abd76d71408e598ed02d7860b8465fa9aLennart Poettering* write blog stories about:
40ff4a4abd76d71408e598ed02d7860b8465fa9aLennart Poettering - enabling dbus services
0a86c1a9d8066267b878dfeddc5e0087dda6a37bLennart Poettering - status update
0a86c1a9d8066267b878dfeddc5e0087dda6a37bLennart Poettering - how to make changes to sysctl and sysfs attributes
f131770b1465fbf423881f16ba85523a05f846feVeres Lajos - remote access
0a86c1a9d8066267b878dfeddc5e0087dda6a37bLennart Poettering - how to pass throw-away units to systemd, or dynamically change properties of existing units
0a86c1a9d8066267b878dfeddc5e0087dda6a37bLennart Poettering - how to integrate cgconfig and suchlike with systemd
0a86c1a9d8066267b878dfeddc5e0087dda6a37bLennart Poettering - resource control in systemd
0a86c1a9d8066267b878dfeddc5e0087dda6a37bLennart Poettering* allow port=0 in .socket units
0a86c1a9d8066267b878dfeddc5e0087dda6a37bLennart Poettering* move readahead files into /var, look for them with .path units
e3286870fdf20c3c93e944b24fd9af53620f7dbaLennart Poettering* teach dbus to activate all services it finds in /etc/systemd/services/org-*.service
e3286870fdf20c3c93e944b24fd9af53620f7dbaLennart Poettering* support systemd.mask= on the kernel command line.
8514b67754c5ff7fa628929b3d27131010c21842Lennart Poettering* when key file cannot be found, read it from kbd in cryptsetup
6c78f43c7b0e54e695af49917fda79b584f46830Lennart Poettering* reuse mkdtemp namespace dirs in /tmp?
7b0fce617c48eda32b2d4e04b5f0e4376e8c0106Lennart Poettering* recreate systemd's D-Bus private socket file on SIGUSR2
7b0fce617c48eda32b2d4e04b5f0e4376e8c0106Lennart Poettering* Support --test based on current system state
7b0fce617c48eda32b2d4e04b5f0e4376e8c0106Lennart Poettering* investigate whether the gnome pty helper should be moved into systemd, to provide cgroup support.
c2d5b3c94d0c082ef29597fb230f8b88b124bab8Lennart Poettering* maybe introduce ExecRestartPre=
264b8070715d2d19344c4991ace21147d998f56dLennart Poettering* configurable jitter for timer events
7e27f3121e5a10629302b5221eb21345f832724aLennart Poettering* timer events with system resume
f81e67f79fa856aa2ecffad4d014772ce981745cLennart Poettering* timer events on calendar time
d48b7bd271b1e70924c8485d2f95c2f5a1ae77cbLennart Poettering* dot output for --test showing the 'initial transaction'
25e14499c4c5b02229d05a5bc26c3693ade5f987Lennart Poettering* calendar time support in timer, iCalendar semantics for the timer stuff (RFC2445)
758c4d7a391c0e024737053c815bf3924653b8c5Lennart Poettering http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=99ee5315dac6211e972fa3f23bcc9a0343ff58c4
821cc13ddae40fb7608458b44aaa7a3fd33d56d9Lennart Poettering* implicitly import "defaults" settings file into all types
821cc13ddae40fb7608458b44aaa7a3fd33d56d9Lennart Poettering* exec settings override
8483d73ff158ee0d51ccbba09a470cc6ae9b071aLennart Poettering* writable cgroups dbus properties for live changes
8483d73ff158ee0d51ccbba09a470cc6ae9b071aLennart Poettering* read config fragments for all units from /lib/systemd/system/foobar.service.d/ to override/extend specific settings
8483d73ff158ee0d51ccbba09a470cc6ae9b071aLennart Poettering - rpcbind (/var/run/rpcbind.sock!) HAVEPATCH
8483d73ff158ee0d51ccbba09a470cc6ae9b071aLennart Poettering - cups HAVEPATCH
25e773eeb4f853804e1bf0dbd9a184f23e9b2a97Kay Sievers - postfix, saslauthd
6dab5bb18151c80fc39bd51f03dcff40b920de3eLennart Poettering - libvirtd (/var/run/libvirt/libvirt-sock-ro)
6dab5bb18151c80fc39bd51f03dcff40b920de3eLennart Poettering - bluetoothd (/var/run/sdp! @/org/bluez/audio!)
706d97503df83d141d241b645d2c920d691b3d62Lennart Poettering* auditd service files
3bcde97e8502c48b53f7420e2433ca68e601662dLennart Poettering* fingerprint.target, wireless.target, gps.target, netdevice.target
533bb267f13e2f7b4d7b78de30e821dc81c82335Lennart Poettering* io priority during initialization
279f036675536d55c901562b49f9df146af1a0e3Lennart Poettering* if a service fails too often, make the service enter failed mode, and the socket, too.
b42de08aa4c97636e42c28c7bce08f0d7c2a719aZbigniew Jędrzejewski-Szmek* systemctl list-jobs - show dependencies
b42de08aa4c97636e42c28c7bce08f0d7c2a719aZbigniew Jędrzejewski-Szmek* add systemctl switch to dump transaction without executing it
202aea456dfb279cd34da7bfd1880f6ac0fd849fLennart Poettering* suspend, resume support?
42aeb14a4a0fa7d43da96a8ed0fb0e180a2dd5c8Lennart Poettering* drop cap bounding set in readahead and other services
14a32924c9b46817c92ae11c1147a59dcb62012bLennart Poettering - get process transport into dbus for systemctl -P/-H (PENDING)
563b1bdc09efe0cf94dd3f514f30376ca854c1ceLennart Poettering - natively watch for dbus-*.service symlinks (PENDING)
563b1bdc09efe0cf94dd3f514f30376ca854c1ceLennart Poettering - allow specification of socket mode/umask when allocating DBusServer
5dcf983854c2e8314dbee239180255490ec8ae1cLennart Poettering - allow disabling of fd passing when connecting a AF_UNIX connection
5dcf983854c2e8314dbee239180255490ec8ae1cLennart Poettering - allow disabling of UID passing for AUTH EXTERNAL
6bd7941ece602ae9962a103c8d65ecda7d642391Tom Gundersen* systemd --user
6bd7941ece602ae9962a103c8d65ecda7d642391Tom Gundersen PR_SET_CHILD_REAPER patch: https://lkml.org/lkml/2011/7/28/426
b873d33ec9583c92a0c2bc6807d010720fa31595Lennart Poettering* fix alsa mixer restore to not print error when no config is stored
ed220efd6657822332b9563ec53c5ab9f3c33220Lennart Poettering* udisks should not use udisks-part-id, instead use blkid. also not probe /dev/loopxxx
41488fe9024a8955d19811620fd55dcc56a5b2baLennart Poettering* snd-seq should go, https://bugzilla.redhat.com/show_bug.cgi?id=676095
41488fe9024a8955d19811620fd55dcc56a5b2baLennart Poettering* gnome-shell python script/glxinfo/is-accelerated must die
41488fe9024a8955d19811620fd55dcc56a5b2baLennart Poettering* make cryptsetup lower --iter-time
41488fe9024a8955d19811620fd55dcc56a5b2baLennart Poettering* patch kernel for xattr support in /dev, /proc/, /sys and /sys/fs/cgroup?
ca70bec9261977336c94f44d5fcf37e1c495326aLennart Poettering* NTP: the kernel's 11-minutes-mode syncs the system time to the RTC, but only
ca70bec9261977336c94f44d5fcf37e1c495326aLennart Poettering in an ~30 minutes window. It does not adjust larger differences. Find a way
ca70bec9261977336c94f44d5fcf37e1c495326aLennart Poettering to tell the kernel, to always do a full time sync when the RTC is in UTC and
1dbe0a6efda7b1d35957eab7e1d56a2c69d806d9Lennart Poettering we are in 11-minutes-mode. When we trust the system time to NTP we also want
1dbe0a6efda7b1d35957eab7e1d56a2c69d806d9Lennart Poettering the RTC to sync up.
157a180e4fc827606833a6724834ba7b0246d650Tom Gundersen* patch kernel for cpu feature modalias for autoloading aes/kvm/...
823f4a91ebd8942a2c1ff31050dc55eaa60f6ffcLukas Nykryn (patches in linux-next, on the way to the next kernel)
9d6db739ce1eaa3eace21801fd606d523b73c8f4Lennart Poettering* kernel: add /proc/sys file exposing CAP_LAST_CAP? sysconf?
1dbe0a6efda7b1d35957eab7e1d56a2c69d806d9Lennart Poettering merged: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commit;h=73efc0394e148d0e15583e13712637831f926720
9d6db739ce1eaa3eace21801fd606d523b73c8f4Lennart Poettering* kernel: add device_type = "fb", "fbcon" to class "graphics"
23c4091dc2b85d117512e89233fdeb47d1ff3d92Lennart Poettering* look for close() vs. close_nointr() vs. close_nointr_nofail()
9d6db739ce1eaa3eace21801fd606d523b73c8f4Lennart Poettering* check for strerror(r) instead of strerror(-r)
9d6db739ce1eaa3eace21801fd606d523b73c8f4Lennart Poettering* Use PR_SET_PROCTITLE_AREA if it becomes available in the kernel
bc07548926ec5ed7b13df8d3656654f238e0b9a7Lennart Poettering* %m in printf() instead of strerror();
3f77a1b19f5a8ce33566f7f6e28e94c08ea30841Kay Sievers* set_put(), hashmap_put() return values check. i.e. == 0 doesn't free()!