1005N/A/*
1005N/A * Copyright (c) 2011, Oracle and/or its affiliates. All rights reserved.
1005N/A * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
1005N/A *
1005N/A * This code is free software; you can redistribute it and/or modify it
1005N/A * under the terms of the GNU General Public License version 2 only, as
1005N/A * published by the Free Software Foundation.
1005N/A *
1005N/A * This code is distributed in the hope that it will be useful, but WITHOUT
1005N/A * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
1005N/A * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
1005N/A * version 2 for more details (a copy is included in the LICENSE file that
1005N/A * accompanied this code).
1005N/A *
1005N/A * You should have received a copy of the GNU General Public License version
1005N/A * 2 along with this work; if not, write to the Free Software Foundation,
1005N/A * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
1005N/A *
1005N/A * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
1005N/A * or visit www.oracle.com if you need additional information or have any
1005N/A * questions.
1005N/A */
1005N/A
1005N/A/*
1005N/A * @test
1005N/A * @bug 7042566
1005N/A * @summary Unambiguous varargs method calls flagged as ambiguous
1005N/A */
1005N/A
1005N/Aimport com.sun.source.util.JavacTask;
1005N/Aimport com.sun.tools.classfile.Instruction;
1005N/Aimport com.sun.tools.classfile.Attribute;
1005N/Aimport com.sun.tools.classfile.ClassFile;
1005N/Aimport com.sun.tools.classfile.Code_attribute;
1005N/Aimport com.sun.tools.classfile.ConstantPool.*;
1005N/Aimport com.sun.tools.classfile.Method;
1005N/Aimport com.sun.tools.javac.api.JavacTool;
1005N/Aimport com.sun.tools.javac.util.List;
1005N/A
1005N/Aimport java.io.File;
1005N/Aimport java.net.URI;
1005N/Aimport java.util.Arrays;
1005N/Aimport java.util.Locale;
1005N/Aimport javax.tools.Diagnostic;
1005N/Aimport javax.tools.JavaCompiler;
1005N/Aimport javax.tools.JavaFileObject;
1005N/Aimport javax.tools.SimpleJavaFileObject;
1005N/Aimport javax.tools.StandardJavaFileManager;
1005N/Aimport javax.tools.ToolProvider;
1005N/A
1005N/Apublic class T7042566 {
1005N/A
1005N/A VarargsMethod m1;
1005N/A VarargsMethod m2;
1005N/A TypeConfiguration actuals;
1005N/A
1005N/A T7042566(TypeConfiguration m1_conf, TypeConfiguration m2_conf, TypeConfiguration actuals) {
1005N/A this.m1 = new VarargsMethod(m1_conf);
1005N/A this.m2 = new VarargsMethod(m2_conf);
1005N/A this.actuals = actuals;
1005N/A }
1005N/A
1005N/A void compileAndCheck() throws Exception {
1005N/A final JavaCompiler tool = ToolProvider.getSystemJavaCompiler();
1005N/A JavaSource source = new JavaSource();
1005N/A ErrorChecker ec = new ErrorChecker();
1005N/A JavacTask ct = (JavacTask)tool.getTask(null, fm, ec,
1005N/A null, null, Arrays.asList(source));
1005N/A ct.call();
1005N/A check(source, ec);
1005N/A }
1005N/A
1005N/A void check(JavaSource source, ErrorChecker ec) {
1005N/A checkCount++;
1005N/A boolean resolutionError = false;
1005N/A VarargsMethod selectedMethod = null;
1005N/A
1005N/A boolean m1_applicable = m1.isApplicable(actuals);
1005N/A boolean m2_applicable = m2.isApplicable(actuals);
1005N/A
1005N/A if (!m1_applicable && !m2_applicable) {
1005N/A resolutionError = true;
1005N/A } else if (m1_applicable && m2_applicable) {
1005N/A //most specific
1005N/A boolean m1_moreSpecific = m1.isMoreSpecificThan(m2);
1005N/A boolean m2_moreSpecific = m2.isMoreSpecificThan(m1);
1005N/A
1005N/A resolutionError = m1_moreSpecific == m2_moreSpecific;
1005N/A selectedMethod = m1_moreSpecific ? m1 : m2;
1005N/A } else {
1005N/A selectedMethod = m1_applicable ?
1005N/A m1 : m2;
1005N/A }
1005N/A
1005N/A if (ec.errorFound != resolutionError) {
1005N/A throw new Error("invalid diagnostics for source:\n" +
1005N/A source.getCharContent(true) +
1005N/A "\nExpected resolution error: " + resolutionError +
1005N/A "\nFound error: " + ec.errorFound +
1005N/A "\nCompiler diagnostics:\n" + ec.printDiags());
1005N/A } else if (!resolutionError) {
1005N/A verifyBytecode(selectedMethod, source);
1005N/A }
1005N/A }
1005N/A
1005N/A void verifyBytecode(VarargsMethod selected, JavaSource source) {
1005N/A bytecodeCheckCount++;
1005N/A File compiledTest = new File("Test.class");
1005N/A try {
1005N/A ClassFile cf = ClassFile.read(compiledTest);
1005N/A Method testMethod = null;
1005N/A for (Method m : cf.methods) {
1005N/A if (m.getName(cf.constant_pool).equals("test")) {
1005N/A testMethod = m;
1005N/A break;
1005N/A }
1005N/A }
1005N/A if (testMethod == null) {
1005N/A throw new Error("Test method not found");
1005N/A }
1005N/A Code_attribute ea = (Code_attribute)testMethod.attributes.get(Attribute.Code);
1005N/A if (testMethod == null) {
1005N/A throw new Error("Code attribute for test() method not found");
1005N/A }
1005N/A
1005N/A for (Instruction i : ea.getInstructions()) {
1005N/A if (i.getMnemonic().equals("invokevirtual")) {
1005N/A int cp_entry = i.getUnsignedShort(1);
1005N/A CONSTANT_Methodref_info methRef =
1005N/A (CONSTANT_Methodref_info)cf.constant_pool.get(cp_entry);
1005N/A String type = methRef.getNameAndTypeInfo().getType();
1005N/A String sig = selected.parameterTypes.bytecodeSigStr;
1005N/A if (!type.contains(sig)) {
1005N/A throw new Error("Unexpected type method call: " + type + "" +
1005N/A "\nfound: " + sig +
1005N/A "\n" + source.getCharContent(true));
1005N/A }
1005N/A break;
1005N/A }
1005N/A }
1005N/A } catch (Exception e) {
1005N/A e.printStackTrace();
1005N/A throw new Error("error reading " + compiledTest +": " + e);
1005N/A }
1005N/A }
1005N/A
1005N/A class JavaSource extends SimpleJavaFileObject {
1005N/A
1005N/A static final String source_template = "class Test {\n" +
1005N/A " #V1\n" +
1005N/A " #V2\n" +
1005N/A " void test() { m(#E); }\n" +
1005N/A "}";
1005N/A
1005N/A String source;
1005N/A
1005N/A public JavaSource() {
1005N/A super(URI.create("myfo:/Test.java"), JavaFileObject.Kind.SOURCE);
1005N/A source = source_template.replaceAll("#V1", m1.toString()).
1005N/A replaceAll("#V2", m2.toString()).
1005N/A replaceAll("#E", actuals.expressionListStr);
1005N/A }
1005N/A
1005N/A @Override
1005N/A public CharSequence getCharContent(boolean ignoreEncodingErrors) {
1005N/A return source;
1005N/A }
1005N/A }
1005N/A
1005N/A /** global decls ***/
1005N/A
1005N/A // Create a single file manager and reuse it for each compile to save time.
1005N/A static StandardJavaFileManager fm = JavacTool.create().getStandardFileManager(null, null, null);
1005N/A
1005N/A //statistics
1005N/A static int checkCount = 0;
1005N/A static int bytecodeCheckCount = 0;
1005N/A
1005N/A public static void main(String... args) throws Exception {
1005N/A for (TypeConfiguration tconf1 : TypeConfiguration.values()) {
1005N/A for (TypeConfiguration tconf2 : TypeConfiguration.values()) {
1005N/A for (TypeConfiguration tconf3 : TypeConfiguration.values()) {
1005N/A new T7042566(tconf1, tconf2, tconf3).compileAndCheck();
1005N/A }
1005N/A }
1005N/A }
1005N/A
1005N/A System.out.println("Total checks made: " + checkCount);
1005N/A System.out.println("Bytecode checks made: " + bytecodeCheckCount);
1005N/A }
1005N/A
1005N/A enum TypeKind {
1005N/A OBJECT("Object", "(Object)null", "Ljava/lang/Object;"),
1005N/A STRING("String", "(String)null", "Ljava/lang/String;");
1005N/A
1005N/A String typeString;
1005N/A String valueString;
1005N/A String bytecodeString;
1005N/A
1005N/A TypeKind(String typeString, String valueString, String bytecodeString) {
1005N/A this.typeString = typeString;
1005N/A this.valueString = valueString;
1005N/A this.bytecodeString = bytecodeString;
1005N/A }
1005N/A
1005N/A boolean isSubtypeOf(TypeKind that) {
1005N/A return that == OBJECT ||
1005N/A (that == STRING && this == STRING);
1005N/A }
1005N/A }
1005N/A
1005N/A enum TypeConfiguration {
1005N/A A(TypeKind.OBJECT),
1005N/A B(TypeKind.STRING),
1005N/A AA(TypeKind.OBJECT, TypeKind.OBJECT),
1005N/A AB(TypeKind.OBJECT, TypeKind.STRING),
1005N/A BA(TypeKind.STRING, TypeKind.OBJECT),
1005N/A BB(TypeKind.STRING, TypeKind.STRING),
1005N/A AAA(TypeKind.OBJECT, TypeKind.OBJECT, TypeKind.OBJECT),
1005N/A AAB(TypeKind.OBJECT, TypeKind.OBJECT, TypeKind.STRING),
1005N/A ABA(TypeKind.OBJECT, TypeKind.STRING, TypeKind.OBJECT),
1005N/A ABB(TypeKind.OBJECT, TypeKind.STRING, TypeKind.STRING),
1005N/A BAA(TypeKind.STRING, TypeKind.OBJECT, TypeKind.OBJECT),
1005N/A BAB(TypeKind.STRING, TypeKind.OBJECT, TypeKind.STRING),
1005N/A BBA(TypeKind.STRING, TypeKind.STRING, TypeKind.OBJECT),
1005N/A BBB(TypeKind.STRING, TypeKind.STRING, TypeKind.STRING);
1005N/A
1005N/A List<TypeKind> typeKindList;
1005N/A String expressionListStr;
1005N/A String parameterListStr;
1005N/A String bytecodeSigStr;
1005N/A
1005N/A private TypeConfiguration(TypeKind... typeKindList) {
1005N/A this.typeKindList = List.from(typeKindList);
1005N/A expressionListStr = asExpressionList();
1005N/A parameterListStr = asParameterList();
1005N/A bytecodeSigStr = asBytecodeString();
1005N/A }
1005N/A
1005N/A private String asExpressionList() {
1005N/A StringBuilder buf = new StringBuilder();
1005N/A String sep = "";
1005N/A for (TypeKind tk : typeKindList) {
1005N/A buf.append(sep);
1005N/A buf.append(tk.valueString);
1005N/A sep = ",";
1005N/A }
1005N/A return buf.toString();
1005N/A }
1005N/A
1005N/A private String asParameterList() {
1005N/A StringBuilder buf = new StringBuilder();
1005N/A String sep = "";
1005N/A int count = 0;
1005N/A for (TypeKind arg : typeKindList) {
1005N/A buf.append(sep);
1005N/A buf.append(arg.typeString);
1005N/A if (count == (typeKindList.size() - 1)) {
1005N/A buf.append("...");
1005N/A }
1005N/A buf.append(" ");
1005N/A buf.append("arg" + count++);
1005N/A sep = ",";
1005N/A }
1005N/A return buf.toString();
1005N/A }
1005N/A
1005N/A private String asBytecodeString() {
1005N/A StringBuilder buf = new StringBuilder();
1005N/A int count = 0;
1005N/A for (TypeKind arg : typeKindList) {
1005N/A if (count == (typeKindList.size() - 1)) {
1005N/A buf.append("[");
1005N/A }
1005N/A buf.append(arg.bytecodeString);
1005N/A count++;
1005N/A }
1005N/A return buf.toString();
1005N/A }
1005N/A }
1005N/A
1005N/A static class VarargsMethod {
1005N/A TypeConfiguration parameterTypes;
1005N/A
1005N/A public VarargsMethod(TypeConfiguration parameterTypes) {
1005N/A this.parameterTypes = parameterTypes;
1005N/A }
1005N/A
1005N/A @Override
1005N/A public String toString() {
1005N/A return "void m( " + parameterTypes.parameterListStr + ") {}";
1005N/A }
1005N/A
1005N/A boolean isApplicable(TypeConfiguration that) {
1005N/A List<TypeKind> actuals = that.typeKindList;
1005N/A List<TypeKind> formals = parameterTypes.typeKindList;
1005N/A if ((actuals.size() - formals.size()) < -1)
1005N/A return false; //not enough args
1005N/A for (TypeKind actual : actuals) {
1005N/A if (!actual.isSubtypeOf(formals.head))
1005N/A return false; //type mismatch
1005N/A formals = formals.tail.isEmpty() ?
1005N/A formals :
1005N/A formals.tail;
1005N/A }
1005N/A return true;
1005N/A }
1005N/A
1005N/A boolean isMoreSpecificThan(VarargsMethod that) {
1005N/A List<TypeKind> actuals = parameterTypes.typeKindList;
1005N/A List<TypeKind> formals = that.parameterTypes.typeKindList;
1005N/A int checks = 0;
1005N/A int expectedCheck = Math.max(actuals.size(), formals.size());
1005N/A while (checks < expectedCheck) {
1005N/A if (!actuals.head.isSubtypeOf(formals.head))
1005N/A return false; //type mismatch
1005N/A formals = formals.tail.isEmpty() ?
1005N/A formals :
1005N/A formals.tail;
1005N/A actuals = actuals.tail.isEmpty() ?
1005N/A actuals :
1005N/A actuals.tail;
1005N/A checks++;
1005N/A }
1005N/A return true;
1005N/A }
1005N/A }
1005N/A
1005N/A static class ErrorChecker implements javax.tools.DiagnosticListener<JavaFileObject> {
1005N/A
1005N/A boolean errorFound;
1005N/A List<String> errDiags = List.nil();
1005N/A
1005N/A public void report(Diagnostic<? extends JavaFileObject> diagnostic) {
1005N/A if (diagnostic.getKind() == Diagnostic.Kind.ERROR) {
1005N/A errDiags = errDiags.append(diagnostic.getMessage(Locale.getDefault()));
1005N/A errorFound = true;
1005N/A }
1005N/A }
1005N/A
1005N/A String printDiags() {
1005N/A StringBuilder buf = new StringBuilder();
1005N/A for (String s : errDiags) {
1005N/A buf.append(s);
1005N/A buf.append("\n");
1005N/A }
1005N/A return buf.toString();
1005N/A }
1005N/A }
1005N/A}