786N/A/*
961N/A * Copyright (c) 2010, 2011, Oracle and/or its affiliates. All rights reserved.
786N/A * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
786N/A *
786N/A * This code is free software; you can redistribute it and/or modify it
786N/A * under the terms of the GNU General Public License version 2 only, as
786N/A * published by the Free Software Foundation.
786N/A *
786N/A * This code is distributed in the hope that it will be useful, but WITHOUT
786N/A * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
786N/A * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
786N/A * version 2 for more details (a copy is included in the LICENSE file that
786N/A * accompanied this code).
786N/A *
786N/A * You should have received a copy of the GNU General Public License version
786N/A * 2 along with this work; if not, write to the Free Software Foundation,
786N/A * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
786N/A *
786N/A * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
786N/A * or visit www.oracle.com if you need additional information or have any
786N/A * questions.
786N/A */
786N/A
786N/A/*
786N/A * @test
786N/A * @bug 6199075
786N/A *
786N/A * @summary Unambiguous varargs method calls flagged as ambiguous
786N/A * @author mcimadamore
786N/A *
786N/A */
786N/A
786N/Aimport com.sun.source.util.JavacTask;
786N/Aimport com.sun.tools.classfile.Instruction;
786N/Aimport com.sun.tools.classfile.Attribute;
786N/Aimport com.sun.tools.classfile.ClassFile;
786N/Aimport com.sun.tools.classfile.Code_attribute;
786N/Aimport com.sun.tools.classfile.ConstantPool.*;
786N/Aimport com.sun.tools.classfile.Method;
891N/Aimport com.sun.tools.javac.api.JavacTool;
786N/Aimport com.sun.tools.javac.util.List;
786N/A
786N/Aimport java.io.File;
786N/Aimport java.net.URI;
786N/Aimport java.util.Arrays;
786N/Aimport java.util.Locale;
786N/Aimport javax.tools.Diagnostic;
786N/Aimport javax.tools.JavaCompiler;
786N/Aimport javax.tools.JavaFileObject;
786N/Aimport javax.tools.SimpleJavaFileObject;
891N/Aimport javax.tools.StandardJavaFileManager;
786N/Aimport javax.tools.ToolProvider;
786N/A
786N/Apublic class T6199075 {
786N/A
786N/A int checkCount = 0;
786N/A int bytecodeCheckCount = 0;
786N/A
786N/A enum TypeKind {
786N/A BYTE("byte", "(byte)1", "[B", 0),
786N/A CHAR("char", "'c'", "[C", 1),
786N/A SHORT("short", "(short)1", "[S", 2),
786N/A INT("int", "1", "[I", 3),
786N/A LONG("long", "1L", "[J", 4),
786N/A FLOAT("float", "1.0F", "[F", 5),
786N/A DOUBLE("double", "1.0D", "[D", 6),
786N/A BOOLEAN("boolean", "true", "[Z", -1);
786N/A
786N/A String typeString;
786N/A String valueString;
786N/A String bytecodeString;
786N/A private int subtypeTag;
786N/A
786N/A TypeKind(String typeString, String valueString, String bytecodeString, int subtypeTag) {
786N/A this.typeString = typeString;
786N/A this.valueString = valueString;
786N/A this.bytecodeString = bytecodeString;
786N/A this.subtypeTag = subtypeTag;
786N/A }
786N/A
786N/A boolean isSubtypeOf(TypeKind that) {
786N/A switch (this) {
786N/A case BOOLEAN:
786N/A return that == BOOLEAN;
786N/A case BYTE:
786N/A case CHAR:
786N/A return this.subtypeTag == that.subtypeTag ||
786N/A this.subtypeTag + 2 <= that.subtypeTag;
786N/A default:
786N/A return this.subtypeTag <= that.subtypeTag;
786N/A }
786N/A }
786N/A }
786N/A
786N/A enum ArgumentsArity {
786N/A ZERO(0),
786N/A ONE(1),
786N/A TWO(2),
786N/A THREE(3);
786N/A
786N/A int arity;
786N/A
786N/A ArgumentsArity(int arity) {
786N/A this.arity = arity;
786N/A }
786N/A
786N/A String asExpressionList(TypeKind type) {
786N/A StringBuilder buf = new StringBuilder();
786N/A String sep = "";
786N/A for (int i = 0; i < arity; i++) {
786N/A buf.append(sep);
786N/A buf.append(type.valueString);
786N/A sep = ",";
786N/A }
786N/A return buf.toString();
786N/A }
786N/A }
786N/A
786N/A static class VarargsMethod {
786N/A TypeKind varargsElement;
786N/A
786N/A VarargsMethod(TypeKind varargsElement) {
786N/A this.varargsElement = varargsElement;
786N/A }
786N/A
786N/A @Override
786N/A public String toString() {
786N/A return "void m("+ varargsElement.typeString+ "... args) {}";
786N/A }
786N/A
786N/A boolean isApplicable(TypeKind actual, ArgumentsArity argsArity) {
786N/A return argsArity == ArgumentsArity.ZERO ||
786N/A actual.isSubtypeOf(varargsElement);
786N/A }
786N/A
786N/A boolean isMoreSpecificThan(VarargsMethod that) {
786N/A return varargsElement.isSubtypeOf(that.varargsElement);
786N/A }
786N/A }
786N/A
786N/A public static void main(String... args) throws Exception {
786N/A new T6199075().test();
786N/A }
786N/A
786N/A void test() throws Exception {
786N/A for (TypeKind formal1 : TypeKind.values()) {
786N/A VarargsMethod m1 = new VarargsMethod(formal1);
786N/A for (TypeKind formal2 : TypeKind.values()) {
786N/A VarargsMethod m2 = new VarargsMethod(formal2);
786N/A for (TypeKind actual : TypeKind.values()) {
786N/A for (ArgumentsArity argsArity : ArgumentsArity.values()) {
786N/A compileAndCheck(m1, m2, actual, argsArity);
786N/A }
786N/A }
786N/A }
786N/A }
786N/A
786N/A System.out.println("Total checks made: " + checkCount);
786N/A System.out.println("Bytecode checks made: " + bytecodeCheckCount);
786N/A }
786N/A
891N/A // Create a single file manager and reuse it for each compile to save time.
891N/A StandardJavaFileManager fm = JavacTool.create().getStandardFileManager(null, null, null);
891N/A
786N/A void compileAndCheck(VarargsMethod m1, VarargsMethod m2, TypeKind actual, ArgumentsArity argsArity) throws Exception {
786N/A final JavaCompiler tool = ToolProvider.getSystemJavaCompiler();
786N/A JavaSource source = new JavaSource(m1, m2, actual, argsArity);
786N/A ErrorChecker ec = new ErrorChecker();
891N/A JavacTask ct = (JavacTask)tool.getTask(null, fm, ec,
786N/A null, null, Arrays.asList(source));
786N/A ct.generate();
786N/A check(source, ec, m1, m2, actual, argsArity);
786N/A }
786N/A
786N/A void check(JavaSource source, ErrorChecker ec, VarargsMethod m1, VarargsMethod m2, TypeKind actual, ArgumentsArity argsArity) {
786N/A checkCount++;
786N/A boolean resolutionError = false;
786N/A VarargsMethod selectedMethod = null;
786N/A
786N/A boolean m1_applicable = m1.isApplicable(actual, argsArity);
786N/A boolean m2_applicable = m2.isApplicable(actual, argsArity);
786N/A
786N/A if (!m1_applicable && !m2_applicable) {
786N/A resolutionError = true;
786N/A } else if (m1_applicable && m2_applicable) {
786N/A //most specific
786N/A boolean m1_moreSpecific = m1.isMoreSpecificThan(m2);
786N/A boolean m2_moreSpecific = m2.isMoreSpecificThan(m1);
786N/A resolutionError = m1_moreSpecific == m2_moreSpecific;
786N/A selectedMethod = m1_moreSpecific ? m1 : m2;
786N/A } else {
786N/A selectedMethod = m1_applicable ?
786N/A m1 : m2;
786N/A }
786N/A
786N/A if (ec.errorFound != resolutionError) {
786N/A throw new Error("invalid diagnostics for source:\n" +
786N/A source.getCharContent(true) +
786N/A "\nExpected resolution error: " + resolutionError +
786N/A "\nFound error: " + ec.errorFound +
786N/A "\nCompiler diagnostics:\n" + ec.printDiags());
786N/A } else if (!resolutionError) {
786N/A verifyBytecode(selectedMethod);
786N/A }
786N/A }
786N/A
786N/A void verifyBytecode(VarargsMethod selected) {
786N/A bytecodeCheckCount++;
786N/A File compiledTest = new File("Test.class");
786N/A try {
786N/A ClassFile cf = ClassFile.read(compiledTest);
786N/A Method testMethod = null;
786N/A for (Method m : cf.methods) {
786N/A if (m.getName(cf.constant_pool).equals("test")) {
786N/A testMethod = m;
786N/A break;
786N/A }
786N/A }
786N/A if (testMethod == null) {
786N/A throw new Error("Test method not found");
786N/A }
786N/A Code_attribute ea = (Code_attribute)testMethod.attributes.get(Attribute.Code);
786N/A if (testMethod == null) {
786N/A throw new Error("Code attribute for test() method not found");
786N/A }
786N/A
786N/A for (Instruction i : ea.getInstructions()) {
786N/A if (i.getMnemonic().equals("invokevirtual")) {
786N/A int cp_entry = i.getUnsignedShort(1);
786N/A CONSTANT_Methodref_info methRef =
786N/A (CONSTANT_Methodref_info)cf.constant_pool.get(cp_entry);
786N/A String type = methRef.getNameAndTypeInfo().getType();
786N/A if (!type.contains(selected.varargsElement.bytecodeString)) {
786N/A throw new Error("Unexpected type method call: " + type);
786N/A }
786N/A break;
786N/A }
786N/A }
786N/A } catch (Exception e) {
786N/A e.printStackTrace();
786N/A throw new Error("error reading " + compiledTest +": " + e);
786N/A }
786N/A }
786N/A
786N/A static class JavaSource extends SimpleJavaFileObject {
786N/A
786N/A static final String source_template = "class Test {\n" +
786N/A " #V1\n" +
786N/A " #V2\n" +
786N/A " void test() { m(#E); }\n" +
786N/A "}";
786N/A
786N/A String source;
786N/A
786N/A public JavaSource(VarargsMethod m1, VarargsMethod m2, TypeKind actual, ArgumentsArity argsArity) {
786N/A super(URI.create("myfo:/Test.java"), JavaFileObject.Kind.SOURCE);
786N/A source = source_template.replaceAll("#V1", m1.toString()).
786N/A replaceAll("#V2", m2.toString()).
786N/A replaceAll("#E", argsArity.asExpressionList(actual));
786N/A }
786N/A
786N/A @Override
786N/A public CharSequence getCharContent(boolean ignoreEncodingErrors) {
786N/A return source;
786N/A }
786N/A }
786N/A
786N/A static class ErrorChecker implements javax.tools.DiagnosticListener<JavaFileObject> {
786N/A
786N/A boolean errorFound;
786N/A List<String> errDiags = List.nil();
786N/A
786N/A public void report(Diagnostic<? extends JavaFileObject> diagnostic) {
786N/A if (diagnostic.getKind() == Diagnostic.Kind.ERROR) {
786N/A errDiags = errDiags.append(diagnostic.getMessage(Locale.getDefault()));
786N/A errorFound = true;
786N/A }
786N/A }
786N/A
786N/A String printDiags() {
786N/A StringBuilder buf = new StringBuilder();
786N/A for (String s : errDiags) {
786N/A buf.append(s);
786N/A buf.append("\n");
786N/A }
786N/A return buf.toString();
786N/A }
786N/A }
786N/A}