spec/lib/concurrency_balancer_spec.rb

	concurrency_balancer_spec.rb revision db149239590d2a39d399f12cd01609b190ea4763
require 'spec_helper'

describe ConcurrencyBalancer do

  let(:balancer) { ConcurrencyBalancer.new }
  let(:redis) { ConcurrencyBalancer::RedisWrapper.new }

  before(:each) do
    redis.del ConcurrencyBalancer::REDIS_KEY
    redis.del ConcurrencyBalancer::SEQUENTIAL_LOCK_KEY
  end

  context 'successfully marking an unmarked iri' do
    it 'should work' do
      expect { balancer.mark_as_processing_or_complain('iri') }.
        not_to raise_error
    end
  end

  context 'trying to mark a marked iri' do
    it 'should completely fail' do
      redis.sadd ConcurrencyBalancer::REDIS_KEY, 'iri'
      expect { balancer.mark_as_processing_or_complain('iri') }.
        to raise_error(ConcurrencyBalancer::AlreadyProcessingError)
    end
  end

  context 'successfully unmarking a marked iri' do
    it 'should work nicely' do
      redis.sadd ConcurrencyBalancer::REDIS_KEY, 'iri'
      expect { balancer.mark_as_finished_processing('iri') }.
        not_to raise_error
    end
  end

  context 'trying to unmark an unmarked iri' do
    it 'should completely fail' do
      expect { balancer.mark_as_finished_processing('iri') }.
        to raise_error(ConcurrencyBalancer::UnmarkedProcessingError)
    end
  end

  context 'marking an iri while unmarking another one' do
    it 'should be awesome' do
      redis.sadd ConcurrencyBalancer::REDIS_KEY, 'iri'
      expect { balancer.mark_as_processing_or_complain('second-iri', unlock_this_iri: 'iri') }.
        not_to raise_error
    end
  end

  context 'unlocking a marked iri "on error"' do
    it 'should not complain' do
      redis.sadd ConcurrencyBalancer::REDIS_KEY, 'iri'
      expect { balancer.unmark_as_processing_on_error('iri') }.
        not_to raise_error
    end

    it 'should work nicely' do
      redis.sadd ConcurrencyBalancer::REDIS_KEY, 'iri'
      balancer.unmark_as_processing_on_error('iri')
      expect(redis.sismember ConcurrencyBalancer::REDIS_KEY, 'iri').
        to be_falsy
    end
  end

  context 'unlocking an unmarked iri "on error"' do
    it 'should not complain' do
      expect { balancer.unmark_as_processing_on_error('iri') }.
        not_to raise_error
    end

    it 'should work nicely' do
      balancer.unmark_as_processing_on_error('iri')
      expect(redis.sismember ConcurrencyBalancer::REDIS_KEY, 'iri').
        to be_falsy
    end
  end

  context 'using the sequential lock' do
    it 'should fail when lock is taken' do
      redis.sadd(ConcurrencyBalancer::SEQUENTIAL_LOCK_KEY, true)
      expect { ConcurrencyBalancer.sequential_lock(&:+) }.
        to raise_error(ConcurrencyBalancer::AlreadyLockedError)
    end

    it "should work, when the lock isn't taken" do
      expect { ConcurrencyBalancer.sequential_lock { } }.
        not_to raise_error
    end

    it "should forward inner block errors when the lock isn't taken" do
      expect { ConcurrencyBalancer.sequential_lock { raise ArgumentError } }.
        to raise_error(ArgumentError)
    end

    it "should still release the lock on internal errors" do
      expect { ConcurrencyBalancer.sequential_lock { raise ArgumentError } }.
        to raise_error(ArgumentError)
      expect(redis.sismember ConcurrencyBalancer::REDIS_KEY, 'iri').to be(false)
    end
  end

end