test-printf-format-fix.c revision 957d34edbe3599fbb4e7c0bcf3785bd7fd4862c4
02c335c23bf5fa225a467c19f2c063fb0dc7b8c3Timo Sirainen/* Copyright (c) 2001-2016 Dovecot authors, see the included COPYING file */
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody/* Unit tests for printf-format-fix helper */
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody#include "test-lib.h"
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody#include "printf-format-fix.h"
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody#include <string.h>
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmodystruct format_fix_rewrites {
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody const char *input;
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody const char *output;
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody size_t length;
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody};
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmodystatic void test_unchanged()
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody{
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody static const char *tests[] = {
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody "Hello world",
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody "Embedded %%, %u, %f, etc. are OK",
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody "%%doesn't cause confusion in %%m and %%n",
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody };
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody unsigned int i;
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody test_begin("printf_format_fix(safe)");
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody for (i = 0; i < N_ELEMENTS(tests); ++i) {
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody unsigned int len;
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody T_BEGIN {
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody test_assert_idx(printf_format_fix(tests[i])
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody == tests[i], i);
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody test_assert_idx(printf_format_fix_get_len(tests[i], &len)
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody == tests[i], i);
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody test_assert_idx(len == strlen(tests[i]), i);
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody } T_END;
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody }
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody test_end();
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody}
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmodystatic void test_ok_changes()
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody{
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody static const char *tests[] = {
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody "OK to have a trailing %m",
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody "%m can appear at the start too",
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody "Even %m in the middle with a confusing %%m elsewhere is OK",
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody };
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody unsigned int i;
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody const char *needle;
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody unsigned int needlen;
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody int old_errno = errno;
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody test_begin("printf_format_fix(rewrites)");
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody errno = EINVAL;
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody needle = strerror(errno);
98c59517ebce19556221065e9231f007bbdd0038Timo Sirainen i_assert(needle != NULL);
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody needlen = strlen(needle);
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody for (i = 0; i < N_ELEMENTS(tests); ++i) {
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody unsigned int len;
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody char const *chgd;
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody char const *insert;
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody unsigned int offs;
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody T_BEGIN {
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody chgd = printf_format_fix(tests[i]);
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody test_assert_idx(chgd != tests[i], i);
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody insert = strstr(chgd, needle);
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody test_assert_idx(insert != NULL, i);
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody offs = insert - chgd;
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody test_assert_idx(memcmp(chgd, tests[i], offs) == 0, i);
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody test_assert_idx(memcmp(chgd+offs, needle, needlen) == 0, i);
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody test_assert_idx(strcmp(chgd+offs+needlen, tests[i]+offs+2) == 0, i);
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody chgd = printf_format_fix_get_len(tests[i], &len);
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody test_assert_idx(chgd != tests[i], i);
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody test_assert_idx(len == strlen(chgd), i);
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody insert = strstr(chgd, needle);
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody test_assert_idx(insert != NULL, i);
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody offs = insert - chgd;
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody test_assert_idx(memcmp(chgd, tests[i], offs) == 0, i);
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody test_assert_idx(memcmp(chgd+offs, needle, needlen) == 0, i);
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody test_assert_idx(memcmp(chgd+offs+needlen, tests[i]+offs+2, len-needlen-offs) == 0, i);
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody } T_END;
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody }
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody errno = old_errno;
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody test_end();
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody}
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmodyvoid test_printf_format_fix()
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody{
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody test_unchanged();
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody test_ok_changes();
8bec19723b39071a1794e76dec35d151473cae5fPhil Carmody}
8bec19723b39071a1794e76dec35d151473cae5fPhil Carmody
8bec19723b39071a1794e76dec35d151473cae5fPhil Carmody/* Want to test the panics too? go for it! */
957d34edbe3599fbb4e7c0bcf3785bd7fd4862c4Timo Sirainenenum fatal_test_state fatal_printf_format_fix(unsigned int stage)
8bec19723b39071a1794e76dec35d151473cae5fPhil Carmody{
8bec19723b39071a1794e76dec35d151473cae5fPhil Carmody static const char *fatals[] = {
8bec19723b39071a1794e76dec35d151473cae5fPhil Carmody "no no no %n's",
8bec19723b39071a1794e76dec35d151473cae5fPhil Carmody "%m allowed once, but not twice: %m",
8bec19723b39071a1794e76dec35d151473cae5fPhil Carmody "%m must not obscure a later %n",
8bec19723b39071a1794e76dec35d151473cae5fPhil Carmody "definitely can't have a tailing %",
8bec19723b39071a1794e76dec35d151473cae5fPhil Carmody };
8bec19723b39071a1794e76dec35d151473cae5fPhil Carmody
957d34edbe3599fbb4e7c0bcf3785bd7fd4862c4Timo Sirainen if(stage >= N_ELEMENTS(fatals)) {
8bec19723b39071a1794e76dec35d151473cae5fPhil Carmody test_end();
8bec19723b39071a1794e76dec35d151473cae5fPhil Carmody return FATAL_TEST_FINISHED;
8bec19723b39071a1794e76dec35d151473cae5fPhil Carmody }
8bec19723b39071a1794e76dec35d151473cae5fPhil Carmody
8bec19723b39071a1794e76dec35d151473cae5fPhil Carmody if(stage == 0)
8bec19723b39071a1794e76dec35d151473cae5fPhil Carmody test_begin("fatal_printf_format_fix");
8bec19723b39071a1794e76dec35d151473cae5fPhil Carmody
8bec19723b39071a1794e76dec35d151473cae5fPhil Carmody /* let's crash! */
8bec19723b39071a1794e76dec35d151473cae5fPhil Carmody (void)printf_format_fix(fatals[stage]);
8bec19723b39071a1794e76dec35d151473cae5fPhil Carmody return FATAL_TEST_FAILURE;
1d940afbc02516d8c3d016780e1223a779844a1ePhil Carmody}