bin/named/client.c

	client.c revision 12df8cb49ace435a6773b9d26d6246328f705245
380c874925f684847d9278b909cf511cb5b0289aShawn Routhier/*
380c874925f684847d9278b909cf511cb5b0289aShawn Routhier * Copyright (C) 1999  Internet Software Consortium.
380c874925f684847d9278b909cf511cb5b0289aShawn Routhier *
380c874925f684847d9278b909cf511cb5b0289aShawn Routhier * Permission to use, copy, modify, and distribute this software for any
380c874925f684847d9278b909cf511cb5b0289aShawn Routhier * purpose with or without fee is hereby granted, provided that the above
380c874925f684847d9278b909cf511cb5b0289aShawn Routhier * copyright notice and this permission notice appear in all copies.
380c874925f684847d9278b909cf511cb5b0289aShawn Routhier *
380c874925f684847d9278b909cf511cb5b0289aShawn Routhier * THE SOFTWARE IS PROVIDED "AS IS" AND INTERNET SOFTWARE CONSORTIUM DISCLAIMS
380c874925f684847d9278b909cf511cb5b0289aShawn Routhier * ALL WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES
380c874925f684847d9278b909cf511cb5b0289aShawn Routhier * OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL INTERNET SOFTWARE
380c874925f684847d9278b909cf511cb5b0289aShawn Routhier * CONSORTIUM BE LIABLE FOR ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL
380c874925f684847d9278b909cf511cb5b0289aShawn Routhier * DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR
380c874925f684847d9278b909cf511cb5b0289aShawn Routhier * PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS
380c874925f684847d9278b909cf511cb5b0289aShawn Routhier * ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS
380c874925f684847d9278b909cf511cb5b0289aShawn Routhier * SOFTWARE.
380c874925f684847d9278b909cf511cb5b0289aShawn Routhier */
380c874925f684847d9278b909cf511cb5b0289aShawn Routhier
380c874925f684847d9278b909cf511cb5b0289aShawn Routhier#include <config.h>
380c874925f684847d9278b909cf511cb5b0289aShawn Routhier
380c874925f684847d9278b909cf511cb5b0289aShawn Routhier#include <isc/assertions.h>
380c874925f684847d9278b909cf511cb5b0289aShawn Routhier#include <isc/mem.h>
380c874925f684847d9278b909cf511cb5b0289aShawn Routhier#include <isc/mutex.h>
380c874925f684847d9278b909cf511cb5b0289aShawn Routhier#include <isc/result.h>
380c874925f684847d9278b909cf511cb5b0289aShawn Routhier#include <isc/task.h>
380c874925f684847d9278b909cf511cb5b0289aShawn Routhier#include <isc/timer.h>
380c874925f684847d9278b909cf511cb5b0289aShawn Routhier
380c874925f684847d9278b909cf511cb5b0289aShawn Routhier#include <dns/dispatch.h>
380c874925f684847d9278b909cf511cb5b0289aShawn Routhier#include <dns/events.h>
380c874925f684847d9278b909cf511cb5b0289aShawn Routhier#include <dns/message.h>
380c874925f684847d9278b909cf511cb5b0289aShawn Routhier#include <dns/rdata.h>
380c874925f684847d9278b909cf511cb5b0289aShawn Routhier#include <dns/rdatalist.h>
380c874925f684847d9278b909cf511cb5b0289aShawn Routhier#include <dns/rdataset.h>
380c874925f684847d9278b909cf511cb5b0289aShawn Routhier#include <dns/view.h>
380c874925f684847d9278b909cf511cb5b0289aShawn Routhier#include <dns/xfrin.h>
380c874925f684847d9278b909cf511cb5b0289aShawn Routhier
380c874925f684847d9278b909cf511cb5b0289aShawn Routhier#include <named/globals.h>
380c874925f684847d9278b909cf511cb5b0289aShawn Routhier#include <named/client.h>
380c874925f684847d9278b909cf511cb5b0289aShawn Routhier#include <named/log.h>
380c874925f684847d9278b909cf511cb5b0289aShawn Routhier#include <named/query.h>
#include <named/update.h>

#include "../../isc/util.h"     /* XXX */

#define NS_CLIENT_TRACE
#ifdef NS_CLIENT_TRACE
#define CTRACE(m)   isc_log_write(ns_g_lctx, \
                      NS_LOGCATEGORY_CLIENT, \
                      NS_LOGMODULE_CLIENT, \
                      ISC_LOG_DEBUG(1), \
                      "client %p: %s", client, (m))
#define MTRACE(m)   isc_log_write(ns_g_lctx, \
                      NS_LOGCATEGORY_GENERAL, \
                      NS_LOGMODULE_CLIENT, \
                      ISC_LOG_DEBUG(1), \
                      "clientmgr %p: %s", manager, (m))
#endif

#define TCP_CLIENT(c)   (((c)->attributes & NS_CLIENTATTR_TCP) != 0)

#define SEND_BUFFER_SIZE        2048

struct ns_clientmgr {
    /* Unlocked. */
    unsigned int            magic;
    isc_mem_t *         mctx;
    isc_taskmgr_t *         taskmgr;
    isc_timermgr_t *        timermgr;
    isc_mutex_t         lock;
    /* Locked by lock. */
    isc_boolean_t           exiting;
    unsigned int            nclients;
    ISC_LIST(ns_client_t)       clients;
};

#define MANAGER_MAGIC           0x4E53436DU /* NSCm */
#define VALID_MANAGER(m)        ((m) != NULL && \
                     (m)->magic == MANAGER_MAGIC)


static void clientmgr_destroy(ns_clientmgr_t *manager);


/***
 *** Client
 ***/

/*
 * Important note!
 *
 * All client state changes, other than that from idle to listening, occur
 * as a result of events.  This guarantees serialization and avoids the
 * need for locking.
 *
 * If a routine is ever created that allows someone other than the client's
 * task to change the client, then the client will have to be locked.
 */

static inline void
client_free(ns_client_t *client) {
    dns_dispatchevent_t **deventp;

    CTRACE("free");

    ns_query_free(client);
    isc_mempool_destroy(&client->sendbufs);
    dns_message_destroy(&client->message);
    isc_timer_detach(&client->timer);
    if (client->dispentry != NULL) {
        if (client->dispevent != NULL)
            deventp = &client->dispevent;
        else
            deventp = NULL;
        dns_dispatch_removerequest(client->dispatch,
                       &client->dispentry,
                       deventp);
    }
    if (client->dispatch != NULL)
        dns_dispatch_detach(&client->dispatch);
    if (client->tcplistener != NULL)
        isc_socket_detach(&client->tcplistener);
    if (client->tcpsocket != NULL) {
        if (client->state == ns_clientstate_reading)
            dns_tcpmsg_cancelread(&client->tcpmsg);
        dns_tcpmsg_invalidate(&client->tcpmsg);
        isc_socket_detach(&client->tcpsocket);
    }
    isc_task_detach(&client->task);
    client->magic = 0;

    isc_mem_put(client->mctx, client, sizeof *client);
}

static void
client_destroy(ns_client_t *client) {
    ns_clientmgr_t *manager;
    isc_boolean_t need_clientmgr_destroy = ISC_FALSE;

    REQUIRE(NS_CLIENT_VALID(client));

    CTRACE("destroy");

    manager = client->manager;

    LOCK(&manager->lock);

    INSIST(manager->nclients > 0);
    manager->nclients--;
    if (manager->nclients == 0 && manager->exiting)
        need_clientmgr_destroy = ISC_TRUE;
    ISC_LIST_UNLINK(manager->clients, client, link);

    UNLOCK(&manager->lock);

    client_free(client);

    if (need_clientmgr_destroy)
        clientmgr_destroy(manager);
}

static void
client_shutdown(isc_task_t *task, isc_event_t *event) {
    ns_client_t *client;

    REQUIRE(event != NULL);
    REQUIRE(event->type == ISC_TASKEVENT_SHUTDOWN);
    client = event->arg;
    REQUIRE(NS_CLIENT_VALID(client));
    REQUIRE(task == client->task);

    CTRACE("shutdown");

    client_destroy(client);

    isc_event_free(&event);
}

static void client_read(ns_client_t *client);
static void client_accept(ns_client_t *client);

void
ns_client_next(ns_client_t *client, isc_result_t result) {

    REQUIRE(NS_CLIENT_VALID(client));
    REQUIRE(client->state == ns_clientstate_listening ||
        client->state == ns_clientstate_working);

    CTRACE("next");

    if (client->next != NULL) {
        (client->next)(client, result);
        client->next = NULL;
    }

    /*
     * XXXRTH  If result != ISC_R_SUCCESS:
     *      Log result if there is interest in doing so.
     */

    if (client->view != NULL)
        dns_view_detach(&client->view);
    if (client->opt != NULL)
        client->opt = NULL;
    client->udpsize = 512;
    dns_message_reset(client->message, DNS_MESSAGE_INTENTPARSE);
    if (client->dispevent != NULL) {
        dns_dispatch_freeevent(client->dispatch, client->dispentry,
                       &client->dispevent);
        client->state = ns_clientstate_listening;
    } else if (TCP_CLIENT(client)) {
        if (result == ISC_R_SUCCESS)
            client_read(client);
        else {
            if (client->tcpsocket != NULL) {
                dns_tcpmsg_invalidate(&client->tcpmsg);
                isc_socket_detach(&client->tcpsocket);
            }
            client_accept(client);
        }
    }
}

static void
client_senddone(isc_task_t *task, isc_event_t *event) {
    ns_client_t *client;
    isc_socketevent_t *sevent = (isc_socketevent_t *)event;

    REQUIRE(sevent != NULL);
    REQUIRE(sevent->type == ISC_SOCKEVENT_SENDDONE);
    client = sevent->arg;
    REQUIRE(NS_CLIENT_VALID(client));
    REQUIRE(task == client->task);

    CTRACE("senddone");

    INSIST(client->nsends > 0);
    client->nsends--;
    isc_mempool_put(client->sendbufs, sevent->region.base);

    isc_event_free(&event);

    /*
     * If all of its sendbufs buffers were busy, the client might be
     * waiting for one to become available.
     */
    if (client->state == ns_clientstate_waiting) {
        client->state = ns_clientstate_working;
        ns_client_send(client);
        return;
    }
    /* XXXRTH need to add exit draining mode. */
}

void
ns_client_send(ns_client_t *client) {
    isc_result_t result;
    unsigned char *data;
    isc_buffer_t buffer;
    isc_buffer_t tcpbuffer;
    isc_region_t r;
    isc_socket_t *socket;
    isc_sockaddr_t *address;
    unsigned int bufsize = 512;

    REQUIRE(NS_CLIENT_VALID(client));

    CTRACE("send");

    data = isc_mempool_get(client->sendbufs);
    if (data == NULL) {
        CTRACE("no buffers available");
        if (client->nsends > 0) {
            /*
             * We couldn't get memory, but there is at least one
             * send outstanding.  We arrange to be restarted when a
             * send completes.
             */
            CTRACE("waiting");
            INSIST(client->state == ns_clientstate_working);
            client->state = ns_clientstate_waiting;
        } else
            ns_client_next(client, ISC_R_NOMEMORY);
        return;
    }

    /*
     * XXXRTH  The following doesn't deal with TSIGs, TCP buffer resizing,
     *         or ENDS1 more data packets.
     */
    if (TCP_CLIENT(client)) {
        /*
         * XXXRTH  "tcpbuffer" is a hack to get things working.
         */
        isc_buffer_init(&tcpbuffer, data, SEND_BUFFER_SIZE,
                ISC_BUFFERTYPE_BINARY);
        isc_buffer_init(&buffer, data + 2, SEND_BUFFER_SIZE - 2,
                ISC_BUFFERTYPE_BINARY);
    } else {
        if (client->udpsize < SEND_BUFFER_SIZE)
            bufsize = client->udpsize;
        else
            bufsize = SEND_BUFFER_SIZE;
        isc_buffer_init(&buffer, data, bufsize, ISC_BUFFERTYPE_BINARY);
    }

    result = dns_message_renderbegin(client->message, &buffer);
    if (result != ISC_R_SUCCESS)
        goto done;
    if (client->opt != NULL) {
        result = dns_message_setopt(client->message, client->opt);
        if (result != ISC_R_SUCCESS)
            goto done;
    }
    result = dns_message_rendersection(client->message,
                       DNS_SECTION_QUESTION, 0, 0);
    if (result != ISC_R_SUCCESS)
        goto done;
    result = dns_message_rendersection(client->message,
                       DNS_SECTION_ANSWER, 0, 0);
    if (result == ISC_R_NOSPACE) {
        client->message->flags |= DNS_MESSAGEFLAG_TC;
        goto renderend;
    }
    if (result != ISC_R_SUCCESS)
        goto done;
    result = dns_message_rendersection(client->message,
                       DNS_SECTION_AUTHORITY, 0, 0);
    if (result == ISC_R_NOSPACE) {
        client->message->flags |= DNS_MESSAGEFLAG_TC;
        goto renderend;
    }
    if (result != ISC_R_SUCCESS)
        goto done;
    result = dns_message_rendersection(client->message,
                       DNS_SECTION_ADDITIONAL, 0, 0);
    if (result != ISC_R_SUCCESS && result != ISC_R_NOSPACE)
        goto done;
 renderend:
    result = dns_message_renderend(client->message);
    if (result != ISC_R_SUCCESS)
        goto done;

    if (TCP_CLIENT(client)) {
        socket = client->tcpsocket;
        address = NULL;
        isc_buffer_used(&buffer, &r);
        isc_buffer_putuint16(&tcpbuffer, (isc_uint16_t)r.length);
        isc_buffer_add(&tcpbuffer, r.length);
        isc_buffer_used(&tcpbuffer, &r);
    } else {
        socket = dns_dispatch_getsocket(client->dispatch);
        address = &client->dispevent->addr;
        isc_buffer_used(&buffer, &r);
    }
    CTRACE("sendto");
    result = isc_socket_sendto(socket, &r, client->task, client_senddone,
                   client, address);
    if (result == ISC_R_SUCCESS)
        client->nsends++;

 done:
    if (result != ISC_R_SUCCESS)
        isc_mempool_put(client->sendbufs, data);

    ns_client_next(client, result);
}

void
ns_client_error(ns_client_t *client, isc_result_t result) {
    dns_rcode_t rcode;
    dns_message_t *message;

    REQUIRE(NS_CLIENT_VALID(client));

    CTRACE("error");

    message = client->message;
    rcode = dns_result_torcode(result);

    /*
     * message may be an in-progress reply that we had trouble
     * with, in which case QR will be set.  We need to clear QR before
     * calling dns_message_reply() to avoid triggering an assertion.
     */
    message->flags &= ~DNS_MESSAGEFLAG_QR;
    /*
     * AA and AD shouldn't be set.
     */
    message->flags &= ~(DNS_MESSAGEFLAG_AA | DNS_MESSAGEFLAG_AD);
    result = dns_message_reply(message, ISC_TRUE);
    if (result != ISC_R_SUCCESS) {
        /*
         * It could be that we've got a query with a good header,
         * but a bad question section, so we try again with
         * want_question_section set to ISC_FALSE.
         */
        result = dns_message_reply(message, ISC_FALSE);
        if (result != ISC_R_SUCCESS) {
            /*
             * There's no hope of replying to this request.
             *
             * XXXRTH  Mark this client to that if it is a
             * TCP session, the session will be closed.
             */
            ns_client_next(client, result);
            return;
        }
    }
    message->rcode = rcode;
    ns_client_send(client);
}

static inline isc_result_t
client_addopt(ns_client_t *client) {
    dns_rdataset_t *rdataset;
    dns_rdatalist_t *rdatalist;
    dns_rdata_t *rdata;
    isc_result_t result;

    REQUIRE(client->opt == NULL);   /* XXXRTH free old. */

    rdatalist = NULL;
    result = dns_message_gettemprdatalist(client->message, &rdatalist);
    if (result != ISC_R_SUCCESS)
        return (result);
    rdata = NULL;
    result = dns_message_gettemprdata(client->message, &rdata);
    if (result != ISC_R_SUCCESS)
        return (result);
    rdataset = NULL;
    result = dns_message_gettemprdataset(client->message, &rdataset);
    if (result != ISC_R_SUCCESS)
        return (result);
    dns_rdataset_init(rdataset);

    rdatalist->type = dns_rdatatype_opt;
    rdatalist->covers = 0;

    /*
     * Set Maximum UDP buffer size.
     */
    rdatalist->rdclass = SEND_BUFFER_SIZE;

    /*
     * Set EXTENDED-RCODE, VERSION, and Z to 0.
     */
    rdatalist->ttl = 0;

    /*
     * No ENDS options.
     */
    rdata->data = NULL;
    rdata->length = 0;

    ISC_LIST_INIT(rdatalist->rdata);
    ISC_LIST_APPEND(rdatalist->rdata, rdata, link);
    dns_rdatalist_tordataset(rdatalist, rdataset);

    client->opt = rdataset;

    return (ISC_R_SUCCESS);
}

static void
client_request(isc_task_t *task, isc_event_t *event) {
    ns_client_t *client;
    dns_dispatchevent_t *devent;
    isc_result_t result;
    isc_buffer_t *buffer;
    dns_view_t *view;
    dns_rdataset_t *opt;

    REQUIRE(event != NULL);
    client = event->arg;
    REQUIRE(NS_CLIENT_VALID(client));
    REQUIRE(task == client->task);

    if (event->type == DNS_EVENT_DISPATCH) {
        devent = (dns_dispatchevent_t *)event;
        REQUIRE(client->dispentry != NULL);
        client->dispevent = devent;
        buffer = &devent->buffer;
        result = devent->result;
    } else {
        REQUIRE(event->type == DNS_EVENT_TCPMSG);
        REQUIRE(event->sender == &client->tcpmsg);
        buffer = &client->tcpmsg.buffer;
        result = client->tcpmsg.result;
    }

    CTRACE("request");

    client->state = ns_clientstate_working;
    if (isc_stdtime_get(&client->requesttime) != ISC_R_SUCCESS)
        client->requesttime = 0;

    if (result != ISC_R_SUCCESS) {
        if (TCP_CLIENT(client))
            ns_client_next(client, result);
        else
            isc_task_shutdown(client->task);
        return;
    }

    result = dns_message_parse(client->message, buffer, ISC_FALSE);
    if (result != ISC_R_SUCCESS) {
        ns_client_error(client, result);
        return;
    }
    INSIST((client->message->flags & DNS_MESSAGEFLAG_QR) == 0);

    /*
     * Deal with EDNS.
     */
    opt = dns_message_getopt(client->message);
    if (opt != NULL) {
        unsigned int version;

        /*
         * Set the client's UDP buffer size.
         */
        client->udpsize = opt->rdclass;

        /*
         * Create an OPT for our reply.
         */
        result = client_addopt(client);
        if (result != ISC_R_SUCCESS) {
            ns_client_error(client, result);
            return;
        }

        /*
         * Do we understand this version of ENDS?
         *
         * XXXRTH need library support for this!
         */
        version = (opt->ttl & 0x00FF0000) >> 16;
        if (version != 0) {
            ns_client_error(client, DNS_R_BADVERS);
            return;
        }
    }

    /*
     * XXXRTH  View list management code will be moving to its own module
     *         soon.
     */
    RWLOCK(&ns_g_viewlock, isc_rwlocktype_read);
    for (view = ISC_LIST_HEAD(ns_g_viewlist);
         view != NULL;
         view = ISC_LIST_NEXT(view, link)) {
        /*
         * XXXRTH  View matching will become more powerful later.
         */
        if (client->message->rdclass == view->rdclass) {
            dns_view_attach(view, &client->view);
            break;
        }
    }
    RWUNLOCK(&ns_g_viewlock, isc_rwlocktype_read);

    if (view == NULL) {
        CTRACE("no view");
        ns_client_error(client, DNS_R_REFUSED);
        return;
    }

    /*
     * Dispatch the request.
     */
    switch (client->message->opcode) {
    case dns_opcode_query:
        CTRACE("query");
        ns_query_start(client);
        break;
    case dns_opcode_update:
        CTRACE("update");
        ns_update_start(client);
        break;
    case dns_opcode_notify:
        CTRACE("notify");
        ns_client_error(client, DNS_R_NOTIMP);
        break;
    case dns_opcode_iquery:
        CTRACE("iquery");
        ns_client_error(client, DNS_R_REFUSED);
    default:
        CTRACE("unknown opcode");
        ns_client_error(client, DNS_R_NOTIMP);
    }
}

static void
client_timeout(isc_task_t *task, isc_event_t *event) {
    ns_client_t *client;

    REQUIRE(event != NULL);
    REQUIRE(event->type == ISC_TIMEREVENT_LIFE ||
        event->type == ISC_TIMEREVENT_IDLE);
    client = event->arg;
    REQUIRE(NS_CLIENT_VALID(client));
    REQUIRE(task == client->task);
    REQUIRE(client->timer != NULL);

    CTRACE("timeout");

    isc_event_free(&event);

    ns_client_next(client, ISC_R_TIMEDOUT);
}

static isc_result_t
client_create(ns_clientmgr_t *manager, ns_clienttype_t type,
          ns_client_t **clientp)
{
    ns_client_t *client;
    isc_result_t result;

    /*
     * Caller must be holding the manager lock.
     *
     * Note: creating a client does not add the client to the manager's
     * client list.  The caller is responsible for that.
     */

    REQUIRE(clientp != NULL && *clientp == NULL);

    client = isc_mem_get(manager->mctx, sizeof *client);
    if (client == NULL)
        return (ISC_R_NOMEMORY);

    client->task = NULL;
    result = isc_task_create(manager->taskmgr, manager->mctx, 0,
                 &client->task);
    if (result != ISC_R_SUCCESS)
        goto cleanup_client;
    result = isc_task_onshutdown(client->task, client_shutdown, client);
    if (result != ISC_R_SUCCESS)
        goto cleanup_task;

    client->timer = NULL;
    result = isc_timer_create(manager->timermgr, isc_timertype_inactive,
                  NULL, NULL, client->task, client_timeout,
                  client, &client->timer);
    if (result != ISC_R_SUCCESS)
        goto cleanup_task;

    client->message = NULL;
    result = dns_message_create(manager->mctx, DNS_MESSAGE_INTENTPARSE,
                    &client->message);
    if (result != ISC_R_SUCCESS)
        goto cleanup_timer;

    /* XXXRTH  Hardwired constants */
    client->sendbufs = NULL;
    result = isc_mempool_create(manager->mctx, SEND_BUFFER_SIZE,
                    &client->sendbufs);
    if (result != ISC_R_SUCCESS)
        goto cleanup_message;
    isc_mempool_setfreemax(client->sendbufs, 3);
    isc_mempool_setmaxalloc(client->sendbufs, 3);

    client->magic = NS_CLIENT_MAGIC;
    client->mctx = manager->mctx;
    client->manager = manager;
    client->type = type;
    client->state = ns_clientstate_idle;
    client->attributes = 0;
    client->waiting = 0;
    client->view = NULL;
    client->dispatch = NULL;
    client->dispentry = NULL;
    client->dispevent = NULL;
    client->tcplistener = NULL;
    client->tcpsocket = NULL;
    client->nsends = 0;
    client->opt = NULL;
    client->udpsize = 512;
    client->next = NULL;
    ISC_LINK_INIT(client, link);

    /*
     * We call the init routines for the various kinds of client here,
     * after we have created an otherwise valid client, because some
     * of them call routines that REQUIRE(NS_CLIENT_VALID(client)).
     */
    result = ns_query_init(client);
    if (result != ISC_R_SUCCESS)
        goto cleanup_sendbufs;

    CTRACE("create");

    *clientp = client;

    return (ISC_R_SUCCESS);

 cleanup_sendbufs:
    isc_mempool_destroy(&client->sendbufs);

    client->magic = 0;

 cleanup_message:
    dns_message_destroy(&client->message);

 cleanup_timer:
    isc_timer_detach(&client->timer);

 cleanup_task:
    isc_task_detach(&client->task);

 cleanup_client:
    isc_mem_put(manager->mctx, client, sizeof *client);

    return (result);
}

static void
client_read(ns_client_t *client) {
    isc_result_t result;

    CTRACE("read");

    result = dns_tcpmsg_readmessage(&client->tcpmsg, client->task,
                    client_request, client);
    if (result != ISC_R_SUCCESS)
        ns_client_next(client, result);
    client->state = ns_clientstate_reading;
}

static void
client_newconn(isc_task_t *task, isc_event_t *event) {
    ns_client_t *client = event->arg;
    isc_socket_newconnev_t *nevent = (isc_socket_newconnev_t *)event;

    REQUIRE(event->type == ISC_SOCKEVENT_NEWCONN);
    REQUIRE(NS_CLIENT_VALID(client));
    REQUIRE(client->task == task);

    CTRACE("newconn");

    if (nevent->result == ISC_R_SUCCESS) {
        client->tcpsocket = nevent->newsocket;
        dns_tcpmsg_init(client->mctx, client->tcpsocket,
                &client->tcpmsg);
        client_read(client);
    } else {
        /*
         * XXXRTH  What should we do?  We're trying to accept but
         *         it didn't work.  If we just give up, then TCP
         *     service may eventually stop.
         *
         *     For now, we just go idle.
         *
         *     Going idle is probably the right thing if the
         *     I/O was canceled.
         */
        client->state = ns_clientstate_idle;
    }

    isc_event_free(&event);
}

static void
client_accept(ns_client_t *client) {
    isc_result_t result;

    CTRACE("accept");

    result = isc_socket_accept(client->tcplistener, client->task,
                   client_newconn, client);
    if (result != ISC_R_SUCCESS) {
        UNEXPECTED_ERROR(__FILE__, __LINE__,
                 "isc_socket_accept() failed: %s",
                 isc_result_totext(result));
        /*
         * XXXRTH  What should we do?  We're trying to accept but
         *         it didn't work.  If we just give up, then TCP
         *     service may eventually stop.
         *
         *     For now, we just go idle.
         */
        client->state = ns_clientstate_idle;
        return;
    }
}

/***
 *** Client Manager
 ***/

static void
clientmgr_destroy(ns_clientmgr_t *manager) {
    REQUIRE(manager->nclients == 0);
    REQUIRE(ISC_LIST_EMPTY(manager->clients));

    MTRACE("clientmgr_destroy");

    manager->magic = 0;
    isc_mem_put(manager->mctx, manager, sizeof *manager);
}

isc_result_t
ns_clientmgr_create(isc_mem_t *mctx, isc_taskmgr_t *taskmgr,
            isc_timermgr_t *timermgr, ns_clientmgr_t **managerp)
{
    ns_clientmgr_t *manager;
    isc_result_t result;

    manager = isc_mem_get(mctx, sizeof *manager);
    if (manager == NULL)
        return (ISC_R_NOMEMORY);

    result = isc_mutex_init(&manager->lock);
    if (result != ISC_R_SUCCESS)
        goto cleanup_manager;

    manager->mctx = mctx;
    manager->taskmgr = taskmgr;
    manager->timermgr = timermgr;
    manager->exiting = ISC_FALSE;
    manager->nclients = 0;
    ISC_LIST_INIT(manager->clients);
    manager->magic = MANAGER_MAGIC;

    MTRACE("create");

    *managerp = manager;

    return (ISC_R_SUCCESS);

 cleanup_manager:
    isc_mem_put(manager->mctx, manager, sizeof *manager);

    return (result);
}

void
ns_clientmgr_destroy(ns_clientmgr_t **managerp) {
    ns_clientmgr_t *manager;
    ns_client_t *client;
    isc_boolean_t need_destroy = ISC_FALSE;

    REQUIRE(managerp != NULL);
    manager = *managerp;
    REQUIRE(VALID_MANAGER(manager));

    MTRACE("destroy");

    LOCK(&manager->lock);

    manager->exiting = ISC_TRUE;

    for (client = ISC_LIST_HEAD(manager->clients);
         client != NULL;
         client = ISC_LIST_NEXT(client, link))
        isc_task_shutdown(client->task);

    if (ISC_LIST_EMPTY(manager->clients))
        need_destroy = ISC_TRUE;

    UNLOCK(&manager->lock);

    if (need_destroy)
        clientmgr_destroy(manager);

    *managerp = NULL;
}

isc_result_t
ns_clientmgr_addtodispatch(ns_clientmgr_t *manager, unsigned int n,
               dns_dispatch_t *dispatch)
{
    isc_result_t result = ISC_R_SUCCESS;
    unsigned int i;
    ns_client_t *client;

    REQUIRE(VALID_MANAGER(manager));
    REQUIRE(n > 0);

    MTRACE("addtodispatch");

    /*
     * We MUST lock the manager lock for the entire client creation
     * process.  If we didn't do this, then a client could get a
     * shutdown event and disappear out from under us.
     */

    LOCK(&manager->lock);

    for (i = 0; i < n; i++) {
        client = NULL;
        result = client_create(manager, ns_clienttype_basic,
                       &client);
        if (result != ISC_R_SUCCESS)
            break;
        client->state = ns_clientstate_listening;
        dns_dispatch_attach(dispatch, &client->dispatch);
        result = dns_dispatch_addrequest(dispatch, client->task,
                         client_request,
                         client, &client->dispentry);
        if (result != ISC_R_SUCCESS) {
            client_free(client);
            break;
        }
        manager->nclients++;
        ISC_LIST_APPEND(manager->clients, client, link);
    }
    if (i != 0) {
        /*
         * We managed to create at least one client, so we
         * declare victory.
         */
        result = ISC_R_SUCCESS;
    }

    UNLOCK(&manager->lock);

    return (result);
}

isc_result_t
ns_clientmgr_accepttcp(ns_clientmgr_t *manager, isc_socket_t *socket,
               unsigned int n)
{
    isc_result_t result = ISC_R_SUCCESS;
    unsigned int i;
    ns_client_t *client;

    REQUIRE(VALID_MANAGER(manager));
    REQUIRE(n > 0);

    MTRACE("accepttcp");

    /*
     * XXXRTH
     *
     * This does not represent the planned method for TCP support,
     * because we are dedicating a few clients to servicing TCP requests
     * instead of allocating TCP clients from a pool and applying quotas.
     *
     * All this will be fixed later, but this code will allow parts of
     * the server that need TCP support, e.g. IXFR and AXFR, to progress.
     */

    /*
     * We MUST lock the manager lock for the entire client creation
     * process.  If we didn't do this, then a client could get a
     * shutdown event and disappear out from under us.
     */

    LOCK(&manager->lock);

    for (i = 0; i < n; i++) {
        client = NULL;
        result = client_create(manager, ns_clienttype_tcp, &client);
        if (result != ISC_R_SUCCESS)
            break;
        client->state = ns_clientstate_listening;
        client->attributes |= NS_CLIENTATTR_TCP;
        isc_socket_attach(socket, &client->tcplistener);
        client_accept(client);
        manager->nclients++;
        ISC_LIST_APPEND(manager->clients, client, link);
    }
    if (i != 0) {
        /*
         * We managed to create at least one client, so we
         * declare victory.
         */
        result = ISC_R_SUCCESS;
    }

    UNLOCK(&manager->lock);

    return (result);
}