Changes in attribute.html http://src.iws.cs.ovgu.de/source/rss/yui3/src/attribute/tests/attribute.html en Copyright 2005 Java Fixed (or at least returned to 3.4.1 state), the sublest regression ever, related to Y.cloning Attribute driven objects with Node values (e.g. Anim), on IE. Fundamentally, Y.cloning nodes is broken in IE and has been since 3.3.0. If an object holds multiple references to a Node instance, the first reference encountered while cloning, will be a damaged clone. Subsequent references encountered will not clone (and hence be OK). After the Attribute refactor, the value stored in State was the first reference encountered, resulting in permanent damage. Before the refactor, a transient event based reference was the first reference encountered, and hence was less likely to cause real-world problems. * Added unit test cases to cover cloning Attribute based objects, with node values * Tested on IE6, 7, 8, 9. * Ran some core unit tests (App, Plugin, Widget, Attribute, Base, Node) through Yeti on IE8, Chrome, Safari, FF. * Spot tested a couple of examples (Widget/App/Attribute). Wanted to get this in before testfest tomorrow. Fixes #2531929 Longer term fix for Y.clone(node) on IE is still required. /yui3/src/attribute/tests/attribute.html - 0b4bad3bc665dbd4cfc6d3c2b65a85b7c6781767 Satyen Desai <sdesai@yahoo-inc.com> More line level coverage for Attribute /yui3/src/attribute/tests/attribute.html - b6b02f95bf4c876d235372bcf5325bec49b3b701 Satyen Desai <sdesai@yahoo-inc.com> Added path to test valueFn:string /yui3/src/attribute/tests/attribute.html - fc959040918187071a259796aee3ff18a90dc22e Satyen Desai <sdesai@yahoo-inc.com> Fixed bugs in attribute._getAttrCfg and state.removeAll, found while bumping up unit test coverage for attribute-extras and attribute-core. Fixes #2531891. Fixes #2531892 Added standalone state unit tests also. /yui3/src/attribute/tests/attribute.html - d2fe481f82326b03c9a545af61f3379ac5d7fef1 Satyen Desai <sdesai@yahoo-inc.com> Fixed regression - Y.augment(node, Y.Attribute) not firing valueChange events. Fixes #2531851 /yui3/src/attribute/tests/attribute.html - 3f06abe9e62a6f13d506c568f6f40017cb856df9 Satyen Desai <sdesai@yahoo-inc.com> Fixed failing Attribute tests /yui3/src/attribute/tests/attribute.html - de3bb93a2386b0b0af425ce11af6db4e9c269b08 Dav Glass <davglass@gmail.com> Fixed failing Attribute tests /yui3/src/attribute/tests/attribute.html - 2b7125b1271732c191ab0b73be768534afd62fc5 Dav Glass <davglass@gmail.com> More adhoc attr tests - enabled/disabled /yui3/src/attribute/tests/attribute.html - 07226670a36c50b38c5abba8a36d013f36a75b7b Satyen Desai <sdesai@yahoo-inc.com> Initial drop for ad-hoc constructor attribute support. See #2528968 /yui3/src/attribute/tests/attribute.html - ed73fd1af1279111c591bd65981adbdc23a3a94a Satyen Desai <sdesai@yahoo-inc.com> * Added BaseCore Tests * Fixed AttributeCore to handle Base and BaseCore references (thanks to tests) * Fixed whitespace in Attribute docs. /yui3/src/attribute/tests/attribute.html - 42ca760bb9929dcdf6624637a7613f6f1ebcb4b4 Satyen Desai <sdesai@yahoo-inc.com> Prepped tests for coverage reporting /yui3/src/attribute/tests/attribute.html - 1bb9ba7f0e700971d0c04fca23820699348cfd49 Satyen Desai <sdesai@yahoo-inc.com> Added param support to constructor. Fixes #2530093. Added unit tests too (just like Ryan does) /yui3/src/attribute/tests/attribute.html - c4cf29edebef0d1c75ccfa55f67b2549c235bf8e Satyen Desai <sdesai@yahoo-inc.com> Pulled in modified tests (names, no console) from 3.1.0+ branch /yui3/src/attribute/tests/attribute.html - 98c1ab155c0e2148f69291b1abe1007c9d5a08e8 Satyen Desai <sdesai@yahoo-inc.com> Added writeOnce:'initOnly' support, to allow users to define attributes which can only be set during construction /yui3/src/attribute/tests/attribute.html - 3e7f85ec7387c4d64019bcf7fdc7bd4c11d1c381 Satyen Desai <sdesai@yahoo-inc.com> Added intl unit tests, fixed root lang handling to return instead of null for root lang. Fixed yui- to yui3- in attribute tests /yui3/src/attribute/tests/attribute.html - 30551f406370f7c8bf461a833205311de720886d Satyen Desai <sdesai@yahoo-inc.com> Updated to account for the "newVal" property of attribute change events passing through defined getter. /yui3/src/attribute/tests/attribute.html - f56f1f09f1262a349b35886a3dc54e54e53087c0 Todd Kloots <kloots@yahoo-inc.com> Added support to allow ATTRS function refs (setter, getter, validator, valueFn) to be specified by instance method name. Avoids anonymous fn hop and promotes best practice of encapsulating logic in instance methods /yui3/src/attribute/tests/attribute.html - 3250d374362f1262404330f9e1ff12ef90fd9ecc Satyen Desai <sdesai@yahoo-inc.com> Attribute should test against raw value stored in state, as opposed to massaged value from getter, when determining if state actually changed in order to notify after listeners. Fixes #2528248. It's a fairly rare case (rawNewVal === massagedPrevVal would not invoke after listeners) for which this would actually break in it's currently buggy state, but it's the right thing for Attribute to do, so wanted to make the fix for GA. * Attribute unit tests all pass, including new ones added for this use case. * No example regressions found, apart from one - in Overlay/Widget-StdMod set content before/after examples. * Widget-StdMod was broken because of the funky way it was handling set content changes, when inserting content before or after the existing content. Cleaning this up fixed the issue. /yui3/src/attribute/tests/attribute.html - 93b31bd141160f8d627792f39168f958fae4e569 Satyen Desai <sdesai@yahoo-inc.com> Added 2nd level merge for Node augmented with Attribute use case, to protect not only the attrs hash, but also each config. Code change is only used for the Node augmented with Attribute use case. Base use case is unchanged. /yui3/src/attribute/tests/attribute.html - 43a2d15bdc307ec452e019bef157e2e1b9eaf074 Satyen Desai <sdesai@yahoo-inc.com> Attribute currently will not invoke after listeners if the value of an attribute has not changed (using a newVal === prevVal test) during a set. This commit limits this behavior to primitives, so that attributes with Object values can be set to the same Object reference, but with modified Object state (e.g. property change, array elements added etc.) and still have after listeners notified to react to the changed Object state. /yui3/src/attribute/tests/attribute.html - b739fa18392d5b0246ada4f88f0fde5cf67ef2fb Satyen Desai <sdesai@yahoo-inc.com>