aa087e251c506cac2b1ca195c53f7eb3a9ef7542 |
|
02-Dec-2011 |
Luke Smith <lsmith@yahoo-inc.com> |
Fixing over-presumptive e.button assignment
e.which was assigned with the button code if
it wasn't undefined. Unfortunately, IE assigns
e.button = 0 for *key* events, which isn't undefined,
so it clobbered the e.keyCode assignment.
e.which now uses e.keyCode if it's truthy, then falls
back to a mapped e.button code, then to e.button.
Collateral damage: e.button is assigned for key events
now, since e.button is also mirrored on e.which.
Take away: just use e.which for keys and mouse events. |
de8655cb74225c53bb19a475b4b719f9f0ae2ee6 |
|
01-Dec-2011 |
Luke Smith <lsmith@yahoo-inc.com> |
Remove some useless logic from LazyEventFacade
LazyEventFacade is only supported for IE8, which
doesn't expose e.charCode or e.which for key events,
so there's no need to reference them, or even populate
the facade properties lazily. |
f841387cb4997959ecf710977b259b86f959ba48 |
|
12-Jul-2011 |
Luke Smith <lsmith@yahoo-inc.com> |
Fix e.button regression from 3.2.0->3.3.0
Commit 8d1736f6000b6c7657192d7bc13a23e374fed77b
caused e.button to report undefined in IE 6-8.
Better to use mouseup for button determination anyway,
but this is still a regression. |
466fc0d571f1df5f7b889a59f328ffcdcef0d87f |
|
12-Mar-2011 |
Luke Smith <lsmith@yahoo-inc.com> |
Add fallback for e.relatedTarget for simulated events
IE doesn't allow setting e.toElement or e.fromElement on
generic events, so Y.Event.simulate populates
e.relatedTarget instead. So first check the real life
properties, then fall back to the simulated compromise.
This is mainly to facilitate automated testing. |
5441886202f0ea3bda7b6d3fdf5b6b8dc01782ba |
|
12-Mar-2011 |
Luke Smith <lsmith@yahoo-inc.com> |
Use Y.config.lazyEventFacad for realz
The config was hard coded to true to facilitate testing
against all automated test suites without having to
modify them all. |
cfdfb15e991f069dc5a2c3a724d378a6395d4eac |
|
12-Mar-2011 |
Luke Smith <lsmith@yahoo-inc.com> |
Add support for YUI config lazyEventFacade (IE8 only)
Initial foray into leveraging Object.defineProperty
when setting up event facades so properties whose values
involve some complicated setup get get the benefit of
delaying the setup logic until the property is accessed.
Involves setting up a proxy object (a native, simulated
event) because IE8 only supports Object.defineProperty
used with DOM objects. Keep an eye out for some
work in the sandbox to leverage this same technique for
Chrome, Safari, and Firefox 3.0+.
Important note: since the object must be a DOM object,
it will no longer be instanceof Y.DOMEventFacade and
the object cannot be stored for later value retrieval,
since IE invalidates event objects at the end of the
JS thread of execution. |
466e89e60fbad15b099068ee771d408bc06f14c1 |
|
08-Dec-2010 |
Adam Moore <adamoore@yahoo-inc.com> |
tweaked event conditional module logic |
c64978b48fe561f13e3d68afc70d7c528946359b |
|
07-Dec-2010 |
Adam Moore <adamoore@yahoo-inc.com> |
hasFeature update for IE event conditional module (for IE9) [fixes bug #2529587]. |
772f655fcf57e58b97fa46b6a8d3fc772b83f743 |
|
22-Oct-2010 |
Adam Moore <adamoore@yahoo-inc.com> |
key events have the charCode assigned to the event facade's 'which' [fixes #2528975]. |
22efc9d4ee55a01a5ab27b1bd8325e1bfc8e550a |
|
16-Oct-2010 |
Adam Moore <adamoore@yahoo-inc.com> |
e.button and e.which normalized to 1/2/3 for l/m/r buttons
respectively. Didn't normalize e.button to 0/1/2 (which may be
more correct) because it would break existing implementations [fixes #2529140]. |
011173392d3a1a59092095d5a24857134cb16f93 |
|
06-Oct-2010 |
Adam Moore <adamoore@yahoo-inc.com> |
Fixed memory leak when adding a listener to an element that is never
inserted into the dom [fixes #2529385]. Added a conditional module for
IE. Faster event facades. |
e3cee6b38c62be71fcb6028e299980eb886a0544 |
|
05-Oct-2010 |
Adam Moore <adamoore@yahoo-inc.com> |
Fixed memory leak when adding a listener to an element that is never
inserted into the dom [fixes #2529385]. Added a conditional module for
IE. Faster event facades. |