VBoxNetNAT, VBoxNetDHCP: use the VirtualBoxClient interface

NAT networks: don't kill VBoxNetDHCP and VBoxNetNAT but send the INATNetworkStartStop event to ask them politely to shutdown

VBoxNetLwipNAT: Windows build fix.

Massage release logging for port-forwarding a bit. Log rules on startup.

NATNet: clean up handling of port-forwarding rules a bit. Don't assert what we don't control, deal with failure. Use RTCMemAutoPtr to manage fwspec copy. Add release logging to VBoxEventType_OnNATNetworkPortForward.

Oops, fix TABs in previous.

fetchNatPortForwardRules: pass fIsIPv6 flag to netPfStrToPf.

VBoxNetLwipNAT::natServicePfRegister: fix trivial constness XXX.

VBoxNetBaseService.cpp: fix build on ancient Linux box.

Print ifconfig-like information about proxy netif to release log.

Entity parameter to VBoxLogRelCreate is used only for log file header intended for human consumption, so use friendlier "NAT Network".

Create NAT Network release logger. This can probably use some improvements. Log rotation is not implemented yet.

TrustedMain: when com::Initialize() fails make error reporting more sane.

spaces

Deal with ETH_PAD_SIZE != 0. Express processGSO() in terms of processFrame() to avoid code duplication.

Get rid of LWIP_SOCKET - we don't need it for NAT and it pollutes namespace.

Refer to lwip symbols without lwip_ prefix introduced by our internal renaming. Renaming will do the right thing if present. Same object code is generated.

Add ifdefed out code to use debug helper for raw ICMP sockets. Add to the makefile commented out option to enable it.

VBoxNetLwipNAT::init: fix begin/end pasto in the condition of the loop over IPv4 loopback mappings.

DHCP/NAT and NAT are acting in the same manner: polling for events on main thread and waiting for packets on internal network on RECV thread. DHCP/Host-Only waits for packets on main thread.

NetworkServices/NAT: windows build fix

VBoxNetLwipNAT.cpp: extract fetchNatPortForwardRules() to fetch ipv4 and ipv6 port-forward-rules.

VBoxNetLwipNAT.cpp: uses exported functions and listener declaration.

VBoxNetLwipNAT.cpp: G/c extra lines.

VBoxNetLwipNAT: G/c removes uniused members and its initializarion: hReqIntNet and hSemSVC.

VBoxNetBaseService hides all details of internal network implementation and become responsible for supporting receiving loop. Notification of children are done via introduced interface: virtual int processFrame(void *, size_t) = 0; virtual int processGSO(PCPDMNETWORKGSO, size_t) = 0; virtual int processUDP(void *, size_t) = 0; processFrame() and processGSO() might return VERR_IGNORED, to inform base service switch to processUDP() (e.g. for DHCP needs)

ICMP_FILTER is not privileged. Drop the comment now that setsockopt was fixed in previous. Things work better when done correctly...

Fix edito in previous: create icmp6 socket using OS-specific socket type, always use SOL_RAW for Linux-specific ICMP_FILTER.

Create ICMP sockets for ping proxy.

G/c redundant lwIP includes.

NetworkServices: VBoxNetBaseService::isMainNeeded() +const.

VBoxNetNAT: always needs Main.

Introduce option "--need-main(-M) on|off" in network services to emphosize whether network service need to establish connection with Main (by default this optiois off).

Handle VBoxNetLwipNAT::init() failure too.

VBoxNetBaseService::tryGoOnline: return iprt status code. Adapt VBoxNetDHCP, add check in VBoxNetLwipNAT.

Finish DNS proxy code and hook it in.

Add listener for HostNameResolutionConfigurationChange (a do-nothing as of yet). Doesn't get events yet b/c of problems on the event source side that are being worked on.

VBoxNetLwipNAT::init: Move code to read IPv6 options so that options-related code is grouped together.

VBoxNetLwipNAT::init: shuffle delcarations a bit to improve readability.

Rename VBoxNetLwipNAT::net to m_net

On NATNetworkSetting trigger quick RAs.

Fix TAB/spaces in previous.

VBoxNetLwipNAT::HandleEvent: set NATSEVICEPORTFORWARDRULE::Pfr::fPfrIPv6

VBoxNetNAT: drops Windows's limitation on registering listeners.

NetworkServices: coding style

VBoxNetLwipNAT.cpp: event qeue processing (borrowed from VBoxHeadless).

VBoxNetLwipNAT.cpp: extend listener scope to class level.

VBoxNetLwipNAT.cpp: typo (copy'n'paste) in dynamic port-forwarding proccessing.

Listen for VBoxEventType_OnNATNetworkSetting to pick up changes in AdvertiseDefaultIPv6RouteEnabled. XXX: We also need to prod rtadvd to send unsolicited advertisement with updated router lifetime, but event delivery seems to be busted, so I can't test that properly. For now just pick up the flag, that will be announced on the next scheduled advertisement.

Blank lines nit.

Rename PortForwardListener to NATNetworkListener (with more events to come).

Do not configure IPv6 addresses and netif::output_ip6 method on the proxy netif if IPv6 is disabled for this NAT network.

Change vestigial names proxytest.* to proxy.*

NetworkServices: Whitespace (including tabs!) and svn:keywords cleanups by scm.

VBoxNetLwipNAT: warns [-Wunused-parameter].

VBoxNetLwipNAT: PortForwardListener::PortForwardListener() explicitly initializes m_pNAT with NULL PortForwardListener::init(VBoxNetLwipNAT *) allows only non-NULL values. PortForwardListener::(un)init() assign m_pNAT to NULL.

VBoxNetLwipNAT: PortForwardListener: cosmetic(lines).

VBoxNetLwipNAT: PortForwardListener uses default (de)constructor, init's n_pNAT with init(...) functions, PortForwardListener::HandleEvent checks m_pNAT before proxying event.

VBoxNetLwipNAT::HandleEvent: pfEvt->COMGETTER(HostPort -> GuestPort)(&lGuestPort);

VBoxNetLwipNAT::init(): vbox-style of multiline if-clause.

VBoxNetLwipNAT::init() Loopback mapping should be loaded unconditionally.

VBoxNetLwipNAT::VBoxNetLwipNAT() initialization of fDontLoadRulesOnStartup to false.

VBoxNetLwipNAT::init: temporary com::Utf8Str object is destructed at the end of the statement, leaving pszLo2Off dangling - give it proper lifetime.

NAT/Loopback mapping: changes semantically unrelated symbol ";" with more expressive "=" for map opperation. VBoxManage natnework modify -t nat-test-1 -l "127.0.1.3=8"

NAT/Lwip: bypass registered loopbacks to proxy.

lwip-nat: warnings [-Wshadow]

lwip-nat: warning [-Wshadow].

lwip-nat: fetching local bindings. (disabled).

VBoxNetNAT: binding to specific interface (IPv4). Address to interface is taken from extradata: NAT/<network-name>/SourceIp4 e.g. # VBoxManage setextradata global "NAT/win-nat-test-0/SourceIp4" 192.168.1.185

lwip-nat: move IPv6 to _DEFS

VBoxNetNAT: (tabs).

VBoxNetNAT: typo: adding ipv4 rules to ip6 list.

Move code to set up IPv6 addresses to VBoxNetLwipNAT::netifInit. While there, clean up netifInit a bit.

VBoxNetLwipNAT::netifInit: it's Ethernet, so create ipv6 link-local address using EUI-64 mapping.

Oops, use sin_len/sin6_len instead of sa_len.

Provide ability to bind proxy socket to a local address - to be used to implement equivalent of --natbindip<N>.

lwip-nat: give just allocated copy of PF descriptor.

lwip-nat: Don't apply port-forward rules immediatly (pollmgr isn't ready yet).

fix OSE