tree-wide: remove Emacs lines from all files This should be handled fine now by .dir-locals.el, so need to carry that stuff in every file.

udev: add emacs header line Otherwise emacs wants to use 2-space indentation and other attrocities.

util-lib: split out allocation calls into alloc-util.[ch]

util-lib: split out globbing related calls into glob-util.[ch]

util-lib: split stat()/statfs()/stavfs() related calls into stat-util.[ch]

util-lib: split out user/group/uid/gid calls into user-util.[ch]

util-lib: split out fd-related operations into fd-util.[ch] There are more than enough to deserve their own .c file, hence move them over.

util-lib: split our string related calls from util.[ch] into its own file string-util.[ch] There are more than enough calls doing string manipulations to deserve its own files, hence do something about it. This patch also sorts the #include blocks of all files that needed to be updated, according to the sorting suggestions from CODING_STYLE. Since pretty much every file needs our string manipulation functions this effectively means that most files have sorted #include blocks now. Also touches a few unrelated include files.

util: split out escaping code into escape.[ch] This really deserves its own file, given how much code this is now.

udev: fix format string after conversion to log_*_errno() Use %m where previously %s was used together with strerrno(). Fixes: e53fc357a9b "tree-wide: remove a number of invocations of strerror() and replace by %m"

Support OP_NOMATCH for TAG key The TAG key can be used in rules for event matching. At the moment, it does not support inequality tests. This patch enhances the key test to validate the rule if it does not contain a given TAG (by TAG!="value"). Signed-off-by: Felipe Franciosi <felipe@paradoxo.org>

tree-wide: remove a number of invocations of strerror() and replace by %m Let's clean up our tree a bit, and reduce invocations of the thread-unsafe strerror() by replacing it with printf()'s %m specifier.

tree-wide: update empty-if coccinelle script to cover empty-while and more Let's also clean up single-line while and for blocks.

tree-wide: drop {} from one-line if blocks Patch via coccinelle.

tree-wide: use coccinelle to patch a lot of code to use mfree() This replaces this: free(p); p = NULL; by this: p = mfree(p); Change generated using coccinelle. Semantic patch is added to the sources.

tree-wide: fix indentation

tree-wide: introduce mfree() Pretty trivial helper which wraps free() but returns NULL, so we can simplify this: free(foobar); foobar = NULL; to this: foobar = mfree(foobar);

tree-wide: use free_and_strdup() Use free_and_strdup() where appropriate and replace equivalent, open-coded versions.

udev: remove WAIT_FOR key This facility was never a proper solution, but only papered over real bugs in the kernel. There are no known sysfs "timing bugs" since a long time.

udev: event - simplify udev_event_spawn() logic Push the extraction of the envp + argv as close as possible to their use, to avoid code duplication. As a sideeffect fix logging when delaing execution.

udevd: event - don't log about failures of spawn processes when this is expected PROGRAM and IMPORT{program} uses the exit code of the spawn process to decide if a rule matches or not, a failing process is hence normal operation and not something we should warn about. We still warn about other types of failing processes.

tree-wide: remove spurious space

udevd: simplify signal mask handling We used to block all signals, and restore the original signal mask before exec'ing external processes. Now we just block the signals we care about and unconditionally unblock all signals before exec'ing.

udev: add some asserts Mostly for documentation purposes.

udev: add SYSCTL{} support

libudev: add missing hunks This should have been committed with udev_device_add_property - implicitly mark properties for saving to db

libudev: udev_device_add_property - implicitly mark properties for saving to db Properties should only be saved to the db when added to the udev_device by udevd, and only if the property does not start with a '.'. Make this implicit rather than expose the marking of properties.

udev: strings in C are NUL-terminated anyway, no need to add a second NUL...

udev: rules - ignore the lack of trailing newline Also accept '\r' as newline character. This dropps warnings of the type: invalid key/value pair in file /usr/lib/udev/rules.d/40-usb-media-players.rules on line 26, starting at character 25 ('')

udev: rules - print the first invalid character The current code would print the character following the first invalid character. Given an udev rules-file without a trailing newline we would otherwise print garbage: invalid key/value pair in file /usr/lib/udev/rules.d/40-usb-media-players.rules on line 26, starting at character 25 ('m') This is now changed to print invalid key/value pair in file /usr/lib/udev/rules.d/40-usb-media-players.rules on line 26, starting at character 25 ('') (still not very good as printing \0 just gives the empty string)

udev: rules - modernise add_rule a bit

treewide: another round of simplifications Using the same scripts as in f647962d64e "treewide: yet more log_*_errno + return simplifications".

treewide: use log_*_errno whenever %m is in the format string If the format string contains %m, clearly errno must have a meaningful value, so we might as well use log_*_errno to have ERRNO= logged. Using: find . -name '*.[ch]' | xargs sed -r -i -e \ 's/log_(debug|info|notice|warning|error|emergency)\((".*%m.*")/log_\1_errno(errno, \2/' Plus some whitespace, linewrap, and indent adjustments.

treewide: yet more log_*_errno + return simplifications Using: find . -name '*.[ch]' | while read f; do perl -i.mmm -e \ 'local $/; local $_=<>; s/(if\s*\([^\n]+\))\s*{\n(\s*)(log_[a-z_]*_errno\(\s*([->a-zA-Z_]+)\s*,[^;]+);\s*return\s+\g4;\s+}/\1\n\2return \3;/msg; print;' $f done And a couple of manual whitespace fixups.

treewide: more log_*_errno() conversions

treewide: drop unnecessary trailing \n in log_*() calls

treewide: no need to negate errno for log_*_errno() It corrrectly handles both positive and negative errno values.

treewide: auto-convert the simple cases to log_*_errno() As a followup to 086891e5c1 "log: add an "error" parameter to all low-level logging calls and intrdouce log_error_errno() as log calls that take error numbers", use sed to convert the simple cases to use the new macros: find . -name '*.[ch]' | xargs sed -r -i -e \ 's/log_(debug|info|notice|warning|error|emergency)\("(.*)%s"(.*), strerror\(-([a-zA-Z_]+)\)\);/log_\1_errno(-\4, "\2%m"\3);/' Multi-line log_*() invocations are not covered. And we also should add log_unit_*_errno().

udev: support ENV{}=="" global property matches

udev: use properly the systemd logging functions

udev: use the systemd logging functions in udev tools

udev: rules - close empty file If the file is found to be empty, we exit early without closing the file first. Found by coverity. Fixes CID #1237759.

udev: rules - add missing whitespace to log message

libudev: drop util_lookup_{user,group} Use shared versions instead. Difference is with overwriting of repeated user/group name, and lack of logging.

udev: timeout - warn after a third of the timeout before killing

udev: allow removing tags via TAG-="foobar" This extends the udev parser to support OP_REMOVE (-=) and adds support for TAG-= to remove previously set tags. We don't fail if the tag didn't exist. This is pretty handy if we ship default rules for seat-assignments and users want to exclude specific devices from that. They can easily add rules that drop any automatically added "seat" tags again.

udev: fix copy-paste error in log message

Revert "libudev: use get_*_creds from shared rather than util_lookup_*" This reverts commit a56ba6158b9649e01226dfaf3ff7082c82571090. The commit was pushed in error.

libudev: use get_*_creds from shared rather than util_lookup_*

udev: fixup commit dd5eddd28a74a49607a8fffcaf960040dba98479 Commit dd5eddd28a74a49607a8fffcaf960040dba98479 accidentally removed one line too many.

udev: place opening { at the same line as the function declaration

udev: unify event timeout handling

Be more careful when checking for empty files If we want to avoid reading a totally empty file, it seems better to check after we have opened the file, not before.

udev: increase the size of RESULT buffer Under some conditions, in udev_rules_apply_to_event the fact that result is 1024 bytes, creates problems if the output of the running command/app is bigger then 1024 bytes.

udev: do not export "static node" tags for non-existing devices

Use strlen even for constant strings GCC optimizes strlen("string constant") to a constant, even with -O0. Thus, replace patterns like sizeof("string constant")-1 with strlen("string constant") where possible, for clarity. In particular, for expressions intended to add up the lengths of components going into a string, this often makes it clearer that the expression counts the trailing '\0' exactly once, by putting the +1 for the '\0' at the end of the expression, rather than hidden in a sizeof in the middle of the expression.

Remove unused variable and two function stubs

everywhere: make use of new0() and macro() macros, and stop using perror()

use memzero(foo, length); for all memset(foo, 0, length); calls In trying to track down a stupid linker bug, I noticed a bunch of memset() calls that should be using memzero() to make it more "obvious" that the options are correct (i.e. 0 is not the length, but the data to set). So fix up all current calls to memset(foo, 0, length) to memzero(foo, length).

udev: static_node - do not exit rule after first static_node item The nodes usually do not exist, so handle the next item instead of skipping the entire rule.

No need to canonicalize fixed paths

systemctl: allow globbing in commands which take multiple unit names

log: log_error() and friends add a newline after each line anyway, so avoid including it in the log strings

trivial coding style clean ups - Add space between if/for and the opening parentheses - Place the opening brace on same line as the function (not for udev) From the CODING_STYLE Try to use this: void foo() { } instead of this: void foo() { }

tree-wide usage of %m specifier instead of strerror(errno) Also for log_error() except where a specific error is specified e.g. errno ? strerror(errno) : "Some user specified message"

udev: udevd - rules can be NULL when reloading

udev: rules - move parsing error to log_error()

udev: do not allow to change the DEVPATH of a device

path_check_timestamp: only keep the most recent timestamp There is no point in keeping one timestamp for each directory, as we only ever care about the most recent one.

udev: move udev_rules_check_timestamp to shared I want to use this from a bulitin in a subsequent patch.

udev: support custom Linux Security Module labels for device nodes

udev-rules: avoid erroring on trailing whitespace https://bugs.archlinux.org/task/36950

udev: fix printf(3) type specifier src/udev/udev-rules.c: In function 'add_rule': src/udev/udev-rules.c:1078:33: warning: format '%lu' expects argument of type 'long unsigned int', but argument 8 has type 'int' [-Wformat=] log_error("invalid key/value pair in file %s on line %u," ^

udev: when complaining about invalid characters, print them out systemd-udevd[6260]: invalid key/value pair in file /usr/lib/udev/rules.d/60-ffado.rules on line 46,starting at character 84 ('#')

udev-rules: report rule parsing errors from get_key

udev: static_node - don't touch permissions uneccessarily Don't set default permissions if only TAGS were specified in a rule.

udev: log error if chmod/chown of static dev nodes fails

udev: export tags of "dead" device nodes to /run/udev/static_node-tags/ Based on a patch by Kay Sievers. A tag is exported at boot as a symlinks to the device node in the folder /run/udev/static_node-tags/<tagname>/, if the device node exists. These tags are cleaned up by udevadm info --cleanup-db, but are otherwise never removed.

libudev: Use correct type for sizeof

Fix spelling errors using 'codespell' tool

use strneq instead of strncmp

shared: conf-files - add root parameter

udev: move string copy functions to shared/

udev: in addition to DEVMODE, honor DEVUID, DEVGID from the uevent

use the same email address everywhere

udev: use usec_t and now()

udev: get rid of SYSCONFDIR

udev: use strbuf to store rules strings

udev: support multiple entries for ENV{SYSTEMD_ALIAS} and ENV{SYSTEM_WANTS}

udev: remove SYMLINK "unique" option

udev: free rule structure on error

udev: fix typo in copyright

udev: initialize rules dir timestamps when reading rules On Wed, Aug 8, 2012 at 11:48 AM, Michael Schroeder <mls@suse.de> wrote: > if rules are installed in the first 3 seconds after the udev start, > the stamps will all be zero, so the [first] call to check_rules_timestamp() > will just copy the current mtime [and not cause a rules re-load].

udev: get rid of TEST_PREFIX and use unshare() to fake /sys, /dev, /run

udev: add some O_CLOEXEC

udev: skip timestamp check if rules are already free()d during reload

util: split-out path-util.[ch]

util: split-out conf-file.[ch]

udev: use conf_files_list() to search rules files

udev: fix the ENV{} blacklist logic

udev: use startswith() and streq()

udev: remove configuration options for /dev, /sys, /run directories

udev: replace ARRAY_SIZE() with ELEMENTSOF()

udev: fix RUN+= logic regarding builtin vs. program

udev: fix gcc warnings showing up after adding $(AM_CFLAGS)

udev: remove RUN+="socket:.." and udev_monitor_new_from_netlink()

udev: convert 'uaccess' to a builtin

udev: switch to systemd logging functions

move imported udev into place