tree-wide: remove Emacs lines from all files This should be handled fine now by .dir-locals.el, so need to carry that stuff in every file.

tree-wide: use xsprintf() where applicable Also add a coccinelle receipt to help with such transitions.

udev: add emacs header line Otherwise emacs wants to use 2-space indentation and other attrocities.

treewide: apply errno.cocci with small manual cleanups for style.

util-lib: move a number of fs operations into fs-util.[ch]

util-lib: split our string related calls from util.[ch] into its own file string-util.[ch] There are more than enough calls doing string manipulations to deserve its own files, hence do something about it. This patch also sorts the #include blocks of all files that needed to be updated, according to the sorting suggestions from CODING_STYLE. Since pretty much every file needs our string manipulation functions this effectively means that most files have sorted #include blocks now. Also touches a few unrelated include files.

smack-util: revise smack-util apis and add read smack attr apis - Add smack xattr lookup table - Unify all of mac_smack_apply_xxx{_fd}() to mac_smack_apply() and mac_smack_apply_fd(). - Add smack xattr read apis similar with apply apis as mac_smack_read{_fd}().

shared: add formats-util.h

remove unused includes This patch removes includes that are not used. The removals were found with include-what-you-use which checks if any of the symbols from a header is in use.

Assorted format fixes Types used for pids and uids in various interfaces are unpredictable. Too bad.

tmpfiles: add new line type 'v' for creating btrfs subvolumes

treewide: use log_*_errno whenever %m is in the format string If the format string contains %m, clearly errno must have a meaningful value, so we might as well use log_*_errno to have ERRNO= logged. Using: find . -name '*.[ch]' | xargs sed -r -i -e \ 's/log_(debug|info|notice|warning|error|emergency)\((".*%m.*")/log_\1_errno(errno, \2/' Plus some whitespace, linewrap, and indent adjustments.

treewide: no need to negate errno for log_*_errno() It corrrectly handles both positive and negative errno values.

treewide: auto-convert the simple cases to log_*_errno() As a followup to 086891e5c1 "log: add an "error" parameter to all low-level logging calls and intrdouce log_error_errno() as log calls that take error numbers", use sed to convert the simple cases to use the new macros: find . -name '*.[ch]' | xargs sed -r -i -e \ 's/log_(debug|info|notice|warning|error|emergency)\("(.*)%s"(.*), strerror\(-([a-zA-Z_]+)\)\);/log_\1_errno(-\4, "\2%m"\3);/' Multi-line log_*() invocations are not covered. And we also should add log_unit_*_errno().

udev: do NOT re-label smack If selinux is disabled and smack is only enabled, smack label is relable-ed by label_fix. To avoid, make only be labeled for selinux.

selinux: clean up selinux label function naming

smack: rework smack APIs a bit a) always return negative errno error codes b) always become a noop if smack is off c) always take a NULL label as a request to remove it

mac: rename all calls that apply a label mac_{selinux|smack}_apply_xyz(), and all that reset it to defaults mac_{selinux|smack}_fix() Let's clean up the naming schemes a bit and use the same one for SMACK and for SELINUX.

mac: rename apis with mac_{selinux/smack}_ prefix

udev: node - warn if chmod/chown fails No functional change, just log the warning. Fonud by Coverity. Fixes CID #1237544.

libudev: util - drop util_delete_path() Use rmdir_parents() from src/shared instead.

udev: place opening { at the same line as the function declaration

log: log_error() and friends add a newline after each line anyway, so avoid including it in the log strings

smack: minimize ifdef use, and move all labeling to smack-util.c

security: rework selinux, smack, ima, apparmor detection logic Always cache the results, and bypass low-level security calls when the respective subsystem is not enabled.

udev: add SECLABEL{selinux}= support

udev: reset Linux Security Module labels if no custom rules are given

udev: support custom Linux Security Module labels for device nodes

use streq instead of strcmp

udev: use unique names for temporary files created in /dev On Tue, Feb 12, 2013 at 2:18 PM, Robert Milasan <rmilasan@suse.com> wrote: > Under some circumstances udev mixed with multipath fails: > > udevd-work[1376]: > symlink(../../sdk, /dev/disk/by-id/scsi-36005076305ffc0670000000000002842.udev-tmp) > failed: File exists udevd-work[1432]: > rename(/dev/disk/by-id/scsi-36005076305ffc0850000000000000a88.udev-tmp, /dev/disk/by-id/scsi-36005076305ffc0850000000000000a88) > failed: No such file or directory > > This is non-fatal, but there is no point of created the symlink or > renaming the symlink if it already exists. > > Reference: https://bugzilla.novell.com/show_bug.cgi?id=791503 It looke like this now: stat("/dev/disk/by-id", {st_mode=S_IFDIR|0755, st_size=80, ...}) = 0 symlink("../../sda", "/dev/disk/by-id/ata-INTEL...N.tmp-b8:0") = 0 rename("/dev/disk/by-id/ata-INTEL...N.tmp-b8:0", "/dev/disk/by-id/ata-INTEL...N") = 0

udev: set default rules permissions only at "add" events

udev: move string copy functions to shared/

udev: set device node permissions only at "add" events

use the same email address everywhere

udev: remove SYMLINK "unique" option

udev: export udev_device_new_from_device_id()

udev: get rid of TEST_PREFIX and use unshare() to fake /sys, /dev, /run

udev: never touch device nodes with symlink requests

mount-setup: don't complain if we try to fix the label of a dir beneath a mount but can't due to EROFS

udev: remove remaining selinux labeling for file in /run

mkdir: append _label to all mkdir() calls that explicitly set the selinux context

selinux: unify systemd and udev code

udev: replace util_create_path() with mkdir_parents()

udev: remove configuration options for /dev, /sys, /run directories

udev: fix gcc warnings showing up after adding $(AM_CFLAGS)

udev: switch to systemd logging functions

move imported udev into place