tree-wide: remove Emacs lines from all files This should be handled fine now by .dir-locals.el, so need to carry that stuff in every file.

udev: add emacs header line Otherwise emacs wants to use 2-space indentation and other attrocities.

udev: fix NULL deref when executing rules We quite obviously check whether event->dev_db is nonnull, and right after that call a function which asserts the same. Move the call under the same if. https://bugzilla.redhat.com/show_bug.cgi?id=1283971

tree-wide: expose "p"-suffix unref calls in public APIs to make gcc cleanup easy GLIB has recently started to officially support the gcc cleanup attribute in its public API, hence let's do the same for our APIs. With this patch we'll define an xyz_unrefp() call for each public xyz_unref() call, to make it easy to use inside a __attribute__((cleanup())) expression. Then, all code is ported over to make use of this. The new calls are also documented in the man pages, with examples how to use them (well, I only added docs where the _unref() call itself already had docs, and the examples, only cover sd_bus_unrefp() and sd_event_unrefp()). This also renames sd_lldp_free() to sd_lldp_unref(), since that's how we tend to call our destructors these days. Note that this defines no public macro that wraps gcc's attribute and makes it easier to use. While I think it's our duty in the library to make our stuff easy to use, I figure it's not our duty to make gcc's own features easy to use on its own. Most likely, client code which wants to make use of this should define its own: #define _cleanup_(function) __attribute__((cleanup(function))) Or similar, to make the gcc feature easier to use. Making this logic public has the benefit that we can remove three header files whose only purpose was to define these functions internally. See #2008.

treewide: apply errno.cocci with small manual cleanups for style.

util-lib: split out allocation calls into alloc-util.[ch]

util-lib: split out fd-related operations into fd-util.[ch] There are more than enough to deserve their own .c file, hence move them over.

util-lib: split our string related calls from util.[ch] into its own file string-util.[ch] There are more than enough calls doing string manipulations to deserve its own files, hence do something about it. This patch also sorts the #include blocks of all files that needed to be updated, according to the sorting suggestions from CODING_STYLE. Since pretty much every file needs our string manipulation functions this effectively means that most files have sorted #include blocks now. Also touches a few unrelated include files.

tree-wide: make use of log_error_errno() return value Turns this: r = -errno; log_error_errno(errno, "foo"); into this: r = log_error_errno(errno, "foo"); and this: r = log_error_errno(errno, "foo"); return r; into this: return log_error_errno(errno, "foo");

tree-wide: drop redundant if checks before safe_close() Replace this: if (fd >= 0) safe_close(fd); by this: safe_close(fd);

tree-wide: make more code use safe_close() Replace this: close(fd); fd = -1; write this: fd = safe_close(fd);

udev: event - simplify udev_event_spawn() logic Push the extraction of the envp + argv as close as possible to their use, to avoid code duplication. As a sideeffect fix logging when delaing execution.

udev: event - check return code of dup2() This fixes CID#1304688.

sd-netlink: rename from sd-rtnl

udevd: event - don't log about failures of spawn processes when this is expected PROGRAM and IMPORT{program} uses the exit code of the spawn process to decide if a rule matches or not, a failing process is hence normal operation and not something we should warn about. We still warn about other types of failing processes.

tree-wide: remove spurious space

udevd: simplify signal mask handling We used to block all signals, and restore the original signal mask before exec'ing external processes. Now we just block the signals we care about and unconditionally unblock all signals before exec'ing.

udev: add some asserts Mostly for documentation purposes.

util: split out signal-util.[ch] from util.[ch] No functional changes.

udevd: event - port spawn_wait() to sd-event This allows us to drop the special sigterm handling in spawn_wait() as this will now be passed directly to the worker event loop. We now log failing spawend processes at 'warning' level, and timeouts are in terms of CLOCK_BOOTTIME when available, otherwise the behavior is unchanged.

udevd: fix REMOVE handling This reverts b67f944. Lazy loading of device properties does not work for devices that are received over netlink, as these are sealed. Reinstate the unconditional loading of the device db. Reported by: Mantas Mikulėnas <grawity@gmail.com>.

udev: event - update tags before writing out db The old tags are read from the db when deciding which tags to clear, make sure we don't write out the new db before the old one has been read.

shared: add formats-util.h

udev: make set_usec_initialized() internal to libudev Instead introduce ensure_usec_initialized(), which copies the timestamp if possible otherwise sets it to now(CLOCK_MONOTONIC).

libudev: introduce clone_with_db() This allows us to move the db reading from udevd to libudev.

udevd: event - make db loading lazy in REMOVE event handling We were explicitly eagerly loading the db, then deletenig the backing file and then processing the rules/symlinks. Instead we delete the backnig db file as the last step and let the db loading be lazy as everywhere else. This may save us a bit of work in casese where the db is not needed, but more importantly it hides some implementation details of libudev-device form udevd.

libudev: introduce udev_device_properties_copy() To copy properties from one device to another. Drop the equivalent functionality from udevd.

libudev: add missing hunks This should have been committed with udev_device_add_property - implicitly mark properties for saving to db

libudev: udev_device_read_db - drop unused argument

udev/libudev: event - move {OLD_,}INTERFACE handling from udevd to libudev This should be internal to the library as it is only about reflecting the sysfs state in the udev_device.

remove unused includes This patch removes includes that are not used. The removals were found with include-what-you-use which checks if any of the symbols from a header is in use.

include <poll.h> instead of <sys/poll.h> include-what-you-use automatically does this and it makes finding unnecessary harder to spot. The only content of poll.h is a include of sys/poll.h so should be harmless.

udev: event - minor nit Stay uniform and use 'dev' rather than 'event->dev', as these are aliases (and event->dev looks like it may be a typo for event->dev_db).

udev: event - introduce and use internal udev_device_shallow_clone()

udev: event - move renaming of udev_device to libudev This is not exposed in the public API. We want to simplify the internal libudev-device API as much as possible so that it will be simpler to rip the whole thing out in the future.

Assorted format fixes Types used for pids and uids in various interfaces are unpredictable. Too bad.

treewide: use log_*_errno whenever %m is in the format string If the format string contains %m, clearly errno must have a meaningful value, so we might as well use log_*_errno to have ERRNO= logged. Using: find . -name '*.[ch]' | xargs sed -r -i -e \ 's/log_(debug|info|notice|warning|error|emergency)\((".*%m.*")/log_\1_errno(errno, \2/' Plus some whitespace, linewrap, and indent adjustments.

treewide: yet more log_*_errno + return simplifications Using: find . -name '*.[ch]' | while read f; do perl -i.mmm -e \ 'local $/; local $_=<>; s/(if\s*\([^\n]+\))\s*{\n(\s*)(log_[a-z_]*_errno\(\s*([->a-zA-Z_]+)\s*,[^;]+);\s*return\s+\g4;\s+}/\1\n\2return \3;/msg; print;' $f done And a couple of manual whitespace fixups.

udev,update-done: more log_xyz_errno() conversions

treewide: drop unnecessary trailing \n in log_*() calls

udev: support ENV{}=="" global property matches

udev: switch to systemd logging functions

udev: fix path for database names on 'change' event If a device does not have a major/minor number attached, we use different database names than if it does. On "change" events, we didn't copy the devnum over, therefore, we used different paths than on 'add' or 'remove' events (where devnum was properly copied). Fix this by always copying the devnum into the udev-device. (David: added commit-log from email)

udev: event - modernize spawn_exec()

udev: event - explicitly don't read() from invalid fd This fixes CID #1237641.

udev: event - modernize spawn_read()

udev: timeout - warn after a third of the timeout before killing

udev: netif_rename - don't log to kmsg As of 3.17, the kernel will do this on its own, so just do regular log_debug() logging from udev.

udev: event - keep one rtnl per worker, rather than per event Creating the rtnl context is cheap, but freeing it may not be, due to synchronous close(). Also drop some excessive logging. We now log about the changing ifname exactly once.

udev: import the full db on MOVE events for devices without dev_t

udev: place opening { at the same line as the function declaration

udev: unify event timeout handling

udev: do not skip the execution of RUN when renaming a network device fails

udev: rename netif - properly break lines in kmsg Before: 30,997,4553484,-;systemd-udevd[439]: renamed network interface wwan0 to wwp0s20u4i6systemd-udevd[439]: renamed network interface wlan0 to wlp3s0 30,998,1175077801,c;systemd-udevd[2345]: renamed network interface wwan0 to wwp0s20u4i6 After: 30,834,4553484,-;systemd-udevd[439]: renamed network interface wwan0 to wwp0s20u4i6 30,835,4732949,-;systemd-udevd[439]: renamed network interface wlan0 to wlp3s0 30,988,1175077801,-;systemd-udevd[2345]: renamed network interface wwan0 to wwp0s20u4i6

udev: properly detect reference to unexisting part of PROGRAM's result

api: in constructor function calls, always put the returned object pointer first (or second) Previously the returned object of constructor functions where sometimes returned as last, sometimes as first and sometimes as second parameter. Let's clean this up a bit. Here are the new rules: 1. The object the new object is derived from is put first, if there is any 2. The object we are creating will be returned in the next arguments 3. This is followed by any additional arguments Rationale: For functions that operate on an object we always put that object first. Constructors should probably not be too different in this regard. Also, if the additional parameters might want to use varargs which suggests to put them last. Note that this new scheme only applies to constructor functions, not to all other functions. We do give a lot of freedom for those. Note that this commit only changes the order of the new functions we added, for old ones we accept the wrong order and leave it like that.

everywhere: make use of new0() and macro() macros, and stop using perror()

rtnl: drop "sd_" prefix from cleanup macros The "sd_" prefix is supposed to be used on exported symbols only, and not in the middle of names. Let's drop it from the cleanup macros hence, to make things simpler. The bus cleanup macros don't carry the "sd_" either, so this brings the APIs a bit nearer.

use memzero(foo, length); for all memset(foo, 0, length); calls In trying to track down a stupid linker bug, I noticed a bunch of memset() calls that should be using memzero() to make it more "obvious" that the options are correct (i.e. 0 is not the length, but the data to set). So fix up all current calls to memset(foo, 0, length) to memzero(foo, length).

log: log_error() and friends add a newline after each line anyway, so avoid including it in the log strings

udev: link-config - less verbose logging Also reinstate print to kmsg when renaming netif.

udev: link-config - let udevd set the ifname

udev-event: use rtnl to set ifname

udev: support custom Linux Security Module labels for device nodes

udev: always set selinux label at "add" events https://bugs.freedesktop.org/show_bug.cgi?id=62615

use streq instead of strcmp

udev: set default rules permissions only at "add" events

udev: move string copy functions to shared/

udev: in addition to DEVMODE, honor DEVUID, DEVGID from the uevent

udev: fix whitespace

udev: properly handle symlink removal by 'change' event If a 'change' event is supposed to remove created symlinks, we create a new device structure from the sysfs device and fill it with the list of links, to compute the delta of the old and new list of links to apply. If the device is already 'remove'd by the kernel though, udev fails to create the device structure, so the links are not removed properly. > From: Neil Brown <nfbrown@suse.com> > Date: Thu, 8 Nov 2012 10:39:06 +0100 > Subject: [PATCH] If a 'change' event does not get handled by udev until > after the device has subsequently disappeared, udev mis-handles > it. This can happen with 'md' devices which emit a change > event and then a remove event when they are stopped. It is > normally only noticed if udev is very busy (lots of arrays > being stopped at once) or the machine is otherwise loaded > and reponding slowly. > > There are two problems. > > 1/ udev_device_new_from_syspath() will refuse to create the device > structure if the device does not exist in /sys, and particularly if > the uevent file does not exist. > If a 'db' file does exist, that is sufficient evidence that the device > is genuine and should be created. Equally if we have just received an > event from the kernel about the device, it must be real. > > This patch just disabled the test for the 'uevent' file, it doesn't > try imposing any other tests - it isn't clear that they are really > needed. > > 2/ udev_event_execute_rules() calls udev_device_read_db() on a 'device' > structure that is largely uninitialised and in particular does not > have the 'subsystem' set. udev_device_read_db() needs the subsystem > so it tries to read the 'subsystem' symlink out of sysfs. If the > device is already deleted, this naturally fails. > udev_event_execute_rules() knows the subsystem (as it was in the > event message) so this patch simply sets the subsystem for the device > structure to be loaded to match the subsystem of the device structure > that is handling the event. > > With these two changes, deleted handling of change events will still > correctly remove any symlinks that are not needed any more. Use udev_device_new() instead of allowing udev_device_new_from_syspath() to proceed without a sysfs device.

use the same email address everywhere

udev: use usec_t and now()

udev: add missing newline when writing to /dev/kmsg

udev: get rid of TEST_PREFIX and use unshare() to fake /sys, /dev, /run

udev: avoid creating /dev/kmsg with fopen() to support CONFIG_PRINTK=n

udev: network device renaming - immediately give up if the target name isn't available

udev: add some O_CLOEXEC

udev: use startswith() and streq()

udev: remove configuration options for /dev, /sys, /run directories

udev: replace ARRAY_SIZE() with ELEMENTSOF()

udev: fix a few issues detected by the llvm static analyzer

udev: fix gcc warnings showing up after adding $(AM_CFLAGS)

udev: remove RUN+="socket:.." and udev_monitor_new_from_netlink()

udev: convert 'uaccess' to a builtin

udev: switch to systemd logging functions

move imported udev into place