tree-wide: remove Emacs lines from all files This should be handled fine now by .dir-locals.el, so need to carry that stuff in every file.

udev: net_id - for ccw bus, shorten the identifier and stip leading zeros The commmon case default qeth link is enccw0.0.0600 is rather long. Thus strip leading zeros (which doesn't make the bus_id unstable), similar to the PCI domain case. Also 'ccw' is redundant on S/390, as there aren't really other buses available which could have qeth driver interfaces. Not sure why this code is even compiled on non-s390[x] platforms. But to distinguish from e.g. MAC stable names shorten the suffix to just 'c'. Thus enccw0.0.0600 becomes enc600.

udev: filter out non-sensically high onboard indexes reported by the kernel Let's not accept onboard interface indexes, that are so high that they are obviously non-sensical. Fixes: #2407

tree-wide: use xsprintf() where applicable Also add a coccinelle receipt to help with such transitions.

udev: add emacs header line Otherwise emacs wants to use 2-space indentation and other attrocities.

doc: correct orthography, word forms and missing/extraneous words

util-lib: split out fd-related operations into fd-util.[ch] There are more than enough to deserve their own .c file, hence move them over.

util-lib: split our string related calls from util.[ch] into its own file string-util.[ch] There are more than enough calls doing string manipulations to deserve its own files, hence do something about it. This patch also sorts the #include blocks of all files that needed to be updated, according to the sorting suggestions from CODING_STYLE. Since pretty much every file needs our string manipulation functions this effectively means that most files have sorted #include blocks now. Also touches a few unrelated include files.

udev: net_id - support predictable ifnames on virtio buses Virtio buses are undeterministically enumerated, so we cannot use them as a basis for deterministic naming (see bf81e792f3c0). However, we are guaranteed that there is only ever one virtio bus for every parent device, so we can simply skip over the virtio buses when naming the devices.

udev: add some asserts Mostly for documentation purposes.

udev/net_id: Only read the first 64 bytes of PCI config space The original code used fread(), which on some libc implementions (ie glibc 2.17) would pre-read a full 4K (PAGE_SIZE) of the PCI config space, when only 64 bytes were requested. I have recently come across PCIe hardware which responds with Completion Timeouts when accesses above 256 bytes are attempted. This can cause server systems with GHES/AEPI support to cause and immediate kernel panic due to the failed PCI transaction. This change replaces the buffered fread() with an explict unbuffered read() of 64 bytes, which corrects this issue by only reading the guaranteed first 64 bytes of PCIe config space.

udev: net_id - improve comments The dev_port concept is a bit confusing, expand on the comment a bit.

udev: net_id - support multi-port enpo* device names I'd argue that having firmware labels for such devices makes no sense, but they exist, so make sure we handle them as best as we can.

udev: net_id - fix copy-paste error In case pci_slot overflows we were truncating pci_path instead.

util: rework strappenda(), and rename it strjoina() After all it is now much more like strjoin() than strappend(). At the same time, add support for NULL sentinels, even if they are normally not necessary.

Assorted format fixes Types used for pids and uids in various interfaces are unpredictable. Too bad.

udevadm,..: make --help output of udev tools more like the output of the various other tools

treewide: correct spacing near eol in code comments

udev: modernize net_id builtin a bit

Use dev_port for the ID of a network device. For network devices on the same PCI function, dev_id should not be used, since its purpose is for IPv6 support on interfaces with the same MAC address. The new dev_port sysfs attribute should be used instead of dev_id.

udev: net_id - use constants rather than magic numbers

udev: persistent naming - we cannot use virtio numbers as they are not stable This reverts commit 8741f2defaf26aafe5ee0fd29954cfdf84ee519c: 'Add virtio-blk support to path_id' and commit e3d563346c4237af23335cc6904e0662efdf62ad: 'udev: net_id - handle virtio buses'. Distros may want to take note of this, as it changes behavior.

udev: update net_id comments

udev/net_id: Introduce predictable network names for Linux on System z Use the bus-ID to create predicatable devices names for network interfaces on Linux on System z instances. The bus-ID identifies a device in the s390 channel subsystem. Network interfaces of device type Ethernet are named as: enccw0.0.1234 (13 characters) up to enccwff.7.ffff (14 characters) CTC network devices of device type SLIP, use a different prefix as follows: slccw0.0.1234 (13 characters) See also Red Hat Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=870859 [tomegun: typical problem of netdevs switching names between reboots.]

udev: net_id - handle virtio buses This was already supported in path_id, so should be uncontroversial.

Fix a few signed/unsigned format string issues Since numbers involved are all small, behaviour was correct already. https://bugzilla.redhat.com/show_bug.cgi?id=1043304

trivial coding style clean ups - Add space between if/for and the opening parentheses - Place the opening brace on same line as the function (not for udev) From the CODING_STYLE Try to use this: void foo() { } instead of this: void foo() { }

hwdb: add --lookup-prefix= option

hwdb: add --device=<device-id> and --filter=<key name glob>

udev: handle network controllers in nonstandard domains Onboard network controllers are not always on PCI domain 0. [Kay: use int instead of long, add [P] to slot naming, remove sysname var]

Use initalization instead of explicit zeroing Before, we would initialize many fields twice: first by filling the structure with zeros, and then a second time with the real values. We can let the compiler do the job for us, avoiding one copy. A downside of this patch is that text gets slightly bigger. This is because all zero() calls are effectively inlined: $ size build/.libs/systemd text data bss dec hex filename before 897737 107300 2560 1007597 f5fed build/.libs/systemd after 897873 107300 2560 1007733 f6075 build/.libs/systemd … actually less than 1‰. A few asserts that the parameter is not null had to be removed. I don't think this changes much, because first, it is quite unlikely for the assert to fail, and second, an immediate SEGV is almost as good as an assert.

udev: fix segfault with android rndis The android gadget driver for network tethering over rndis somehow has a parent device with a null subsystem. Probably this is bug in android driver, but it is easy enough to make systemd/udev behave gracefully and not segfault. And this will help for making linux distros with systemd (like fedora) work on android devices.

honor SELinux labels, when creating and writing config files Also split out some fileio functions to fileio.c and provide a SELinux aware pendant in fileio-label.c see https://bugzilla.redhat.com/show_bug.cgi?id=881577

use streq instead of strcmp

use strneq instead of strncmp

udev: net_id - add link to the wiki page

udev: net_id - suppress bcma core == 0

udev: net_id - handle "bcma" buses

udev: move string copy functions to shared/

udev: don't call fclose on NULL in is_pci_multifunction

udev: net_id - skip stacked network devices

udev: net_id - append "dev_id" value if needed

udev: net_id: update comments

udev: net_id - fix OUI handling

udev: net_id - fix typos

udev: net_id - update examples

udev: net_id - update examples

udev: net_id - provide path names for USB devices

hwdb: add IAB to the OUI database The individual address block is a poor man's organizationally unique identifier. Perhaps we should change the udev key from ID_OUI_FROM_DATABASE to something like ID_IEEE_VENDOR_FROM_DATABASE? Suggested-by: Diego Elio Pettenò <flameeyes@flameeyes.eu>

udev: net_id - clarify comments

udev: hwdb - fix OUI lookup

udev: net_id - suppress function number for single-function devices

udev: net_id - merge properties into the correct device

udev: net_id - export PCI hotplug slot names

udev: net_id - read ACPI _SUN -- slot user number

udev: net - add device naming properties

udev: net_id - add builtin to retrieve data for network devices