tree-wide: group include of libudev.h with sd-*

tree-wide: sort includes Sort the includes accoding to the new coding style.

util-lib: split out fd-related operations into fd-util.[ch] There are more than enough to deserve their own .c file, hence move them over.

util-lib: split our string related calls from util.[ch] into its own file string-util.[ch] There are more than enough calls doing string manipulations to deserve its own files, hence do something about it. This patch also sorts the #include blocks of all files that needed to be updated, according to the sorting suggestions from CODING_STYLE. Since pretty much every file needs our string manipulation functions this effectively means that most files have sorted #include blocks now. Also touches a few unrelated include files.

udev: ata_id - ATA_ID_SATA_CAPABILITY == 76

Fixup WWN bytes for big-endian systems

tree-wide: replace while(1) by for(;;) everywhere Another Coccinelle script.

ata_id: remove unused union member The last use of octa was removed in 01f61d331bb5038f0c877ac03c54333328b6ea28

ata_id: unreverse WWN identifier An endianness conversion was lost in 6024a6e302bad6bcf073fa84a41a6123305dc845. Restore it. Now ata_id and scsi_id output match. https://bugzilla.redhat.com/show_bug.cgi?id=1227503

ata_id: unbotch format specifier Commit v218-247-g11c6f69 broke the output of the utility. "%1$" PRIu64 "x" expands to "%1$lux", essentially "%lux", which shows the problem. u and x cannot be combined, u wins as the type character, and x gets emitted verbatim to stdout. References: https://bugzilla.redhat.com/show_bug.cgi?id=1227503

ata_id: drop spurious space

ata_id: remove unused header files Signed-off-by: Robert Milasan <rmilasan@suse.com>

udev: improve help/usage for some more programs

ata_id: remove temp variable to kill warning src/udev/ata_id/ata_id.c:503:24: warning: assignment from incompatible pointer type identify_words = &identify.wyde; ^

ata_id: modernize

udev: fix another strict aliasing issue

treewide: use log_*_errno whenever %m is in the format string If the format string contains %m, clearly errno must have a meaningful value, so we might as well use log_*_errno to have ERRNO= logged. Using: find . -name '*.[ch]' | xargs sed -r -i -e \ 's/log_(debug|info|notice|warning|error|emergency)\((".*%m.*")/log_\1_errno(errno, \2/' Plus some whitespace, linewrap, and indent adjustments.

udev: switch to systemd logging functions

udev: never bypass our own logging framework and call vsyslog() directly from udev tools

everywhere: always use O_CLOEXEC where it makes sense

log: log_error() and friends add a newline after each line anyway, so avoid including it in the log strings

Add more _printf_'s for format-nonliterals Clang is a bit more strict wrt format-nonliterals: http://clang.llvm.org/docs/LanguageExtensions.html#format-string-checking Adding these extra printf attributes also makes gcc able to find more problems. E.g. this patch uncovers a format issue in udev-builtin-path_id.c Some parts looked intetional about breaking the format-nonliteral check. I added some supression for warnings there.

udev: ata_id: log faling ioctls as "debug"

udev/ata_id: zero out variable properly b8a2b0f76 'use initalization instead of explicit zeroing' introduced a bug where only the first sizeof(uint_t*) bytes would be zeroed out, instead of the whole array.

udev/ata_id: use initalization instead of explicit zeroing

use the same email address everywhere

udev: ata_id - fixup all 8 not only 6 bytes of the fw_rev string The last two digits are in the wrong order: $ hdparm -I /dev/sda | grep Revision 4PC10362 $ /lib/udev/ata_id -x /dev/sda | grep REVISION 4PC10326

udev: fix a few issues detected by the llvm static analyzer

udev: switch to systemd logging functions

udev: ata_id - remove assert() until we switch over to systemd logging

move imported udev into place