tree-wide: remove Emacs lines from all files This should be handled fine now by .dir-locals.el, so need to carry that stuff in every file.

timesyncd: use (void) to mark ignored value CID #1325772.

timesync: return negative errno from manager_adjust_clock() on error

util-lib: split out allocation calls into alloc-util.[ch]

util-lib: move a number of fs operations into fs-util.[ch]

util-lib: split out fd-related operations into fd-util.[ch] There are more than enough to deserve their own .c file, hence move them over.

util-lib: split our string related calls from util.[ch] into its own file string-util.[ch] There are more than enough calls doing string manipulations to deserve its own files, hence do something about it. This patch also sorts the #include blocks of all files that needed to be updated, according to the sorting suggestions from CODING_STYLE. Since pretty much every file needs our string manipulation functions this effectively means that most files have sorted #include blocks now. Also touches a few unrelated include files.

util: introduce CMSG_FOREACH() macro and make use of it everywhere It's only marginally shorter then the usual for() loop, but certainly more readable.

timesyncd: print an INFO log message when we successfully reached a time server

remove unused includes This patch removes includes that are not used. The removals were found with include-what-you-use which checks if any of the symbols from a header is in use.

timesync: Use UINT64_C for OFFSET_1900_1970 So it matches what the comment says in both 32 and 64 bit systems.

Revert "tree-wide: Always use recvmsg with MSG_CMSG_CLOEXEC" This reverts commit d6d810fbf8071f8510450dbacd1d083f37603656. It's apparently not OK to pass MSG_CMSG_CLOEXEC to recvmsg() of raw sockets.

tree-wide: Always use recvmsg with MSG_CMSG_CLOEXEC

timesyncd: downgrade more log messages from LOG_INFO to LOG_DEBUG https://bugs.freedesktop.org/show_bug.cgi?id=87505 Let's make timesyncd less chatty.

timesyncd: reduce log chattiness a bit Let's downgrade the statistics output from LOG_INFO to LOG_DEBUG. https://bugs.freedesktop.org/show_bug.cgi?id=88926

timesyncd: consider too long packets as invalid If the received NTP message from server didn't fit to our buffer, either it is doing something nasty or we don't know the protocol. Consider the packet as invalid. (David: add parantheses around conditional)

timesync: remove square(), use pow instead In any case, the compiler generates the same code inline and never actually calls the library function.

timesyncd: minor simplification

treewide: another round of simplifications Using the same scripts as in f647962d64e "treewide: yet more log_*_errno + return simplifications".

treewide: use log_*_errno whenever %m is in the format string If the format string contains %m, clearly errno must have a meaningful value, so we might as well use log_*_errno to have ERRNO= logged. Using: find . -name '*.[ch]' | xargs sed -r -i -e \ 's/log_(debug|info|notice|warning|error|emergency)\((".*%m.*")/log_\1_errno(errno, \2/' Plus some whitespace, linewrap, and indent adjustments.

treewide: yet more log_*_errno + return simplifications Using: find . -name '*.[ch]' | while read f; do perl -i.mmm -e \ 'local $/; local $_=<>; s/(if\s*\([^\n]+\))\s*{\n(\s*)(log_[a-z_]*_errno\(\s*([->a-zA-Z_]+)\s*,[^;]+);\s*return\s+\g4;\s+}/\1\n\2return \3;/msg; print;' $f done And a couple of manual whitespace fixups.

treewide: drop unnecessary trailing \n in log_*() calls

treewide: no need to negate errno for log_*_errno() It corrrectly handles both positive and negative errno values.

treewide: auto-convert the simple cases to log_*_errno() As a followup to 086891e5c1 "log: add an "error" parameter to all low-level logging calls and intrdouce log_error_errno() as log calls that take error numbers", use sed to convert the simple cases to use the new macros: find . -name '*.[ch]' | xargs sed -r -i -e \ 's/log_(debug|info|notice|warning|error|emergency)\("(.*)%s"(.*), strerror\(-([a-zA-Z_]+)\)\);/log_\1_errno(-\4, "\2%m"\3);/' Multi-line log_*() invocations are not covered. And we also should add log_unit_*_errno().

timesyncd: do not keep listening socket open forever This also makes the source port less predicatable.

timesyncd: the IP_TOS sockopt is really just an optimization, we shouldn't fail if we can't set it This partially undos 2f905e821e0342c36f5a5d3a51d53aabccc800bd

util: avoid duplication of TIME_T_MAX

timesyncd: check return of setting IP_TOS Fonud by Coverity. Fixes CID #1237534.

Revert "timesyncd: remove retry_timer logic which is covered by the server timeout" This reverts commit 665c6a9eab46b0b253af6566ca9fc70c866b3fcd. On Tue, Sep 2, 2014 at 3:17 PM, Miroslav Lichvar <mlichvar@redhat.com> wrote: > > With the other patch allowing missed replies included it's now getting > stuck as there is no timer to send the 2nd and 3rd request.

timesyncd: don't reset polling interval when reselecting server Original patch from: Miroslav Lichvar <mlichvar@redhat.com>

timesyncd: allow two missed replies before reselecting server After receiving a reply from the server, allow two missed replies before switching to another server to avoid unnecessary clock hopping when packets are getting lost in the network.

timesyncd: remove retry_timer logic which is covered by the server timeout

timesyncd: wait before reconnecting to first server When all servers are exhausted, wait for one poll interval before trying to connect again to the first server in the list. Also, keep increasing the polling interval to make sure a client not getting any valid replies will not send requests to any server more frequently than is allowed by the maximum polling interval.

timesyncd-manager: don't clear current_server_name if ServerAddress is NULL https://bugs.freedesktop.org/show_bug.cgi?id=83091 [zj: add comment]

timesyncd: check root distance NTPv4 servers don't reply with unsynchronized status when they lost synchronization, they only keep increasing the root dispersion and it's up to the client to decide at which point they no longer consider it synchronized. Ignore replies with root distance over 5 seconds.

timesyncd: get kernel timestamp in nanoseconds

timesyncd: fix calculation of transmit time The kernel timestamp (recv_time) is made earlier than current time (now_ts), use the timestamp captured before sending packet directly.

timesyncd: check if stratum is valid

timesyncd: don't trip up if networkd isn't running and can't tell us any NTP servers

timesyncd: beef up NTP server selection logic, and acquire NTP servers from DHCP

timesyncd: split up into multiple source file The source file got much too large, hence split up the sources into multiple per-object files, similar in style to resolved.