tree-wide: remove Emacs lines from all files This should be handled fine now by .dir-locals.el, so need to carry that stuff in every file.

networkctl: move strv_isempty() check into dump_list() Previously, each invocation of dump_list() was prefixed with a call to strv_isempty() to suppress invocation of the function when the list is empty anyway. Move the check into the function itself, so that we can reduce the code a bit in size. (Also, prefix a couple of invocations we knowingly ignore return errors with a (void) cast).

networkd: rework Domains= setting Previously, .network files only knew a vaguely defined "Domains=" concept, for which the documentation declared it was the "DNS domain" for the network connection, without specifying what that means. With this the Domains setting is reworked, so that there are now "routing" domains and "search" domains. The former are to be used by resolved to route DNS request to specific network interfaces, the latter is to be used for searching single-label hostnames with (in addition to being used for routing). Both settings are configured in the "Domains=" setting. Normal domain names listed in it are now considered search domains (for compatibility with existing setups), while those prefixed with "~" are considered routing domains only. To route all lookups to a specific interface the routing domain "." may be used, referring to the root domain. An alternative syntax for this is the "*", as was already implemented before using the "wildcard" domain concept. This commit adds proper parsers for this new logic, and exposes this via the sd-network API. This information is not used by resolved yet, this will be added in a later commit.

tree-wide: use xsprintf() where applicable Also add a coccinelle receipt to help with such transitions.

tree-wide: expose "p"-suffix unref calls in public APIs to make gcc cleanup easy GLIB has recently started to officially support the gcc cleanup attribute in its public API, hence let's do the same for our APIs. With this patch we'll define an xyz_unrefp() call for each public xyz_unref() call, to make it easy to use inside a __attribute__((cleanup())) expression. Then, all code is ported over to make use of this. The new calls are also documented in the man pages, with examples how to use them (well, I only added docs where the _unref() call itself already had docs, and the examples, only cover sd_bus_unrefp() and sd_event_unrefp()). This also renames sd_lldp_free() to sd_lldp_unref(), since that's how we tend to call our destructors these days. Note that this defines no public macro that wraps gcc's attribute and makes it easier to use. While I think it's our duty in the library to make our stuff easy to use, I figure it's not our duty to make gcc's own features easy to use on its own. Most likely, client code which wants to make use of this should define its own: #define _cleanup_(function) __attribute__((cleanup(function))) Or similar, to make the gcc feature easier to use. Making this logic public has the benefit that we can remove three header files whose only purpose was to define these functions internally. See #2008.

tree-wide: sort includes Sort the includes accoding to the new coding style.

networkctl: lldp port to extract_first_word

parse-util: introduce parse_ifindex() and make use of it everywhere We have enough places where we parse an ifindex, hence introduce a proper parsing function for it, that verifies all parameters.

util-lib: split out allocation calls into alloc-util.[ch]

util-lib: move more locale-related calls to locale-util.[ch]

util-lib: move string table stuff into its own string-table.[ch]

util-lib: split string parsing related calls from util.[ch] into parse-util.[ch]

util-lib: split our string related calls from util.[ch] into its own file string-util.[ch] There are more than enough calls doing string manipulations to deserve its own files, hence do something about it. This patch also sorts the #include blocks of all files that needed to be updated, according to the sorting suggestions from CODING_STYLE. Since pretty much every file needs our string manipulation functions this effectively means that most files have sorted #include blocks now. Also touches a few unrelated include files.

util: introduce common version() implementation and use it everywhere This also allows us to drop build.h from a ton of files, hence do so. Since we touched the #includes of those files, let's order them properly according to CODING_STYLE.

cgtop: underline table header Let's underline the header line of the table shown by cgtop, how it is customary for tables. In order to do this, let's introduce new ANSI underline macros, and clean up the existing ones as side effect.

tree-wide: do not shadow the global var timezone

dhcp,network: implement RFC 4833 (DHCP Timezone option) This one is simply to add: encode the tzdata timezone in the DHCP options and optionally make use of it.

tree-wide: fix indentation

tree-wide: convert bootchart and lldp code to use clock_boottime_or_monotonic() We should avoid using CLOCK_BOOTTIME directly unless we actually can sensible distuingish it from CLOCK_MONOTONIC. CLOCK_BOOTTIME is only fully feature on very recent Linux kernels, hence we should stick to a fallback logic, which is already available in the clock_boottime_or_monotonic() call.

sd-netlink: rename from sd-rtnl

sd-rtnl: make joining broadcast groups implicit

tree-wide: remove spurious space

networkctl: fix uninitialized variable We ignore the return value of sd_device_get_devtype, then devtype could be uninitialized when used with streq_ptr. So we need to initialize it first.

shared: add terminal-util.[ch]

networkctl: port from libudev to sd-device

fix gcc warnings about uninitialized variables like: src/shared/install.c: In function ‘unit_file_lookup_state’: src/shared/install.c:1861:16: warning: ‘r’ may be used uninitialized in this function [-Wmaybe-uninitialized] return r < 0 ? r : state; ^ src/shared/install.c:1796:13: note: ‘r’ was declared here int r; ^

networkctl: avoid leak if a field was specified twice The input data would have to be borked, so this is unlikely to happen, but since we have a nice helper function to do it properly... why not? CID #1261390.

networkd: add support for Uplink Failure Detection Introduce BindCarrier= to indicate the set of links that determine if the current link should be brought UP or DOWN. [tomegun: add a bit to commit message]

man: add networkctl(1)

networkctl: avoid potential use of unitialized variables Those values are based on a file we read from disk, so we should verify everything we receive, and make sure everything we print is sensible. Also, print fractional seconds for TTL.

networkctl: remove unused variable

network: fix scanf/printf format usec_t is defined as 64 bit wide, but long is 32 bit on many archs.

networkctl: fix strappend() error checking Make sure to test the right variable for NULL.

networkctl: lldp - respect arg_legend

LLDP: Add support for networkctl

networkctl: port to verbs helper

networkctl: port from libudev to sd-hwdb

networkctl: remove unused variable

networkctl: also draw a nice unicode cirlce when "networkctl status" is run without parameters

networkctl: show interface names next to IP addresses if we dump adresses from all interfaces

networkctl: also show gateway address when "networkctl status" without further arguments is passed

networkctl: show MAC address OUI vendor next to MAC addresses

networkctl: use the shared functions for enumerating the local gateways

rtnl: when querying local addresses and gateways, take address family into account

networkctl: remove unused variable

networkd: fix typo V2: found another one

shared: add format helpers for printing MAC addresses Use these in networctl.

networkctl: print the Gateway in the status output This is the IP address of the default route on the link, if present. A description is printed when available (the manufacturer of the gateway NIC based on its MAC address). In the future we should prefer LLDP information over MAC info.

treewide: another round of simplifications Using the same scripts as in f647962d64e "treewide: yet more log_*_errno + return simplifications".

treewide: use log_*_errno whenever %m is in the format string If the format string contains %m, clearly errno must have a meaningful value, so we might as well use log_*_errno to have ERRNO= logged. Using: find . -name '*.[ch]' | xargs sed -r -i -e \ 's/log_(debug|info|notice|warning|error|emergency)\((".*%m.*")/log_\1_errno(errno, \2/' Plus some whitespace, linewrap, and indent adjustments.

treewide: yet more log_*_errno + return simplifications Using: find . -name '*.[ch]' | while read f; do perl -i.mmm -e \ 'local $/; local $_=<>; s/(if\s*\([^\n]+\))\s*{\n(\s*)(log_[a-z_]*_errno\(\s*([->a-zA-Z_]+)\s*,[^;]+);\s*return\s+\g4;\s+}/\1\n\2return \3;/msg; print;' $f done And a couple of manual whitespace fixups.

treewide: no need to negate errno for log_*_errno() It corrrectly handles both positive and negative errno values.

treewide: auto-convert the simple cases to log_*_errno() As a followup to 086891e5c1 "log: add an "error" parameter to all low-level logging calls and intrdouce log_error_errno() as log calls that take error numbers", use sed to convert the simple cases to use the new macros: find . -name '*.[ch]' | xargs sed -r -i -e \ 's/log_(debug|info|notice|warning|error|emergency)\("(.*)%s"(.*), strerror\(-([a-zA-Z_]+)\)\);/log_\1_errno(-\4, "\2%m"\3);/' Multi-line log_*() invocations are not covered. And we also should add log_unit_*_errno().

networkctl: show the link file applied to each link

networkctl: show the network file applied to each link

networkctl: do not mix dns and ntp servers

networkctl: use safe_qsort in case no links are present Unlikely to happen but still...

networkctl: show acquired system domains

networkctl: two OOM fixes

sd-network: add support for wildcard domains

util: never use ether_ntoa(), since it formats with %x, not %02x, which makes ethernet addresses look funny

networkctl: increase column width for link type to 18, to accomodate for 'ieee80211_radiotap'

networkctl: print local domain name in status output

networkctl: also use the same color logic when running "networkctl status" without arguments

networkctl: add the same color logic to "list" and "status" outputs And always put operational state first, setup state second.

networkctl: name setup state variable setup_state

networkctl: update column header to new 'setup' state naming

sd-networkd: rename link_get_state to link_get_setup_state Suggested by Kay and Lennart.

sd-network: /_get_link_/_link_get_/ The link is the 'object', so make this in line with our usual naming convention. Suggested by Kay and Lennart.

networkctl: color status dump without link name Lets mimic colored operational state dump as if link name is appiled

networkctl: add colors to admin state and fix alignment It is useful to color in the admin state both to easily spot failed links, but also to quickly distinguish between links that are fully configured and in degraded mode (only IPv4LL) or in degraded mode and still waiting for DHCP.

networkctl: make networkctl status without link name show all local IP addresses

networkctl: when outputing a list fo links, sort them by ifindex

networkctl: add a bit of color to the output

networkctl: add new switch "-a" to "networkctl status" to show verbose status of all local links

networkctl: properly format MAC addresses

sd-network: add API to output all collected system-wide NTP and DNS servers Also, output the collected information in "networkctl".

networkd: add minimal client tool "networkd" to query network status In the long run this should become a full fledged client to networkd (but not before networkd learns bus support). For now, just pull interesting data out of networkd, udev, and rtnl and present it to the user, in a simple but useful output.