tree-wide: group include of libudev.h with sd-*

tree-wide: sort includes Sort the includes accoding to the new coding style.

treewide: apply errno.cocci with small manual cleanups for style.

mount-util: move fstype_is_network() and name_to_handle_at() definitions over

util-lib: split out allocation calls into alloc-util.[ch]

util-lib: move more file I/O related calls into fileio.[ch]

util-lib: split out fd-related operations into fd-util.[ch] There are more than enough to deserve their own .c file, hence move them over.

util-lib: split our string related calls from util.[ch] into its own file string-util.[ch] There are more than enough calls doing string manipulations to deserve its own files, hence do something about it. This patch also sorts the #include blocks of all files that needed to be updated, according to the sorting suggestions from CODING_STYLE. Since pretty much every file needs our string manipulation functions this effectively means that most files have sorted #include blocks now. Also touches a few unrelated include files.

libudev: monitor - set nl_pid when reusing fd in udev_monitor_new_from_netlink_fd This allows a fd to be created and configured as part of one monitor, to be passed in to create a second monitor without having to redo any of the configuration.

libudev: monitor - fix typo in log message

libudev: monitor - clarify log messages

shared: add formats-util.h

libudev: monitor - improve logging

libudev-monitor: use initialization

libudev: monitor - fix error path in send_device Return -errno rather than -1 in case sendmsg() fails.

remove unused includes This patch removes includes that are not used. The removals were found with include-what-you-use which checks if any of the symbols from a header is in use.

include <poll.h> instead of <sys/poll.h> include-what-you-use automatically does this and it makes finding unnecessary harder to spot. The only content of poll.h is a include of sys/poll.h so should be harmless.

Revert "tree-wide: Always use recvmsg with MSG_CMSG_CLOEXEC" This reverts commit d6d810fbf8071f8510450dbacd1d083f37603656. It's apparently not OK to pass MSG_CMSG_CLOEXEC to recvmsg() of raw sockets.

tree-wide: Always use recvmsg with MSG_CMSG_CLOEXEC

libudev: monitor - move nulstr parsing to libudev-device Hide the details a bit.

Assorted format fixes Types used for pids and uids in various interfaces are unpredictable. Too bad.

Add initialization helper for file_handle_union

libudev: fix check for too long packet Don't use recvmsg(2) return value to check for too long packets (it doesn't work) but MSG_TRUNC flag. (David: add parantheses around condition)

libudev: fix strict aliasing violation

treewide: use log_*_errno whenever %m is in the format string If the format string contains %m, clearly errno must have a meaningful value, so we might as well use log_*_errno to have ERRNO= logged. Using: find . -name '*.[ch]' | xargs sed -r -i -e \ 's/log_(debug|info|notice|warning|error|emergency)\((".*%m.*")/log_\1_errno(errno, \2/' Plus some whitespace, linewrap, and indent adjustments.

treewide: drop unnecessary trailing \n in log_*() calls

udev: switch to systemd logging functions

libudev: we do not log errors from libraries

libudev: monitor - warn if we fail to request SO_PASSCRED The function still succeeds, so there is no functional change. This fixes CID #996288.

udev: warn when name_to_handle_at is not implemented We have a bunch of reports from people who have a custom kernel and are confused why udev is not running. Issue a warning on error. Barring an error in the code, the only error that is possible is ENOSYS. https://bugzilla.redhat.com/show_bug.cgi?id=1072966

util: make sure all our name_to_handle_at() code makes use of file_handle_union

implement a union to pad out file_handle Cases where name_to_handle_at is used allocated the full struct to be MAX_HANDLE_SZ, and assigned this size to handle_bytes. This is wrong since handle_bytes should describe the length of the flexible array member and not the whole struct. Define a union type which includes sufficient padding to allow assignment of MAX_HANDLE_SZ to be correct.

udev: remove seqnum API and all assumptions about seqnums The way the kernel namespaces have been implemented breaks assumptions udev made regarding uevent sequence numbers. Creating devices in a namespace "steals" uevents and its sequence numbers from the host. It confuses the "udevadmin settle" logic, which might block until util a timeout is reached, even when no uevent is pending. Remove any assumptions about sequence numbers and deprecate libudev's API exposing these numbers; none of that can reliably be used anymore when namespaces are involved.

everywhere: make use of new0() and macro() macros, and stop using perror()

use memzero(foo, length); for all memset(foo, 0, length); calls In trying to track down a stupid linker bug, I noticed a bunch of memset() calls that should be using memzero() to make it more "obvious" that the options are correct (i.e. 0 is not the length, but the data to set). So fix up all current calls to memset(foo, 0, length) to memzero(foo, length).

remove unused variable

libudev: monitor - only disallow "udev" type events

libudev: disable monitor inside a container Uevents are events of the host, which should not leak into a container. Containers do not support hotplug at the moment, and devices and uevents are not namespace aware.

bus: catch up with kdbus changes

libudev: devices received from udev are always initialized

libudev: always return NULL in _unref() APIs Returning anything else but NULL would suggest the caller's reference might still be valid, but it isn't, because the caller just invoked _unref() after all. This turns the return value into a typesafe shortcut that allows unreffing and resetting a reference in one line. In contrast to solutions for this which take a pointer to a pointer to accomplish the same this solution is just syntactic sugar the developer can make use of but doesn't have to, and this is particularly useful when immediately unreffing objects returned by function calls.

libudev: always return valid negative error codes on API functions

use streq instead of strcmp

libudev: update copyright headers

libudev: clarify that udev_monitor_receive_device() is non-blocking Based on a patch from: Sam Thursfield <ssssam@gmail.com> https://bugs.freedesktop.org/show_bug.cgi?id=51202

udev: silent gcc warnings

udev: update docs, NEWS

udev: libudev - bump soname, remove deprecated functions, introduce symbol versions

libudev: prefix log macros with 'udev_'

udev: replace ARRAY_SIZE() with ELEMENTSOF()

udev: udev_monitor_new_from_socket() - log error and remove from public header

udev: move libudev, gudev to src/; move gudev/docs/, udev/docs/ to to docs/