tree-wide: remove Emacs lines from all files This should be handled fine now by .dir-locals.el, so need to carry that stuff in every file.

dhcp: make DHCP_OPTION_* enum public libsystemd-network provides the public function sd_dhcp_client_set_request_option() to enable the request of a given DHCP option. However the enum defining such options is defined in the internal header dhcp-protocol.h. Move the enum definition to the public header sd-dhcp-client.h and properly namespace values.

sd-dhcp: parse error message in DECLINE or NAK If a client sends a DECLINE or a server sends a NAK, they can include a string with a message to explain the error. Parse this and print it at debug level.

tree-wide: sort includes Sort the includes accoding to the new coding style.

util-lib: split out allocation calls into alloc-util.[ch]

dhcp: generic data should be void*, not uint8_t* If we handly arbitrary data we should use "void*" pointers, not "uint8_t*", how go intended C to be used.

network: s/user_data/userdata/ Everywhere else we call the generic user data pointer just "userdata", rather than "user_data". Let's do this here, too.

test-dhcp-option: conform to usual coding style

test-dhcp-option: add assert to check index is nonnegative CID #1237623.

remove unused includes This patch removes includes that are not used. The removals were found with include-what-you-use which checks if any of the symbols from a header is in use.

use correct format types

sd-dhcp-client: support non-Ethernet hardware addresses Like Infiniband. See RFC 4390 section 2.1 for details on DHCP and Infiniband; chaddr is zeroed, hlen is set to 0, and htype is set to ARPHRD_INFINIBAND because IB hardware addresses are 20 bytes in length.

libsystemd-network: dhcp-test - assert that malloc0 succeeds Otherwise we would get a nullptr dereference later on. Found by coverity. Fixes CID #1237655.

sd-dhcp: fix test of magic cookie The magic cookie is set in dhcp_message_init. Test the magic cookie value intead of writing the last 3/4 of it directly. Found with Coverity. Fixes: CID#1237732 CID#1237734 CID#1237735

test-dhcp-option: fix memleak

sd-dhcp: option_append - support falling back to 'sname' and 'file'

sd-dhcp: make sure we can not fill options so much that there is no space for END

sd-dhcp: refactor dhcp_option_append Store a pointer to the options in the DHCPMessage struct, and pass this together with an offset around, rather than a uint8_t**. This avoids us having to (re)compute the pointer; and changes dhcp_option_append from adjusting both the pointer to the next option and the remaining size of the options, to just adjusting the current offset. This makes the code a bit simpler to follow IMHO, but there should be no functional change.

sd-dhcp-client: test - fix for jenkins This test should have been updated when changing the magic cookie handling around. Reported by Ken MacLeod.

sd-network: add new library This is similar to sd-login, but exposes the state of networkd rather than logind. Include it in libsystemd-dhcp and rename it to libsystemd-network.