tree-wide: remove Emacs lines from all files This should be handled fine now by .dir-locals.el, so need to carry that stuff in every file.

gpt-auto: handle errors from blkid more correctly Let's make sure we don't choke if blkid_probe_lookup_value() returns a NULL string. Also, make sur we propagate the correct error when blkid_probe_lookup_value() fails.

gpt-auto: don't log an EIO error if blkid finds something which is not a partition table Fixes: #2483

tree-wide: group include of libudev.h with sd-*

tree-wide: sort includes Sort the includes accoding to the new coding style.

treewide: apply errno.cocci with small manual cleanups for style.

util-lib: split out allocation calls into alloc-util.[ch]

util-lib: move /proc/cmdline parsing code to proc-cmdline.[ch]

util-lib: split stat()/statfs()/stavfs() related calls into stat-util.[ch]

util-lib: introduce dirent-util.[ch] for directory entry calls Also, move a couple of more path-related functions to path-util.c.

util-lib: move mount related utility calls to mount-util.[ch]

util-lib: split string parsing related calls from util.[ch] into parse-util.[ch]

util-lib: split out fd-related operations into fd-util.[ch] There are more than enough to deserve their own .c file, hence move them over.

util-lib: split our string related calls from util.[ch] into its own file string-util.[ch] There are more than enough calls doing string manipulations to deserve its own files, hence do something about it. This patch also sorts the #include blocks of all files that needed to be updated, according to the sorting suggestions from CODING_STYLE. Since pretty much every file needs our string manipulation functions this effectively means that most files have sorted #include blocks now. Also touches a few unrelated include files.

gpt-auto-generator: fix duplicate backing partition check We shouldn't exit the loop early, otherwise our duplicate backing partition check won't work.

gpt-auto-generator: check fstab for /boot entries We need to prevent the creation of the gpt automount unit, which will not get overridden by the fstab mount unit. https://github.com/systemd/systemd/issues/1378

gpt-auto: fix ESP options and description Since 59512f21 the parameters were passed in the wrong order, causing the options to be interpreted as the description. Also, while "false" was supposed to be passed for "rw", the ESP should actually be mounted read-write. It just happened to be "true" since the description char* was passed for "rw".

basic: rework virtualization detection API Introduce a proper enum, and don't pass around string ids anymore. This simplifies things quite a bit, and makes virtualization detection more similar to architecture detection.

gpt-auto: minor simplificatin handling the no-auto GPT flag Let's query the flags only once, and document why we ignore it for the ESP.

gpt-auto: try to handle LUKS root partitions better If the root file system is located on an encrypted root disk, we'll not find the GPT partition table for it. Let's fix that by following the slaves/ symlinks in /sys for the device. We only handle devices having exactly one backing device. Also see: #1167

gpt-auto-generator: warn on ambiguous blkid probe

gpt-auto-generator: don't warn on !ENABLE_EFI add_automount() was only used on EFI systems, compile it conditionally to avoid the warning.

gpt-auto-generator: apply partition-type flags only to specific partition-types The partition-type flags are defined independently for every partition-type. Apply them only to the types where they are defined, and not to the ESP, which does not appear to share the same set of flags. https://github.com/systemd/systemd/issues/920

gpt-auto-generator: remove unused variable

tree-wide: use free_and_strdup() Use free_and_strdup() where appropriate and replace equivalent, open-coded versions.

tree-wide: port everything over to fflush_and_check() Some places invoked fflush() directly with their own manual error checking, let's unify all that by using fflush_and_check(). This also unifies the general error paths of fflush()+rename() file writers.

gpt-auto-generator: merge efi-boot-generator

fileio: consolidate write_string_file*() Merge write_string_file(), write_string_file_no_create() and write_string_file_atomic() into write_string_file() and provide a flags mask that allows combinations of atomic writing, newline appending and automatic file creation. Change all users accordingly.

path-util: Change path_is_mount_point() symlink arg from bool to flags This makes path_is_mount_point() consistent with fd_is_mount_point() wrt. flags.

core: rework unit name validation and manipulation logic A variety of changes: - Make sure all our calls distuingish OOM from other errors if OOM is not the only error possible. - Be much stricter when parsing escaped paths, do not accept trailing or leading escaped slashes. - Change unit validation to take a bit mask for allowing plain names, instance names or template names or an combination thereof. - Refuse manipulating invalid unit name

gpt-generator: Find device on a stateless system A stateless system has a tmpfs as root file system. That obviously does not have any block device associated with it. So try falling back to the device of the /usr filesystem if the root filesystem fails.

gpt-auto-generator: prefix messages with device name

gpt-auto-generator: allow type check to fail add_mount() is OK with unknow file type, but we have to initalize the variable to NULL not to pass garbage on error.

gpt-auto-generator: fix detection of /srv https://bugs.freedesktop.org/show_bug.cgi?id=89226

remove unused includes This patch removes includes that are not used. The removals were found with include-what-you-use which checks if any of the symbols from a header is in use.

util: rework strappenda(), and rename it strjoina() After all it is now much more like strjoin() than strappend(). At the same time, add support for NULL sentinels, even if they are normally not necessary.

gpt-auto-generator: make use of new btrfs-util.h APIs

treewide: another round of simplifications Using the same scripts as in f647962d64e "treewide: yet more log_*_errno + return simplifications".

treewide: use log_*_errno whenever %m is in the format string If the format string contains %m, clearly errno must have a meaningful value, so we might as well use log_*_errno to have ERRNO= logged. Using: find . -name '*.[ch]' | xargs sed -r -i -e \ 's/log_(debug|info|notice|warning|error|emergency)\((".*%m.*")/log_\1_errno(errno, \2/' Plus some whitespace, linewrap, and indent adjustments.

treewide: more log_*_errno + return simplifications

treewide: no need to negate errno for log_*_errno() It corrrectly handles both positive and negative errno values.

treewide: auto-convert the simple cases to log_*_errno() As a followup to 086891e5c1 "log: add an "error" parameter to all low-level logging calls and intrdouce log_error_errno() as log calls that take error numbers", use sed to convert the simple cases to use the new macros: find . -name '*.[ch]' | xargs sed -r -i -e \ 's/log_(debug|info|notice|warning|error|emergency)\("(.*)%s"(.*), strerror\(-([a-zA-Z_]+)\)\);/log_\1_errno(-\4, "\2%m"\3);/' Multi-line log_*() invocations are not covered. And we also should add log_unit_*_errno().

gpt-auto-generator: properly ignore value A negative return code was treated as a true value.

util: simplify proc_cmdline() to reuse get_process_cmdline() Also, make all parsing of the kernel cmdline non-fatal.

readahead: wipe out readahead

gpt-auto-generator: fix typo

stop complaining about unknown kernel cmdline options Also stop warning about unknown kernel cmdline options in the various tools, not just in PID 1

gpt-auto-generator: there's no point in looking for a superblock on raw disk, we only care for a partition table

gpt-auto-generator: print debug messages when we ignore a block device

gpt-auto-generator: honour read-only and no-auto flag from GPT data Similar to the read-only and no-automount flags of Microsoft Basic Data Partitions, introduce our own flags. We map them to the same flag bits as Microsoft's, to keep things simple.

gpt-auto-generator: don't return OOM on parentless devices

gpt-auto-generator: rename root device node symlink to /dev/gpt-auto-root Before it was placed in /dev/disk/by-id, which makes it a bit too much API. However, it's mostly an implementation detail for now, hence move it out of the stable block device dir.

nspawn: add --image= switch to boot GPT disk images that follow the Discoverable Partitions Specification

gpt-auto-generator: probe only partition table and partitions we are interested in Instead of iterating through the list of partitions and probing them all with blkid, simply probe the partition table and use that information to only probe the partitions we care for.

gpt-auto-generator: automatically find the root disk of the system When run in an initrd and no root= argument is set (or is set to root=gpt-auto) we will automatically look for the root partition on the same disk the EFI ESP is located on. Since we look for swap, /home and /srv on the disk the root partition is located on, we hence have a fully discoverable chain: Firmware discovers the EFI ESP partition → the initrd discovers the root partition → the host OS discovers swap, /home, and /srv. Note that this requires an EFI boot loader that sets the LoaderDevicePartUUID EFI variable, such as Gummiboot.

generators: make automatic discovery generators work correctly when reloading In addition to checking whether the diestination mount point is populated, check whether it is already a mount point. If it is already a mount point, or if it is unpopulated, let's create the unit.

generators: add Documentation= fields that point to the generator man pages

gpt-auto-generation: set a pretty description string

gpt-auto-generator: properly handle LUKS partitions

update TODO

generators: rework mount generators - Add support for finding and mounting /srv based on GPT data, similar to how we already handly /home. - Share the fsck logic between GPT, EFI and fstab generators - Make sure we never run the EFI generator inside containers - Drop DefaultDependencies=no from EFI mount units - Other fixes

gpt-auto-generator: use EBADSLT code when unable to detect partition type ENODEV suggests that something is missing, which is be misleading here.

gpt-auto-generator: skip nonexistent devices The devices we work with have eMMC chips for storage. The chips provide four "hardware" partitions. The first is /dev/mmcblk0, it takes almost whole space and holds a GPT with several real partitions (/dev/mmcblk0p?). Then there are three block devices (mmcblk0boot0, mmcblk0boot1, rpmb) that are part of the same hardware as mmcblk0 that are presented by the kernel as children of the latter. That relationship makes gpt-auto-generator try to peek them but since they are not GPT partitions blkid_do_safeprobe() returns -2 making verify_gpt_parition() function return -ENODEV.

fix scan-build issues The static analyzer scan-build had a few issues with analysing parts of systemd. gpt-auto-generator.c: scan-build could not find blkid.h. Whether it should be blkid.h or blkid/blkid.h seems to depend on the version used. We already use blkid/blkid.h in udev-builtin-blkid.c so it seems safe to use that here too. Makefile.am: Moved some -D's from CFLAGS to CPPFLAGS. I also simplified them a bit and got rid of a left over DBUS_CFLAGS. test-cgroup-mask.c/test-sched-prio.c A variable was added to store the replaced TEST_DIR. When wrapped in an assert_se TEST_DIR was not replaced in the logged error. While not an issue introduced in this patch we might as well fix it up while we are here.

bus: add generator that turns old dbus1 activation files into .busname + .service units

gpt-auto-generator: Generate explicit dependencies on systemd-fsck@.service instead of using FsckPassNo [tomegun: check for OOM]

util: allow trailing semicolons on define_trivial_cleanup_func lines Emacs C indenting really gets confused by these lines if they carry no trailing semicolon, hence let's make this nicer for good old emacs. The other macros which define functions already do this too, so let's copy the scheme here. Also, let's use an uppercase name for the macro. So far our rough rule was that macros that are totally not function-like (like this ones, which define a function) are uppercase. (Well, admittedly it is a rough rule only, for example function and variable decorators are all lower-case SINCE THE CONSTANT YELLING IN THE SOURCES WOULD SUCK, and also they at least got underscore prefixes.) Also, the macros that define functions that we already have are all uppercase, so let's do the same here...

Introduce udev object cleanup functions

Modernization Fixes minor leak in error path in device.c.

gpt-auto-generator: exit immediately if in container Otherwise we get an ugly warning when running systemd in a container.

gpt-auto-generator: do not assume that /dev/block/%u:%u is useable The generator might run before udev, and udev sets up the /dev/block/ symlinks, hence we cannot use them from the gpt generator. Instead, manually translate a major/minor to a device node.

Rename F_TYPE_CMP() to F_TYPE_EQUAL()

gpt-auto-generator: do not show error for non-GPT disks

gpt-auto-generator: use _cleanup_ for blkid_free_probe

gpt-auto-generator: include device name in error reports

build-sys: Add configure check for linux/btrfs.h btrfs.h was added to uapi in Linux 3.9. To fix building with older header versions this adds a configure check for the header and re-adds btrfs definitions to missing.h which was removed in bed2e820 along with two other ioctls used by gpt-auto-generator. [ Apparently, btrfs.h was only added recently: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=55e301fd57a6239ec14b91a1cf2e70b3dd135194 let's re-add it for now -- kay ]

gpt-auto-generator: fix swap unit generation

gpt-auto-generator: Skip /home mounting if /home is not empty

gpt-auto-generator: add basic auto-discovery of GPT partitions This adds a simple generator that is capable of automatically discovering certain GPT partitions by their type UUID and mount/enable them. This currently covers swap partitions and /home partitions, but is expected to grow more features soon. This currently doesn't handle LUKS encrypted /home. This enables all swap partitions of type 0657fd6da4ab43c484e50933c84b4f4f, if found. This mounts the first partition of type 933ac7e12eb44f13b8440e14e2aef915 as /home, if it is found.