tree-wide: remove Emacs lines from all files This should be handled fine now by .dir-locals.el, so need to carry that stuff in every file.

tree-wide: use xsprintf() where applicable Also add a coccinelle receipt to help with such transitions.

tree-wide: sort includes Sort the includes accoding to the new coding style.

util-lib: split out allocation calls into alloc-util.[ch]

util-lib: split out fd-related operations into fd-util.[ch] There are more than enough to deserve their own .c file, hence move them over.

bootchart: use get_proc_field and PROC_CPUINFO_MODEL Use get_proc_field and PROC_CPUINFO_MODEL to get the CPU type. Also don't fail if it missing, instead restore the old behaviour and print "Unknown". Fixes the following error seen with v225 on powerpc: Unable to read module name from cpuinfo. Error generating svg file: No such file or directory

tree-wide: replace while(1) by for(;;) everywhere Another Coccinelle script.

tree-wide: drop {} from one-line if blocks Patch via coccinelle.

bootchart: do not report warning when disk is missing model. In VMs / virtio drives there is no model. Also don't print "Disk: (null)" in output if no model is available.

bootchart: reset list_sample_data head before generating SVG Until commit 1f2ecb0 ("bootchart: kill a bunch of global variables") variable "head" was declared global and this action was performed by svg_header. Now that "head" is local and passed to each function called by svg_do(...) move the code at the beginning of svg_do(...) to restore the correct behaviour.

bootchart: fix per-cpu scales. Closes systemd/systemd#330

bootchart: kill newline characters from log_error_errno() calls

bootchart: assorted coding style fixes * kill unnecessary {} * add newlines where appropriate * remove dead code * reorder variable declarations * fix more return code logic * pass O_CLOEXEC to all open*() calles * use safe_close() where possible

bootchart: kill a bunch of global variables This code is in a confusingly bad shape. Kill a bunch of global variables and pass needed variables around in function calls.

bootchart: clean up sysfd and proc handling Retrieve the handle to procfs in main(), and pass it functions that need it. Kill the global variables. Also, refactor lots of code in svg_title(). There's no need to access any global variables from there either, and we really should return proper errors from there as well.

bootchart: switch to log_* helpers Let the helper functions take care of the string message output.

systemd-bootchart: Prevent leaking file descriptors in open-fdopen combination Correctly handle the potential failure of fdopen() (because of OOM, for instance) after potentially successful open(). Prevent leaking open fd in such case.

bootchart: svg: fix checking of list end If we have less samples than expected, systemd-bootchart will crash.

remove unused includes This patch removes includes that are not used. The removals were found with include-what-you-use which checks if any of the symbols from a header is in use.

bootchart: display each CPU utilization/wait

bootchart: escape non printable process name

bootchart: check return of strftime Found by coverity. Fixes: CID#996314 and #996312

bootchart: use the bool type where appropriate

bootchart: add assert since 376cd3b89c62f580a6f576cecfbbb28d3944118f LIST_FIND_TAIL accepts an empty list. That removed an assert in LIST_FIND_TAIL and we now theoretically risk a null pointer deref. This adds the assert directly to protect against that.

bootchart: set white background In programs like eog and gimp the transparant background did not look very good. Similar fix from the one done in systemd-analyze (418e3750)

bootchart: add control group option

use memzero(foo, length); for all memset(foo, 0, length); calls In trying to track down a stupid linker bug, I noticed a bunch of memset() calls that should be using memzero() to make it more "obvious" that the options are correct (i.e. 0 is not the length, but the data to set). So fix up all current calls to memset(foo, 0, length) to memzero(foo, length).

Bring bootchart code in line with CODING_STYLE Use double and not float, as there is little to no benefit.

bootchart: remove dead assignment

trivial coding style clean ups - Add space between if/for and the opening parentheses - Place the opening brace on same line as the function (not for udev) From the CODING_STYLE Try to use this: void foo() { } instead of this: void foo() { }

list: make our list macros a bit easier to use by not requring type spec on each invocation We can determine the list entry type via the typeof() gcc construct, and so we should to make the macros much shorter to use.

Fix write-only use of a few variables Since the invention of read-only memory, write-only memory has been considered deprecated. Where appropriate, either make use of the value, or avoid writing it, to make it clear that it is not used.

bootchart: fix typos in copyright notices "Corporation" was misspelled as "Coproration"

Dynamically allocate bootchart logs Instead of storing bootchart sample data in arrays, this patch moves storage to linked lists so that there is no more limit on samples. This patch also fixes parsing of /proc/<pid>/smaps in kernels > 3.7.

move _cleanup_ attribute in front of the type http://lists.freedesktop.org/archives/systemd-devel/2013-April/010510.html

Use initalization instead of explicit zeroing in more places

Always use our own MAX/MIN definitions code in src/shared/macro.h only defined MAX/MIN in case they were not defined previously. however the MAX/MIN macros implemented in glibc are not of the "safe" kind but defined as: define MIN(a,b) (((a)<(b))?(a):(b)) define MAX(a,b) (((a)>(b))?(a):(b)) Avoid nasty side effects by using our own versions instead. Also fix the warnings derived from this change. [zj: - modify MAX3 macro to fix warning about _a shadowing _a, - do bootchart/svg.c too, - remove unused MIN3.]

Remove some dead code Based on coverity report.

bootchart: fix two unitialized memory frees The new gcc isn't bad! In file included from src/bootchart/svg.c:36:0: src/bootchart/svg.c: In function 'svg_ps_bars': ./src/shared/util.h:524:13: warning: 'enc_name' may be used uninitialized in this function [-Wmaybe-uninitialized] free(*(void**) p); ^ src/bootchart/svg.c:821:37: note: 'enc_name' was declared here char _cleanup_free_*enc_name; ^ CC src/udev/mtd_probe/mtd_probe-probe_smartmedia.o XSLT man/systemd.unit.5 In file included from src/bootchart/svg.c:36:0: src/bootchart/svg.c: In function 'svg_pss_graph': ./src/shared/util.h:524:13: warning: 'enc_name' may be used uninitialized in this function [-Wmaybe-uninitialized] free(*(void**) p); ^ src/bootchart/svg.c:395:37: note: 'enc_name' was declared here char _cleanup_free_*enc_name; ^

bootchart: various superficial cleanups Let's update bootchar to share the coding style a bit more with the rest of the package. - Some tabs/spaces fixes - add #pragma to header - split up header so that we have a 1:1 relation between .c and .h files like everywhere else - Prefix user command line arguments/configuration settings with "arg_". - other coding style fixes

Revert "bootchart: use _cleanup_close_" This reverts commit 0ea9530d401827e299c6e04a433e69a7a2a89d80. attribute(cleanup) can only be used inside functions (*of, sysfd are leaked). Cleanup functions are only called once when exiting scope (*f is leaked twice).

bootchart: use _cleanup_close_ use _cleanup_{close_,fclose_} to close streams and file descriptors

bootchart: rename global len to samples_len

bootchart: add parameter "-C" to expand process names to the full cmdline

bootchart: if "root=/dev" is not matched, don't try to read /sys

bootchart: parse /etc/os-release rather than system-release Also parse it early, so that we can get it in the initramfs.

bootchart: more fixes for bootchart in the initramfs

man: bootchart: change /var/log to /run/log As of [1], bootchart stores files in /run/log, not /var/log, by default. [1] f2f85884caac671da84256acb44148df9a4dca70

bootchart: Fix typos and some English bootchart.conf: direct users to `bootchart.conf(5)`, not a nonexistent man page. svg.c: Fix some English in the svg comment header. * Chrome/Chromium => Chrome, Chromium * firefox => Firefox * much more slow => more slowly

systemd-bootchart: relicense to LGPLv2.1+ When we merged systemd-bootchart we omitted relicensing this to LGPL. Now that code is being used for other purposes we need to make sure the code is shareable within systemd without further problems. The original committers and contributors of bootchart before it was merged all have agreed with the relicensing.

Add _cleanup_pclose_ and fix mismatching pipe close opened by popen() Based-on-patch-by: Thomas Jarosch <thomas.jarosch@intra2net.com> cppcheck reported: [src/bootchart/svg.c:791]: (error) Mismatching allocation and deallocation: f

bootchart: tabs to spaces

bootchart: merge bootchart Bootchart is renamed to 'systemd-bootchart' and installed as /usr/lib/systemd/systemd-bootchart. The configuration file will reside in /etc/systemd/bootchart.conf.